From 4d8151a1d045ce1555eebaba99d61e37b130e9f6 Mon Sep 17 00:00:00 2001 From: Adam Stankiewicz Date: Wed, 3 Nov 2021 00:34:05 -0400 Subject: [PATCH] build: use shared browserslist config --- .github/workflows/ci.yml | 1 - Makefile | 2 +- package-lock.json | 13 +++++++++++++ package.json | 5 ++--- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c84ab1d..cc31d9a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -13,7 +13,6 @@ jobs: npm: [8.5.0] npm-test: - i18n_extract - - is-es5 - lint - test steps: diff --git a/Makefile b/Makefile index 73cd33a..316395b 100755 --- a/Makefile +++ b/Makefile @@ -11,7 +11,7 @@ tx_url2 = https://www.transifex.com/api/2/project/edx-platform/resource/$(transi # This directory must match .babelrc . transifex_temp = ./temp/babel-plugin-react-intl -NPM_TESTS=build i18n_extract lint test is-es5 +NPM_TESTS=build i18n_extract lint test .PHONY: test test: $(addprefix test.npm.,$(NPM_TESTS)) ## validate ci suite diff --git a/package-lock.json b/package-lock.json index 76e69f8..d3052c5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -60,6 +60,7 @@ "universal-cookie": "4.0.4" }, "devDependencies": { + "@edx/browserslist-config": "1.0.0", "@edx/frontend-build": "9.1.1", "@edx/reactifex": "^1.0.3", "@testing-library/jest-dom": "5.15.1", @@ -2109,6 +2110,12 @@ "resolved": "https://registry.npmjs.org/@edx/brand-openedx/-/brand-openedx-1.1.0.tgz", "integrity": "sha512-ne2ZKF1r0akkt0rEzCAQAk4cTDTI2GiWCpc+T7ldQpw9X57OnUB16dKsFNe40C9uEjL5h3Ps/ZsFM5dm4cIkEQ==" }, + "node_modules/@edx/browserslist-config": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/@edx/browserslist-config/-/browserslist-config-1.0.0.tgz", + "integrity": "sha512-gLAlpz9Y5VruxqiUBTROG7PvouIxoMc6dvhvNpXUDHRN0KEke+zBj+zJ4frL9kGbkeex273nzSazbG42hNDLrg==", + "dev": true + }, "node_modules/@edx/eslint-config": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/@edx/eslint-config/-/eslint-config-2.0.0.tgz", @@ -25664,6 +25671,12 @@ "resolved": "https://registry.npmjs.org/@edx/brand-openedx/-/brand-openedx-1.1.0.tgz", "integrity": "sha512-ne2ZKF1r0akkt0rEzCAQAk4cTDTI2GiWCpc+T7ldQpw9X57OnUB16dKsFNe40C9uEjL5h3Ps/ZsFM5dm4cIkEQ==" }, + "@edx/browserslist-config": { + "version": "1.0.0", + "resolved": "https://registry.npmjs.org/@edx/browserslist-config/-/browserslist-config-1.0.0.tgz", + "integrity": "sha512-gLAlpz9Y5VruxqiUBTROG7PvouIxoMc6dvhvNpXUDHRN0KEke+zBj+zJ4frL9kGbkeex273nzSazbG42hNDLrg==", + "dev": true + }, "@edx/eslint-config": { "version": "2.0.0", "resolved": "https://registry.npmjs.org/@edx/eslint-config/-/eslint-config-2.0.0.tgz", diff --git a/package.json b/package.json index 45fe40d..e00de31 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,6 @@ "scripts": { "build": "fedx-scripts webpack", "i18n_extract": "BABEL_ENV=i18n fedx-scripts babel src --quiet > /dev/null", - "is-es5": "es-check es5 ./dist/*.js", "lint": "fedx-scripts eslint --ext .js --ext .jsx .", "snapshot": "fedx-scripts jest --updateSnapshot", "start": "fedx-scripts webpack-dev-server --progress", @@ -25,8 +24,7 @@ "access": "public" }, "browserslist": [ - "last 2 versions", - "ie 11" + "extends @edx/browserslist-config" ], "dependencies": { "@edx/brand": "npm:@edx/brand-openedx@1.1.0", @@ -80,6 +78,7 @@ "universal-cookie": "4.0.4" }, "devDependencies": { + "@edx/browserslist-config": "1.0.0", "@edx/frontend-build": "9.1.1", "@edx/reactifex": "^1.0.3", "@testing-library/jest-dom": "5.15.1",