From 0e8d7622c6e74d76dc9a7366011320c4ff4b3bcf Mon Sep 17 00:00:00 2001
From: Matt Tuchfarber <mtuchfarber@edx.org>
Date: Fri, 8 May 2020 12:31:28 -0400
Subject: [PATCH] Only save coaching name if not managed profile

Managed profiles don't allow the user to change their name so we disable
the name input and skip name submission during coaching signup.
---
 src/account-settings/AccountSettingsPage.jsx  |  6 ++--
 .../coaching/CoachingConsent.jsx              | 14 ++++++++--
 .../coaching/CoachingConsent.messages.js      |  5 ++++
 .../coaching/CoachingConsentForm.jsx          | 28 ++++++++++++++++++-
 .../coaching/CoachingToggle.jsx               |  9 +++---
 src/account-settings/data/selectors.js        |  3 ++
 6 files changed, 54 insertions(+), 11 deletions(-)

diff --git a/src/account-settings/AccountSettingsPage.jsx b/src/account-settings/AccountSettingsPage.jsx
index 34858cb..8ed54bf 100644
--- a/src/account-settings/AccountSettingsPage.jsx
+++ b/src/account-settings/AccountSettingsPage.jsx
@@ -488,11 +488,11 @@ AccountSettingsPage.propTypes = {
     social_link_facebook: PropTypes.string,
     social_link_twitter: PropTypes.string,
     time_zone: PropTypes.string,
-    coaching: PropTypes.objectOf(PropTypes.shape({
-      coaching_consent: PropTypes.string.isRequired,
+    coaching: PropTypes.shape({
+      coaching_consent: PropTypes.bool.isRequired,
       user: PropTypes.number.isRequired,
       eligible_for_coaching: PropTypes.bool.isRequired,
-    })),
+    }),
   }).isRequired,
   siteLanguage: PropTypes.shape({
     previousValue: PropTypes.string,
diff --git a/src/account-settings/coaching/CoachingConsent.jsx b/src/account-settings/coaching/CoachingConsent.jsx
index 4bb647c..0839bab 100644
--- a/src/account-settings/coaching/CoachingConsent.jsx
+++ b/src/account-settings/coaching/CoachingConsent.jsx
@@ -133,11 +133,14 @@ class CoachingConsent extends React.Component {
     // !important: The order of this data matters!
     // The order that this data is in, is the order that the saveSettings() function
     // is called.
-    this.props.saveMultipleSettings([
-      {
+    const settingsSubmissions = [];
+    if (!this.props.profileDataManager) {
+      settingsSubmissions.push({
         formId: 'name',
         commitValues: fullName,
-      },
+      });
+    }
+    Array.prototype.push.apply(settingsSubmissions, [
       {
         formId: 'coaching',
         commitValues: {
@@ -152,6 +155,7 @@ class CoachingConsent extends React.Component {
         commitValues: phoneNumber,
       },
     ]);
+    this.props.saveMultipleSettings(settingsSubmissions);
   }
 
   async declineCoaching(e) {
@@ -181,6 +185,7 @@ class CoachingConsent extends React.Component {
           formErrors={this.state.formErrors}
           formValues={this.props.formValues}
           redirectUrl={this.state.redirectUrl}
+          profileDataManager={this.props.profileDataManager}
         />);
       case VIEWS.SUCCESS_PENDING:
         return <PageLoading srMessage="Submitting..." />;
@@ -273,6 +278,7 @@ AutoRedirect.propTypes = {
 CoachingConsent.defaultProps = {
   loaded: false,
   saveState: undefined,
+  profileDataManager: null,
 };
 
 CoachingConsent.propTypes = {
@@ -298,7 +304,9 @@ CoachingConsent.propTypes = {
   }).isRequired,
   fetchSettings: PropTypes.func.isRequired,
   saveSettings: PropTypes.func.isRequired,
+  saveMultipleSettings: PropTypes.func.isRequired,
   saveState: PropTypes.string,
+  profileDataManager: PropTypes.string,
 };
 
 export default connect(coachingConsentPageSelector, {
diff --git a/src/account-settings/coaching/CoachingConsent.messages.js b/src/account-settings/coaching/CoachingConsent.messages.js
index 0eae5ae..ffd5464 100644
--- a/src/account-settings/coaching/CoachingConsent.messages.js
+++ b/src/account-settings/coaching/CoachingConsent.messages.js
@@ -56,6 +56,11 @@ const messages = defineMessages({
     defaultMessage: 'Start my course',
     description: 'Text that the user will be sent back to the courseware',
   },
+  'account.settings.coaching.managed.support': {
+    id: 'account.settings.coaching.managed.support',
+    defaultMessage: 'support',
+    description: 'website support',
+  },
 });
 
 export default messages;
diff --git a/src/account-settings/coaching/CoachingConsentForm.jsx b/src/account-settings/coaching/CoachingConsentForm.jsx
index 1403fc5..5db4612 100644
--- a/src/account-settings/coaching/CoachingConsentForm.jsx
+++ b/src/account-settings/coaching/CoachingConsentForm.jsx
@@ -1,15 +1,30 @@
 import React from 'react';
 
-import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
+import { getConfig } from '@edx/frontend-platform';
+import { injectIntl, intlShape, FormattedMessage } from '@edx/frontend-platform/i18n';
 import { Input, Button, Hyperlink } from '@edx/paragon';
+
 import PropTypes from 'prop-types';
 
+import Alert from '../Alert';
 import messages from './CoachingConsent.messages';
 
 const ErrorMessage = props => (
   <div className="alert-warning mb-2">{props.message}</div>
 );
 
+const ManagedProfileAlert = ({ profileDataManager }) => (
+  <Alert className="alert alert-primary" role="alert">
+    <FormattedMessage
+      id="account.settings.coaching.managed.alert"
+      defaultMessage="Your name is managed by {managerTitle}. Contact your administrator for help."
+      description="alert message informing the user their account data is managed by a third party"
+      values={{
+        managerTitle: <b>{profileDataManager}</b>,
+      }}
+    />
+  </Alert>
+);
 const CoachingForm = props => (
   <div className="col-12 col-md-6 col-xl-5 mx-auto mt-4 p-5 shadow-lg">
     <h2 className="h2">
@@ -19,12 +34,17 @@ const CoachingForm = props => (
     <div>
       <form onSubmit={props.onSubmit}>
         <div className="py-3">
+          {
+            !!props.profileDataManager &&
+            <ManagedProfileAlert profileDataManager={props.profileDataManager} />
+          }
           <ErrorMessage message={props.formErrors.name} />
           <label className="h6" htmlFor="fullName">{props.intl.formatMessage(messages['account.settings.coaching.consent.label.name'])}</label>
           <Input
             type="text"
             name="full-name"
             id="fullName"
+            disabled={!!props.profileDataManager}
             defaultValue={props.formValues.name}
           />
         </div>
@@ -91,6 +111,7 @@ CoachingForm.propTypes = {
     phone_number: PropTypes.string,
   }),
   redirectUrl: PropTypes.string.isRequired,
+  profileDataManager: PropTypes.string.isRequired,
 };
 
 ErrorMessage.defaultProps = {
@@ -101,4 +122,9 @@ ErrorMessage.propTypes = {
   message: PropTypes.string,
 };
 
+ManagedProfileAlert.propTypes = {
+  profileDataManager: PropTypes.string.isRequired,
+  intl: intlShape.isRequired,
+};
+
 export default injectIntl(CoachingForm);
diff --git a/src/account-settings/coaching/CoachingToggle.jsx b/src/account-settings/coaching/CoachingToggle.jsx
index 1b7b438..b56c206 100644
--- a/src/account-settings/coaching/CoachingToggle.jsx
+++ b/src/account-settings/coaching/CoachingToggle.jsx
@@ -55,17 +55,18 @@ const CoachingToggle = props => (
 CoachingToggle.defaultProps = {
   phone_number: '',
   error: '',
+  saveState: undefined,
 };
 
 CoachingToggle.propTypes = {
   name: PropTypes.string.isRequired,
   error: PropTypes.string,
-  coaching: PropTypes.objectOf(PropTypes.shape({
-    coaching_consent: PropTypes.string.isRequired,
+  coaching: PropTypes.shape({
+    coaching_consent: PropTypes.bool.isRequired,
     user: PropTypes.number.isRequired,
     eligible_for_coaching: PropTypes.bool.isRequired,
-  })).isRequired,
-  saveState: PropTypes.func.isRequired,
+  }).isRequired,
+  saveState: PropTypes.oneOf(['default', 'pending', 'complete', 'error']),
   saveSettings: PropTypes.func.isRequired,
   updateDraft: PropTypes.func.isRequired,
   intl: intlShape.isRequired,
diff --git a/src/account-settings/data/selectors.js b/src/account-settings/data/selectors.js
index 0f287e5..f2289ff 100644
--- a/src/account-settings/data/selectors.js
+++ b/src/account-settings/data/selectors.js
@@ -167,6 +167,7 @@ export const coachingConsentPageSelector = createSelector(
   accountSettingsSelector,
   formValuesSelector,
   activeAccountSelector,
+  profileDataManagerSelector,
   saveStateSelector,
   confirmationValuesSelector,
   errorSelector,
@@ -174,6 +175,7 @@ export const coachingConsentPageSelector = createSelector(
     accountSettings,
     formValues,
     activeAccount,
+    profileDataManager,
     saveState,
     confirmationValues,
     errors,
@@ -182,6 +184,7 @@ export const coachingConsentPageSelector = createSelector(
     loaded: accountSettings.loaded,
     loadingError: accountSettings.loadingError,
     isActive: activeAccount,
+    profileDataManager,
     formValues,
     saveState,
     confirmationValues,