From 0dc1df07d4238e24fb21eea5de122a2afa13520b Mon Sep 17 00:00:00 2001
From: Andy Shultz <ashultz@edx.org>
Date: Thu, 26 Aug 2021 11:13:43 -0400
Subject: [PATCH] feat: gate render verified name success message outside of
 function

this frees the function from doing logic we've already done elsewhere
---
 src/account-settings/AccountSettingsPage.jsx | 26 +++++++++-----------
 1 file changed, 11 insertions(+), 15 deletions(-)

diff --git a/src/account-settings/AccountSettingsPage.jsx b/src/account-settings/AccountSettingsPage.jsx
index 61d1330..398beb4 100644
--- a/src/account-settings/AccountSettingsPage.jsx
+++ b/src/account-settings/AccountSettingsPage.jsx
@@ -208,20 +208,16 @@ class AccountSettingsPage extends React.Component {
     );
   }
 
-  renderVerifiedNameSuccessMessage(showVerifiedApproved) {
-    if (showVerifiedApproved) {
-      return (
-        <OneTimeDismissibleAlert
-          id="dismissedVerifiedNameSuccessMessage"
-          variant="success"
-          icon={CheckCircle}
-          header={this.props.intl.formatMessage(messages['account.settings.field.name.verified.sucess.message.header'])}
-          body={this.props.intl.formatMessage(messages['account.settings.field.name.verified.sucess.message'])}
-        />
-      );
-    }
-
-    return null;
+  renderVerifiedNameSuccessMessage() {
+    return (
+      <OneTimeDismissibleAlert
+        id="dismissedVerifiedNameSuccessMessage"
+        variant="success"
+        icon={CheckCircle}
+        header={this.props.intl.formatMessage(messages['account.settings.field.name.verified.sucess.message.header'])}
+        body={this.props.intl.formatMessage(messages['account.settings.field.name.verified.sucess.message'])}
+      />
+    );
   }
 
   renderEmptyStaticFieldMessage() {
@@ -294,7 +290,7 @@ class AccountSettingsPage extends React.Component {
     return (
       <>
         <div className="account-section" id="basic-information" ref={this.navLinkRefs['#basic-information']}>
-          {this.renderVerifiedNameSuccessMessage(showVerifiedApproved)}
+          {showVerifiedApproved && this.renderVerifiedNameSuccessMessage()}
 
           <h2 className="section-heading">
             {this.props.intl.formatMessage(messages['account.settings.section.account.information'])}