Current State (before this commit): Studio, as of today doesn't have a way to restrict a user to create a course in a particular organization. What Studio provides right now is a CourseCreator permission which gives an Admin the power to grant a user the permission to create a course. For example: If the Admin has given a user Spiderman the permission to create courses, Spiderman can now create courses in any organization i.e Marvel as well as DC. There is no way to restrict Spiderman from creating courses under DC. Purpose of this commit: The changes done here gives Admin the ability to restrict a user on an Organization level from creating courses via the Course Creators section of the Studio Django administration panel. For example: Now, the Admin can give the user Spiderman the privilege of creating courses only under Marvel organization. The moment Spiderman tries to create a course under some other organization(i.e DC), Studio will show an error message. This change is available to all Studio instances that enable the FEATURES['ENABLE_CREATOR_GROUP'] flag. Regardless of the flag, it will not affect any instances that choose not to use it. BB-3622
202 lines
7.2 KiB
Python
202 lines
7.2 KiB
Python
"""
|
|
The application interface to roles which checks whether any user trying to change
|
|
authorization has authorization to do so, which infers authorization via role hierarchy
|
|
(GlobalStaff is superset of auths of course instructor, ...), which consults the config
|
|
to decide whether to check course creator role, and other such functions.
|
|
"""
|
|
|
|
|
|
from ccx_keys.locator import CCXBlockUsageLocator, CCXLocator
|
|
from django.conf import settings
|
|
from django.core.exceptions import PermissionDenied
|
|
from opaque_keys.edx.locator import LibraryLocator
|
|
|
|
from common.djangoapps.student.roles import (
|
|
CourseBetaTesterRole,
|
|
CourseCreatorRole,
|
|
CourseInstructorRole,
|
|
CourseRole,
|
|
CourseStaffRole,
|
|
GlobalStaff,
|
|
LibraryUserRole,
|
|
OrgContentCreatorRole,
|
|
OrgInstructorRole,
|
|
OrgLibraryUserRole,
|
|
OrgStaffRole
|
|
)
|
|
|
|
# Studio permissions:
|
|
STUDIO_EDIT_ROLES = 8
|
|
STUDIO_VIEW_USERS = 4
|
|
STUDIO_EDIT_CONTENT = 2
|
|
STUDIO_VIEW_CONTENT = 1
|
|
STUDIO_NO_PERMISSIONS = 0
|
|
# In addition to the above, one is always allowed to "demote" oneself to a lower role within a course, or remove oneself
|
|
|
|
|
|
def is_ccx_course(course_key):
|
|
"""
|
|
Check whether the course locator maps to a CCX course; this is important
|
|
because we don't allow access to CCX courses in Studio.
|
|
"""
|
|
return isinstance(course_key, CCXLocator) or isinstance(course_key, CCXBlockUsageLocator) # lint-amnesty, pylint: disable=consider-merging-isinstance
|
|
|
|
|
|
def user_has_role(user, role):
|
|
"""
|
|
Check whether this user has access to this role (either direct or implied)
|
|
:param user:
|
|
:param role: an AccessRole
|
|
"""
|
|
if not user.is_active:
|
|
return False
|
|
# Do cheapest check first even though it's not the direct one
|
|
if GlobalStaff().has_user(user):
|
|
return True
|
|
# CourseCreator is odd b/c it can be disabled via config
|
|
if isinstance(role, CourseCreatorRole):
|
|
# completely shut down course creation setting
|
|
if settings.FEATURES.get('DISABLE_COURSE_CREATION', False):
|
|
return False
|
|
# wide open course creation setting
|
|
if not settings.FEATURES.get('ENABLE_CREATOR_GROUP', False):
|
|
return True
|
|
|
|
if role.has_user(user):
|
|
return True
|
|
# If not, then check inferred permissions
|
|
if (isinstance(role, (CourseStaffRole, CourseBetaTesterRole)) and
|
|
CourseInstructorRole(role.course_key).has_user(user)):
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
def get_user_permissions(user, course_key, org=None):
|
|
"""
|
|
Get the bitmask of permissions that this user has in the given course context.
|
|
Can also set course_key=None and pass in an org to get the user's
|
|
permissions for that organization as a whole.
|
|
"""
|
|
if org is None:
|
|
org = course_key.org
|
|
course_key = course_key.for_branch(None)
|
|
else:
|
|
assert course_key is None
|
|
# No one has studio permissions for CCX courses
|
|
if is_ccx_course(course_key):
|
|
return STUDIO_NO_PERMISSIONS
|
|
all_perms = STUDIO_EDIT_ROLES | STUDIO_VIEW_USERS | STUDIO_EDIT_CONTENT | STUDIO_VIEW_CONTENT
|
|
# global staff, org instructors, and course instructors have all permissions:
|
|
if GlobalStaff().has_user(user) or OrgInstructorRole(org=org).has_user(user):
|
|
return all_perms
|
|
if course_key and user_has_role(user, CourseInstructorRole(course_key)):
|
|
return all_perms
|
|
# Staff have all permissions except EDIT_ROLES:
|
|
if OrgStaffRole(org=org).has_user(user) or (course_key and user_has_role(user, CourseStaffRole(course_key))):
|
|
return STUDIO_VIEW_USERS | STUDIO_EDIT_CONTENT | STUDIO_VIEW_CONTENT
|
|
# Otherwise, for libraries, users can view only:
|
|
if course_key and isinstance(course_key, LibraryLocator):
|
|
if OrgLibraryUserRole(org=org).has_user(user) or user_has_role(user, LibraryUserRole(course_key)):
|
|
return STUDIO_VIEW_USERS | STUDIO_VIEW_CONTENT
|
|
return STUDIO_NO_PERMISSIONS
|
|
|
|
|
|
def has_studio_write_access(user, course_key):
|
|
"""
|
|
Return True if user has studio write access to the given course.
|
|
Note that the CMS permissions model is with respect to courses.
|
|
There is a super-admin permissions if user.is_staff is set.
|
|
Also, since we're unifying the user database between LMS and CAS,
|
|
I'm presuming that the course instructor (formally known as admin)
|
|
will not be in both INSTRUCTOR and STAFF groups, so we have to cascade our
|
|
queries here as INSTRUCTOR has all the rights that STAFF do.
|
|
|
|
:param user:
|
|
:param course_key: a CourseKey
|
|
"""
|
|
return bool(STUDIO_EDIT_CONTENT & get_user_permissions(user, course_key))
|
|
|
|
|
|
def has_course_author_access(user, course_key):
|
|
"""
|
|
Old name for has_studio_write_access
|
|
"""
|
|
return has_studio_write_access(user, course_key)
|
|
|
|
|
|
def has_studio_read_access(user, course_key):
|
|
"""
|
|
Return True iff user is allowed to view this course/library in studio.
|
|
Will also return True if user has write access in studio (has_course_author_access)
|
|
|
|
There is currently no such thing as read-only course access in studio, but
|
|
there is read-only access to content libraries.
|
|
"""
|
|
return bool(STUDIO_VIEW_CONTENT & get_user_permissions(user, course_key))
|
|
|
|
|
|
def add_users(caller, role, *users):
|
|
"""
|
|
The caller requests adding the given users to the role. Checks that the caller
|
|
has sufficient authority.
|
|
|
|
:param caller: a user
|
|
:param role: an AccessRole
|
|
"""
|
|
_check_caller_authority(caller, role)
|
|
role.add_users(*users)
|
|
|
|
|
|
def remove_users(caller, role, *users):
|
|
"""
|
|
The caller requests removing the given users from the role. Checks that the caller
|
|
has sufficient authority.
|
|
|
|
:param caller: a user
|
|
:param role: an AccessRole
|
|
"""
|
|
# can always remove self (at this layer)
|
|
if not(len(users) == 1 and caller == users[0]):
|
|
_check_caller_authority(caller, role)
|
|
role.remove_users(*users)
|
|
|
|
|
|
def update_org_role(caller, role, user, orgs):
|
|
"""
|
|
The caller requests updating the Org role for the user. Checks that the caller has
|
|
sufficient authority.
|
|
|
|
:param caller: an user
|
|
:param role: an AccessRole class
|
|
:param user: an user for which org roles are updated
|
|
:param orgs: List of organization names to update the org role
|
|
"""
|
|
_check_caller_authority(caller, role())
|
|
existing_org_roles = set(role().get_orgs_for_user(user))
|
|
orgs_roles_to_create = list(set(orgs) - existing_org_roles)
|
|
org_roles_to_delete = list(existing_org_roles - set(orgs))
|
|
for org in orgs_roles_to_create:
|
|
role(org=org).add_users(user)
|
|
for org in org_roles_to_delete:
|
|
role(org=org).remove_users(user)
|
|
|
|
|
|
def _check_caller_authority(caller, role):
|
|
"""
|
|
Internal function to check whether the caller has authority to manipulate this role
|
|
:param caller: a user
|
|
:param role: an AccessRole
|
|
"""
|
|
if not (caller.is_authenticated and caller.is_active):
|
|
raise PermissionDenied
|
|
# superuser
|
|
if GlobalStaff().has_user(caller):
|
|
return
|
|
|
|
if isinstance(role, (GlobalStaff, CourseCreatorRole, OrgContentCreatorRole)): # lint-amnesty, pylint: disable=no-else-raise
|
|
raise PermissionDenied
|
|
elif isinstance(role, CourseRole): # instructors can change the roles w/in their course
|
|
if not user_has_role(caller, CourseInstructorRole(role.course_key)):
|
|
raise PermissionDenied
|