b8a34f0c57
We have a need to lock the version of Django for production and tests, but also to test on newer versions of Django so that we can get the repo ready for long-term-support releases. We've been doing that by extracting the `django==x.y.z` from the pip-compiled files and moving it to a django.txt that is then co-installed but can be overridden during tests. The problem is that this can result in broken packages. The approach here is to have `make test-requirements` continue to ensure a consistent set of packages, and then install a different Django on top of that in the CI script -- and call `pip check` to make sure that combination isn't broken. Adding Django 4.0 to the unit-tests.yml matrix will now correctly result in this error and a failing job: `django-splash 1.2.1 has requirement Django<4.0, but you have django 4.0.8.` The other half of this is to change other CI runners to remove their ability to control the Django version, since it's complicated to make this work, and we probably only need it in unit-tests.yml. Convert them to just use `make test-requirements`. Also: - Simplify handling of `pip --src` by setting `PIP_SRC` (rather than our own `PIP_SRC_DIR`, which pip ignores because `--src-dir` isn't an option that it knows). This is needed to allow `make test-requirements` to do the pip calls. An alternative would be to set a pip-options env var for the make target to use, but `PIP_SRC` already exists. - Remove outdated modifications to common_constraints - Add comment explaining why pylint tests need dev-requirements
83 lines
1.9 KiB
YAML
83 lines
1.9 KiB
YAML
name: Quality checks
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- master
|
|
- open-release/lilac.master
|
|
|
|
jobs:
|
|
run_tests:
|
|
name: Quality Others
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
matrix:
|
|
os: [ ubuntu-20.04 ]
|
|
python-version: [ 3.8 ]
|
|
node-version: [ 16 ]
|
|
|
|
steps:
|
|
|
|
- uses: actions/checkout@v2
|
|
with:
|
|
fetch-depth: 2
|
|
|
|
- name: Fetch base branch for comparison
|
|
run: git fetch --depth=1 origin ${{ github.base_ref }}
|
|
|
|
- name: Install Required System Packages
|
|
run: sudo apt-get update && sudo apt-get install libxmlsec1-dev
|
|
|
|
- name: Setup Python
|
|
uses: actions/setup-python@v2
|
|
with:
|
|
python-version: ${{ matrix.python-version }}
|
|
|
|
- name: Setup Node
|
|
uses: actions/setup-node@v2
|
|
with:
|
|
node-version: ${{ matrix.node-version }}
|
|
|
|
- name: Setup npm
|
|
run: npm i -g npm@8.5.x
|
|
|
|
- name: Get pip cache dir
|
|
id: pip-cache-dir
|
|
run: |
|
|
echo "::set-output name=dir::$(pip cache dir)"
|
|
|
|
- name: Cache pip dependencies
|
|
id: cache-dependencies
|
|
uses: actions/cache@v2
|
|
with:
|
|
path: ${{ steps.pip-cache-dir.outputs.dir }}
|
|
key: ${{ runner.os }}-pip-${{ hashFiles('requirements/edx/testing.txt') }}
|
|
restore-keys: ${{ runner.os }}-pip-
|
|
|
|
- name: Install Required Python Dependencies
|
|
env:
|
|
PIP_SRC: ${{ runner.temp }}
|
|
run: |
|
|
make test-requirements
|
|
|
|
- name: Run Quality Tests
|
|
env:
|
|
TEST_SUITE: quality
|
|
SCRIPT_TO_RUN: ./scripts/generic-ci-tests.sh
|
|
SHARD: 4
|
|
PIP_SRC: ${{ runner.temp }}
|
|
TARGET_BRANCH: ${{ github.base_ref }}
|
|
run: |
|
|
./scripts/all-tests.sh
|
|
|
|
- name: Save Job Artifacts
|
|
if: always()
|
|
uses: actions/upload-artifact@v2
|
|
with:
|
|
name: Build-Artifacts
|
|
path: |
|
|
**/reports/**/*
|
|
test_root/log/**/*.log
|
|
*.log
|