ac2436f520
When the thread is closed user can't able to report the thread and it gives the error. User can now report thread even it is closed. TNL-151
1006 lines
41 KiB
Python
1006 lines
41 KiB
Python
import logging
|
|
import json
|
|
|
|
from django.test.client import Client, RequestFactory
|
|
from django.test.utils import override_settings
|
|
from django.contrib.auth.models import User
|
|
from django.core.management import call_command
|
|
from django.core.urlresolvers import reverse
|
|
from mock import patch, ANY, Mock
|
|
from nose.tools import assert_true, assert_equal # pylint: disable=E0611
|
|
from opaque_keys.edx.locations import SlashSeparatedCourseKey
|
|
|
|
from courseware.tests.modulestore_config import TEST_DATA_MIXED_MODULESTORE
|
|
from django_comment_client.base import views
|
|
from django_comment_client.tests.utils import CohortedContentTestCase
|
|
from django_comment_client.tests.unicode import UnicodeTestMixin
|
|
from django_comment_common.models import Role, FORUM_ROLE_STUDENT
|
|
from django_comment_common.utils import seed_permissions_roles
|
|
from student.tests.factories import CourseEnrollmentFactory, UserFactory
|
|
from util.testing import UrlResetMixin
|
|
from xmodule.modulestore.tests.factories import CourseFactory
|
|
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
|
|
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
CS_PREFIX = "http://localhost:4567/api/v1"
|
|
|
|
|
|
class MockRequestSetupMixin(object):
|
|
def _create_repsonse_mock(self, data):
|
|
return Mock(text=json.dumps(data), json=Mock(return_value=data))\
|
|
|
|
def _set_mock_request_data(self, mock_request, data):
|
|
mock_request.return_value = self._create_repsonse_mock(data)
|
|
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
class CreateCohortedThreadTestCase(CohortedContentTestCase):
|
|
"""
|
|
Tests how `views.create_thread` passes `group_id` to the comments service
|
|
for cohorted topics.
|
|
"""
|
|
def _create_thread_in_cohorted_topic(
|
|
self,
|
|
user,
|
|
mock_request,
|
|
group_id,
|
|
pass_group_id=True,
|
|
expected_status_code=200
|
|
):
|
|
self._create_thread(user, "cohorted_topic", mock_request, group_id, pass_group_id, expected_status_code)
|
|
|
|
def test_student_without_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.student, mock_request, None, pass_group_id=False)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.student_cohort.id)
|
|
|
|
def test_student_none_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.student, mock_request, None)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.student_cohort.id)
|
|
|
|
def test_student_with_own_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.student, mock_request, self.student_cohort.id)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.student_cohort.id)
|
|
|
|
def test_student_with_other_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.student, mock_request, self.moderator_cohort.id)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.student_cohort.id)
|
|
|
|
def test_moderator_without_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.moderator, mock_request, None, pass_group_id=False)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.moderator_cohort.id)
|
|
|
|
def test_moderator_none_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.moderator, mock_request, None, expected_status_code=400)
|
|
self.assertFalse(mock_request.called)
|
|
|
|
def test_moderator_with_own_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.moderator, mock_request, self.moderator_cohort.id)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.moderator_cohort.id)
|
|
|
|
def test_moderator_with_other_group_id(self, mock_request):
|
|
self._create_thread_in_cohorted_topic(self.moderator, mock_request, self.student_cohort.id)
|
|
self._assert_mock_request_called_with_group_id(mock_request, self.student_cohort.id)
|
|
|
|
def test_moderator_with_invalid_group_id(self, mock_request):
|
|
invalid_id = self.student_cohort.id + self.moderator_cohort.id
|
|
self._create_thread_in_cohorted_topic(self.moderator, mock_request, invalid_id, expected_status_code=400)
|
|
self.assertFalse(mock_request.called)
|
|
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
class CreateNonCohortedThreadTestCase(CohortedContentTestCase):
|
|
"""
|
|
Tests how `views.create_thread` passes `group_id` to the comments service
|
|
for non-cohorted topics.
|
|
"""
|
|
def _create_thread_in_non_cohorted_topic(
|
|
self,
|
|
user,
|
|
mock_request,
|
|
group_id,
|
|
pass_group_id=True,
|
|
expected_status_code=200
|
|
):
|
|
self._create_thread(user, "non_cohorted_topic", mock_request, group_id, pass_group_id, expected_status_code)
|
|
|
|
def test_student_without_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.student, mock_request, None, pass_group_id=False)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_student_none_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.student, mock_request, None)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_student_with_own_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.student, mock_request, self.student_cohort.id)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_student_with_other_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.student, mock_request, self.moderator_cohort.id)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_moderator_without_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.moderator, mock_request, None, pass_group_id=False)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_moderator_none_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.student, mock_request, None)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_moderator_with_own_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.moderator, mock_request, self.moderator_cohort.id)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_moderator_with_other_group_id(self, mock_request):
|
|
self._create_thread_in_non_cohorted_topic(self.moderator, mock_request, self.student_cohort.id)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
def test_moderator_with_invalid_group_id(self, mock_request):
|
|
invalid_id = self.student_cohort.id + self.moderator_cohort.id
|
|
self._create_thread_in_non_cohorted_topic(self.moderator, mock_request, invalid_id)
|
|
self._assert_mock_request_called_without_group_id(mock_request)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
class ViewsTestCase(UrlResetMixin, ModuleStoreTestCase, MockRequestSetupMixin):
|
|
|
|
@patch.dict("django.conf.settings.FEATURES", {"ENABLE_DISCUSSION_SERVICE": True})
|
|
def setUp(self):
|
|
|
|
# Patching the ENABLE_DISCUSSION_SERVICE value affects the contents of urls.py,
|
|
# so we need to call super.setUp() which reloads urls.py (because
|
|
# of the UrlResetMixin)
|
|
super(ViewsTestCase, self).setUp(create_user=False)
|
|
|
|
# create a course
|
|
self.course = CourseFactory.create(org='MITx', course='999',
|
|
display_name='Robot Super Course')
|
|
self.course_id = self.course.id
|
|
# seed the forums permissions and roles
|
|
call_command('seed_permissions_roles', self.course_id.to_deprecated_string())
|
|
|
|
# Patch the comment client user save method so it does not try
|
|
# to create a new cc user when creating a django user
|
|
with patch('student.models.cc.User.save'):
|
|
uname = 'student'
|
|
email = 'student@edx.org'
|
|
password = 'test'
|
|
|
|
# Create the user and make them active so we can log them in.
|
|
self.student = User.objects.create_user(uname, email, password)
|
|
self.student.is_active = True
|
|
self.student.save()
|
|
|
|
# Enroll the student in the course
|
|
CourseEnrollmentFactory(user=self.student,
|
|
course_id=self.course_id)
|
|
|
|
self.client = Client()
|
|
assert_true(self.client.login(username='student', password='test'))
|
|
|
|
def test_create_thread(self, mock_request):
|
|
mock_request.return_value.status_code = 200
|
|
self._set_mock_request_data(mock_request, {
|
|
"thread_type": "discussion",
|
|
"title": "Hello",
|
|
"body": "this is a post",
|
|
"course_id": "MITx/999/Robot_Super_Course",
|
|
"anonymous": False,
|
|
"anonymous_to_peers": False,
|
|
"commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
|
|
"created_at": "2013-05-10T18:53:43Z",
|
|
"updated_at": "2013-05-10T18:53:43Z",
|
|
"at_position_list": [],
|
|
"closed": False,
|
|
"id": "518d4237b023791dca00000d",
|
|
"user_id": "1",
|
|
"username": "robot",
|
|
"votes": {
|
|
"count": 0,
|
|
"up_count": 0,
|
|
"down_count": 0,
|
|
"point": 0
|
|
},
|
|
"abuse_flaggers": [],
|
|
"type": "thread",
|
|
"group_id": None,
|
|
"pinned": False,
|
|
"endorsed": False,
|
|
"unread_comments_count": 0,
|
|
"read": False,
|
|
"comments_count": 0,
|
|
})
|
|
thread = {
|
|
"thread_type": "discussion",
|
|
"body": ["this is a post"],
|
|
"anonymous_to_peers": ["false"],
|
|
"auto_subscribe": ["false"],
|
|
"anonymous": ["false"],
|
|
"title": ["Hello"],
|
|
}
|
|
url = reverse('create_thread', kwargs={'commentable_id': 'i4x-MITx-999-course-Robot_Super_Course',
|
|
'course_id': self.course_id.to_deprecated_string()})
|
|
response = self.client.post(url, data=thread)
|
|
assert_true(mock_request.called)
|
|
mock_request.assert_called_with(
|
|
'post',
|
|
'{prefix}/i4x-MITx-999-course-Robot_Super_Course/threads'.format(prefix=CS_PREFIX),
|
|
data={
|
|
'thread_type': 'discussion',
|
|
'body': u'this is a post',
|
|
'anonymous_to_peers': False, 'user_id': 1,
|
|
'title': u'Hello',
|
|
'commentable_id': u'i4x-MITx-999-course-Robot_Super_Course',
|
|
'anonymous': False,
|
|
'course_id': u'MITx/999/Robot_Super_Course',
|
|
},
|
|
params={'request_id': ANY},
|
|
headers=ANY,
|
|
timeout=5
|
|
)
|
|
assert_equal(response.status_code, 200)
|
|
|
|
def test_delete_comment(self, mock_request):
|
|
self._set_mock_request_data(mock_request, {
|
|
"user_id": str(self.student.id),
|
|
"closed": False,
|
|
})
|
|
test_comment_id = "test_comment_id"
|
|
request = RequestFactory().post("dummy_url", {"id": test_comment_id})
|
|
request.user = self.student
|
|
request.view_name = "delete_comment"
|
|
response = views.delete_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id=test_comment_id)
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
args = mock_request.call_args[0]
|
|
self.assertEqual(args[0], "delete")
|
|
self.assertTrue(args[1].endswith("/{}".format(test_comment_id)))
|
|
|
|
def _setup_mock_request(self, mock_request, include_depth=False):
|
|
"""
|
|
Ensure that mock_request returns the data necessary to make views
|
|
function correctly
|
|
"""
|
|
mock_request.return_value.status_code = 200
|
|
data = {
|
|
"user_id": str(self.student.id),
|
|
"closed": False,
|
|
}
|
|
if include_depth:
|
|
data["depth"] = 0
|
|
self._set_mock_request_data(mock_request, data)
|
|
|
|
def _test_request_error(self, view_name, view_kwargs, data, mock_request):
|
|
"""
|
|
Submit a request against the given view with the given data and ensure
|
|
that the result is a 400 error and that no data was posted using
|
|
mock_request
|
|
"""
|
|
self._setup_mock_request(mock_request, include_depth=(view_name == "create_sub_comment"))
|
|
|
|
response = self.client.post(reverse(view_name, kwargs=view_kwargs), data=data)
|
|
self.assertEqual(response.status_code, 400)
|
|
for call in mock_request.call_args_list:
|
|
self.assertEqual(call[0][0].lower(), "get")
|
|
|
|
def test_create_thread_no_title(self, mock_request):
|
|
self._test_request_error(
|
|
"create_thread",
|
|
{"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_thread_empty_title(self, mock_request):
|
|
self._test_request_error(
|
|
"create_thread",
|
|
{"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": "foo", "title": " "},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_thread_no_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_thread",
|
|
{"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"title": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_thread_empty_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_thread",
|
|
{"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": " ", "title": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_thread_no_title(self, mock_request):
|
|
self._test_request_error(
|
|
"update_thread",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_thread_empty_title(self, mock_request):
|
|
self._test_request_error(
|
|
"update_thread",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": "foo", "title": " "},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_thread_no_body(self, mock_request):
|
|
self._test_request_error(
|
|
"update_thread",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"title": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_thread_empty_body(self, mock_request):
|
|
self._test_request_error(
|
|
"update_thread",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": " ", "title": "foo"},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_comment_no_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_comment",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_comment_empty_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_comment",
|
|
{"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": " "},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_sub_comment_no_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_sub_comment",
|
|
{"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{},
|
|
mock_request
|
|
)
|
|
|
|
def test_create_sub_comment_empty_body(self, mock_request):
|
|
self._test_request_error(
|
|
"create_sub_comment",
|
|
{"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": " "},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_comment_no_body(self, mock_request):
|
|
self._test_request_error(
|
|
"update_comment",
|
|
{"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_comment_empty_body(self, mock_request):
|
|
self._test_request_error(
|
|
"update_comment",
|
|
{"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
|
|
{"body": " "},
|
|
mock_request
|
|
)
|
|
|
|
def test_update_comment_basic(self, mock_request):
|
|
self._setup_mock_request(mock_request)
|
|
comment_id = "test_comment_id"
|
|
updated_body = "updated body"
|
|
|
|
response = self.client.post(
|
|
reverse(
|
|
"update_comment",
|
|
kwargs={"course_id": self.course_id.to_deprecated_string(), "comment_id": comment_id}
|
|
),
|
|
data={"body": updated_body}
|
|
)
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
mock_request.assert_called_with(
|
|
"put",
|
|
"{prefix}/comments/{comment_id}".format(prefix=CS_PREFIX, comment_id=comment_id),
|
|
headers=ANY,
|
|
params=ANY,
|
|
timeout=ANY,
|
|
data={"body": updated_body}
|
|
)
|
|
|
|
def test_flag_thread_open(self, mock_request):
|
|
self.flag_thread(mock_request, False)
|
|
|
|
def test_flag_thread_close(self, mock_request):
|
|
self.flag_thread(mock_request, True)
|
|
|
|
def flag_thread(self, mock_request, is_closed):
|
|
mock_request.return_value.status_code = 200
|
|
self._set_mock_request_data(mock_request, {
|
|
"title": "Hello",
|
|
"body": "this is a post",
|
|
"course_id": "MITx/999/Robot_Super_Course",
|
|
"anonymous": False,
|
|
"anonymous_to_peers": False,
|
|
"commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
|
|
"created_at": "2013-05-10T18:53:43Z",
|
|
"updated_at": "2013-05-10T18:53:43Z",
|
|
"at_position_list": [],
|
|
"closed": is_closed,
|
|
"id": "518d4237b023791dca00000d",
|
|
"user_id": "1","username": "robot",
|
|
"votes": {
|
|
"count": 0,
|
|
"up_count": 0,
|
|
"down_count": 0,
|
|
"point": 0
|
|
},
|
|
"abuse_flaggers": [1],
|
|
"type": "thread",
|
|
"group_id": None,
|
|
"pinned": False,
|
|
"endorsed": False,
|
|
"unread_comments_count": 0,
|
|
"read": False,
|
|
"comments_count": 0,
|
|
})
|
|
url = reverse('flag_abuse_for_thread', kwargs={'thread_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
|
|
response = self.client.post(url)
|
|
assert_true(mock_request.called)
|
|
|
|
call_list = [
|
|
(
|
|
('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'mark_as_read': True, 'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('put', '{prefix}/threads/518d4237b023791dca00000d/abuse_flag'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': {'user_id': '1'},
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'mark_as_read': True, 'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
)
|
|
]
|
|
|
|
assert_equal(call_list, mock_request.call_args_list)
|
|
|
|
assert_equal(response.status_code, 200)
|
|
|
|
def test_un_flag_thread_open(self, mock_request):
|
|
self.un_flag_thread(mock_request, False)
|
|
|
|
def test_un_flag_thread_close(self, mock_request):
|
|
self.un_flag_thread(mock_request, True)
|
|
|
|
def un_flag_thread(self, mock_request, is_closed):
|
|
mock_request.return_value.status_code = 200
|
|
self._set_mock_request_data(mock_request, {
|
|
"title": "Hello",
|
|
"body": "this is a post",
|
|
"course_id": "MITx/999/Robot_Super_Course",
|
|
"anonymous": False,
|
|
"anonymous_to_peers": False,
|
|
"commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
|
|
"created_at": "2013-05-10T18:53:43Z",
|
|
"updated_at": "2013-05-10T18:53:43Z",
|
|
"at_position_list": [],
|
|
"closed": is_closed,
|
|
"id": "518d4237b023791dca00000d",
|
|
"user_id": "1",
|
|
"username": "robot",
|
|
"votes": {
|
|
"count": 0,
|
|
"up_count": 0,
|
|
"down_count": 0,
|
|
"point": 0
|
|
},
|
|
"abuse_flaggers": [],
|
|
"type": "thread",
|
|
"group_id": None,
|
|
"pinned": False,
|
|
"endorsed": False,
|
|
"unread_comments_count": 0,
|
|
"read": False,
|
|
"comments_count": 0
|
|
})
|
|
url = reverse('un_flag_abuse_for_thread', kwargs={'thread_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
|
|
response = self.client.post(url)
|
|
assert_true(mock_request.called)
|
|
|
|
call_list = [
|
|
(
|
|
('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'mark_as_read': True, 'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('put', '{prefix}/threads/518d4237b023791dca00000d/abuse_unflag'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': {'user_id': '1'},
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'mark_as_read': True, 'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
)
|
|
]
|
|
|
|
assert_equal(call_list, mock_request.call_args_list)
|
|
|
|
assert_equal(response.status_code, 200)
|
|
|
|
def test_flag_comment_open(self, mock_request):
|
|
self.flag_comment(mock_request, False)
|
|
|
|
def test_flag_comment_close(self, mock_request):
|
|
self.flag_comment(mock_request, True)
|
|
|
|
def flag_comment(self, mock_request, is_closed):
|
|
mock_request.return_value.status_code = 200
|
|
self._set_mock_request_data(mock_request, {
|
|
"body": "this is a comment",
|
|
"course_id": "MITx/999/Robot_Super_Course",
|
|
"anonymous": False,
|
|
"anonymous_to_peers": False,
|
|
"commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
|
|
"created_at": "2013-05-10T18:53:43Z",
|
|
"updated_at": "2013-05-10T18:53:43Z",
|
|
"at_position_list": [],
|
|
"closed": is_closed,
|
|
"id": "518d4237b023791dca00000d",
|
|
"user_id": "1",
|
|
"username": "robot",
|
|
"votes": {
|
|
"count": 0,
|
|
"up_count": 0,
|
|
"down_count": 0,
|
|
"point": 0
|
|
},
|
|
"abuse_flaggers": [1],
|
|
"type": "comment",
|
|
"endorsed": False
|
|
})
|
|
url = reverse('flag_abuse_for_comment', kwargs={'comment_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
|
|
response = self.client.post(url)
|
|
assert_true(mock_request.called)
|
|
|
|
call_list = [
|
|
(
|
|
('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('put', '{prefix}/comments/518d4237b023791dca00000d/abuse_flag'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': {'user_id': '1'},
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
)
|
|
]
|
|
|
|
assert_equal(call_list, mock_request.call_args_list)
|
|
|
|
assert_equal(response.status_code, 200)
|
|
|
|
def test_un_flag_comment_open(self, mock_request):
|
|
self.un_flag_comment(mock_request, False)
|
|
|
|
def test_un_flag_comment_close(self, mock_request):
|
|
self.un_flag_comment(mock_request, True)
|
|
|
|
def un_flag_comment(self, mock_request, is_closed):
|
|
mock_request.return_value.status_code = 200
|
|
self._set_mock_request_data(mock_request, {
|
|
"body": "this is a comment",
|
|
"course_id": "MITx/999/Robot_Super_Course",
|
|
"anonymous": False,
|
|
"anonymous_to_peers": False,
|
|
"commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
|
|
"created_at": "2013-05-10T18:53:43Z",
|
|
"updated_at": "2013-05-10T18:53:43Z",
|
|
"at_position_list": [],
|
|
"closed": is_closed,
|
|
"id": "518d4237b023791dca00000d",
|
|
"user_id": "1",
|
|
"username": "robot",
|
|
"votes": {
|
|
"count": 0,
|
|
"up_count": 0,
|
|
"down_count": 0,
|
|
"point": 0
|
|
},
|
|
"abuse_flaggers": [],
|
|
"type": "comment",
|
|
"endorsed": False
|
|
})
|
|
url = reverse('un_flag_abuse_for_comment', kwargs={'comment_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
|
|
response = self.client.post(url)
|
|
assert_true(mock_request.called)
|
|
|
|
call_list = [
|
|
(
|
|
('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('put', '{prefix}/comments/518d4237b023791dca00000d/abuse_unflag'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': {'user_id': '1'},
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
),
|
|
(
|
|
('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
|
|
{
|
|
'data': None,
|
|
'params': {'request_id': ANY},
|
|
'headers': ANY,
|
|
'timeout': 5
|
|
}
|
|
)
|
|
]
|
|
|
|
assert_equal(call_list, mock_request.call_args_list)
|
|
|
|
assert_equal(response.status_code, 200)
|
|
|
|
|
|
@patch("lms.lib.comment_client.utils.requests.request")
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class ViewPermissionsTestCase(UrlResetMixin, ModuleStoreTestCase, MockRequestSetupMixin):
|
|
@patch.dict("django.conf.settings.FEATURES", {"ENABLE_DISCUSSION_SERVICE": True})
|
|
def setUp(self):
|
|
super(ViewPermissionsTestCase, self).setUp()
|
|
self.password = "test password"
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create(password=self.password)
|
|
self.moderator = UserFactory.create(password=self.password)
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
CourseEnrollmentFactory(user=self.moderator, course_id=self.course.id)
|
|
self.moderator.roles.add(Role.objects.get(name="Moderator", course_id=self.course.id))
|
|
|
|
def test_pin_thread_as_student(self, mock_request):
|
|
self._set_mock_request_data(mock_request, {})
|
|
self.client.login(username=self.student.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 401)
|
|
|
|
def test_pin_thread_as_moderator(self, mock_request):
|
|
self._set_mock_request_data(mock_request, {})
|
|
self.client.login(username=self.moderator.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
def test_un_pin_thread_as_student(self, mock_request):
|
|
self._set_mock_request_data(mock_request, {})
|
|
self.client.login(username=self.student.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("un_pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 401)
|
|
|
|
def test_un_pin_thread_as_moderator(self, mock_request):
|
|
self._set_mock_request_data(mock_request, {})
|
|
self.client.login(username=self.moderator.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("un_pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
def _set_mock_request_thread_and_comment(self, mock_request, thread_data, comment_data):
|
|
def handle_request(*args, **kwargs):
|
|
url = args[1]
|
|
if "/threads/" in url:
|
|
return self._create_repsonse_mock(thread_data)
|
|
elif "/comments/" in url:
|
|
return self._create_repsonse_mock(comment_data)
|
|
else:
|
|
raise ArgumentError("Bad url to mock request")
|
|
mock_request.side_effect = handle_request
|
|
|
|
def test_endorse_response_as_staff(self, mock_request):
|
|
self._set_mock_request_thread_and_comment(
|
|
mock_request,
|
|
{"type": "thread", "thread_type": "question", "user_id": str(self.student.id)},
|
|
{"type": "comment", "thread_id": "dummy"}
|
|
)
|
|
self.client.login(username=self.moderator.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
def test_endorse_response_as_student(self, mock_request):
|
|
self._set_mock_request_thread_and_comment(
|
|
mock_request,
|
|
{"type": "thread", "thread_type": "question", "user_id": str(self.moderator.id)},
|
|
{"type": "comment", "thread_id": "dummy"}
|
|
)
|
|
self.client.login(username=self.student.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 401)
|
|
|
|
def test_endorse_response_as_student_question_author(self, mock_request):
|
|
self._set_mock_request_thread_and_comment(
|
|
mock_request,
|
|
{"type": "thread", "thread_type": "question", "user_id": str(self.student.id)},
|
|
{"type": "comment", "thread_id": "dummy"}
|
|
)
|
|
self.client.login(username=self.student.username, password=self.password)
|
|
response = self.client.post(
|
|
reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
|
|
)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class CreateThreadUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def _test_unicode_data(self, text, mock_request):
|
|
self._set_mock_request_data(mock_request, {})
|
|
request = RequestFactory().post("dummy_url", {"thread_type": "discussion", "body": text, "title": text})
|
|
request.user = self.student
|
|
request.view_name = "create_thread"
|
|
response = views.create_thread(request, course_id=self.course.id.to_deprecated_string(), commentable_id="test_commentable")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["title"], text)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class UpdateThreadUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def _test_unicode_data(self, text, mock_request):
|
|
self._set_mock_request_data(mock_request, {
|
|
"user_id": str(self.student.id),
|
|
"closed": False,
|
|
})
|
|
request = RequestFactory().post("dummy_url", {"body": text, "title": text})
|
|
request.user = self.student
|
|
request.view_name = "update_thread"
|
|
response = views.update_thread(request, course_id=self.course.id.to_deprecated_string(), thread_id="dummy_thread_id")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["title"], text)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class CreateCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def _test_unicode_data(self, text, mock_request):
|
|
self._set_mock_request_data(mock_request, {
|
|
"closed": False,
|
|
})
|
|
request = RequestFactory().post("dummy_url", {"body": text})
|
|
request.user = self.student
|
|
request.view_name = "create_comment"
|
|
response = views.create_comment(request, course_id=self.course.id.to_deprecated_string(), thread_id="dummy_thread_id")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class UpdateCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def _test_unicode_data(self, text, mock_request):
|
|
self._set_mock_request_data(mock_request, {
|
|
"user_id": str(self.student.id),
|
|
"closed": False,
|
|
})
|
|
request = RequestFactory().post("dummy_url", {"body": text})
|
|
request.user = self.student
|
|
request.view_name = "update_comment"
|
|
response = views.update_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id="dummy_comment_id")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class CreateSubCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def _test_unicode_data(self, text, mock_request):
|
|
self._set_mock_request_data(mock_request, {
|
|
"closed": False,
|
|
"depth": 1,
|
|
})
|
|
request = RequestFactory().post("dummy_url", {"body": text})
|
|
request.user = self.student
|
|
request.view_name = "create_sub_comment"
|
|
response = views.create_sub_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id="dummy_comment_id")
|
|
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertTrue(mock_request.called)
|
|
self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
|
|
|
|
|
|
@override_settings(MODULESTORE=TEST_DATA_MIXED_MODULESTORE)
|
|
class UsersEndpointTestCase(ModuleStoreTestCase, MockRequestSetupMixin):
|
|
|
|
def set_post_counts(self, mock_request, threads_count=1, comments_count=1):
|
|
"""
|
|
sets up a mock response from the comments service for getting post counts for our other_user
|
|
"""
|
|
self._set_mock_request_data(mock_request, {
|
|
"threads_count": threads_count,
|
|
"comments_count": comments_count,
|
|
})
|
|
|
|
def setUp(self):
|
|
self.course = CourseFactory.create()
|
|
seed_permissions_roles(self.course.id)
|
|
self.student = UserFactory.create()
|
|
self.enrollment = CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
|
|
self.other_user = UserFactory.create(username="other")
|
|
CourseEnrollmentFactory(user=self.other_user, course_id=self.course.id)
|
|
|
|
def make_request(self, method='get', course_id=None, **kwargs):
|
|
course_id = course_id or self.course.id
|
|
request = getattr(RequestFactory(), method)("dummy_url", kwargs)
|
|
request.user = self.student
|
|
request.view_name = "users"
|
|
return views.users(request, course_id=course_id.to_deprecated_string())
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def test_finds_exact_match(self, mock_request):
|
|
self.set_post_counts(mock_request)
|
|
response = self.make_request(username="other")
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(
|
|
json.loads(response.content)["users"],
|
|
[{"id": self.other_user.id, "username": self.other_user.username}]
|
|
)
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def test_finds_no_match(self, mock_request):
|
|
self.set_post_counts(mock_request)
|
|
response = self.make_request(username="othor")
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(json.loads(response.content)["users"], [])
|
|
|
|
def test_requires_GET(self):
|
|
response = self.make_request(method='post', username="other")
|
|
self.assertEqual(response.status_code, 405)
|
|
|
|
def test_requires_username_param(self):
|
|
response = self.make_request()
|
|
self.assertEqual(response.status_code, 400)
|
|
content = json.loads(response.content)
|
|
self.assertIn("errors", content)
|
|
self.assertNotIn("users", content)
|
|
|
|
def test_course_does_not_exist(self):
|
|
course_id = SlashSeparatedCourseKey.from_deprecated_string("does/not/exist")
|
|
response = self.make_request(course_id=course_id, username="other")
|
|
|
|
self.assertEqual(response.status_code, 404)
|
|
content = json.loads(response.content)
|
|
self.assertIn("errors", content)
|
|
self.assertNotIn("users", content)
|
|
|
|
def test_requires_requestor_enrolled_in_course(self):
|
|
# unenroll self.student from the course.
|
|
self.enrollment.delete()
|
|
|
|
response = self.make_request(username="other")
|
|
self.assertEqual(response.status_code, 404)
|
|
content = json.loads(response.content)
|
|
self.assertTrue(content.has_key("errors"))
|
|
self.assertFalse(content.has_key("users"))
|
|
|
|
@patch('lms.lib.comment_client.utils.requests.request')
|
|
def test_requires_matched_user_has_forum_content(self, mock_request):
|
|
self.set_post_counts(mock_request, 0, 0)
|
|
response = self.make_request(username="other")
|
|
self.assertEqual(response.status_code, 200)
|
|
self.assertEqual(json.loads(response.content)["users"], [])
|