6f9a3911e5
This abstract class contains most of the fields (aside from the id and foreign key to StudentModule that the subclasses need to manage). It also provides a get_history method that abstracts searching across multiple backends. Move router code to openedx/core We need to use it from cms and lms. Ensure aws_migrate can be used for migrating both the lms and cms. Handle queries directed to student_module_history vs default and the extra queries generated by Django 1.8 (SAVEPOINTS, etc). Additionally, flag testing classes as multi_db so that Django will flush the non-default database between unit tests. Further decouple the foreignkey relation between csm and csmhe When calling StudentModule().delete() Django will try to delete CSMHE objects, but naively does so in the database, not by consulting the database router. Instead, we disable django cascading deletes and listen for post_delete signals and clean up CSMHE by hand. Add feature flags for CSMHE One to turn it on/off so we can control the deploy. The other will control whether or not we read from two database tables or one when searching. Update tests to explicitly use this get_history method rather than looking directly into StudentModuleHistory or StudentModuleHistoryExtended. Inform lettuce to avoid the coursewarehistoryextended app Otherwise it fails when it can't find features/ in that app. Add Pg support, this is not tested automatically.
515 lines
19 KiB
Python
515 lines
19 KiB
Python
"""
|
|
Test grade calculation.
|
|
"""
|
|
from django.http import Http404
|
|
from django.test import TestCase
|
|
from django.test.client import RequestFactory
|
|
|
|
from mock import patch, MagicMock
|
|
from nose.plugins.attrib import attr
|
|
from opaque_keys.edx.locations import SlashSeparatedCourseKey
|
|
from opaque_keys.edx.locator import CourseLocator, BlockUsageLocator
|
|
|
|
from courseware.grades import (
|
|
field_data_cache_for_grading,
|
|
grade,
|
|
iterate_grades_for,
|
|
MaxScoresCache,
|
|
ProgressSummary,
|
|
get_module_score
|
|
)
|
|
from courseware.module_render import get_module
|
|
from courseware.model_data import FieldDataCache, set_score
|
|
from courseware.tests.helpers import (
|
|
LoginEnrollmentTestCase,
|
|
get_request_for_user
|
|
)
|
|
from capa.tests.response_xml_factory import MultipleChoiceResponseXMLFactory
|
|
from student.tests.factories import UserFactory
|
|
from student.models import CourseEnrollment
|
|
from xmodule.modulestore.tests.factories import CourseFactory, ItemFactory
|
|
from xmodule.modulestore.tests.django_utils import SharedModuleStoreTestCase
|
|
|
|
|
|
def _grade_with_errors(student, request, course, keep_raw_scores=False):
|
|
"""This fake grade method will throw exceptions for student3 and
|
|
student4, but allow any other students to go through normal grading.
|
|
|
|
It's meant to simulate when something goes really wrong while trying to
|
|
grade a particular student, so we can test that we won't kill the entire
|
|
course grading run.
|
|
"""
|
|
if student.username in ['student3', 'student4']:
|
|
raise Exception("I don't like {}".format(student.username))
|
|
|
|
return grade(student, request, course, keep_raw_scores=keep_raw_scores)
|
|
|
|
|
|
@attr('shard_1')
|
|
class TestGradeIteration(SharedModuleStoreTestCase):
|
|
"""
|
|
Test iteration through student gradesets.
|
|
"""
|
|
COURSE_NUM = "1000"
|
|
COURSE_NAME = "grading_test_course"
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestGradeIteration, cls).setUpClass()
|
|
cls.course = CourseFactory.create(
|
|
display_name=cls.COURSE_NAME,
|
|
number=cls.COURSE_NUM
|
|
)
|
|
|
|
def setUp(self):
|
|
"""
|
|
Create a course and a handful of users to assign grades
|
|
"""
|
|
super(TestGradeIteration, self).setUp()
|
|
|
|
self.students = [
|
|
UserFactory.create(username='student1'),
|
|
UserFactory.create(username='student2'),
|
|
UserFactory.create(username='student3'),
|
|
UserFactory.create(username='student4'),
|
|
UserFactory.create(username='student5'),
|
|
]
|
|
|
|
def test_empty_student_list(self):
|
|
"""If we don't pass in any students, it should return a zero-length
|
|
iterator, but it shouldn't error."""
|
|
gradeset_results = list(iterate_grades_for(self.course.id, []))
|
|
self.assertEqual(gradeset_results, [])
|
|
|
|
def test_nonexistent_course(self):
|
|
"""If the course we want to get grades for does not exist, a `Http404`
|
|
should be raised. This is a horrible crossing of abstraction boundaries
|
|
and should be fixed, but for now we're just testing the behavior. :-("""
|
|
with self.assertRaises(Http404):
|
|
gradeset_results = iterate_grades_for(SlashSeparatedCourseKey("I", "dont", "exist"), [])
|
|
gradeset_results.next()
|
|
|
|
def test_all_empty_grades(self):
|
|
"""No students have grade entries"""
|
|
all_gradesets, all_errors = self._gradesets_and_errors_for(self.course.id, self.students)
|
|
self.assertEqual(len(all_errors), 0)
|
|
for gradeset in all_gradesets.values():
|
|
self.assertIsNone(gradeset['grade'])
|
|
self.assertEqual(gradeset['percent'], 0.0)
|
|
|
|
@patch('courseware.grades.grade', _grade_with_errors)
|
|
def test_grading_exception(self):
|
|
"""Test that we correctly capture exception messages that bubble up from
|
|
grading. Note that we only see errors at this level if the grading
|
|
process for this student fails entirely due to an unexpected event --
|
|
having errors in the problem sets will not trigger this.
|
|
|
|
We patch the grade() method with our own, which will generate the errors
|
|
for student3 and student4.
|
|
"""
|
|
all_gradesets, all_errors = self._gradesets_and_errors_for(self.course.id, self.students)
|
|
student1, student2, student3, student4, student5 = self.students
|
|
self.assertEqual(
|
|
all_errors,
|
|
{
|
|
student3: "I don't like student3",
|
|
student4: "I don't like student4"
|
|
}
|
|
)
|
|
|
|
# But we should still have five gradesets
|
|
self.assertEqual(len(all_gradesets), 5)
|
|
|
|
# Even though two will simply be empty
|
|
self.assertFalse(all_gradesets[student3])
|
|
self.assertFalse(all_gradesets[student4])
|
|
|
|
# The rest will have grade information in them
|
|
self.assertTrue(all_gradesets[student1])
|
|
self.assertTrue(all_gradesets[student2])
|
|
self.assertTrue(all_gradesets[student5])
|
|
|
|
################################# Helpers #################################
|
|
def _gradesets_and_errors_for(self, course_id, students):
|
|
"""Simple helper method to iterate through student grades and give us
|
|
two dictionaries -- one that has all students and their respective
|
|
gradesets, and one that has only students that could not be graded and
|
|
their respective error messages."""
|
|
students_to_gradesets = {}
|
|
students_to_errors = {}
|
|
|
|
for student, gradeset, err_msg in iterate_grades_for(course_id, students):
|
|
students_to_gradesets[student] = gradeset
|
|
if err_msg:
|
|
students_to_errors[student] = err_msg
|
|
|
|
return students_to_gradesets, students_to_errors
|
|
|
|
|
|
class TestMaxScoresCache(SharedModuleStoreTestCase):
|
|
"""
|
|
Tests for the MaxScoresCache
|
|
"""
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestMaxScoresCache, cls).setUpClass()
|
|
cls.course = CourseFactory.create()
|
|
cls.problems = []
|
|
for _ in xrange(3):
|
|
cls.problems.append(
|
|
ItemFactory.create(category='problem', parent=cls.course)
|
|
)
|
|
|
|
def setUp(self):
|
|
super(TestMaxScoresCache, self).setUp()
|
|
self.student = UserFactory.create()
|
|
|
|
CourseEnrollment.enroll(self.student, self.course.id)
|
|
self.request = RequestFactory().get('/')
|
|
self.locations = [problem.location for problem in self.problems]
|
|
|
|
def test_max_scores_cache(self):
|
|
"""
|
|
Tests the behavior fo the MaxScoresCache
|
|
"""
|
|
max_scores_cache = MaxScoresCache("test_max_scores_cache")
|
|
self.assertEqual(max_scores_cache.num_cached_from_remote(), 0)
|
|
self.assertEqual(max_scores_cache.num_cached_updates(), 0)
|
|
|
|
# add score to cache
|
|
max_scores_cache.set(self.locations[0], 1)
|
|
self.assertEqual(max_scores_cache.num_cached_updates(), 1)
|
|
|
|
# push to remote cache
|
|
max_scores_cache.push_to_remote()
|
|
|
|
# create a new cache with the same params, fetch from remote cache
|
|
max_scores_cache = MaxScoresCache("test_max_scores_cache")
|
|
max_scores_cache.fetch_from_remote(self.locations)
|
|
|
|
# see cache is populated
|
|
self.assertEqual(max_scores_cache.num_cached_from_remote(), 1)
|
|
|
|
|
|
class TestFieldDataCacheScorableLocations(SharedModuleStoreTestCase):
|
|
"""
|
|
Make sure we can filter the locations we pull back student state for via
|
|
the FieldDataCache.
|
|
"""
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestFieldDataCacheScorableLocations, cls).setUpClass()
|
|
cls.course = CourseFactory.create()
|
|
chapter = ItemFactory.create(category='chapter', parent=cls.course)
|
|
sequential = ItemFactory.create(category='sequential', parent=chapter)
|
|
vertical = ItemFactory.create(category='vertical', parent=sequential)
|
|
ItemFactory.create(category='video', parent=vertical)
|
|
ItemFactory.create(category='html', parent=vertical)
|
|
ItemFactory.create(category='discussion', parent=vertical)
|
|
ItemFactory.create(category='problem', parent=vertical)
|
|
|
|
def setUp(self):
|
|
super(TestFieldDataCacheScorableLocations, self).setUp()
|
|
self.student = UserFactory.create()
|
|
|
|
CourseEnrollment.enroll(self.student, self.course.id)
|
|
|
|
def test_field_data_cache_scorable_locations(self):
|
|
"""Only scorable locations should be in FieldDataCache.scorable_locations."""
|
|
fd_cache = field_data_cache_for_grading(self.course, self.student)
|
|
block_types = set(loc.block_type for loc in fd_cache.scorable_locations)
|
|
self.assertNotIn('video', block_types)
|
|
self.assertNotIn('html', block_types)
|
|
self.assertNotIn('discussion', block_types)
|
|
self.assertIn('problem', block_types)
|
|
|
|
|
|
class TestProgressSummary(TestCase):
|
|
"""
|
|
Test the method that calculates the score for a given block based on the
|
|
cumulative scores of its children. This test class uses a hard-coded block
|
|
hierarchy with scores as follows:
|
|
a
|
|
+--------+--------+
|
|
b c
|
|
+--------------+-----------+ |
|
|
d e f g
|
|
+-----+ +-----+-----+ | |
|
|
h i j k l m n
|
|
(2/5) (3/5) (0/1) - (1/3) - (3/10)
|
|
|
|
"""
|
|
# Tell Django to clean out all databases, not just default
|
|
multi_db = True
|
|
|
|
def setUp(self):
|
|
super(TestProgressSummary, self).setUp()
|
|
self.course_key = CourseLocator(
|
|
org='some_org',
|
|
course='some_course',
|
|
run='some_run'
|
|
)
|
|
self.loc_a = self.create_location('chapter', 'a')
|
|
self.loc_b = self.create_location('section', 'b')
|
|
self.loc_c = self.create_location('section', 'c')
|
|
self.loc_d = self.create_location('vertical', 'd')
|
|
self.loc_e = self.create_location('vertical', 'e')
|
|
self.loc_f = self.create_location('vertical', 'f')
|
|
self.loc_g = self.create_location('vertical', 'g')
|
|
self.loc_h = self.create_location('problem', 'h')
|
|
self.loc_i = self.create_location('problem', 'i')
|
|
self.loc_j = self.create_location('problem', 'j')
|
|
self.loc_k = self.create_location('html', 'k')
|
|
self.loc_l = self.create_location('problem', 'l')
|
|
self.loc_m = self.create_location('html', 'm')
|
|
self.loc_n = self.create_location('problem', 'n')
|
|
|
|
weighted_scores = {
|
|
self.loc_h: self.create_score(2, 5),
|
|
self.loc_i: self.create_score(3, 5),
|
|
self.loc_j: self.create_score(0, 1),
|
|
self.loc_l: self.create_score(1, 3),
|
|
self.loc_n: self.create_score(3, 10),
|
|
}
|
|
locations_to_scored_children = {
|
|
self.loc_a: [self.loc_h, self.loc_i, self.loc_j, self.loc_l, self.loc_n],
|
|
self.loc_b: [self.loc_h, self.loc_i, self.loc_j, self.loc_l],
|
|
self.loc_c: [self.loc_n],
|
|
self.loc_d: [self.loc_h, self.loc_i],
|
|
self.loc_e: [self.loc_j, self.loc_l],
|
|
self.loc_f: [],
|
|
self.loc_g: [self.loc_n],
|
|
self.loc_k: [],
|
|
self.loc_m: [],
|
|
}
|
|
self.progress_summary = ProgressSummary(
|
|
None, weighted_scores, locations_to_scored_children
|
|
)
|
|
|
|
def create_score(self, earned, possible):
|
|
"""
|
|
Create a new mock Score object with specified earned and possible values
|
|
"""
|
|
score = MagicMock()
|
|
score.possible = possible
|
|
score.earned = earned
|
|
return score
|
|
|
|
def create_location(self, block_type, block_id):
|
|
"""
|
|
Create a new BlockUsageLocation with the given type and ID.
|
|
"""
|
|
return BlockUsageLocator(
|
|
course_key=self.course_key, block_type=block_type, block_id=block_id
|
|
)
|
|
|
|
def test_score_chapter(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_a)
|
|
self.assertEqual(earned, 9)
|
|
self.assertEqual(possible, 24)
|
|
|
|
def test_score_section_many_leaves(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_b)
|
|
self.assertEqual(earned, 6)
|
|
self.assertEqual(possible, 14)
|
|
|
|
def test_score_section_one_leaf(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_c)
|
|
self.assertEqual(earned, 3)
|
|
self.assertEqual(possible, 10)
|
|
|
|
def test_score_vertical_two_leaves(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_d)
|
|
self.assertEqual(earned, 5)
|
|
self.assertEqual(possible, 10)
|
|
|
|
def test_score_vertical_two_leaves_one_unscored(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_e)
|
|
self.assertEqual(earned, 1)
|
|
self.assertEqual(possible, 4)
|
|
|
|
def test_score_vertical_no_score(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_f)
|
|
self.assertEqual(earned, 0)
|
|
self.assertEqual(possible, 0)
|
|
|
|
def test_score_vertical_one_leaf(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_g)
|
|
self.assertEqual(earned, 3)
|
|
self.assertEqual(possible, 10)
|
|
|
|
def test_score_leaf(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_h)
|
|
self.assertEqual(earned, 2)
|
|
self.assertEqual(possible, 5)
|
|
|
|
def test_score_leaf_no_score(self):
|
|
earned, possible = self.progress_summary.score_for_module(self.loc_m)
|
|
self.assertEqual(earned, 0)
|
|
self.assertEqual(possible, 0)
|
|
|
|
|
|
class TestGetModuleScore(LoginEnrollmentTestCase, SharedModuleStoreTestCase):
|
|
"""
|
|
Test get_module_score
|
|
"""
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super(TestGetModuleScore, cls).setUpClass()
|
|
cls.course = CourseFactory.create()
|
|
cls.chapter = ItemFactory.create(
|
|
parent=cls.course,
|
|
category="chapter",
|
|
display_name="Test Chapter"
|
|
)
|
|
cls.seq1 = ItemFactory.create(
|
|
parent=cls.chapter,
|
|
category='sequential',
|
|
display_name="Test Sequential",
|
|
graded=True
|
|
)
|
|
cls.seq2 = ItemFactory.create(
|
|
parent=cls.chapter,
|
|
category='sequential',
|
|
display_name="Test Sequential",
|
|
graded=True
|
|
)
|
|
cls.vert1 = ItemFactory.create(
|
|
parent=cls.seq1,
|
|
category='vertical',
|
|
display_name='Test Vertical 1'
|
|
)
|
|
cls.vert2 = ItemFactory.create(
|
|
parent=cls.seq2,
|
|
category='vertical',
|
|
display_name='Test Vertical 2'
|
|
)
|
|
cls.randomize = ItemFactory.create(
|
|
parent=cls.vert2,
|
|
category='randomize',
|
|
display_name='Test Randomize'
|
|
)
|
|
problem_xml = MultipleChoiceResponseXMLFactory().build_xml(
|
|
question_text='The correct answer is Choice 3',
|
|
choices=[False, False, True, False],
|
|
choice_names=['choice_0', 'choice_1', 'choice_2', 'choice_3']
|
|
)
|
|
cls.problem1 = ItemFactory.create(
|
|
parent=cls.vert1,
|
|
category="problem",
|
|
display_name="Test Problem 1",
|
|
data=problem_xml
|
|
)
|
|
cls.problem2 = ItemFactory.create(
|
|
parent=cls.vert1,
|
|
category="problem",
|
|
display_name="Test Problem 2",
|
|
data=problem_xml
|
|
)
|
|
cls.problem3 = ItemFactory.create(
|
|
parent=cls.randomize,
|
|
category="problem",
|
|
display_name="Test Problem 3",
|
|
data=problem_xml
|
|
)
|
|
cls.problem4 = ItemFactory.create(
|
|
parent=cls.randomize,
|
|
category="problem",
|
|
display_name="Test Problem 4",
|
|
data=problem_xml
|
|
)
|
|
|
|
def setUp(self):
|
|
"""
|
|
Set up test course
|
|
"""
|
|
super(TestGetModuleScore, self).setUp()
|
|
|
|
self.request = get_request_for_user(UserFactory())
|
|
self.client.login(username=self.request.user.username, password="test")
|
|
CourseEnrollment.enroll(self.request.user, self.course.id)
|
|
|
|
def test_get_module_score(self):
|
|
"""
|
|
Test test_get_module_score
|
|
"""
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, 0)
|
|
|
|
answer_problem(self.course, self.request, self.problem1)
|
|
answer_problem(self.course, self.request, self.problem2)
|
|
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, 1.0)
|
|
|
|
answer_problem(self.course, self.request, self.problem1)
|
|
answer_problem(self.course, self.request, self.problem2, 0)
|
|
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, .5)
|
|
|
|
def test_get_module_score_with_empty_score(self):
|
|
"""
|
|
Test test_get_module_score_with_empty_score
|
|
"""
|
|
set_score(self.request.user.id, self.problem1.location, None, None) # pylint: disable=no-member
|
|
set_score(self.request.user.id, self.problem2.location, None, None) # pylint: disable=no-member
|
|
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, 0)
|
|
|
|
answer_problem(self.course, self.request, self.problem1)
|
|
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, 0.5)
|
|
|
|
answer_problem(self.course, self.request, self.problem2)
|
|
|
|
with self.assertNumQueries(1):
|
|
score = get_module_score(self.request.user, self.course, self.seq1)
|
|
self.assertEqual(score, 1.0)
|
|
|
|
def test_get_module_score_with_randomize(self):
|
|
"""
|
|
Test test_get_module_score_with_randomize
|
|
"""
|
|
answer_problem(self.course, self.request, self.problem3)
|
|
answer_problem(self.course, self.request, self.problem4)
|
|
|
|
score = get_module_score(self.request.user, self.course, self.seq2)
|
|
self.assertEqual(score, 1.0)
|
|
|
|
|
|
def answer_problem(course, request, problem, score=1):
|
|
"""
|
|
Records a correct answer for the given problem.
|
|
|
|
Arguments:
|
|
course (Course): Course object, the course the required problem is in
|
|
request (Request): request Object
|
|
problem (xblock): xblock object, the problem to be answered
|
|
"""
|
|
|
|
user = request.user
|
|
grade_dict = {'value': score, 'max_value': 1, 'user_id': user.id}
|
|
field_data_cache = FieldDataCache.cache_for_descriptor_descendents(
|
|
course.id,
|
|
user,
|
|
course,
|
|
depth=2
|
|
)
|
|
# pylint: disable=protected-access
|
|
module = get_module(
|
|
user,
|
|
request,
|
|
problem.scope_ids.usage_id,
|
|
field_data_cache,
|
|
)._xmodule
|
|
module.system.publish(problem, 'grade', grade_dict)
|