b353ed2ea2
The existing pattern of using `override_settings(MODULESTORE=...)` prevented
us from having more than one layer of subclassing in modulestore tests.
In a structure like:
@override_settings(MODULESTORE=store_a)
class BaseTestCase(ModuleStoreTestCase):
def setUp(self):
# use store
@override_settings(MODULESTORE=store_b)
class ChildTestCase(BaseTestCase):
def setUp(self):
# use store
In this case, the store actions performed in `BaseTestCase` on behalf of
`ChildTestCase` would still use `store_a`, even though the `ChildTestCase`
had specified to use `store_b`. This is because the `override_settings`
decorator would be the innermost wrapper around the `BaseTestCase.setUp` method,
no matter what `ChildTestCase` does.
To remedy this, we move the call to `override_settings` into the
`ModuleStoreTestCase.setUp` method, and use a cleanup to remove the override.
Subclasses can just defined the `MODULESTORE` class attribute to specify which
modulestore to use _for the entire `setUp` chain_.
[PLAT-419]
140 lines
6.6 KiB
Python
140 lines
6.6 KiB
Python
"""
|
|
Unit tests for email feature flag in new instructor dashboard.
|
|
Additionally tests that bulk email is always disabled for
|
|
non-Mongo backed courses, regardless of email feature flag, and
|
|
that the view is conditionally available when Course Auth is turned on.
|
|
"""
|
|
from django.conf import settings
|
|
from django.core.urlresolvers import reverse
|
|
from django.test.utils import override_settings
|
|
from mock import patch
|
|
from opaque_keys.edx.locations import SlashSeparatedCourseKey
|
|
|
|
from bulk_email.models import CourseAuthorization
|
|
from xmodule.modulestore.tests.django_utils import TEST_DATA_MIXED_TOY_MODULESTORE, ModuleStoreTestCase
|
|
from student.tests.factories import AdminFactory
|
|
from xmodule.modulestore.tests.factories import CourseFactory
|
|
|
|
|
|
class TestNewInstructorDashboardEmailViewMongoBacked(ModuleStoreTestCase):
|
|
"""
|
|
Check for email view on the new instructor dashboard
|
|
for Mongo-backed courses
|
|
"""
|
|
def setUp(self):
|
|
super(TestNewInstructorDashboardEmailViewMongoBacked, self).setUp()
|
|
self.course = CourseFactory.create()
|
|
|
|
# Create instructor account
|
|
instructor = AdminFactory.create()
|
|
self.client.login(username=instructor.username, password="test")
|
|
|
|
# URL for instructor dash
|
|
self.url = reverse('instructor_dashboard', kwargs={'course_id': self.course.id.to_deprecated_string()})
|
|
# URL for email view
|
|
self.email_link = '<a href="" data-section="send_email">Email</a>'
|
|
|
|
def tearDown(self):
|
|
"""
|
|
Undo all patches.
|
|
"""
|
|
patch.stopall()
|
|
|
|
# In order for bulk email to work, we must have both the ENABLE_INSTRUCTOR_EMAIL_FLAG
|
|
# set to True and for the course to be Mongo-backed.
|
|
# The flag is enabled and the course is Mongo-backed (should work)
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_true_mongo_true(self):
|
|
# Assert that instructor email is enabled for this course - since REQUIRE_COURSE_EMAIL_AUTH is False,
|
|
# all courses should be authorized to use email.
|
|
self.assertTrue(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is in the response
|
|
response = self.client.get(self.url)
|
|
self.assertIn(self.email_link, response.content)
|
|
|
|
send_to_label = '<label for="id_to">Send to:</label>'
|
|
self.assertTrue(send_to_label in response.content)
|
|
self.assertEqual(response.status_code, 200)
|
|
|
|
# The course is Mongo-backed but the flag is disabled (should not work)
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': False})
|
|
def test_email_flag_false_mongo_true(self):
|
|
# Assert that the URL for the email view is not in the response
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|
|
|
|
# Flag is enabled, but we require course auth and haven't turned it on for this course
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': True})
|
|
def test_course_not_authorized(self):
|
|
# Assert that instructor email is not enabled for this course
|
|
self.assertFalse(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is not in the response
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|
|
|
|
# Flag is enabled, we require course auth and turn it on for this course
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': True})
|
|
def test_course_authorized(self):
|
|
# Assert that instructor email is not enabled for this course
|
|
self.assertFalse(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is not in the response
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|
|
|
|
# Authorize the course to use email
|
|
cauth = CourseAuthorization(course_id=self.course.id, email_enabled=True)
|
|
cauth.save()
|
|
|
|
# Assert that instructor email is enabled for this course
|
|
self.assertTrue(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is in the response
|
|
response = self.client.get(self.url)
|
|
self.assertTrue(self.email_link in response.content)
|
|
|
|
# Flag is disabled, but course is authorized
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': False, 'REQUIRE_COURSE_EMAIL_AUTH': True})
|
|
def test_course_authorized_feature_off(self):
|
|
# Authorize the course to use email
|
|
cauth = CourseAuthorization(course_id=self.course.id, email_enabled=True)
|
|
cauth.save()
|
|
|
|
# Assert that instructor email IS enabled for this course
|
|
self.assertTrue(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view IS NOT in the response
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|
|
|
|
|
|
class TestNewInstructorDashboardEmailViewXMLBacked(ModuleStoreTestCase):
|
|
"""
|
|
Check for email view on the new instructor dashboard
|
|
"""
|
|
|
|
MODULESTORE = TEST_DATA_MIXED_TOY_MODULESTORE
|
|
|
|
def setUp(self):
|
|
super(TestNewInstructorDashboardEmailViewXMLBacked, self).setUp()
|
|
self.course_key = SlashSeparatedCourseKey('edX', 'toy', '2012_Fall')
|
|
|
|
# Create instructor account
|
|
instructor = AdminFactory.create()
|
|
self.client.login(username=instructor.username, password="test")
|
|
|
|
# URL for instructor dash
|
|
self.url = reverse('instructor_dashboard', kwargs={'course_id': self.course_key.to_deprecated_string()})
|
|
# URL for email view
|
|
self.email_link = '<a href="" data-section="send_email">Email</a>'
|
|
|
|
# The flag is enabled, and since REQUIRE_COURSE_EMAIL_AUTH is False, all courses should
|
|
# be authorized to use email. But the course is not Mongo-backed (should not work)
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_true_mongo_false(self):
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|
|
|
|
# The flag is disabled and the course is not Mongo-backed (should not work)
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': False, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_false_mongo_false(self):
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_link in response.content)
|