b353ed2ea2
The existing pattern of using `override_settings(MODULESTORE=...)` prevented
us from having more than one layer of subclassing in modulestore tests.
In a structure like:
@override_settings(MODULESTORE=store_a)
class BaseTestCase(ModuleStoreTestCase):
def setUp(self):
# use store
@override_settings(MODULESTORE=store_b)
class ChildTestCase(BaseTestCase):
def setUp(self):
# use store
In this case, the store actions performed in `BaseTestCase` on behalf of
`ChildTestCase` would still use `store_a`, even though the `ChildTestCase`
had specified to use `store_b`. This is because the `override_settings`
decorator would be the innermost wrapper around the `BaseTestCase.setUp` method,
no matter what `ChildTestCase` does.
To remedy this, we move the call to `override_settings` into the
`ModuleStoreTestCase.setUp` method, and use a cleanup to remove the override.
Subclasses can just defined the `MODULESTORE` class attribute to specify which
modulestore to use _for the entire `setUp` chain_.
[PLAT-419]
104 lines
4.1 KiB
Python
104 lines
4.1 KiB
Python
"""
|
|
Tests for class dashboard (Metrics tab in instructor dashboard)
|
|
"""
|
|
from django.test.utils import override_settings
|
|
from django.test.client import RequestFactory
|
|
from django.utils import simplejson
|
|
from mock import patch
|
|
|
|
from xmodule.modulestore.tests.django_utils import TEST_DATA_MOCK_MODULESTORE
|
|
from student.tests.factories import AdminFactory
|
|
from xmodule.modulestore.tests.factories import CourseFactory
|
|
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
|
|
|
|
from class_dashboard import views
|
|
|
|
|
|
class TestViews(ModuleStoreTestCase):
|
|
"""
|
|
Tests related to class_dashboard/views.py
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(TestViews, self).setUp()
|
|
|
|
self.request_factory = RequestFactory()
|
|
self.request = self.request_factory.get('')
|
|
self.request.user = None
|
|
self.simple_data = {'error': 'error'}
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_all_problem_grade_distribution_has_access(self, has_access):
|
|
"""
|
|
Test returns proper value when have proper access
|
|
"""
|
|
has_access.return_value = True
|
|
response = views.all_problem_grade_distribution(self.request, 'test/test/test')
|
|
|
|
self.assertEqual(simplejson.dumps(self.simple_data), response.content)
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_all_problem_grade_distribution_no_access(self, has_access):
|
|
"""
|
|
Test for no access
|
|
"""
|
|
has_access.return_value = False
|
|
response = views.all_problem_grade_distribution(self.request, 'test/test/test')
|
|
|
|
self.assertEqual("{\"error\": \"Access Denied: User does not have access to this course\'s data\"}", response.content)
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_all_sequential_open_distribution_has_access(self, has_access):
|
|
"""
|
|
Test returns proper value when have proper access
|
|
"""
|
|
has_access.return_value = True
|
|
response = views.all_sequential_open_distrib(self.request, 'test/test/test')
|
|
|
|
self.assertEqual(simplejson.dumps(self.simple_data), response.content)
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_all_sequential_open_distribution_no_access(self, has_access):
|
|
"""
|
|
Test for no access
|
|
"""
|
|
has_access.return_value = False
|
|
response = views.all_sequential_open_distrib(self.request, 'test/test/test')
|
|
|
|
self.assertEqual("{\"error\": \"Access Denied: User does not have access to this course\'s data\"}", response.content)
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_section_problem_grade_distribution_has_access(self, has_access):
|
|
"""
|
|
Test returns proper value when have proper access
|
|
"""
|
|
has_access.return_value = True
|
|
response = views.section_problem_grade_distrib(self.request, 'test/test/test', '1')
|
|
|
|
self.assertEqual(simplejson.dumps(self.simple_data), response.content)
|
|
|
|
@patch('class_dashboard.views.has_instructor_access_for_class')
|
|
def test_section_problem_grade_distribution_no_access(self, has_access):
|
|
"""
|
|
Test for no access
|
|
"""
|
|
has_access.return_value = False
|
|
response = views.section_problem_grade_distrib(self.request, 'test/test/test', '1')
|
|
|
|
self.assertEqual("{\"error\": \"Access Denied: User does not have access to this course\'s data\"}", response.content)
|
|
|
|
def test_sending_deprecated_id(self):
|
|
|
|
course = CourseFactory.create()
|
|
instructor = AdminFactory.create()
|
|
self.request.user = instructor
|
|
|
|
response = views.all_sequential_open_distrib(self.request, course.id.to_deprecated_string())
|
|
self.assertEqual('[]', response.content)
|
|
|
|
response = views.all_problem_grade_distribution(self.request, course.id.to_deprecated_string())
|
|
self.assertEqual('[]', response.content)
|
|
|
|
response = views.section_problem_grade_distrib(self.request, course.id.to_deprecated_string(), 'no section')
|
|
self.assertEqual('{"error": "error"}', response.content)
|