d857695d62
Clicking quickly on up/down votes in forums generates a race condition where the votes can continue going up or down (and I can get e.g. large negative numbers). This is client-side; the server-side is not affected. This is caused by safeAjax calling code (including updateWithUndo) not handling the possible undefined return value. This is returned in the case where the element that triggers the event is already disabled. Corrected typo in DiscussionThreadView cleanup: @responseRequest -> @responsesRequest Resolves TNL-1061
49 lines
1.9 KiB
CoffeeScript
49 lines
1.9 KiB
CoffeeScript
describe 'DiscussionUtil', ->
|
|
beforeEach ->
|
|
DiscussionSpecHelper.setUpGlobals()
|
|
|
|
describe "updateWithUndo", ->
|
|
|
|
it "calls through to safeAjax with correct params, and reverts the model in case of failure", ->
|
|
deferred = $.Deferred()
|
|
spyOn($, "ajax").andReturn(deferred)
|
|
spyOn(DiscussionUtil, "safeAjax").andCallThrough()
|
|
|
|
model = new Backbone.Model({hello: false, number: 42})
|
|
updates = {hello: "world"}
|
|
|
|
# the ajax request should fire and the model should be updated
|
|
res = DiscussionUtil.updateWithUndo(model, updates, {foo: "bar"}, "error message")
|
|
expect(DiscussionUtil.safeAjax).toHaveBeenCalled()
|
|
expect(model.attributes).toEqual({hello: "world", number: 42})
|
|
|
|
# the error message callback should be set up correctly
|
|
spyOn(DiscussionUtil, "discussionAlert")
|
|
DiscussionUtil.safeAjax.mostRecentCall.args[0].error()
|
|
expect(DiscussionUtil.discussionAlert).toHaveBeenCalledWith("Sorry", "error message")
|
|
|
|
# if the ajax call ends in failure, the model state should be reverted
|
|
deferred.reject()
|
|
expect(model.attributes).toEqual({hello: false, number: 42})
|
|
|
|
it "rolls back the changes if the associated element is disabled", ->
|
|
spyOn(DiscussionUtil, "safeAjax").andCallThrough()
|
|
|
|
model = new Backbone.Model({hello: false, number: 42})
|
|
updates = {hello: "world"}
|
|
|
|
# This is the element that is disabled/enabled while the ajax request is
|
|
# in progress
|
|
$elem = jasmine.createSpyObj('$elem', ['attr'])
|
|
$elem.attr.andReturn(true)
|
|
|
|
res = DiscussionUtil.updateWithUndo(model, updates, {foo: "bar", $elem:$elem}, "error message")
|
|
|
|
expect($elem.attr).toHaveBeenCalledWith("disabled")
|
|
expect(DiscussionUtil.safeAjax).toHaveBeenCalled()
|
|
expect(model.attributes).toEqual({hello: false, number: 42})
|
|
|
|
failed = false
|
|
res.fail(() => failed = true)
|
|
expect(failed).toBe(true);
|