The existing pattern of using `override_settings(MODULESTORE=...)` prevented
us from having more than one layer of subclassing in modulestore tests.
In a structure like:
@override_settings(MODULESTORE=store_a)
class BaseTestCase(ModuleStoreTestCase):
def setUp(self):
# use store
@override_settings(MODULESTORE=store_b)
class ChildTestCase(BaseTestCase):
def setUp(self):
# use store
In this case, the store actions performed in `BaseTestCase` on behalf of
`ChildTestCase` would still use `store_a`, even though the `ChildTestCase`
had specified to use `store_b`. This is because the `override_settings`
decorator would be the innermost wrapper around the `BaseTestCase.setUp` method,
no matter what `ChildTestCase` does.
To remedy this, we move the call to `override_settings` into the
`ModuleStoreTestCase.setUp` method, and use a cleanup to remove the override.
Subclasses can just defined the `MODULESTORE` class attribute to specify which
modulestore to use _for the entire `setUp` chain_.
[PLAT-419]
138 lines
5.7 KiB
Python
138 lines
5.7 KiB
Python
"""
|
|
Unit tests for email feature flag in student dashboard. Additionally tests
|
|
that bulk email is always disabled for non-Mongo backed courses, regardless
|
|
of email feature flag, and that the view is conditionally available when
|
|
Course Auth is turned on.
|
|
"""
|
|
import unittest
|
|
|
|
from django.conf import settings
|
|
from django.core.urlresolvers import reverse
|
|
from django.test.utils import override_settings
|
|
from mock import patch
|
|
from opaque_keys.edx.locations import SlashSeparatedCourseKey
|
|
|
|
from student.tests.factories import UserFactory, CourseEnrollmentFactory
|
|
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
|
|
from xmodule.modulestore.tests.django_utils import (
|
|
TEST_DATA_MOCK_MODULESTORE, TEST_DATA_MIXED_TOY_MODULESTORE
|
|
)
|
|
from xmodule.modulestore.tests.factories import CourseFactory
|
|
|
|
# This import is for an lms djangoapp.
|
|
# Its testcases are only run under lms.
|
|
from bulk_email.models import CourseAuthorization # pylint: disable=import-error
|
|
|
|
|
|
@unittest.skipUnless(settings.ROOT_URLCONF == 'lms.urls', 'Test only valid in lms')
|
|
class TestStudentDashboardEmailView(ModuleStoreTestCase):
|
|
"""
|
|
Check for email view displayed with flag
|
|
"""
|
|
|
|
def setUp(self):
|
|
super(TestStudentDashboardEmailView, self).setUp()
|
|
|
|
self.course = CourseFactory.create()
|
|
|
|
# Create student account
|
|
student = UserFactory.create()
|
|
CourseEnrollmentFactory.create(user=student, course_id=self.course.id)
|
|
self.client.login(username=student.username, password="test")
|
|
|
|
self.url = reverse('dashboard')
|
|
# URL for email settings modal
|
|
self.email_modal_link = (
|
|
'<a href="#email-settings-modal" class="email-settings" rel="leanModal" '
|
|
'data-course-id="{org}/{num}/{name}" data-course-number="{num}" '
|
|
'data-optout="False">Email Settings</a>'
|
|
).format(
|
|
org=self.course.org,
|
|
num=self.course.number,
|
|
name=self.course.display_name.replace(' ', '_'),
|
|
)
|
|
|
|
def tearDown(self):
|
|
"""
|
|
Undo all patches.
|
|
"""
|
|
patch.stopall()
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_true(self):
|
|
# Assert that the URL for the email view is in the response
|
|
response = self.client.get(self.url)
|
|
self.assertTrue(self.email_modal_link in response.content)
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': False})
|
|
def test_email_flag_false(self):
|
|
# Assert that the URL for the email view is not in the response
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_modal_link in response.content)
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': True})
|
|
def test_email_unauthorized(self):
|
|
# Assert that instructor email is not enabled for this course
|
|
self.assertFalse(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is not in the response
|
|
# if this course isn't authorized
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_modal_link in response.content)
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': True})
|
|
def test_email_authorized(self):
|
|
# Authorize the course to use email
|
|
cauth = CourseAuthorization(course_id=self.course.id, email_enabled=True)
|
|
cauth.save()
|
|
# Assert that instructor email is enabled for this course
|
|
self.assertTrue(CourseAuthorization.instructor_email_enabled(self.course.id))
|
|
# Assert that the URL for the email view is not in the response
|
|
# if this course isn't authorized
|
|
response = self.client.get(self.url)
|
|
self.assertTrue(self.email_modal_link in response.content)
|
|
|
|
|
|
@unittest.skipUnless(settings.ROOT_URLCONF == 'lms.urls', 'Test only valid in lms')
|
|
class TestStudentDashboardEmailViewXMLBacked(ModuleStoreTestCase):
|
|
"""
|
|
Check for email view on student dashboard, with XML backed course.
|
|
"""
|
|
MODULESTORE = TEST_DATA_MIXED_TOY_MODULESTORE
|
|
|
|
def setUp(self):
|
|
self.course_name = 'edX/toy/2012_Fall'
|
|
|
|
# Create student account
|
|
student = UserFactory.create()
|
|
CourseEnrollmentFactory.create(
|
|
user=student,
|
|
course_id=SlashSeparatedCourseKey.from_deprecated_string(self.course_name)
|
|
)
|
|
self.client.login(username=student.username, password="test")
|
|
|
|
self.url = reverse('dashboard')
|
|
|
|
# URL for email settings modal
|
|
self.email_modal_link = (
|
|
'<a href="#email-settings-modal" class="email-settings" rel="leanModal" '
|
|
'data-course-id="{org}/{num}/{name}" data-course-number="{num}" '
|
|
'data-optout="False">Email Settings</a>'
|
|
).format(
|
|
org='edX',
|
|
num='toy',
|
|
name='2012_Fall',
|
|
)
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': True, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_true_xml_store(self):
|
|
# The flag is enabled, and since REQUIRE_COURSE_EMAIL_AUTH is False, all courses should
|
|
# be authorized to use email. But the course is not Mongo-backed (should not work)
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_modal_link in response.content)
|
|
|
|
@patch.dict(settings.FEATURES, {'ENABLE_INSTRUCTOR_EMAIL': False, 'REQUIRE_COURSE_EMAIL_AUTH': False})
|
|
def test_email_flag_false_xml_store(self):
|
|
# Email disabled, shouldn't see link.
|
|
response = self.client.get(self.url)
|
|
self.assertFalse(self.email_modal_link in response.content)
|