787366fe02
According to someone from Datadog, this was generating tags like "knowledgeable_ people_who_put_this_course_together._this_is_harvard._you_can_t_tell_us_there_s_ a_shortage_of_editorial_talent." They say that they can handle tens or hundreds of unique tags but not thousands. Given that we have a unique URL for each thread, we can't even use that as a tag. Thus, all tags are removed for now until we can determine whether there is a useful set of tags with small enough cardinality. In light of this, I did not investigate why the long tag mentioned above was being generated.
79 lines
2.3 KiB
Python
79 lines
2.3 KiB
Python
from dogapi import dog_stats_api
|
|
import json
|
|
import logging
|
|
import requests
|
|
import settings
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
|
|
def strip_none(dic):
|
|
return dict([(k, v) for k, v in dic.iteritems() if v is not None])
|
|
|
|
|
|
def strip_blank(dic):
|
|
def _is_blank(v):
|
|
return isinstance(v, str) and len(v.strip()) == 0
|
|
return dict([(k, v) for k, v in dic.iteritems() if not _is_blank(v)])
|
|
|
|
|
|
def extract(dic, keys):
|
|
if isinstance(keys, str):
|
|
return strip_none({keys: dic.get(keys)})
|
|
else:
|
|
return strip_none({k: dic.get(k) for k in keys})
|
|
|
|
|
|
def merge_dict(dic1, dic2):
|
|
return dict(dic1.items() + dic2.items())
|
|
|
|
|
|
def perform_request(method, url, data_or_params=None, *args, **kwargs):
|
|
if data_or_params is None:
|
|
data_or_params = {}
|
|
data_or_params['api_key'] = settings.API_KEY
|
|
try:
|
|
with dog_stats_api.timer('comment_client.request.time'):
|
|
if method in ['post', 'put', 'patch']:
|
|
response = requests.request(method, url, data=data_or_params, timeout=5)
|
|
else:
|
|
response = requests.request(method, url, params=data_or_params, timeout=5)
|
|
except Exception as err:
|
|
# remove API key if it is in the params
|
|
if 'api_key' in data_or_params:
|
|
log.info('Deleting API key from params')
|
|
del data_or_params['api_key']
|
|
log.exception("Trying to call {method} on {url} with params {params}".format(
|
|
method=method, url=url, params=data_or_params))
|
|
# Reraise with a single exception type
|
|
raise CommentClientError(str(err))
|
|
|
|
if 200 < response.status_code < 500:
|
|
raise CommentClientError(response.text)
|
|
# Heroku returns a 503 when an application is in maintenance mode
|
|
elif response.status_code == 503:
|
|
raise CommentClientMaintenanceError(response.text)
|
|
elif response.status_code == 500:
|
|
raise CommentClientUnknownError(response.text)
|
|
else:
|
|
if kwargs.get("raw", False):
|
|
return response.text
|
|
else:
|
|
return json.loads(response.text)
|
|
|
|
|
|
class CommentClientError(Exception):
|
|
def __init__(self, msg):
|
|
self.message = msg
|
|
|
|
def __str__(self):
|
|
return repr(self.message)
|
|
|
|
|
|
class CommentClientMaintenanceError(CommentClientError):
|
|
pass
|
|
|
|
|
|
class CommentClientUnknownError(CommentClientError):
|
|
pass
|