8d825fc977
Because of the way async tasks pass arguments, we were passing in a string of a dictionary that contained the id verification status but checking it against a dictionary in the task's function, which was causing errors for generating certificates for passing users whose id verification status changes to approved after they are passing.
47 lines
2.2 KiB
Python
47 lines
2.2 KiB
Python
from celery import task
|
|
from logging import getLogger
|
|
|
|
from celery_utils.persist_on_failure import LoggedPersistOnFailureTask
|
|
from django.contrib.auth.models import User
|
|
from lms.djangoapps.verify_student.services import IDVerificationService
|
|
from opaque_keys.edx.keys import CourseKey
|
|
|
|
from .api import generate_user_certificates
|
|
|
|
logger = getLogger(__name__)
|
|
|
|
|
|
@task(base=LoggedPersistOnFailureTask, bind=True, default_retry_delay=30, max_retries=2)
|
|
def generate_certificate(self, **kwargs):
|
|
"""
|
|
Generates a certificate for a single user.
|
|
|
|
kwargs:
|
|
- student: The student for whom to generate a certificate.
|
|
- course_key: The course key for the course that the student is
|
|
receiving a certificate in.
|
|
- expected_verification_status: The expected verification status
|
|
for the user. When the status has changed, we double check
|
|
that the actual verification status is as expected before
|
|
generating a certificate, in the off chance that the database
|
|
has not yet updated with the user's new verification status.
|
|
"""
|
|
original_kwargs = kwargs.copy()
|
|
student = User.objects.get(id=kwargs.pop('student'))
|
|
course_key = CourseKey.from_string(kwargs.pop('course_key'))
|
|
expected_verification_status = kwargs.pop('expected_verification_status', None)
|
|
if expected_verification_status:
|
|
actual_verification_status = IDVerificationService.user_status(student)
|
|
actual_verification_status = actual_verification_status['status']
|
|
if expected_verification_status != actual_verification_status:
|
|
logger.warn('Expected verification status {expected} '
|
|
'differs from actual verification status {actual} '
|
|
'for user {user} in course {course}'.format(
|
|
expected=expected_verification_status,
|
|
actual=actual_verification_status,
|
|
user=student.id,
|
|
course=course_key
|
|
))
|
|
raise self.retry(kwargs=original_kwargs)
|
|
generate_user_certificates(student=student, course_key=course_key, **kwargs)
|