88610cb8fb
This applies to global staff (is_staff=True), not course staff. Previously, staff were granted the Moderator role but not the Student role upon enrolling in a course. If the Moderator role were later revoked, then the user would have no role and be unable to post in the forums, which is confusing for the user. edX staff indicated they would prefer to not automatically receive the Moderator role, so the Student role is granted instead. Note that staff will still be able to grant themselves Moderator privileges through the instructor dashboard if they wish. JIRA: FOR-338
55 lines
2.1 KiB
Python
55 lines
2.1 KiB
Python
from django.test import TestCase
|
|
|
|
from django_comment_common.models import Role
|
|
from student.models import CourseEnrollment, User
|
|
|
|
class RoleAssignmentTest(TestCase):
|
|
"""
|
|
Basic checks to make sure our Roles get assigned and unassigned as students
|
|
are enrolled and unenrolled from a course.
|
|
"""
|
|
|
|
def setUp(self):
|
|
# Check a staff account because those used to get the Moderator role
|
|
self.staff_user = User.objects.create_user(
|
|
"patty",
|
|
"patty@fake.edx.org",
|
|
)
|
|
self.staff_user.is_staff = True
|
|
|
|
self.student_user = User.objects.create_user(
|
|
"hacky",
|
|
"hacky@fake.edx.org"
|
|
)
|
|
self.course_id = "edX/Fake101/2012"
|
|
CourseEnrollment.enroll(self.staff_user, self.course_id)
|
|
CourseEnrollment.enroll(self.student_user, self.course_id)
|
|
|
|
def test_enrollment_auto_role_creation(self):
|
|
student_role = Role.objects.get(
|
|
course_id=self.course_id,
|
|
name="Student"
|
|
)
|
|
|
|
self.assertEqual([student_role], list(self.staff_user.roles.all()))
|
|
self.assertEqual([student_role], list(self.student_user.roles.all()))
|
|
|
|
# The following was written on the assumption that unenrolling from a course
|
|
# should remove all forum Roles for that student for that course. This is
|
|
# not necessarily the case -- please see comments at the top of
|
|
# django_comment_client.models.assign_default_role(). Leaving it for the
|
|
# forums team to sort out.
|
|
#
|
|
# def test_unenrollment_auto_role_removal(self):
|
|
# another_student = User.objects.create_user("sol", "sol@fake.edx.org")
|
|
# CourseEnrollment.enroll(another_student, self.course_id)
|
|
#
|
|
# CourseEnrollment.unenroll(self.student_user, self.course_id)
|
|
# # Make sure we didn't delete the actual Role
|
|
# student_role = Role.objects.get(
|
|
# course_id=self.course_id,
|
|
# name="Student"
|
|
# )
|
|
# self.assertNotIn(student_role, self.student_user.roles.all())
|
|
# self.assertIn(student_role, another_student.roles.all())
|