11d260910f
This commit adds validation for course advanced settings. Currently when course
administrators make invalid changes in the Settings/Advanced Settings tab,
they're not notified through a new modal window of the list of invalid settings
changes.
* Extending CourseMetadata
- Previously, we only had update_from_json method in CourseMetadata.py,
and it was only validating one field every POST request.
- Now we have validate_and_update_from_json method that encapsulates the
functionality of update_from_json into a validation call
- To avoid discrepancy of validation standards between modules, validation
uses the from_json method implemented to each field in xblock.
* Different Response in advanced settings ajax requests
- After receiving a POST ajax request, course.py calls
validate_and_update_from_json, and sends a json object of either:
1) valid course metadata model
2) error objects
* Error Messages shown in validation-error-modal
- error objects passed through ajax are shown in a separate modal.
126 lines
4.5 KiB
Python
126 lines
4.5 KiB
Python
"""
|
|
Test for JsonResponse and JsonResponseBadRequest util classes.
|
|
"""
|
|
|
|
from django.http import HttpResponse, HttpResponseBadRequest
|
|
from util.json_request import JsonResponse, JsonResponseBadRequest
|
|
import json
|
|
import unittest
|
|
import mock
|
|
|
|
|
|
class JsonResponseTestCase(unittest.TestCase):
|
|
"""
|
|
A set of tests to make sure that JsonResponse Class works correctly.
|
|
"""
|
|
def test_empty(self):
|
|
resp = JsonResponse()
|
|
self.assertIsInstance(resp, HttpResponse)
|
|
self.assertEqual(resp.content, "")
|
|
self.assertEqual(resp.status_code, 204)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_empty_string(self):
|
|
resp = JsonResponse("")
|
|
self.assertIsInstance(resp, HttpResponse)
|
|
self.assertEqual(resp.content, "")
|
|
self.assertEqual(resp.status_code, 204)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_string(self):
|
|
resp = JsonResponse("foo")
|
|
self.assertEqual(resp.content, '"foo"')
|
|
self.assertEqual(resp.status_code, 200)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_dict(self):
|
|
obj = {"foo": "bar"}
|
|
resp = JsonResponse(obj)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 200)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_set_status_kwarg(self):
|
|
obj = {"error": "resource not found"}
|
|
resp = JsonResponse(obj, status=404)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 404)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_set_status_arg(self):
|
|
obj = {"error": "resource not found"}
|
|
resp = JsonResponse(obj, 404)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 404)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_encoder(self):
|
|
obj = [1, 2, 3]
|
|
encoder = object()
|
|
with mock.patch.object(json, "dumps", return_value="[1,2,3]") as dumps:
|
|
resp = JsonResponse(obj, encoder=encoder)
|
|
self.assertEqual(resp.status_code, 200)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
kwargs = dumps.call_args[1]
|
|
self.assertIs(kwargs["cls"], encoder)
|
|
|
|
|
|
class JsonResponseBadRequestTestCase(unittest.TestCase):
|
|
"""
|
|
A set of tests to make sure that the JsonResponseBadRequest wrapper class
|
|
works as intended.
|
|
"""
|
|
|
|
def test_empty(self):
|
|
resp = JsonResponseBadRequest()
|
|
self.assertIsInstance(resp, HttpResponseBadRequest)
|
|
self.assertEqual(resp.content, "")
|
|
self.assertEqual(resp.status_code, 400)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_empty_string(self):
|
|
resp = JsonResponseBadRequest("")
|
|
self.assertIsInstance(resp, HttpResponse)
|
|
self.assertEqual(resp.content, "")
|
|
self.assertEqual(resp.status_code, 400)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_dict(self):
|
|
obj = {"foo": "bar"}
|
|
resp = JsonResponseBadRequest(obj)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 400)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_set_status_kwarg(self):
|
|
obj = {"error": "resource not found"}
|
|
resp = JsonResponseBadRequest(obj, status=404)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 404)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_set_status_arg(self):
|
|
obj = {"error": "resource not found"}
|
|
resp = JsonResponseBadRequest(obj, 404)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
self.assertEqual(resp.status_code, 404)
|
|
self.assertEqual(resp["content-type"], "application/json")
|
|
|
|
def test_encoder(self):
|
|
obj = [1, 2, 3]
|
|
encoder = object()
|
|
with mock.patch.object(json, "dumps", return_value="[1,2,3]") as dumps:
|
|
resp = JsonResponseBadRequest(obj, encoder=encoder)
|
|
self.assertEqual(resp.status_code, 400)
|
|
compare = json.loads(resp.content)
|
|
self.assertEqual(obj, compare)
|
|
kwargs = dumps.call_args[1]
|
|
self.assertIs(kwargs["cls"], encoder)
|