83f6e560b7
This will ensure that errors raised by these tasks will alert the right team. `send_course_enrollment_email` is the one I set out to fix, but I discovered a few others. I located tasks that were missing decorators by running the following search and visually inspecting the results, although semgrep might be able to do better: ``` ack '^@.*task|^@set_code_owner_attribute' cms lms common openedx xmodule --ignore-dir=tests --python ``` Also, add more detailed explanation of why a couple of tasks can't use the decorator. This should only be an issue on tasks inheriting from UserTaskMixin, which in practice is just CourseExportTask and CourseImportTask (and the apparently unused EnrollmentReadTask and EnrollmentWriteTask), via UserTask.
49 lines
1.7 KiB
Python
49 lines
1.7 KiB
Python
"""
|
|
Asynchronous tasks for the CCX app.
|
|
"""
|
|
|
|
|
|
import logging
|
|
|
|
from ccx_keys.locator import CCXLocator
|
|
from django.dispatch import receiver
|
|
from edx_django_utils.monitoring import set_code_owner_attribute
|
|
from opaque_keys import InvalidKeyError
|
|
from opaque_keys.edx.locator import CourseLocator
|
|
|
|
from lms import CELERY_APP
|
|
from lms.djangoapps.ccx.models import CustomCourseForEdX
|
|
from xmodule.modulestore.django import SignalHandler # lint-amnesty, pylint: disable=wrong-import-order
|
|
|
|
log = logging.getLogger("edx.ccx")
|
|
|
|
|
|
@receiver(SignalHandler.course_published)
|
|
def course_published_handler(sender, course_key, **kwargs): # pylint: disable=unused-argument
|
|
"""
|
|
Consume signals that indicate course published. If course already a CCX, do nothing.
|
|
"""
|
|
if not isinstance(course_key, CCXLocator):
|
|
send_ccx_course_published.delay(str(course_key))
|
|
|
|
|
|
@CELERY_APP.task
|
|
@set_code_owner_attribute
|
|
def send_ccx_course_published(course_key):
|
|
"""
|
|
Find all CCX derived from this course, and send course published event for them.
|
|
"""
|
|
course_key = CourseLocator.from_string(course_key)
|
|
for ccx in CustomCourseForEdX.objects.filter(course_id=course_key):
|
|
try:
|
|
ccx_key = CCXLocator.from_course_locator(course_key, str(ccx.id))
|
|
except InvalidKeyError:
|
|
log.info('Attempt to publish course with deprecated id. Course: %s. CCX: %s', course_key, ccx.id)
|
|
continue
|
|
responses = SignalHandler.course_published.send(
|
|
sender=ccx,
|
|
course_key=ccx_key
|
|
)
|
|
for rec, response in responses:
|
|
log.info('Signal fired when course is published. Receiver: %s. Response: %s', rec, response)
|