Files
edx-platform/lms/djangoapps/branding/tests/test_views.py
Feanil Patel a0ab48921f fix: Handle a case that could cause infinite redirects.
If ENABLE_MKTG_SITE is True, MKTG_URLS['ROOT'] must be set.  However if
it is set to the same value as the LMS_ROOT_URL (which points to this
view), you can end up in an infinite redirect loop.  If the two URLs do
match, don't redirect, just fall through to the content that this page
would have responded with instead.
2025-10-21 12:11:57 -04:00

368 lines
13 KiB
Python

"""Tests of Branding API views. """
import json
from unittest import mock
import ddt
import six
from django.conf import settings
from django.contrib.auth.models import User # lint-amnesty, pylint: disable=imported-auth-user
from django.test import override_settings, TestCase
from django.urls import reverse
from common.djangoapps.student.tests.factories import UserFactory
from lms.djangoapps.branding.models import BrandingApiConfig
from openedx.core.djangoapps.dark_lang.models import DarkLangConfig
from openedx.core.djangoapps.lang_pref.api import released_languages
from openedx.core.djangoapps.site_configuration.tests.mixins import SiteMixin
from openedx.core.djangoapps.theming.tests.test_util import with_comprehensive_theme_context
from openedx.core.djangolib.testing.utils import CacheIsolationTestCase
@ddt.ddt
class TestFooter(CacheIsolationTestCase):
"""Test API end-point for retrieving the footer. """
@ddt.data("*/*", "text/html", "application/json")
def test_feature_flag(self, accepts):
self._set_feature_flag(False)
resp = self._get_footer(accepts=accepts)
assert resp.status_code == 404
@ddt.data(
# Open source version
(None, "application/json", "application/json; charset=utf-8", "Open edX"),
(None, "text/html", "text/html; charset=utf-8", "lms-footer.css"),
(None, "text/html", "text/html; charset=utf-8", "Open edX"),
)
@ddt.unpack
def test_footer_content_types(self, theme, accepts, content_type, content):
self._set_feature_flag(True)
with with_comprehensive_theme_context(theme):
resp = self._get_footer(accepts=accepts)
assert resp['Content-Type'] == content_type
self.assertContains(resp, content)
@mock.patch.dict(settings.FEATURES, {'ENABLE_FOOTER_MOBILE_APP_LINKS': True})
def test_footer_json(self):
self._set_feature_flag(True)
with with_comprehensive_theme_context(None):
resp = self._get_footer()
assert resp.status_code == 200
json_data = json.loads(resp.content.decode('utf-8'))
assert isinstance(json_data, dict)
# Logo
assert 'logo_image' in json_data
# Links
assert 'navigation_links' in json_data
for link in json_data["navigation_links"]:
assert 'name' in link
assert 'title' in link
assert 'url' in link
# Social links
assert 'social_links' in json_data
for link in json_data["social_links"]:
assert 'name' in link
assert 'title' in link
assert 'url' in link
assert 'icon-class' in link
assert 'action' in link
# Mobile links
assert 'mobile_links' in json_data
for link in json_data["mobile_links"]:
assert 'name' in link
assert 'title' in link
assert 'url' in link
assert 'image' in link
# Legal links
assert 'legal_links' in json_data
for link in json_data["legal_links"]:
assert 'name' in link
assert 'title' in link
assert 'url' in link
# OpenEdX
assert 'openedx_link' in json_data
assert 'url' in json_data['openedx_link']
assert 'title' in json_data['openedx_link']
assert 'image' in json_data['openedx_link']
# Copyright
assert 'copyright' in json_data
def test_absolute_urls_with_cdn(self):
self._set_feature_flag(True)
# Ordinarily, we'd use `override_settings()` to override STATIC_URL,
# which is what the staticfiles storage backend is using to construct the URL.
# Unfortunately, other parts of the system are caching this value on module
# load, which can cause other tests to fail. To ensure that this change
# doesn't affect other tests, we patch the `url()` method directly instead.
cdn_url = "http://cdn.example.com/static/image.png"
with mock.patch('lms.djangoapps.branding.api.staticfiles_storage.url', return_value=cdn_url):
resp = self._get_footer()
assert resp.status_code == 200
json_data = json.loads(resp.content.decode('utf-8'))
assert json_data['logo_image'] == cdn_url
for link in json_data["mobile_links"]:
assert link['url'] == cdn_url
@ddt.data(
("en", "registered trademarks"),
("eo", "régïstéréd trädémärks"), # Dummy language string
("unknown", "registered trademarks"), # default to English
)
@ddt.unpack
def test_language_override_translation(self, language, expected_copyright):
self._set_feature_flag(True)
# Load the footer with the specified language
resp = self._get_footer(params={'language': language})
assert resp.status_code == 200
json_data = json.loads(resp.content.decode('utf-8'))
# Verify that the translation occurred
assert expected_copyright in json_data['copyright']
@ddt.data(
# OpenEdX
(None, "en", "lms-footer.css"),
(None, "ar", "lms-footer-rtl.css"),
)
@ddt.unpack
def test_language_rtl(self, theme, language, static_path):
self._set_feature_flag(True)
with with_comprehensive_theme_context(theme):
resp = self._get_footer(accepts="text/html", params={'language': language})
self.assertContains(resp, static_path)
@ddt.data(
# OpenEdX
(None, True),
(None, False),
)
@ddt.unpack
def test_show_openedx_logo(self, theme, show_logo):
self._set_feature_flag(True)
with with_comprehensive_theme_context(theme):
params = {'show-openedx-logo': 1} if show_logo else {}
resp = self._get_footer(accepts="text/html", params=params)
if show_logo:
self.assertContains(resp, 'alt="Powered by Open edX"')
else:
self.assertNotContains(resp, 'alt="Powered by Open edX"')
@ddt.data(
# OpenEdX
(None, False),
(None, True),
)
@ddt.unpack
def test_include_dependencies(self, theme, include_dependencies):
self._set_feature_flag(True)
with with_comprehensive_theme_context(theme):
params = {'include-dependencies': 1} if include_dependencies else {}
resp = self._get_footer(accepts="text/html", params=params)
if include_dependencies:
self.assertContains(resp, "vendor",)
else:
self.assertNotContains(resp, "vendor")
@ddt.data(
# OpenEdX
(None, None, '1'),
(None, 'eo', '1'),
(None, None, ''),
)
@ddt.unpack
def test_include_language_selector(self, theme, language, include_language_selector):
self._set_feature_flag(True)
DarkLangConfig(released_languages='en,eo,es-419,fr', enabled=True, changed_by=User().save()).save()
with with_comprehensive_theme_context(theme):
params = {
key: val for key, val in [
('language', language), ('include-language-selector', include_language_selector)
] if val
}
resp = self._get_footer(accepts="text/html", params=params)
assert resp.status_code == 200
if include_language_selector:
selected_language = language if language else 'en'
self._verify_language_selector(resp, selected_language)
else:
self.assertNotContains(resp, 'footer-language-selector')
def test_no_supported_accept_type(self):
self._set_feature_flag(True)
resp = self._get_footer(accepts="application/x-shockwave-flash")
assert resp.status_code == 406
def _set_feature_flag(self, enabled):
"""Enable or disable the feature flag for the branding API end-points. """
config = BrandingApiConfig(enabled=enabled)
config.save()
def _get_footer(self, accepts="application/json", params=None):
"""Retrieve the footer. """
url = reverse("branding_footer")
if params is not None:
url = "{url}?{params}".format(
url=url,
params=six.moves.urllib.parse.urlencode(params)
)
return self.client.get(url, HTTP_ACCEPT=accepts)
def _verify_language_selector(self, response, selected_language):
""" Verify that the language selector is present and correctly configured."""
# Verify the selector is included
content = response.content.decode(response.charset)
assert 'footer-language-selector' in content
# Verify the correct language is selected
assert f'<option value="{selected_language}" selected="selected">' in content
# Verify the language choices
for language in released_languages():
if language.code == selected_language:
continue
assert f'<option value="{language.code}">' in content
@ddt.ddt
class TestIndex(SiteMixin, TestCase):
""" Test the index view """
def setUp(self):
""" Set up a user """
super().setUp()
patcher = mock.patch("common.djangoapps.student.models.course_enrollment.tracker")
self.mock_tracker = patcher.start()
self.user = UserFactory.create()
self.user.set_password("password")
self.user.save()
def test_index_does_not_redirect_without_site_override(self):
""" Test index view does not redirect if MKTG_URLS['ROOT'] is not set """
response = self.client.get(reverse("root"))
assert response.status_code == 200
@override_settings(ENABLE_MKTG_SITE=True)
@override_settings(MKTG_URLS={'ROOT': 'https://foo.bar/'})
@override_settings(LMS_ROOT_URL='https://foo.bar/')
def test_index_wont_redirect_to_marketing_root_if_it_matches_lms_root(self):
response = self.client.get(reverse("root"))
assert response.status_code == 200
@override_settings(ENABLE_MKTG_SITE=True)
@override_settings(MKTG_URLS={'ROOT': 'https://home.foo.bar/'})
@override_settings(LMS_ROOT_URL='https://foo.bar/')
def test_index_will_redirect_to_new_root_if_mktg_site_is_enabled(self):
response = self.client.get(reverse("root"))
assert response.status_code == 302
def test_index_redirects_to_marketing_site_with_site_override(self):
""" Test index view redirects if MKTG_URLS['ROOT'] is set in SiteConfiguration """
self.use_site(self.site_other)
response = self.client.get(reverse("root"))
self.assertRedirects(
response,
self.site_configuration_other.site_values["MKTG_URLS"]["ROOT"],
fetch_redirect_response=False
)
def test_header_logo_links_to_marketing_site_with_site_override(self):
"""
Test marketing site root link is included on dashboard page
if MKTG_URLS['ROOT'] is set in SiteConfiguration
"""
self.use_site(self.site_other)
self.client.login(username=self.user.username, password="password")
response = self.client.get(reverse("dashboard"))
assert self.site_configuration_other.site_values['MKTG_URLS']['ROOT'] in response.content.decode('utf-8')
@ddt.data(
(True, True),
(True, False),
(False, False),
(False, False),
)
@ddt.unpack
def test_index_redirects_to_mfe(self, catalog_mfe_enabled, expected_redirect):
"""Test that index view redirects to MFE when both flags are enabled."""
new_settings = {
"ENABLE_CATALOG_MICROFRONTEND": catalog_mfe_enabled,
"CATALOG_MICROFRONTEND_URL": "http://example.com/catalog",
}
with override_settings(**new_settings):
response = self.client.get(reverse("root"))
if expected_redirect:
expected_url = f'{settings.CATALOG_MICROFRONTEND_URL}/'
self.assertRedirects(
response,
expected_url,
status_code=301,
fetch_redirect_response=False
)
else:
assert response.status_code in [200, 301, 302]
@ddt.ddt
class TestCourses(SiteMixin, TestCase):
"""Test the courses view"""
def setUp(self):
super().setUp()
self.courses_url = reverse("courses")
@ddt.data(
(True, True),
(True, False),
(False, False),
(False, False),
)
@ddt.unpack
def test_courses_redirect_to_mfe(self, catalog_mfe_enabled, expected_redirect):
"""Test that courses view redirects to MFE when both flags are enabled"""
new_settings = {
"ENABLE_CATALOG_MICROFRONTEND": catalog_mfe_enabled,
"CATALOG_MICROFRONTEND_URL": "http://example.com/catalog",
}
with override_settings(**new_settings):
response = self.client.get(self.courses_url)
if expected_redirect:
expected_url = f'{settings.CATALOG_MICROFRONTEND_URL}/courses'
self.assertRedirects(
response,
expected_url,
status_code=301,
fetch_redirect_response=False
)
else:
assert response.status_code in [200, 301, 302]