edx-platform/common/djangoapps/student/tests/test_authz.py

"""
Tests authz.py
"""

from unittest import mock

import pytest
from ccx_keys.locator import CCXLocator
from django.contrib.auth.models import AnonymousUser
from django.core.exceptions import PermissionDenied
from django.test import TestCase, override_settings
from opaque_keys.edx.locator import CourseLocator

from common.djangoapps.student.models.user import CourseAccessRole
from common.djangoapps.student.auth import (
    add_users,
    has_studio_read_access,
    has_studio_write_access,
    remove_users,
    update_org_role,
    user_has_role
)
from common.djangoapps.student.roles import (
    CourseCreatorRole,
    CourseInstructorRole,
    CourseLimitedStaffRole,
    CourseStaffRole,
    OrgContentCreatorRole
)
from common.djangoapps.student.tests.factories import AdminFactory, UserFactory


class CreatorGroupTest(TestCase):
    """
    Tests for the course creator group.
    """

    def setUp(self):
        """ Test case setup """
        super().setUp()
        self.user = UserFactory.create(
            username='testuser', email='test+courses@edx.org', password='foo',
        )
        self.admin = UserFactory.create(
            username='Mark', email='admin+courses@edx.org', password='foo',
        )
        self.admin.is_staff = True

    def test_creator_group_not_enabled(self):
        """
        Tests that CourseCreatorRole().has_user always returns True if ENABLE_CREATOR_GROUP
        and DISABLE_COURSE_CREATION are both not turned on.
        """
        assert user_has_role(self.user, CourseCreatorRole())

    def test_creator_group_enabled_but_empty(self):
        """ Tests creator group feature on, but group empty. """
        with mock.patch.dict('django.conf.settings.FEATURES', {"ENABLE_CREATOR_GROUP": True}):
            assert not user_has_role(self.user, CourseCreatorRole())

            # Make user staff. This will cause CourseCreatorRole().has_user to return True.
            self.user.is_staff = True
            assert user_has_role(self.user, CourseCreatorRole())

    def test_creator_group_enabled_nonempty(self):
        """ Tests creator group feature on, user added. """
        with mock.patch.dict('django.conf.settings.FEATURES', {"ENABLE_CREATOR_GROUP": True}):
            add_users(self.admin, CourseCreatorRole(), self.user)
            assert user_has_role(self.user, CourseCreatorRole())

            # check that a user who has not been added to the group still returns false
            user_not_added = UserFactory.create(username='testuser2', email='test+courses2@edx.org', password='foo2')
            assert not user_has_role(user_not_added, CourseCreatorRole())

            # remove first user from the group and verify that CourseCreatorRole().has_user now returns false
            remove_users(self.admin, CourseCreatorRole(), self.user)
            assert not user_has_role(self.user, CourseCreatorRole())

    def test_course_creation_disabled(self):
        """ Tests that the COURSE_CREATION_DISABLED flag overrides course creator group settings. """
        with mock.patch.dict('django.conf.settings.FEATURES',
                             {'DISABLE_COURSE_CREATION': True, "ENABLE_CREATOR_GROUP": True}):
            # Add user to creator group.
            add_users(self.admin, CourseCreatorRole(), self.user)

            # DISABLE_COURSE_CREATION overrides (user is not marked as staff).
            assert not user_has_role(self.user, CourseCreatorRole())

            # Mark as staff. Now CourseCreatorRole().has_user returns true.
            self.user.is_staff = True
            assert user_has_role(self.user, CourseCreatorRole())

            # Remove user from creator group. CourseCreatorRole().has_user still returns true because is_staff=True
            remove_users(self.admin, CourseCreatorRole(), self.user)
            assert user_has_role(self.user, CourseCreatorRole())

    def test_add_user_not_authenticated(self):
        """
        Tests that adding to creator group fails if user is not authenticated
        """
        with mock.patch.dict(
            'django.conf.settings.FEATURES',
            {'DISABLE_COURSE_CREATION': False, "ENABLE_CREATOR_GROUP": True}
        ):
            anonymous_user = AnonymousUser()
            role = CourseCreatorRole()
            add_users(self.admin, role, anonymous_user)
            assert not user_has_role(anonymous_user, role)

    def test_add_user_not_active(self):
        """
        Tests that adding to creator group fails if user is not active
        """
        with mock.patch.dict(
            'django.conf.settings.FEATURES',
            {'DISABLE_COURSE_CREATION': False, "ENABLE_CREATOR_GROUP": True}
        ):
            self.user.is_active = False
            add_users(self.admin, CourseCreatorRole(), self.user)
            assert not user_has_role(self.user, CourseCreatorRole())

    def test_add_user_to_group_requires_staff_access(self):
        with pytest.raises(PermissionDenied):
            self.admin.is_staff = False
            add_users(self.admin, CourseCreatorRole(), self.user)

        with pytest.raises(PermissionDenied):
            add_users(self.user, CourseCreatorRole(), self.user)

    def test_add_user_to_group_requires_active(self):
        with pytest.raises(PermissionDenied):
            self.admin.is_active = False
            add_users(self.admin, CourseCreatorRole(), self.user)

    def test_add_user_to_group_requires_authenticated(self):
        with pytest.raises(PermissionDenied):
            with mock.patch(
                'django.contrib.auth.models.User.is_authenticated',
                new_callable=mock.PropertyMock
            ) as mock_is_auth:
                mock_is_auth.return_value = False
                add_users(self.admin, CourseCreatorRole(), self.user)

    def test_remove_user_from_group_requires_staff_access(self):
        with pytest.raises(PermissionDenied):
            self.admin.is_staff = False
            remove_users(self.admin, CourseCreatorRole(), self.user)

    def test_remove_user_from_group_requires_active(self):
        with pytest.raises(PermissionDenied):
            self.admin.is_active = False
            remove_users(self.admin, CourseCreatorRole(), self.user)

    def test_remove_user_from_group_requires_authenticated(self):
        with pytest.raises(PermissionDenied):
            with mock.patch(
                'django.contrib.auth.models.User.is_authenticated',
                new_callable=mock.PropertyMock
            ) as mock_is_auth:
                mock_is_auth.return_value = False
                remove_users(self.admin, CourseCreatorRole(), self.user)


class CCXCourseGroupTest(TestCase):
    """
    Test that access to a CCX course in Studio is disallowed
    """
    def setUp(self):
        """
        Set up test variables
        """
        super().setUp()
        self.global_admin = AdminFactory()
        self.staff = UserFactory.create(username='teststaff', email='teststaff+courses@edx.org', password='foo')
        self.ccx_course_key = CCXLocator.from_string('ccx-v1:edX+DemoX+Demo_Course+ccx@1')
        add_users(self.global_admin, CourseStaffRole(self.ccx_course_key), self.staff)

    def test_no_global_admin_write_access(self):
        """
        Test that global admins have no write access
        """
        assert not has_studio_write_access(self.global_admin, self.ccx_course_key)

    def test_no_staff_write_access(self):
        """
        Test that course staff have no write access
        """
        assert not has_studio_write_access(self.staff, self.ccx_course_key)

    def test_no_global_admin_read_access(self):
        """
        Test that global admins have no read access
        """
        assert not has_studio_read_access(self.global_admin, self.ccx_course_key)

    def test_no_staff_read_access(self):
        """
        Test that course staff have no read access
        """
        assert not has_studio_read_access(self.staff, self.ccx_course_key)


class CourseGroupTest(TestCase):
    """
    Tests for instructor, staff and limited staff groups for a particular course.
    """

    def setUp(self):
        """ Test case setup """
        super().setUp()
        self.global_admin = AdminFactory()
        self.creator = UserFactory.create(
            username='testcreator', email='testcreator+courses@edx.org', password='foo',
        )
        self.staff = UserFactory.create(
            username='teststaff', email='teststaff+courses@edx.org', password='foo',
        )
        self.limited_staff = UserFactory.create(
            username='testlimitedstaff', email='testlimitedstaff+courses@edx.org', password='foo',
        )
        self.course_key = CourseLocator('mitX', '101', 'test')

    def test_add_user_to_course_group(self):
        """
        Tests adding user to course group (happy path).
        """
        # Create groups for a new course (and assign instructor role to the creator).
        assert not user_has_role(self.creator, CourseInstructorRole(self.course_key))
        add_users(self.global_admin, CourseInstructorRole(self.course_key), self.creator)
        add_users(self.global_admin, CourseStaffRole(self.course_key), self.creator)
        assert user_has_role(self.creator, CourseInstructorRole(self.course_key))

        # Add another user to the staff role.
        assert not user_has_role(self.staff, CourseStaffRole(self.course_key))
        add_users(self.creator, CourseStaffRole(self.course_key), self.staff)
        assert user_has_role(self.staff, CourseStaffRole(self.course_key))

        # Add another user to the limited staff role.
        assert not user_has_role(self.limited_staff, CourseLimitedStaffRole(self.course_key))
        add_users(self.creator, CourseLimitedStaffRole(self.course_key), self.limited_staff)
        assert user_has_role(self.limited_staff, CourseLimitedStaffRole(self.course_key))

        # Verify that limited staff inherits from staff.
        assert user_has_role(self.limited_staff, CourseStaffRole(self.course_key))

    def test_add_user_to_course_group_permission_denied(self):
        """
        Verifies PermissionDenied if caller of add_user_to_course_group is not instructor role.
        """
        add_users(self.global_admin, CourseInstructorRole(self.course_key), self.creator)
        add_users(self.global_admin, CourseStaffRole(self.course_key), self.creator)
        with pytest.raises(PermissionDenied):
            add_users(self.staff, CourseStaffRole(self.course_key), self.staff)

    def test_remove_user_from_course_group(self):
        """
        Tests removing user from course group (happy path).
        """
        add_users(self.global_admin, CourseInstructorRole(self.course_key), self.creator)
        add_users(self.global_admin, CourseStaffRole(self.course_key), self.creator)

        add_users(self.creator, CourseStaffRole(self.course_key), self.staff)
        assert user_has_role(self.staff, CourseStaffRole(self.course_key))

        add_users(self.creator, CourseLimitedStaffRole(self.course_key), self.limited_staff)
        assert user_has_role(self.limited_staff, CourseLimitedStaffRole(self.course_key))

        remove_users(self.creator, CourseLimitedStaffRole(self.course_key), self.limited_staff)
        assert not user_has_role(self.limited_staff, CourseLimitedStaffRole(self.course_key))

        remove_users(self.creator, CourseStaffRole(self.course_key), self.staff)
        assert not user_has_role(self.staff, CourseStaffRole(self.course_key))

        remove_users(self.creator, CourseInstructorRole(self.course_key), self.creator)
        assert not user_has_role(self.creator, CourseInstructorRole(self.course_key))

    def test_remove_user_from_course_group_permission_denied(self):
        """
        Verifies PermissionDenied if caller of remove_user_from_course_group is not instructor role.
        """
        add_users(self.global_admin, CourseInstructorRole(self.course_key), self.creator)
        another_staff = UserFactory.create(
            username='another', email='teststaff+anothercourses@edx.org', password='foo',
        )
        add_users(self.global_admin, CourseStaffRole(self.course_key), self.creator, self.staff, another_staff)
        with pytest.raises(PermissionDenied):
            remove_users(self.staff, CourseStaffRole(self.course_key), another_staff)

    @override_settings(SERVICE_VARIANT='lms')
    def test_limited_staff_no_studio_read_access_lms(self):
        """
        Verifies that course limited staff have no read, but have write access when SERVICE_VARIANT is 'lms'.
        """
        add_users(self.global_admin, CourseLimitedStaffRole(self.course_key), self.limited_staff)

        assert not has_studio_read_access(self.limited_staff, self.course_key)
        assert has_studio_write_access(self.limited_staff, self.course_key)

    @override_settings(SERVICE_VARIANT='cms')
    def test_limited_staff_no_studio_access_cms(self):
        """
        Verifies that course limited staff have no read and no write access when SERVICE_VARIANT is not 'lms'.
        """
        add_users(self.global_admin, CourseLimitedStaffRole(self.course_key), self.limited_staff)

        assert not has_studio_read_access(self.limited_staff, self.course_key)
        assert not has_studio_write_access(self.limited_staff, self.course_key)

    @override_settings(SERVICE_VARIANT='cms')
    def test_limited_org_staff_no_studio_access_cms(self):
        """
        Verifies that course limited staff have no read and no write access when SERVICE_VARIANT is not 'lms'.
        """
        # Add a user as course_limited_staff on the org
        # This is not possible using the course roles classes but is possible via Django admin so we
        # insert a row into the model directly to test that scenario.
        CourseAccessRole.objects.create(
            user=self.limited_staff,
            org=self.course_key.org,
            role=CourseLimitedStaffRole.ROLE,
        )

        assert not has_studio_read_access(self.limited_staff, self.course_key)
        assert not has_studio_write_access(self.limited_staff, self.course_key)


class CourseOrgGroupTest(TestCase):
    """
    Tests for Org Content Creator groups for a particular course.
    """

    def setUp(self):
        """ Test case setup """
        super().setUp()
        self.global_admin = AdminFactory()
        self.user = UserFactory.create(
            username='test', email='test+courses@edx.org', password='foo'
        )
        self.org = 'mitx'
        self.course_key = CourseLocator(self.org, '101', 'test')

    def test_update_org_role_permission_denied(self):
        """
        Verifies PermissionDenied if caller of update_org_role is not instructor role.
        """
        with pytest.raises(PermissionDenied):
            update_org_role(self.user, OrgContentCreatorRole, self.user, [self.org])

    def test_update_org_role_permission(self):
        """
        Verifies if caller of update_org_role is GlobalAdmin.
        """
        assert not user_has_role(self.user, OrgContentCreatorRole(self.org))
        update_org_role(self.global_admin, OrgContentCreatorRole, self.user, [self.org])
        assert user_has_role(self.user, OrgContentCreatorRole(self.org))