import hashlib import logging import json import sys from lxml import etree from xmodule.x_module import XModule from xmodule.editing_module import JSONEditingDescriptor from xmodule.errortracker import exc_info_to_str from xmodule.modulestore import Location log = logging.getLogger(__name__) # NOTE: This is not the most beautiful design in the world, but there's no good # way to tell if the module is being used in a staff context or not. Errors that get discovered # at course load time are turned into ErrorDescriptor objects, and automatically hidden from students. # Unfortunately, we can also have errors when loading modules mid-request, and then we need to decide # what to show, and the logic for that belongs in the LMS (e.g. in get_module), so the error handler # decides whether to create a staff or not-staff module. class ErrorModule(XModule): def get_html(self): '''Show an error to staff. TODO (vshnayder): proper style, divs, etc. ''' # staff get to see all the details return self.system.render_template('module-error.html', { 'staff_access': True, 'data': self.definition['data']['contents'], 'error': self.definition['data']['error_msg'], }) class NonStaffErrorModule(XModule): def get_html(self): '''Show an error to a student. TODO (vshnayder): proper style, divs, etc. ''' # staff get to see all the details return self.system.render_template('module-error.html', { 'staff_access': False, 'data': "", 'error': "", }) class ErrorDescriptor(JSONEditingDescriptor): """ Module that provides a raw editing view of broken xml. """ module_class = ErrorModule @classmethod def _construct(self, system, contents, error_msg, location): if location.name is None: location = location._replace( category='error', # Pick a unique url_name -- the sha1 hash of the contents. # NOTE: We could try to pull out the url_name of the errored descriptor, # but url_names aren't guaranteed to be unique between descriptor types, # and ErrorDescriptor can wrap any type. When the wrapped module is fixed, # it will be written out with the original url_name. name=hashlib.sha1(contents).hexdigest() ) definition = { 'data': { 'error_msg': str(error_msg), 'contents': contents, } } # real metadata stays in the content, but add a display name metadata = {'display_name': 'Error: ' + location.name} return ErrorDescriptor( system, definition, location=location, metadata=metadata ) def get_context(self): return { 'module': self, 'data': self.definition['data']['contents'], } @classmethod def from_json(cls, json_data, system, error_msg='Error not available'): return cls._construct( system, json.dumps(json_data, indent=4), error_msg, location=Location(json_data['location']), ) @classmethod def from_descriptor(cls, descriptor, error_msg='Error not available'): return cls._construct( descriptor.system, json.dumps({ 'definition': descriptor.definition, 'metadata': descriptor.metadata, }, indent=4), error_msg, location=descriptor.location, ) @classmethod def from_xml(cls, xml_data, system, org=None, course=None, error_msg='Error not available'): '''Create an instance of this descriptor from the supplied data. Does not require that xml_data be parseable--just stores it and exports as-is if not. Takes an extra, optional, parameter--the error that caused an issue. (should be a string, or convert usefully into one). ''' try: # If this is already an error tag, don't want to re-wrap it. xml_obj = etree.fromstring(xml_data) if xml_obj.tag == 'error': xml_data = xml_obj.text error_node = xml_obj.find('error_msg') if error_node is not None: error_msg = error_node.text else: error_msg = 'Error not available' except etree.XMLSyntaxError: # Save the error to display later--overrides other problems error_msg = exc_info_to_str(sys.exc_info()) return cls._construct(system, xml_data, error_msg, location=Location('i4x', org, course, None, None)) def export_to_xml(self, resource_fs): ''' If the definition data is invalid xml, export it wrapped in an "error" tag. If it is valid, export without the wrapper. NOTE: There may still be problems with the valid xml--it could be missing required attributes, could have the wrong tags, refer to missing files, etc. That would just get re-wrapped on import. ''' try: xml = etree.fromstring(self.definition['data']['contents']) return etree.tostring(xml, encoding='unicode') except etree.XMLSyntaxError: # still not valid. root = etree.Element('error') root.text = self.definition['data']['contents'] err_node = etree.SubElement(root, 'error_msg') err_node.text = self.definition['data']['error_msg'] return etree.tostring(root, encoding='unicode') class NonStaffErrorDescriptor(ErrorDescriptor): """ Module that provides non-staff error messages. """ module_class = NonStaffErrorModule