Commit Graph

4 Commits

Author SHA1 Message Date
Robert Raposa
7e56d89bcc remove temp_view_func_compare custom metric (#24211)
In an earlier PR, we moved logic from process_view to process
request, so mapping would happen earlier in the middleware
lifecycle, and the code_owner metric would be set for requests
that never made it to process_view.

The temp_view_func_compare custom metric was added temporarily to
ensure this earlier refactor did not introduce any unaccounted for
differences. It did not, so we are removing this temporary metric.

ARCHBOM-1263
2020-06-12 08:53:20 -04:00
Robert Raposa
b721e186f3 ARCHBOM-1263: enhance code owner middleware (#24184)
* conservative move to process_request
* added temp_view_func_compare metric to be extra conservative

ARCHBOM-1263
2020-06-10 10:36:13 -04:00
Robert Raposa
4d30876d06 ARCHBOM-1263: refactor ownership mapping from middleware (#24175)
- move ownership mapping code to separate module
- simplify `__module__` mocking.

ARCHBOM-1263
2020-06-09 09:59:37 -04:00
Robert Raposa
59e0f6efcf ARCHBOM-1244: Add code_owner custom metric (#24084)
* includes ADR for Monitoring by Code Owner
* add monitoring middleware to add the following custom metrics:
- code_owner: The owning team mapped to the current view.
- code_owner_mapping_error: If there are any errors when trying to
        perform the mapping.
- view_func_module: The __module__ of the view_func, which can
        be used to find missing mappings.
* add script to generate `settings.CODE_OWNER_MAPPINGS` from
     a csv file.

ARCHBOM-1244
2020-06-01 12:27:38 -04:00