Commit Graph

19336 Commits

Author SHA1 Message Date
Kaustav Banerjee
c48c655998 refactor: deprecates replace url related properties from ModuleSystem
Deprecates the following attributes from ModuleSystem:
 * replace_urls
 * replace_course_urls
 * replace_jump_to_id_urls

A new ReplaceURLService is created as replacement with a unified replace_urls method
2022-03-14 09:35:41 -04:00
Dillon Dumesnil
d43ece5dba feat: AA-1205: Add Learning MFE support for Entrance Exams
* Adds entrance exam information to the Course Overview object
    * Enables hiding other tabs since the get_course_tab_list uses
      a Course Overview
    * Enables using the entrance exam helper functions to determine
      if Entrance exams are being used in this course.
* Posts a message when Entrance Exam is passed to parent container for
usage in the Learning MFE
* Overrides the 'title' field of the courseware tab since the Learning MFE
uses that over the 'name' field.
2022-03-14 09:04:45 -04:00
Dillon Dumesnil
61b93d953d feat: Add backfill course tabs management command
Previously, course tabs would only be created once and never try to
update the default tabs again. This leads to an issue if you ever want
to add a new tab. With this command, you can now update the default tabs
for all existing courses and new courses will pick it up upon creation
when CourseTabList.initialize_default is called.
2022-03-11 11:16:18 -05:00
Braden MacDonald
dcb7ef8821 feat: Read course indexes from MySQL, not MongoDB (#29184)
Description
This is a follow up to #29058 and #29413. This is the next step in moving part of the modulestore data (the course indexes / "active versions" table) from MongoDB to MySQL.

There are four steps planned in moving course index data to MySQL:

Step 1: create the tables in MySQL, start writing to MySQL + MongoDB  done
Step 2: migrate all remaining courses to MySQL  done
Step 3: switch reads from MongoDB to MySQL (this PR)
Step 4 (much later, once we know this is working well): stop writing to MongoDB altogether.
Supporting information
OpenCraft Jira ticket: MNG-2557

Status
 Tested with a large Open edX instance is in progress.

Testing instructions
Try making changes in Studio and verify that they work fine.

Deadline
None
2022-03-09 10:21:09 -05:00
Syed Muhammad Dawoud Sheraz Ali
b4bd552365 Merge pull request #29999 from openedx/prod-2708/add-paid-unpaid-modes
feat: paid unpaid named course modes
2022-03-08 21:48:32 +05:00
Michael Terry
37601a03f1 Merge pull request #30021 from openedx/mikix/guard-course-end
fix: add some extra guards for a None course.end value
2022-03-07 15:49:13 -05:00
Michael Terry
dbb1e4c8dd fix: add some extra guards for a None course.end value
This has bit us in the past, and here are a few more places
where it doesn't hurt to be cautious.

AA-1198
2022-03-07 15:25:53 -05:00
Abdurrahman Asad
f9c9832b28 fix: post preview body shows html tags in legacy discussion (updated) (#30017)
fix: post preview body shows HTML tags in legacy discussion
2022-03-07 18:28:03 +05:00
uzairr
7bc56c46ed feat: paid unpaid named course modes
Add executive education variants for paid and unpaid modes.

PROD-2708
2022-03-07 16:30:46 +05:00
Robert Raposa
8178a039ae Revert "fix: post preview body shows html tags in legacy discussion (#30007)" (#30016)
This reverts commit 89f92a1a9d.
2022-03-04 10:20:28 -05:00
Abdurrahman Asad
89f92a1a9d fix: post preview body shows html tags in legacy discussion (#30007)
fix: post preview body shows HTML tags in legacy discussion
2022-03-04 17:48:17 +05:00
connorhaugh
23690712ba fix: capa numerical response with scientic notation (#30010)
I found a potential location for a solution to the numericalinput bug. The problem stemmed from. In the convert markdown -> xml process, here, the checkIsNumeric function rejects the input if stringValue.match(/[a-z]/i) which says: does this value contain any letters, regardless of case? This rejection would cause uses of e and i in answers like the described problem to be string input problems. A simple fix would be to replace that match with regex like '/[a-df-hj-z]/i'.
2022-03-03 16:16:17 -05:00
Bianca Severino
f177855e1b feat: add REST endpoint to confirm name changes 2022-03-01 16:22:31 -05:00
Bianca Severino
cc43b5e567 Merge pull request #29952 from openedx/bseverino/name-affirmation-plugin
[MST-1360] Only enable verified name feature if Name Affirmation is installed
2022-02-23 09:18:44 -05:00
SaadYousaf
782ee338c9 fix: remove pre tag processing for course import 2022-02-21 16:29:01 +05:00
SaadYousaf
65f7800083 refactor: cleanup investigation logs 2022-02-21 13:28:39 +05:00
Bianca Severino
76f9756f92 feat: only enable verified name feature if Name Affirmation is installed 2022-02-18 13:25:30 -05:00
Binod Pant
3e53771878 feat: super trivial log change to help see entity_id (#29935)
to better log which changes we are making to which entity_id samlproviderdata
2022-02-18 12:18:42 -05:00
Felipe Montoya
e1acd52e0b Merge pull request #29764 from raccoongang/dyudyunov/fix-account-activation-email-site-logo-theming
fix: account activation email site logo is not themed
2022-02-17 11:53:00 -05:00
Carlos Muniz
37bf73ca50 refactor: Replace videosequence & problemset (#29905)
`videosequence` and `problemset` have been replaced with `sequential`.

`problemset` and `videosequence` are old-but-not-entirely-unused aliases to the `sequential` block type (in Studio-speak, "Subsection").
Since [these block types have been removed from the 6 courses that used them](https://openedx.atlassian.net/browse/DEPR-151?focusedCommentId=588197), this ticket removes the support for the `problemset` and `videosequence` block-types.

For more information, see ticket: [DEPR-151](https://openedx.atlassian.net/browse/DEPR-151)
2022-02-16 10:21:31 -05:00
dyudyunov
2ae94d08b8 fix: account activation email site logo is not themed
Fix the issue when the email sent from the microsite with its own theme
has the logo from the main site.

Preconditions:
- microsite with its own theme is up and running

STR:
- Create a new account on the microsite;
- Check your email inbox.
2022-02-16 12:18:27 +02:00
Bianca Severino
af81b3a609 chore: replace integrity signature flag with django setting 2022-02-15 09:57:00 -05:00
Aarif
aa31f3b255 refactor: remove a11y tests setup (#29813) 2022-02-15 18:56:34 +05:00
Carlos Muniz
8e8d8404be Carlos muniz/symmath removal unrevert (#29912)
* Revert "Merge pull request #29909 from openedx/revert-29869-Carlos-Muniz/symmath-removal"

This reverts commit 8c0db8ddff, reversing
changes made to 1156c62014.

* fix: Remove misplaced `-e`

`-e` was wrongfully placed in front of `common/lib/sandbox-packages`,
which may have most likely been causing the edxAPP to break.

* fix: Change regex to apply to right dirs

`py38.txt` does not include `common/lib/xmodule` so it doesn't match the
regex. Therefore, it never got its lines in `common/lib/sandbox-packages`
fixed. If we change the regex to match any `common/lib/<packagename>` it
should work correctly.
2022-02-14 10:26:40 -05:00
Michael Terry
e81c4fe49d Merge pull request #29911 from openedx/mikix/more-old-mongo-test-cleanup
test: more Old Mongo removal from tests
2022-02-11 15:10:45 -05:00
Michael Terry
b905de757b test: more Old Mongo removal from tests
Convert more tests from MONGO_AMNESTY to SPLIT modulestores.

This is in preparation for just wholesale denying access to Old
Mongo, so I either converted tests to split or just deleted some
test variants that were Old Mongo specific. (e.g. ddt lines)
2022-02-11 14:50:30 -05:00
Phillip Shiu
6ac1dd688a Revert "Remove symmath from edx-platform" 2022-02-11 10:30:08 -05:00
Carlos Muniz
a01a7ad416 feat: Update openedx-calc==3.0.1
This allows common/lib/capa/capa/responsetypes.py to not have to
change.
2022-02-10 15:06:20 -05:00
Carlos Muniz
675486a174 fix: Correct path to symmath function 2022-02-10 15:06:20 -05:00
Carlos Muniz
18e4c1cec4 refactor: Remove symmath from common/lib 2022-02-10 14:55:22 -05:00
Zainab Amir
120ed72739 Merge pull request #240 from edx/zamir/VAN-277/ensure_redirect_url_is_safe
fix: ensure redirect url is whitelisted
2022-02-10 12:02:21 +05:00
Pooja Kulkarni
b7d420a29e * feat: Add completion progress bar to dashboard
[SE-4473] Add completion progress bar to dashboard (#29271)
2022-02-09 09:28:48 -05:00
Tim McCormack
a1b09c0b8d fix: More resilience when calling encrypt_for_log with missing key (#29878)
It's likely that someone will at some point enable encrypted logging but
forget to deploy the config change that sets the key; if this happens, we
should gracefully return a warning rather than raise an exception.

Along the same lines, make sure that safe-sessions won't raise an exception
if the setting is missing, and document the suggested use of getattr.
2022-02-07 16:00:56 +00:00
Michael Terry
cb1bb7fa64 test: switch default test store to the split store
It's long past time that the default test modulestore was Split,
instead of Old Mongo. This commit switches the default store and
fixes some tests that now fail:
- Tests that didn't expect MFE to be enabled (because we don't
  enable MFE for Old Mongo) - opt out of MFE for those
- Tests that hardcoded old key string formats
- Lots of other random little differences

In many places, I didn't spend much time trying to figure out how to
properly fix the test, and instead just set the modulestore to Old
Mongo.

For those tests that I didn't spend time investigating, I've set
the modulestore to TEST_DATA_MONGO_AMNESTY_MODULESTORE - search for
that string to find further work.
2022-02-04 14:32:50 -05:00
SaadYousaf
87b029f293 fix: add investigation logs for course import. 2022-02-04 15:45:57 +05:00
SaadYousaf
314aa86f1e fix: remove investigation logs 2022-02-04 12:25:56 +05:00
SaadYousaf
52db919b6c fix: add further additional logs for course import 2022-02-03 12:25:29 +05:00
SaadYousaf
7a4ed05279 fix: add additional logs to investigate import issue 2022-02-02 15:07:38 +05:00
Zainab Amir
a717dfd50e fix: ensure redirect url is whitelisted 2022-02-01 15:10:23 +05:00
Maria Grimaldi
07f88fab4b fix: avoid raising error when auth_entry is None (#29787)
This commit avoids raising AuthEntryError when auth_entry is None.
At some point of the authentication flow, when the auth_entry is
missing from the auth URL (eg. auth/login/tpa-saml/?idp=idp), the
request session stores auth_entry: None causing this edited line to fail
which stops the login from completing.
2022-01-31 14:36:44 -05:00
Nathan Sprenkle
1212e3550c feat: ora staff grader backend (#29828)
- Adds Enhanced Staff Grader (ESG) backend-for-frontend (BFF) in `lms/djangoapps/ora_staff_grader`
    - Adds routing to ESG BFF at `{lms_url}/api/ora_staff_grader/*`
    - Adds mock implementation routing at `{lms_url}/api/ora_staff_grader/mock/*`
    - Adds `ORA_GRADING_MICROFRONTEND_URL` setting for routing to ESG microfrontend (MFE)
- Updates to the teams app:
    - Add`get_teams_in_teamset` to the teams API.
    - Add `get_team_names` to teams service.
- Adds `openassessment.staffgrader` app for appropriate ORA migrations.
- Modifies management commands for creation of users.
- Updates test factory to return display org with course overview.

Co-authored-by: jansenk <jkantor@edx.org>
Co-authored-by: Leangseu Kim <lkim@edx.org>
Co-authored-by: Ben Warzeski <bwarzeski@edx.org>
2022-01-31 11:09:41 -05:00
Felipe Montoya
c807af628f Merge pull request #29449 from eduNEXT/MJG/1st_filters_batch
[BD-32] feat: add first batch of Open edX Filters
2022-01-26 11:35:00 -05:00
Maria Grimaldi
f29a4eef68 feat: add first batch of Open edX Filters
* Add PreEnrollmentFilter
* Add PreRegisterFilter
* Add PreLoginFilter
2022-01-26 11:45:44 -04:00
alangsto
0e7534d730 fix: enrollment should still display if IDV is disabled (#29819)
MST-1317. The enrollment mode of a learner should still display on the course listing, even if IDV is disabled. Right now, all enrollment messaging is disabled if IDV is turned off, as we are no longer returning the verifications status for a learner in that case. We should still return the enrollment mode if IDV is disabled, but exclude any IDV messaging.
2022-01-26 10:14:33 -05:00
Peter Pinch
4f58ed4f25 Merge pull request #29260 from open-craft/jill/BD-13-sandbox
[BD-13] refactor: deprecates ModuleSystem properties related to code sandboxing
2022-01-26 09:57:41 -05:00
SaadYousaf
739083e301 fix: remove check for default values for video component when exporting. 2022-01-26 18:14:25 +05:00
Attiya Ishaque
60f3623066 fix: [VAN-823] Remove Authn MFE Waffle Flag (#29778) 2022-01-26 16:02:53 +05:00
Jillian Vogel
23a0d9ffb1 test: fixes safe_exec test TestSafeOrNot
so that both tests succeed on local devstack and in CI.
2022-01-25 14:49:31 +10:30
Jillian Vogel
57b390f8e2 refactor: removes calls to deprecated properties from source and tests. 2022-01-25 14:49:21 +10:30
Jillian Vogel
2173a98ef8 refactor: deprecates ModuleSystem properties for code sandboxing and cache
* Deprecates ModuleSystem can_execute_unsafe_code, get_python_lib_zip and cache properties
* Adds a new CacheService and SandboxService to provide the deprecated property
* Adds tests for the added CacheService and SandboxService
* Updates the ModuleSystemShim tests in Lms and Studio
2022-01-25 14:42:39 +10:30