Commit Graph

1572 Commits

Author SHA1 Message Date
Manjinder Singh
f7c5a109d4 Revert "feat: add explicit courserun_key parameter to /event endpoint" (#28410) 2021-08-05 18:05:20 -04:00
kenclary
e14ceaab3f Merge pull request #28333 from edx/TNL-7752
feat: add explicit courserun_key parameter to /event endpoint
2021-08-05 13:59:42 -04:00
Ken Clary
bbb14a2c6a feat: add explicit courserun_key parameter to /event endpoint
We add 'courserun_key' (aka "course_id" though that's technically a
misnomer) as an optional parameter to the /event endpoint url. If it
is not present, it will still be parsed out of the url, if the url is
of the right format.

Additionally, Logger.log() in js adds this parameter to its /event
call, pulling it from the $$course_id global.

This provides opportunity for MFEs to (separately) provide the key
without concern about url parsing.

TNL-7752
2021-08-04 22:47:43 -04:00
mohtamba
30a70d06c2 Fixed spacing on dropdowns 2021-08-04 15:25:02 -04:00
Farhaan Bukhsh
fa5736285e fix: Passwored reset page throwing page not found error (#27982)
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
2021-07-22 09:51:02 -04:00
Albert (AJ) St. Aubin
26678daf1f feat: Add the Request Certificate button to a Course card
[MICROBA-678]

When a certificate is in an unexpected state (i.e. notpassing with a
passing grade) this alert will allow the user to attempt to resolve the
issue on their own. It will run the code that checks the certificates
status. It requires that the course is configured to allow users to
Request Certificates though.
2021-07-15 10:27:18 -04:00
Waheed Ahmed
13270cd733 fix: user info cookie name for Edge (#28170)
We were generating cookie name for only stage and prod, the script
was raising an error on the Edge environment.

VAN-659
2021-07-13 19:18:38 +05:00
Zaman Afzal
843e9ba29b ENT4083: Removed ENABLE_MULTIPLE_USER_ENTERPRISES_FEATURE waffle switch (#28057) 2021-06-30 13:58:11 +05:00
adeelehsan
2e650110c9 activation a11y issue fixed 2021-06-22 21:44:15 +05:00
Justin Hynes
336e4dc7c9 Merge pull request #27990 from edx/jhynes/microba-1179_allowlist
refactor: Rename "whitelist" references to "allowlist" where possible in Instructor Dashboard/Certificates apps
2021-06-22 11:20:42 -04:00
Justin Hynes
205911653b refactor: Rename "whitelist" references to "allowlist" where possible in Instructor Dashboard/Certificates apps
[MICROBA-1179]
- Continue renaming/removal of code referring to the Certificate "white list".

The Certificates Django app `CertificateWhitelist` model is going away in an effort to make our codebase more inclusive. It is being replaced
with the `CertificateAllowlist` model. This PR continues to replace references to the Certificate "whitelist" with "allowlist" wherever
possible. There should be no change in functionality, nor are there any changes in appearance.
2021-06-22 08:18:15 -04:00
Ali-D-Akbar
e17b2abbf4 fix: mishandled xss change 2021-06-21 23:53:41 +05:00
Adeel Ehsan
335a0f28de Merge pull request #27661 from edx/aehsan/VAN-434/account_activation_dialogue_box_added
Account activation popup added
2021-06-10 15:20:15 +05:00
adeelehsan
78f1f1916c Account activation popup added
VAN-434
2021-06-10 14:46:49 +05:00
Adam Stankiewicz
50c8ab2d7b fix: close modal on escape keydown (#27758) 2021-05-28 10:01:12 -04:00
Adam Stankiewicz
31f66a4f2c feat: enterprise learner portal access modal (#27736)
* feat: enterprise learner portal access modal

* fix: quality

* fix: remove log.info
2021-05-27 15:31:27 -04:00
Sameen Fatima
0be941b224 ENT-4095: Handle coupon expiration date scenario in LMS (#27704) 2021-05-24 14:50:34 +05:00
Sameen Fatima
d8b07ebacd Revert "ENT-4095: Handle coupon expiration date scenario in LMS (#27539)" (#27675)
This reverts commit 9f2a72ad08.
2021-05-19 18:06:21 +05:00
Sameen Fatima
9f2a72ad08 ENT-4095: Handle coupon expiration date scenario in LMS (#27539) 2021-05-19 12:47:11 +05:00
Omar Al-Ithawi
64f8c01a92 Remove "edX" from the logout popup message
Not using `settings.PLATFORM_NAME` because sharing it with this script would need too much platform changes for this small error.

Removing the word "edX" makes the statement more accurate for other forks. Generally there shouldn't be any mention of "edX" in the code.
2021-05-12 13:49:38 +03:00
Matt Tuchfarber
4c0f856962 Merge pull request #27562 from edx/tuchfarber/show_course_card_with_cert
feat: Show course enrollment with cert on dash
2021-05-11 10:46:12 -04:00
Alex Dusenbery
4b247013ff feat: account activation now supports a next query param. ENT-4433
This change causes the activation link that’s emailed to a newly-registered user
to utilize a next query parameter. The impetus for this change is an edX Enterprise use-case:
we'd like newly registered Enterprise Customer admins and learners
to be directed to the Enterprise Learner Portal (or Admin Portal) upon account activation.
This is likely a broad enough use case to be valuable in other endeavors.
2021-05-10 12:58:26 -04:00
Matt Tuchfarber
e6e3bade93 feat: Show course enrollment with cert on dash
Previously the programs dashboard picked the first course run enrollment
for a course to display on the dash if the user had multiple. Now it has
a preference for the enrolled course run that earned a certificate if
there is one.
2021-05-07 15:17:32 -04:00
Adeel Ehsan
798b523712 Revert "CTA dialogue added" (#27560) 2021-05-07 16:17:18 +05:00
Adeel Ehsan
03a8dbffb7 Merge pull request #27334 from edx/aehsan/Van-434/cta_dialogue_box_added
CTA dialogue added
2021-05-07 05:42:56 +05:00
adeelehsan
dc306f8f6d CTA dialogue added
VAN-434
2021-05-05 23:29:47 +05:00
dylan-grafmyre
8995f1bf32 fix: prevent a backbone fieldview race condition that can delete user input (#25950)
* prevent a backbone fieldview race condition that can delete user input

eslint for effected

* Fixing quality

* Allow _super in fields.js

* Fixing new issues

* Revert some changes

* Fixing errors, formatting

* Fix bug

* Fix eslint rule allowing _super

* Refactor code

Co-authored-by: Dylan Grafmyre <dylan@opencraft.com>
Co-authored-by: Paulo Viadanna <paulo@opencraft.com>
2021-05-04 12:17:15 -04:00
Matt Tuchfarber
b3e76dc151 fix: Facebook share button on course certificates.
Facebook requires a callback when using the `.ui()` method now. I don't
know when this changed, but the share button is currently broken on
course certificates.

Facebook documentation of the `.ui()` method:
https://developers.facebook.com/docs/javascript/reference/FB.ui/
2021-04-30 13:34:58 -04:00
Ali-D-Akbar
de87916768 refactor: disable xsslint: PROD-2310 2021-04-19 12:37:08 +05:00
Ali-D-Akbar
eb2c369750 refactor: disable xsslint: PROD-2311 2021-04-16 17:13:05 +05:00
Ali Akbar
baa83d77e3 Merge pull request #27337 from edx/aakbar/xss-disable
refactor: disable xss for numerous files
2021-04-15 20:11:39 +05:00
Igor Degtiarov
70ab50181a fix: Hide enterprise/login button if enterprise integration disabled. (#27130)
* fix: Hide enterprise/login button if enterprise integration disabled.

[BTR-52](https://openedx.atlassian.net/browse/BTR-52)
Fix an issue with existing button for enterprise login on the login page
when enterprise integration is disabled.

* Address review comments
2021-04-15 11:54:56 +05:00
Ali-D-Akbar
eb1eb06bbd refactor: disable xss PROD-2312 2021-04-14 21:03:45 +05:00
Ali-D-Akbar
f82955bb62 refactor: disable xss PROD-2313 2021-04-14 17:17:32 +05:00
Ali-D-Akbar
b8d36e7a18 refactor: disable xss PROD-2316 2021-04-14 16:42:57 +05:00
Sarina Canelake
6e71251f57 Merge pull request #27209 from raccoongang/ideg/fix_language_preferences_change
fix: Language preferences change enhancement.
2021-04-06 08:09:40 -04:00
Azan Bin Zahid
2136cde713 Merge pull request #226 from edx/im-security-13
Incident Management Security Fix 13
2021-04-02 12:30:04 +05:00
Igor Degtiarov
13c9cf6fd4 fix: Language preferences change enhancement.
[CRI-229](https://openedx.atlassian.net/browse/CRI-229)
On "/account/settings" page, try to change the language. Language is
changed only after additional action click, page reload, etc.

Current fix change that behavior in a way that new language preferences
take place just after the new language is chosen.
2021-04-01 12:58:00 +03:00
Adam Blackwell
dd69020de1 fix: Add space after comma in legacy unenroll message. (#27177) 2021-03-30 10:48:44 -04:00
Azan Bin Zahid
5e466bc772 PROD-2314 2021-03-24 18:13:36 +05:00
Azan Bin Zahid
5c0fce308e PROD-2296 2021-03-24 18:13:36 +05:00
Saad Yousaf
b6b8c3b8d6 [TNL-7970] - Convert anonymized id report code to an instructor task. (#26778)
Co-authored-by: SaadYousaf <saadyousaf@A006-00314.local>
2021-03-11 11:48:35 +05:00
Ali Akbar
6259a82059 Merge pull request #26866 from edx/aakbar/PROD-2293
fix override error message
2021-03-09 14:55:35 +05:00
Zainab Amir
a39befb548 VAN-113: Add error code for registration workflow (#26821) 2021-03-08 18:09:26 +05:00
Ali-D-Akbar
7aa5e27201 fix override error message 2021-03-05 17:27:56 +05:00
Carla Duarte
368df80c05 Merge pull request #26838 from edx/ciduarte/AA-517
AA-517: fix duplicate IDs in MessageBannerView
2021-03-04 09:46:26 -05:00
Carla Duarte
5868e3aef8 AA-517: fix duplicate IDs in MessageBannerView 2021-03-03 16:29:11 -05:00
sarina
3ef0f626a0 feat! Remove JS validation for Role field in batch enroll feature 2021-02-28 18:40:16 -05:00
Justin Hynes
0de1d2b89a MICROBA-908 | Prevent overlap of allowlist and blocklist [WIP]
[MICROBA-908]
- When adding a learner to the allowlist we now check if they have an invalidated certificate on the blocklist
- Refactor some pieces of the Certificate Invalidation flow
- Make it so an error message is displayed when trying to add someone to CertificateInvalidation list if they already appear on the Allowlist
- Add support to pass back and display an error message to Instructor Dashboard UI if a learner already appears on the certificate invalidation list when attempting to create certificate exceptions in bulk
- Add python tests for backend changes
- Disable xss linting warnings in certificate_bulk_whitelist.js (checked with security group first)
2021-02-24 09:25:13 -05:00
Kyle McCormick
6d78f6aab2 fix: staff debug actions depended on legacy courseware URL (#26658)
The Staff Debug Actions didn't work in the Learning MFE
because the underlying JS depended on the URL being
formatted as /courses/<course_key>/... in order to
parse out the course key. This worked in the legacy
experience, but breaks in the chromeless xblock view,
which is rendered under the URL /xblock/<usage_key>/...

The fix is to explicitly pass the course key into the
templated courseware HTML as a data attribute.

TNL-7955
2021-02-22 15:14:31 -05:00