Commit Graph

141 Commits

Author SHA1 Message Date
Feanil Patel
d5082c0341 fix: Remove non-working teams from the CODEOWNERS file.
The teams stopped working when we moved the repo to the openedx org.
Also, things have been re-organized at 2U so it's unclear if these
ownership mappings are still relevant.  I'm removing them for now and
I've posted on the forums to let people know if they want to add back in
more relevant teams.

Relevant Link: https://discuss.openedx.org/t/edx-platform-codeowners/8649
2022-11-03 13:49:03 -04:00
Feanil Patel
eb0f7864ea Merge pull request #31253 from openedx/feanil/update_codeowners
feat: Ping tCRIL on-call if someone updates the legacy dashboard.
2022-11-03 13:44:17 -04:00
Feanil Patel
dccc697b0e feat: Ping tCRIL on-call if someone updates the legacy dashboard.
This could be a person using the quickstart and we want to be notified
of that so we can prais them and close the PR.
2022-11-03 10:28:52 -04:00
Usama Sadiq
4734f9f16e fix: bump pylint version (#31084) 2022-10-27 12:19:09 +05:00
Feanil Patel
2ee7aa4657 build!: Revert to default issue templates.
Rather than having an override for this repo, revert to the default
issue templates defined in the `.github` repo for the Open edX Project.

BREAKING CHANGE: This will allow anyone to create blank issues which was
previously only possible via a work-around.
2022-10-20 10:20:29 -04:00
Matjaz Gregoric
2f5a5ecd48 build: nudge devs about Olive release in github
Remind devs that when they open PRs on edx-platform, that they should backport their bug fixes to the Olive master branch (and think about backporting to Nutmeg as well).
2022-10-11 20:15:24 +02:00
Ned Batchelder
f3031d0b2a build(fix): use alls-green to correctly aggregate earlier steps
If a job "needs" earlier jobs, and one of the earlier jobs fails, then
the "needs" job will be marked as Skipped.  A required check that is
skipped doesn't block merging.

The alls-green action has the correct logic to fail the aggregation job
if any of its required jobs fail.
2022-10-06 04:22:42 -07:00
Kyle McCormick
56961ce0e6 build: fix syntax error in GH-hosted tests workflow (#31105)
We were seeing this error whenever unit tests
were run from a fork (only forks use the GH-hosted
workflow, which is why this was able to merge
into master):

  You have an error in your yaml syntax on line 65

The comment hash (#) needs to be aligned
with the rest of the text block.
2022-10-05 13:30:01 -04:00
Tim McCormack
2edbdcf7f4 build: Clear out stale dependencies when installing requirements (#31080)
We've been seeing some cross-version caching issues in the
edx-platform-runner unit tests, which apparently run on a "dirty"
environment—the virtualenv does not get cleared out between runs,
which probably improves performance but allows installed dependencies
to "leak" between runs. This results in errors between master and older
open-releases but could also prevent us from noticing missing deps.

By using pip-sync in the new CI Make targets (as we already do for
the regular `make requirements` target) we can ensure that any stale
dependencies from runs by other branches (or older versions of the
code) are removed.

Calling `make local-requirements` at the end of each `*-requirements`
target rather than making it a prerequisite is necessary for using sync,
since otherwise the local reqs would be wiped out.

The `requirements` target is also deduplicated into the newer
`dev-requirements` (aliased to it, with both installing private deps now.)

Adding a prerequisite of `pre-requirements` allows us to simplify some
workflow calls slightly. This ends up being the bulk of the commit by
line count. The pip lockfile also wasn't being used in the Makefile, so
I added that to pre-requirements as well.

Also fix leading whitespace issue in Makefile.
2022-10-03 20:26:40 +00:00
Ned Batchelder
a5f687bf70 build: add a success aggregation step to simplify required check configuration 2022-10-03 07:11:53 -07:00
Ned Batchelder
63f6baf528 style: make action style more uniform 2022-10-03 07:11:53 -07:00
Ned Batchelder
a78f8f9496 style: make action style more uniform 2022-10-03 07:11:53 -07:00
Ned Batchelder
1e0f0e344b build: add a collection step so we can simplify required checks 2022-09-30 12:48:21 -07:00
Ned Batchelder
18fcbc33ef style: make the action syntax more uniform 2022-09-30 12:48:21 -07:00
UsamaSadiq
897cb3617f refactor!: delete common/lib and related usages 2022-09-22 14:16:34 +05:00
Sarina Canelake
69f0849165 fix: update path to .github workflows to read from openedx org 2022-09-15 14:52:28 -04:00
Sarina Canelake
4a2f231302 fix: fix github url strings (org edx -> openedx) 2022-09-15 14:52:28 -04:00
Sarina Canelake
b0143c0e43 build: add check for Open edX tutorial changes 2022-09-01 16:08:30 -04:00
Adam Blackwell
f03f744863 fix: Fixed link to pull request template 2022-08-16 20:56:25 -04:00
Adam Blackwell
0046628fe2 chore: Add link to important doc (#30834) 2022-08-16 20:55:33 -04:00
Nathan Sprenkle
e025463872 feat: Learner Dashboard get enrollments (#30808)
* feat: fill out enrollment serializer

* test: add basic integration tests for enrollments

* feat: get info for user account activation

* test: test integrating user account activation

* feat: get course enrollments

* feat: get course email settings

* feat: add ecommerce info

* feat: add resume urls

* refactor: move learner home to separate app

* refactor: remove course limit

Co-authored-by: nsprenkle <nsprenkle@2u.com>
2022-08-11 11:05:07 -04:00
Muhammad Soban Javed
d053bba952 Revert "Revert "refactor: move common/lib/capa/capa to xmodule/capa" (#30762)"
This reverts commit 4463ee751d.
2022-07-27 15:36:08 +05:00
Muhammad Soban Javed
4463ee751d Revert "refactor: move common/lib/capa/capa to xmodule/capa" (#30762) 2022-07-21 18:22:15 +05:00
Muhammad Soban Javed
06064b237b Merge pull request #30403 from openedx/iamsobanjaved/BOM-2582-move-common-lib-capa
refactor: move common/lib/capa/capa to xmodule/capa
2022-07-21 16:27:47 +05:00
M Umar Khan
91f4585166 build: add doc build check 2022-07-20 15:39:05 +05:00
Soban Javed
9eba9f983a refactor!: move common/lib/capa/capa to xmodule/capa
As part of dissolving our sub-projects in edx-platform, we are moving this package under the xmodule directory.
We have fixed all the occurences of import of this package and also fixed all documents related references.
This might break your platform if you have any reference of `import capa` or `from capa import` in your codebase or in any Xblock.

Ref: https://openedx.atlassian.net/browse/BOM-2582
2022-07-19 12:20:04 +05:00
Maria Fernanda Magallanes Zubillaga
f6f66d0f39 refactor!: change the api naming and url 2022-07-08 00:05:10 -04:00
María Fernanda Magallanes Z
7f5eb296a3 feat: add mfe_api v1
This PR adds MFE API. This is part of the work that is being done to obtain the MFE Runtime Configurations and that has been discussed in the BTR WG.

Discussion: https://discuss.openedx.org/t/how-to-use-microfrontend-in-a-multitenant-instance/6936/14?u=mafermazu
MFE Runtime configuration - eduNEXT: https://docs.google.com/document/d/1-FHIQmyeQZu3311x8eYUNMru4JX7Yb3UlqjmJxvM8do/edit?usp=sharing

feat: add lms setting to set mfe config cache (#262)

Co-authored-by: María Fernanda Magallanes Z <maria.magallanes@edunext.co>

feat: make mfe config api disabled by default (#263)

* feat: make mfe config api disabled by default

* fix: simple is better than complex

test: add mfe config tests (#264)

* test: add mfe config tests

* test: fix it and simplify it

* test: correct pylint issues

fix: correct pep 8 violations

fix: add mfe api unit test in github workflow

fix: correct unit tests

refactor: move mfe api to lms

fix: try mfe api urls without regex

fix: add app_namespace in lms urls

fix: try url without conditional

Revert "fix: try url without conditional"

This reverts commit 694aab546134b4bd9ad2642e24927b42cac24459.

fix: set enable_mfe_config_api feature to true in the tests

test: try to add failed test case

Revert "test: try to add failed test case"

This reverts commit cee6bf656ab1b96492b0b6199ddff32a6d6a65bd.

docs: improve explanation and documentation

fix: ensure the response is a json object

refactor: be consistent with the variable names

fix: allow overriding mfe api config cache timeout in production

fix: handle 404 response in view

refactor: use a guard instead if-else

feat: add the possibility to show mfe specific config
2022-07-07 23:57:36 -04:00
Awais Qureshi
872c951417 build: new check for static assets. (#30599)
* build: static assets check for lms and cms.
2022-06-21 19:55:13 +05:00
Muhammad Umar Khan
a389a9ff10 Revert "Revert "refactor: move xmodule folder to root"" 2022-06-20 18:20:06 +05:00
Muhammad Umar Khan
d890f06507 Revert "refactor: move xmodule folder to root" 2022-06-20 16:03:48 +05:00
M Umar Khan
a91df0c40f refactor: move xmodule folder to root
- Moving xmodule folder to root as we're dissolving sub-projects of common folder in edx-platform
    - More info: https://openedx.atlassian.net/browse/BOM-2579
- -e common/lib/xmodule has been removed from the requirements as xmodule has itself become the part of edx-platform and not being installed through requirements
- The test files common/lib/xmodule/test_files/ have been removed as they are not being used anymore
2022-06-20 14:33:45 +05:00
Sagirov Eugeniy
92ca176fde refactor: Remove legacy course info page & related code 2022-06-05 19:00:05 +03:00
Mohammad Ahtasham ul Hassan
79b3c82e5f build!: drop node12 support (#30468) 2022-05-30 17:38:31 +05:00
Mohammad Ahtasham ul Hassan
7deea6ec6e feat: add lockfile check (#30440) 2022-05-19 17:54:09 +05:00
Mohammad Ahtasham ul Hassan
f801deaae5 Node Upgrade (#30420)
* feat: Node16 upgrade
2022-05-18 16:12:34 +05:00
Mohammad Ahtasham ul Hassan
fee54bf424 Revert "Node 16 Upgrade (#30354)" (#30399)
This reverts commit f4c3c3fb4d.
2022-05-16 18:42:42 -04:00
Mohammad Ahtasham ul Hassan
f4c3c3fb4d Node 16 Upgrade (#30354)
* feat: Node16 upgrade
2022-05-16 16:53:37 +05:00
Muneeb Ur Rehman
20a0e6e9e1 feat: create learner pathway skeleton (#30355)
* feat: create skeleton for learner_pathway app

* feat: add learner_pathway app for quality checks

* feat: add verbose name and dir for tests

* feat: add docstrings for files in app

* fix: remove unused imports

* refactor: resolve quality issues
2022-05-10 13:19:45 +05:00
Ned Batchelder
e7caec5ab8 build: the Django matrix needs to use the pinned version also.
The logic here seems to work, but Django 4.0 won't install over our
other pinned requirements, so tests fail for Django 4.0.
2022-04-28 02:28:32 -07:00
Tim McCormack
8bcec1a7c9 build: Remove empty coursegraph module (and the pylint reference to it) (#30273)
Coursegraph was moved from openedx to cms in commit 92552e50/PR #29156;
module init file was reintroduced in commit 80f9f1de/PR #30197, I think
by accident.
2022-04-21 19:33:38 +00:00
Mohammad Ahtasham ul Hassan
e84187bacd Revert "feat: node16 upgrade (#30249)" (#30268)
This reverts commit f10ebf0752.
2022-04-18 21:57:17 +05:00
Mohammad Ahtasham ul Hassan
f10ebf0752 feat: node16 upgrade (#30249) 2022-04-18 16:32:53 +05:00
Régis Behmo
10e4634a7f build: nudge devs to backport changes to nutmeg 2022-04-12 13:09:53 -07:00
Mohammad Ahtasham ul Hassan
a443542260 Revert "feat: node16 upgrade (#30158)" (#30228)
This reverts commit 5ee25c65ea.
2022-04-12 17:18:30 +05:00
Mohammad Ahtasham ul Hassan
5ee25c65ea feat: node16 upgrade (#30158) 2022-04-12 15:23:34 +05:00
Usama Sadiq
80f9f1de7a Fix quality failures with pylint 2.13.5 (#30197)
* build: update pylint-checks ci workflow
* fix: fix quality failures with new pylint version
* chore: remove pylint constraint
* chore: Updating Python Requirements (#30196)
Co-authored-by: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com>
2022-04-07 13:59:44 +05:00
Sarina Canelake
ea76006fdf docs: Add description to temporary .github/ISSUE_TEMPLATE files 2022-04-04 18:25:24 -04:00
Muhammad Soban Javed
aa742f09fb Merge branch 'master' into iamsobanjaved/unit-tests-for-forks 2022-03-31 15:53:45 +05:00
Kyle McCormick
8039e40f47 refactor: move coursegraph to cms
This code was originally located at:
  ./openedx/core/djangoapps/coursegraph

However, code makes more sense within the ./cms tree, because:
* it is responsible for publishing course content to an
  external system, with is within the responsibilities of CMS, and
* is uses modulestore, which is discouraged for use in LMS
  (see 0011-limit-modulestore-use-in-lms.rst).

So, we move the code to:
  ./cms/djangoapps/coursegraph
and uninstall coursegraph from LMS.

We do not expect this refactor to have any breaking downstream effects.
2022-03-29 11:21:20 -04:00