Commit Graph

4617 Commits

Author SHA1 Message Date
Calen Pennington
d8cd6135a6 Revert "Improve the performance of access checking for a specific user in CourseViewList by prefetching data"
This reverts commit a2a340bcd0.
2019-03-14 10:31:24 -04:00
David Ormsbee
07e93bc264 Merge pull request #19837 from open-craft/opencraft/edx-platform/devan/show-enroll-links-on-public-courses-only-if-self-enrollment-allowed
Show enroll links on public courses only if self enrollment allowed
2019-03-13 14:25:53 -04:00
Devan Rehunathan
c6f87d49f2 Show Enroll links on public courses only if self-enrollment is allowed
This commit updates the Info messages on the course page to display
more informative messages to the user. Specifically, messages for Public
and Invitation-only courses.
2019-03-12 21:24:56 +00:00
Calen Pennington
a2a340bcd0 Improve the performance of access checking for a specific user in CourseViewList by prefetching data 2019-03-11 10:37:53 -04:00
uzairr
881c8e035c Improve 403 error handling
Currently, ajax calls in courseware is handling 403 like 401.
In this PR, proper modifications have been done to make it
coherent with its intended behaviour.

LEARNER-7131
2019-03-06 20:22:37 +05:00
Mike Dikan
2c149ca6be Removing the Deprecated the 'external_auth' package in favor of 'third_party_auth' which is the current recommendation. 2019-03-02 16:06:46 -05:00
Usama
a826145d91 Progress Page update
Updated progress page certificate view for
unverified users.
2019-03-01 12:47:37 +05:00
Farhanah Sheets
bc00313a9c Revert "Improve 403 error handling" 2019-02-27 11:28:14 -05:00
Uzair Rasheed
989180dde3 Merge pull request #19881 from edx/LEARNER-7131/improve-403-error-handling
Improve 403 error handling
2019-02-27 18:27:25 +05:00
uzairr
aa39f2c438 Improve 403 error handling
Currently, ajax calls in courseware is handling 403 like 401.In this
PR, proper modifications have been done to make it coherent with its
intended behaviour.

LEARNER-7131
2019-02-26 19:05:48 +05:00
Dave St.Germain
cd4f44a91b Fixed proctoring tests 2019-02-25 14:09:11 -05:00
emma-green
507cfb8942 Merge pull request #19849 from edx/emma-green/REVEM-176/C/Hacky-cache-course_runs-to-programs
add course to program caching
2019-02-25 10:41:51 -05:00
Dave St.Germain
954c8e1a67 Merge pull request #19771 from edx/dahlia/masters-track
Added master's track
2019-02-25 10:11:24 -05:00
Emma Green
57b7150b09 add course to program caching 2019-02-22 13:18:23 -05:00
Calen Pennington
c9ee6ed78d Record a plan for converting has_access to user.has_perm 2019-02-22 12:24:30 -05:00
Calen Pennington
78c8950ea3 Clean up a few remaining unicode format string errors 2019-02-20 15:28:14 -05:00
emma-green
cbf3f78325 Revert "WIP:Cache course runs to programs" 2019-02-20 12:03:07 -05:00
emma-green
304fba5959 Merge pull request #19677 from edx/emma-green/REVEM-176/cache-course_runs-to-programs
WIP:Cache course runs to programs
2019-02-20 09:55:36 -05:00
Jeremy Bowman
974ae50bf4 Merge pull request #19620 from cclauss/new-style-exceptions
Old style exceptions --> new style for Python 3
2019-02-19 16:31:35 -05:00
Emma Green
f2139bbe2f add courses to programs to cache 2019-02-19 15:17:23 -05:00
bmedx
7df1e05f49 Fix xxslint errors in touched files 2019-02-19 11:24:24 -05:00
Julia Eskew
368f221f0a Initial start on annotations. 2019-02-19 11:24:21 -05:00
cclauss
c0c935b685 Old style exceptions --> new style for Python 3 2019-02-19 13:09:23 +01:00
Matthew Piatetsky
444799fb0e fix unicode strings in openedx/ part 2 2019-02-15 10:15:51 -05:00
Dave St.Germain
d780908bbd Define permission used in edx-proctoring 2019-02-13 11:45:44 -05:00
Nimisha Asthagiri
34201c62e8 Merge pull request #19790 from edx/pwnage101/read-from-extra-list-of-logout-uris
Additionally logout from a settings list of extra logout URIs
2019-02-12 22:49:36 -05:00
Troy Sankey
10afe5e52f Additionally logout from a settings list of extra logout URIs
Currently, the LMS logout endpoint should iframe in the logout pages of
all the IDAs you were logged into. In short, this was made possible with
DOP because keeping track of the logout URIs and leaving a trail of
evidence in the user cookies was part of what we added in our fork of
DOP.  In the case of DOT, we don't have time or desire to fork DOT to
mirror this behavior, so our stop-gap solution is to log out the user
from a list of logout URIs in settings.
2019-02-12 19:44:41 -05:00
Michael Youngstrom
3221c2b91f Remove lms pytest shards 2019-02-12 11:03:46 -05:00
Pooja Kulkarni
9ddb1cc074 Implement public cohort
This PR is based on #19284 and is part of the
series of work related to the proposal #18134.

This PR avoids the assignment of
anonymous/unenrolled users to any cohort when
course is public. Anonymous or unenrolled users
will only see content that does not have a
content group assigned.
The "View Course" link to the course outline
is shown on the course about page for a course
marked public/public outline.
It also makes course handouts available for
public courses (not for public_outline).
This PR also hides the different warnings and
messages asking the user to sign-in and enroll
in the course, when the course is marked public.
It modifies the default public_view text to
include the component display_name when
unenrolled access is not available.
2019-02-07 21:42:21 +05:30
Calen Pennington
829227ade3 Merge pull request #19663 from cpennington/fbe-improve-course-api-performance
Fbe improve course api performance
2019-02-06 11:01:25 -05:00
Calen Pennington
43d975a92a Select related CourseOverview.image_set when loading the course_api 2019-02-06 10:11:16 -05:00
Calen Pennington
419657d7a5 Prefetch course modes used in has_access calls in course api 2019-02-06 10:11:15 -05:00
Calen Pennington
6c596f7c49 Allow courses api to return data incrementally
Prior to this commit, the course api (/api/courses/v1/courses/)
performed all the work necessary to return all courses available
to the user, and then only actually returned on page's worth of those
courses.

With this change, the api now does the work incrementally, computing
only the data needed to fetch the courses up to and including the page
being returned. This still increases approximately linearly as
the page number accessed being increases, but should be more cache-friendly.
One side effect of this is that the max_page reported by pagination
will be an overestimate (it will include pages that are removed due
to a users access restrictions).

This change also changes the sort-order of courses being returned by the
course_api. By sorting by course-id, rather than course-number, we
can sort in the database, rather than in Python, and defer loading data
from the end of the list until it is requested.

REVMI-90
2019-02-06 10:11:15 -05:00
Matthew Piatetsky
6e81c84d8b fix unicode strings in lms/ part 1 2019-02-05 15:15:02 -05:00
Matthew Piatetsky
b37bc75bb4 Revert "Revert "change banner date localization to use dateutilfactory""
This reverts commit 08cb56664b.
2019-02-04 12:42:27 -05:00
Calen Pennington
95252f1a81 Run caniusepython3.pylint_checker 2019-02-01 10:03:42 -05:00
Calen Pennington
040b60c38c Stop swallowing UnicodeEncodeErrors in courseware rendering 2019-02-01 09:22:54 -05:00
Farhanah Sheets
fb7d597554 unicode messages developer and user messages 2019-02-01 09:22:54 -05:00
Michael Youngstrom
a090d4b7a3 Merge pull request #19697 from edx/youngstrom/incr
INCR-19: Move to python3-saml
2019-01-31 09:30:46 -05:00
Agha Awais
30359a2995 Merge pull request #19668 from edx/awais/removed_old_lettuce_tests_for_courseware_problems
removed lettuce files
2019-01-31 10:29:58 +05:00
Michael Youngstrom
e7898d153d Move to python3-saml 2019-01-30 16:35:16 -05:00
Jansen Kantor
6f4bbf6a01 Merge pull request #19676 from edx/jkantor/failed-cert
fail a certificate if grades are modified to failing
2019-01-29 17:07:00 -05:00
jansenk
726fb0f6f0 fail a certificate if grades are modified to failing 2019-01-29 15:57:15 -05:00
Calen Pennington
daf6fd3330 Merge pull request #19599 from cpennington/fbe-adrs
Add ADRs for FBE decisions
2019-01-28 14:40:48 -05:00
Calen Pennington
4ac3caab23 Add ADRs for FBE decisions
REVMI-39
2019-01-28 13:16:53 -05:00
Agha Awais
e89ccc8614 removed lettuce files 2019-01-28 06:50:02 +00:00
Calen Pennington
805f32a357 Revert "Allow courses api to return data incrementally" 2019-01-25 12:56:57 -05:00
Calen Pennington
c9ed838991 Merge pull request #19642 from cpennington/fbe-improve-course-api-performance
Allow courses api to return data incrementally
2019-01-25 11:31:24 -05:00
Calen Pennington
2527efd822 Prefetch CourseOverview.image_set when loading the course_api 2019-01-25 10:30:09 -05:00
Calen Pennington
0d273e9506 Prefetch course modes used in has_access calls in course api 2019-01-25 10:30:09 -05:00