Syed Ali Abbas Zaidi
adf879e8b2
Revert "fix: all auto fixable eslint issues ( #31900 )" ( #32203 )
...
This reverts commit 228180b1ef .
2023-05-09 13:53:54 +05:00
Syed Ali Abbas Zaidi
228180b1ef
fix: all auto fixable eslint issues ( #31900 )
...
* fix: eslint operator-linebreak issue
* fix: eslint quotes issue
* fix: react jsx indent and props issues
* fix: eslint trailing spaces issues
* fix: eslint line around directives issue
* fix: eslint prefer template issue
* fix: eslint semi rule
* fix: eslint newline per chain rule
* fix: eslint space infix ops rule
* fix: eslint space-in-parens issue
* fix: eslint space before function paren issue
* fix: eslint space before blocks issue
* fix: eslint arrow body style issue
* fix: eslint dot-location issue
* fix: eslint quotes issue
* fix: eslint quote props issue
* fix: eslint operator assignment issue
* fix: eslint new line after import issue
* fix: indent issues
* fix: operator assignment issue
2023-05-09 11:57:15 +05:00
Syed Ali Abbas Zaidi
f1fb38ed83
fix: multi lines and spaces issues ( #31885 )
...
* fix: multi lines and spaces issues
* fix: eslint operator-linebreak issue
* fix: eslint quotes issue
* fix: remaining quotes issues
* fix: eslint object curly newline issue
* fix: eslint object curly spacing issue
* fix: eslint brace-style issues
* fix: react jsx indent and props issues
* fix: eslint trailing spaces issues
* fix: eslint linbreak style issue
* fix: eslint space unary operator issue
* fix: eslint line around directives issue
* fix: void and typeof space unary ops issue
2023-05-03 12:22:46 +05:00
Syed Ali Abbas Zaidi
5549db4d80
fix: migrate remaining eslint-config-edx ( #31760 )
...
* fix: migrate remaining eslint-config-edx
* refactor: updated eslint rules according to eslint-config-edx-es5
* refactor: add custom rules to suppress unnecessary eslint issues
* refactor: add custom rules to internal eslint configs
* fix: fix all indentation issues
* chore: update lock file
2023-03-02 16:16:50 +05:00
Dave St.Germain
05e0de2956
TNL-6968
...
The access settings modal should not have an editable title. Also, the title of the modal was not being interpolated correctly.
2019-10-28 10:21:34 -04:00
Dave St.Germain
ea3232feac
TNL-6920 Component Editor Efficiency Improvements
...
* Enlarges component modal for easier editing
* Allows display name to be edited in place
* Improves markdown button labeling
* Moves markdown cheatsheet to the edit modal, for quick reference
2019-09-26 09:34:14 -04:00
Calen Pennington
07a15c681f
Reapply the XBlock RequireJS -> Webpack changes
...
This reverts commit 105db2cf59 , reversing
changes made to 447457594f .
2018-06-27 22:27:07 -04:00
Eric Fischer
e72549cdbe
Revert "Merge pull request #18340 from cpennington/fix-studio-xblock-rendering"
...
This reverts commit 9a70ca78a5 , reversing
changes made to efd5b9abbd .
Hopefully fixes EDUCATOR-3053
2018-06-15 13:18:27 -04:00
Calen Pennington
be3c7e05c5
Reapply "Switch container factory to webpack"
...
This reverts commit 18d93b00ba .
2018-06-07 15:52:05 -04:00
Calen Pennington
18d93b00ba
Revert "Switch container factory to webpack"
2018-06-07 13:46:47 -04:00
Calen Pennington
0abe75a7c6
Re-apply the changes to convert XBlocks to Webpack
...
Reapplies edx/edx-platform#17509
This reverts commit 0f7e2373d0 .
2018-06-06 12:52:12 -04:00
Calen Pennington
0f7e2373d0
Revert "Switch container factory to webpack"
2018-05-29 16:01:38 -04:00
Calen Pennington
61855b2b30
Extract a new webpack-based suite of cms javascript tests
2018-05-29 12:28:19 -04:00
muhammad-ammar
c02955d025
add check transcript ajax for edx_video_id
2018-05-02 18:23:46 +05:00
Eric Fischer
5bc6b31e29
eslint --fix
2017-12-08 14:38:41 -05:00
Mushtaq Ali
e9b8e17fc8
Enable disable move - TNL-6063
2017-03-01 19:27:01 +05:00
Mushtaq Ali
e856f07b87
Move and undo move XBlock
...
- TNL-6062
- TNL-6229
2017-03-01 19:27:00 +05:00
muhammad-ammar
c7dc83c378
Move modal show course outline with breadcrumb
...
TNL-6060
2017-03-01 19:25:57 +05:00
muhammad-ammar
1b011af7e2
move dialog
...
TNL-6047
2017-03-01 19:21:38 +05:00
Brian Jacobel
d43e915dab
Run eslint autofixer on /cms
2016-08-08 15:04:06 -04:00
Andy Armstrong
d462c73fd8
Use the UI Toolkit's spec helpers.
2016-06-21 10:16:00 -04:00
muzaffaryousaf
c0fef0b0e0
Js test fixes for cms and cms-squire.
2016-04-22 19:09:33 +05:00
Chris Rodriguez
2bea68fc58
Sending focus to modal in CMS
2015-07-29 09:19:36 -04:00
Andy Armstrong
1689004189
Create a common paginated list view
...
TNL-2384
Refactored Studio's PagingView to use RequireJS Text and moved it
to common so that it can also be used by LMS.
2015-06-15 13:51:09 -04:00
Braden MacDonald
42ee0571e7
Read-only users get "Details" instead of "Edit" button, remove "Save" option
2015-01-12 13:40:55 +03:00
Andy Armstrong
8627fdef32
Support adding students to a cohort via the instructor dashboard.
...
TNL-163
2014-10-01 09:22:31 -04:00
Se Won Jang
11d260910f
Implemented Validation for Course Advanced Setting
...
This commit adds validation for course advanced settings. Currently when course
administrators make invalid changes in the Settings/Advanced Settings tab,
they're not notified through a new modal window of the list of invalid settings
changes.
* Extending CourseMetadata
- Previously, we only had update_from_json method in CourseMetadata.py,
and it was only validating one field every POST request.
- Now we have validate_and_update_from_json method that encapsulates the
functionality of update_from_json into a validation call
- To avoid discrepancy of validation standards between modules, validation
uses the from_json method implemented to each field in xblock.
* Different Response in advanced settings ajax requests
- After receiving a POST ajax request, course.py calls
validate_and_update_from_json, and sends a json object of either:
1) valid course metadata model
2) error objects
* Error Messages shown in validation-error-modal
- error objects passed through ajax are shown in a separate modal.
2014-08-26 11:24:38 -07:00
Andy Armstrong
d451c3e91d
Fix Studio to gracefully handle xblock JavaScript errors
...
TNL-46
I've changed Studio to catch JavaScript errors when rendering xblocks, log the error, but to then continue as normal. This means that the user is still able to interact with the xblock to delete, duplicate etc. This seems reasonable as the xblock is only rendered as a WYSIWYG representation so if it isn't fully interactive that shouldn't be a big problem.
2014-08-21 17:31:19 -04:00
cahrens
37da399997
Update unit test based on changes in master.
2014-05-02 15:09:25 -04:00
Andy Armstrong
a3b2809601
Fix duplicate save and cancel buttons in Studio
...
STUD-1531
Also add support for refreshing the modal on custom save
2014-04-15 14:04:55 -04:00
Andy Armstrong
2ae28c5db7
Improve unit testing of xblock editing
2014-04-09 10:32:13 -04:00
Andy Armstrong
a6aae729b7
Address the next round of review comments.
2014-04-09 10:32:13 -04:00
Andy Armstrong
88d95d119c
Rebuild the way modals are constructed to support nesting.
2014-04-09 10:32:13 -04:00
Andy Armstrong
b779b8a6fb
Add unit tests for custom tabs and modal titles
2014-04-09 10:32:13 -04:00
Andy Armstrong
dce075a852
Changes based upon code review comments
2014-04-09 10:32:12 -04:00
Andy Armstrong
7770d9d427
Implement editing from the Studio container page.
...
STUD-1306
2014-04-09 10:32:11 -04:00