Greg Price
c850be4ab9
Merge pull request #1167 from edx/fix/kevin/forums_accessibility
2013-09-27 14:18:09 -07:00
Kevin Chugh
9a5e6f1fdd
code review cleanup
2013-09-27 17:12:48 -04:00
Greg Price
cbbb5c7e7e
Improve focus management of forums nav sidebar
...
Now, when the list is reset (e.g. by sorting), the first thread is
focused. When the "Load more" link is clicked, upon loading more
threads, focus moves to the thread immediately following the thread
that was previously last in the list.
2013-09-27 16:57:11 -04:00
Kevin Chugh
d816d5fade
update coffeescript to dynamically render sr spans
2013-09-27 16:24:30 -04:00
Greg Price
f39886ef57
Ensure nav sidebar is sized correctly on page load
2013-09-27 15:34:32 -04:00
Greg Price
98142c02d3
Improve accessibility of forum nav sort buttons
2013-09-20 13:31:37 -04:00
Greg Price
8a32f274be
Fix forums nav sidebar overlapping content
...
Previously, when the window was scrolled down past the top of the
discussion content pane, scrolling right would cause the sidebar to
appear above the background of the content pane but below the text.
This is only an issue with very small windows or with the text size
increased significantly, which is why this came up in an accessibility
audit. Now the sidebar is fixed to the left side of the page instead
of the left side of the viewport.
2013-09-11 14:24:58 -04:00
Miles Steele
cb7a3ad8eb
switch from log_event to Logger.log
...
keep log_event for compatibility
2013-08-20 16:52:18 -04:00
Kevin Chugh
4f7edbf67d
fix notifications URL
2013-07-30 01:50:33 -04:00
Kevin Chugh
5c91edd4a5
update coffeescript to use new status url
2013-07-30 01:43:49 -04:00
Kevin Chugh
8f98a1c2be
remove failing jasmine tests and print statements
2013-07-30 00:46:47 -04:00
Kevin Chugh
99f235ec56
first pass at jasmine tests
2013-07-30 00:13:03 -04:00
Kevin Chugh
62f6e2d52b
home button working, default to home when no thread selected
2013-07-29 23:33:50 -04:00
Your Name
47dbf2e6cb
updates but getting status and setting status not working
2013-07-29 18:33:19 -04:00
Your Name
4afa5481dd
set and get settings and fix discussion.css post-variable-apocalypse
2013-07-29 16:11:59 -04:00
Your Name
6276997180
update checkbox with get settings
2013-07-29 13:26:31 -04:00
Kevin Chugh
d95693ebb7
hook up panel to new stats service
2013-07-25 03:23:04 -04:00
Kevin Chugh
63b2b47106
update to render home page
2013-07-19 07:33:50 -04:00
David Ormsbee
aaf3a47538
Remove use of keyword "delete" in forum coffee code to fix IE8 bug LMS-441.
...
Change client-side code references from "delete" to "_delete". Some of these
were method names (or would generate method names), which breaks in IE8
because "delete" is a JavaScript reserved keyword. foo["delete"] is ok, but
foo.delete is not. This also makes forums marginally functional in IE8,
though the left-nav still has some display issues.
2013-07-10 17:54:13 -04:00
Renzo Lucioni
51f694b18d
Remove Segment.io whitelist from Logger
2013-07-02 13:49:33 -04:00
Renzo Lucioni
42efd33cfa
Refactor Segment.io integration with sequentials and instructor dashboard pages
2013-07-02 13:49:33 -04:00
Adam Palay
af75e1f785
log student answers using POST instead of GET
2013-07-01 18:21:47 -04:00
Felix Sun
6f6a451784
Working prototype of crowdsourced hinting module.
...
Conflicts:
common/static/coffee/src/logger.coffee
2013-07-01 10:25:03 -04:00
Renzo Lucioni
881d63dae7
Fixed Jasmine tests in light of Logger changes, and wrote test to cover case where data passed is not a dictionary
2013-06-25 16:04:00 -04:00
Renzo Lucioni
84f4361d52
Avoid changing format of data sent to our logs, and prevent problem_check event from firing twice
2013-06-25 15:33:16 -04:00
Renzo Lucioni
bcbce3eff0
Add handful of events to the Segment.io whitelist
2013-06-25 15:33:16 -04:00
Renzo Lucioni
841ff4765f
Abridge tests in light of learning how Segment.io works
2013-06-18 17:58:10 -04:00
Renzo Lucioni
305e9315ef
Write Jasmine tests to prove Segment.io works in Logger
2013-06-18 14:27:43 -04:00
Renzo Lucioni
f528f61ec1
Add new Jasmine test to ensure Segment.io is called when appropriate
2013-06-17 16:18:07 -04:00
Renzo Lucioni
c30d2d2f52
Incorporate Segment.io into Logger.log with whitelist
2013-06-17 13:48:50 -04:00
Your Name
6fb8adaa50
add flagging and unflagging tests to response show view
2013-05-17 09:52:02 -04:00
Your Name
ad5b71deae
format content view test for readability
2013-05-17 09:34:41 -04:00
Your Name
296a878169
add flagging tests to DiscussionContentView
2013-05-17 09:31:12 -04:00
Your Name
ce2308b5bb
add flagging tests to DiscussionContentView
2013-05-17 09:28:12 -04:00
Your Name
82d2b78b96
update jasmine tests
2013-05-16 10:56:58 -04:00
Your Name
90892450b7
failed jasmine tests still failing
2013-05-16 10:56:57 -04:00
Jay Zoldak
cc2cc469fe
more work on jasmine tests for forums
2013-05-16 10:56:57 -04:00
Jay Zoldak
cbdf93473b
start to get the jasmine tests working for comment service
2013-05-16 10:56:57 -04:00
Jay Zoldak
ed3df10638
Set up rake task for jasmine tests for discussion forums code.
2013-05-16 10:56:57 -04:00
Jay Zoldak
ed5ad46192
Revert "Revert "fix merge conflict""
...
This reverts commit 2df3fe9344
2013-05-16 10:29:33 -04:00
Your Name
4b806768ec
more server trial and error
2013-05-16 10:29:33 -04:00
Your Name
8568ce7ad0
server django version generating 1 instead of True so test for both
2013-05-16 10:29:33 -04:00
Kevin Chugh
ab08fa94e4
coffeescript fixes
2013-05-16 10:29:32 -04:00
Jay Zoldak
aa4e29d2f1
Add leanModal vendor src to files.json for cms jasmine tests. Also .gitignore compiled js from coffee specs
2013-04-30 15:22:08 -04:00
Diana Huang
2df3fe9344
Revert "fix merge conflict"
...
This reverts commit acfd0d9fd6e4194c99d8
2013-04-26 12:40:35 -04:00
Your Name
b8114b9eb2
restore accidentally deleted chunk
2013-04-22 16:17:54 -04:00
Your Name
8a02001a4f
minimize diff by restoring function locations
2013-04-22 15:40:19 -04:00
Your Name
385026172e
remove double Comment from merge conflict
2013-04-22 15:28:27 -04:00
Kevin Chugh
bb12cdf6f4
remove whitespace
2013-04-21 19:57:19 -04:00
Kevin Chugh
bee25f3ba0
fix git mangle take 3
2013-04-21 19:51:04 -04:00
