Commit Graph

22102 Commits

Author SHA1 Message Date
Diana Huang
ea8907ca53 Add edx_sga to our code_owners mappings. 2021-01-19 11:23:08 -05:00
Saad Yousaf
93f4ceeee7 Revert "[TNL-7361] - Restrict Instructor Tab from masquerading user with student role." 2021-01-19 20:01:03 +05:00
Syed Muhammad Dawoud Sheraz Ali
985229fb7a add last_login user and staff only field in user_api (#26087)
* add last_login user and staff only field in user_api
2021-01-18 19:36:01 +05:00
Ned Batchelder
e6c7b6fd60 Merge pull request #26080 from open-craft/0x29a/fix_add_post
Fix Markdown errors on discussions tab
2021-01-15 11:45:46 -05:00
Ned Batchelder
15ce0a3fde Merge pull request #25020 from jramnai/registration-api
[ADD]  /user_api endpoints in api-docs
2021-01-15 11:18:05 -05:00
0x29a
c8fc932c45 Preserve js files order for discussions view
Co-authored-by: Shimul Chowdhury <shimul@opencraft.com>
2021-01-15 15:15:08 +01:00
Saad Yousaf
e01c07775c Merge pull request #26052 from edx/saad/TNL-7361
[TNL-7361] - Restrict Instructor Tab from masquerading user with student role.
2021-01-15 13:13:50 +05:00
Jayram
5a9e12dd96 [ADD] user account registration endpoint for api-docs
Added alias for /user_api endpoints

FIX quality violations

IMPROVED urls_common for readability

Removed redundant URL entry from urls_common file
2021-01-15 03:59:16 +00:00
Bianca Severino
2a7fe2a385 Merge pull request #26062 from edx/bseverino/enrollment-api
[MST-570] Create runtime api to return active enrollments by course
2021-01-14 09:56:29 -05:00
Calen Pennington
197c6d11ee Merge pull request #26043 from cpennington/user-profile-segment-identify
Call segment.identify with any changed values when user profile field…
2021-01-14 08:54:21 -05:00
Zach Hancock
3a738e6c02 Create runtime api to return active enrollments by course
Co-authored-by: Bianca Severino <biancasev@gmail.com>
2021-01-13 16:45:40 -05:00
Calen Pennington
0294f28818 Tag some known instances of sailthru specific code that can be removed as part of AA-607 2021-01-13 15:58:55 -05:00
Nizar Mahmoud
a44091e7ec Adds grade cutoffs to gradebook grading information 2021-01-13 14:10:19 -05:00
Ned Batchelder
91d0c43cc8 Slightly clearer (#26060)
Without to_locale, it's not a locale anymore, so don't call it that.
2021-01-13 13:34:30 -05:00
Usama Sadiq
e4b8f56e26 Merge pull request #26031 from edx/djangorestfram-upgrade
Upgrade drf version.
2021-01-13 23:29:42 +05:00
Mahyar Damavand
e66ff41194 Change data-language format to ISO639-1 (#25278) 2021-01-13 12:07:59 -05:00
Calen Pennington
f1a9132308 Fix a flaky test error that happened if the factory generated usernames rolled over from 999 to 1000 2021-01-13 10:40:25 -05:00
Calen Pennington
fdac36ec13 Call segment.identify with any changed values when user profile fields change 2021-01-13 10:40:25 -05:00
Awais Qureshi
b6930adb21 Fixed deprecated warning. 2021-01-13 20:35:14 +05:00
Awais Qureshi
c978e5b204 Upgrade drf version. 2021-01-13 20:35:14 +05:00
Robert Raposa
e0aa459732 Merge pull request #26017 from regisb/regisb/refactor_set_request_cache
[BD-21] Get rid of calls to `set_request_cache_with_short_name`
2021-01-13 09:57:13 -05:00
David Ormsbee
098e047fce Merge pull request #25987 from edx/ormsbee/tnl-7636-xblock-access
Check sequence-level gating in render_xblock (TNL-7636)
2021-01-13 09:35:56 -05:00
Ahtisham Shahid
780deeed7a Merge pull request #217 from edx/ahtisham/PROD-1916-p
Error incase of disabled user social login
2021-01-13 16:24:02 +05:00
SaadYousaf
005a414561 [TNL-7361] - Restrict Instructor Tab from masquerading user with student role. 2021-01-13 15:00:39 +05:00
Saad Yousaf
cf8c0bbec7 Merge pull request #26028 from edx/saad/TNL-7820
[TNL-7820] - remove important rule for links on hover.
2021-01-13 12:02:41 +05:00
David Ormsbee
5f94a082ce Check sequence-level gating in render_xblock (TNL-7636).
There is certain gating logic around pre-reqs, timed exams, etc.
that happen at the SequenceModule level, and should be respected
when rendering descendant XBlocks (like individual problems) that
are in that Sequence. Rather than do a risky refactoring, I'm
keeping that logic where it is and having the render_xblock view
climb up through the ancestor list to call the SequenceModule for
that gating information.

We do _not_ check all descendants (so cousin leaf nodes in the
sequence) for cotent-type-based restrictions because sequences can
become very large (esp. when content libraries are used), and there
is a performance overhead.

If the enclosing sequence is gated in some way, we redirect to the
render_xblock view for that sequence, where hopefully some useful
messaging will be available. This is a stopgap. That redirect
should never happen because we should never be calling the leaf
XBlock for a sequence that is restricted in the MFE. But if somehow
we get there anyway, either by bug or by intrepid user fiddling,
it's better to redirect somewhere that an error _might_ be surfaced
rather than just failing.

This will actually be a little overzealous and lock things down
that should be made visible later. If there's a timed exam and the
exam is completed, it should be the case that content is visible
(just read-only). This commit will block the content before the exam
starts (this is right), open the content while the exam is live
(this is right), but make the content unavailable after the exam
period has finished (this is wrong).

But I am going to go forward with this even knowing it's wrong
because:

1. The render_xblock endpoint should never currently be used in
   timed exams in an intentional way. Neither the mobile experience
   nor the courseware MFE support it.
2. This fix will address security concerns for creative access
   patterns, even if it goes too far.
3. We're going to need to do a lot of work to address both pluggable
   access permissions handling and special exams in the courseware
   MFE, and a better implementation can be done then.
4. I've had multiple failed attempts to get this to work without
   breaking things on and off over the course of weeks, and this
   is a relatively low risk way of doing it that doesn't involve
   a major refactoring (though the bill for that will come due
   when we bring timed exams to the MFE).
2021-01-12 12:57:22 -05:00
Zainab Amir
2e6e360f03 fix login cookie parse issue (#26032) 2021-01-12 22:45:21 +05:00
David Ormsbee
5a149f0fe3 Enable timed/special exams and pre-reqs in devstack.
These are common and useful enough features that it makes sense to
enable it for developers by default.
2021-01-12 11:30:58 -05:00
Régis Behmo
3a29cff016 Get rid of calls to set_request_cache_with_short_name
This method from the toggle legacy classes should not actually be
exposed to all. So we get rid of it by manually setting the cached
value. While we are at it, we convert the STORAGE_BACKING_FOR_CACHE
legacy waffle switch to its modern version. As the flag is not being
used elsewhere, this should not break anything.

We take the opportunity to modernize waffle switches from
block_structure.config: to do so we convert the INVALIDATE_CACHE_ON_PUBLISH and
RAISE_ERROR_WHEN_NOT_FOUND waffle switches from legacy classes to their modern
equivalents. These switches are not used outside of edx-platform, so this
change should not trigger any error.
2021-01-12 16:52:08 +01:00
Nathan Sprenkle
0e194bf517 Add team protection tests for CSV team management (#26019) 2021-01-11 10:42:50 -05:00
Christie Rice
7817c47df1 MICROBA-885 Check whitelisted, even if a grade exists (#26011) 2021-01-11 10:19:16 -05:00
Michael Terry
1c322bbe67 Merge pull request #26008 from edx/mikix/timezone-alerts
Show discount deadline in a timezone-aware way
2021-01-11 08:00:43 -05:00
SaadYousaf
c6a661820f [TNL-7820] - remove important rule for links on hover. 2021-01-11 14:35:53 +05:00
Michael Terry
1482755bbd Show discount deadline in a timezone-aware way
Also, fix it and the access expiration deadline to not hardcode
the date presentation in an American way.
2021-01-08 13:56:18 -05:00
Ali Akbar
0e2d12fc7c Merge pull request #213 from edx/IM/security-fixes-4
Incident Management Security Fixes 4
2021-01-08 21:46:05 +05:00
Saad Yousaf
ba7602476b Merge pull request #26002 from edx/saad/TNL-7877
[TNL-7877] - Cleanup branding app.
2021-01-08 13:58:49 +05:00
alangsto
2a10406924 added logging messages in case of decryption exception (#26007) 2021-01-07 15:12:00 -05:00
Usman Khalid
9e38b17202 Convert ErrorModule and NonStaffErrorModule to XBlocks. (#25570) 2021-01-07 10:51:33 -05:00
Tobias Macey
50bb70298c Added a configuration flag to force third party auth (#24789)
This adds a toggle to allow operators to prevent user registration and login via username/password authentication, forcing the platform to only support login and registration using third-party auth such as SAML.

Co-authored-by: Umar Asghar <mrumarasghar@gmail.com>
2021-01-07 09:55:27 -05:00
Muhammad Soban Javed
f62b1c417b replaced task decorator with shared_task decorator (#25925) 2021-01-07 19:46:34 +05:00
alangsto
e9dc5baf79 added two endpoints for IDV decryption on stage (#25939)
simplified public keys

made migration

fixes for quality

added pylint fixes

fixed for pylint

added endpoint to retrieve user's receipt_ids

added tests for 404 with decryption error

fixed for quality

fixed for quality

updates for feedback

removed unnecessary method

fixed quality issue

updated tests
2021-01-07 09:05:33 -05:00
Ali-D-Akbar
8f4ac5c112 disable xsslint 2021-01-07 16:40:10 +05:00
SaadYousaf
d0d3dc84be cleanup branding app. 2021-01-07 15:01:44 +05:00
Carla Duarte
492ce7f217 Merge pull request #25975 from edx/ciduarte/AA-545
AA-545: Include has_scheduled_content in StartDateTransformer
2021-01-06 15:09:48 -05:00
Ahtisham Shahid
b2466c8c2b Error incase of disabled user social login
Updated status code and manage user func

update auth verification

Fixed auth condition

fixed test failuers

fixed style issues

fixed style issues

Created test for auth disabled use

Code refactor

Fixed form ain auth exchange

Fixed oauth apps with disabled user fail

applied quality fixes

Refactored tests

fixed quality issues

removed extra files

Fixed linter issues

Fixed linter issues
2021-01-06 20:37:01 +05:00
Dillon Dumesnil
6e2da06e46 Merge pull request #25986 from edx/ddumesnil/aa-501
AA-501: Use hidden blocks to determine past due status
2021-01-06 06:49:32 -08:00
Dillon Dumesnil
e17e691d54 AA-501: Use hidden blocks to determine past due status
Blocks that were hidden by access checks would not be used when
calculating past due status for a unit. This adds in a check to
still look at those blocks, but will maintain not rendering them
when being accessed via the MFE
2021-01-06 14:11:03 +00:00
Peter Pinch
285ec771bf fix: Remove CAS settings (#25330)
part of DEPR-6
2021-01-06 08:15:35 -05:00
azanbinzahid
cd1d07b081 PROD-2210 2021-01-06 11:36:36 +05:00
azanbinzahid
6c514eb9dc PROD-2200 2021-01-06 11:36:36 +05:00