Commit Graph

345 Commits

Author SHA1 Message Date
Renzo Lucioni
835c9cc957 Prevent dumpdata from dumping api_admin's Catalog model
The Catalog model is unmanaged, meaning no corresponding table exists in the database. When dumpdata tries to dump this model, it chokes because there's no table to read from.
2016-06-01 14:21:00 -04:00
Robert Raposa
ff862612da Fix false positives on javascript_contact_html. 2016-05-27 13:23:54 -04:00
Calen Pennington
2aa9967189 Merge pull request #12386 from cpennington/cale/concurrent-unit-tests
[EV-12] Run LMS unit tests concurrently on jenkins
2016-05-19 14:25:24 -04:00
Robert Raposa
94adf7fb74 Merge pull request #12490 from edx/robrap/linter-mako
TNL-4566: Lint Mako templates outside of expressions
2016-05-18 16:17:10 -04:00
Robert Raposa
cf3ef8aae3 Enhance safe template linter.
- Lint directories and files in sorted order.
- Lint python blocks in Mako.
2016-05-18 14:23:57 -04:00
Calen Pennington
09dc884c38 Isolate databases between test processes 2016-05-18 14:10:28 -04:00
Andy Armstrong
a7e754dd9a Exclude deleted files from safe template linting 2016-05-18 12:52:21 -04:00
Christine Lytwynec
73806beeec Merge pull request #12478 from edx/clytwynec/ac-367
Add skip_clean option to pa11ycrawler
2016-05-17 09:05:21 -04:00
Christine Lytwynec
0f90b92775 Add skip_clean option to pa11ycrawler 2016-05-16 11:12:03 -04:00
Robert Raposa
06505c45ba Update thresholds. 2016-05-13 15:12:55 -04:00
Robert Raposa
143a22fb9f Enhance Jenkins integration of safe templates take 2
- Handle case when no files are linted
- Skip deleted files for safe commit script
- Add verbose options for safe commit
2016-05-13 09:59:23 -04:00
Christine Lytwynec
510eaa3c95 Merge pull request #12423 from edx/clytwynec/ac-367
Speed up pa11ycrawler runs on Jenkins, Update pa11ycrawler to v0.0.2
2016-05-12 13:16:19 -04:00
Christine Lytwynec
f68747ec96 Speed up pa11ycrawler runs on Jenkins, Update pa11ycrawler to v0.0.2 2016-05-12 11:33:58 -04:00
Robert Raposa
5ea529ae39 Revert: Enhance Jenkins integration of safe template linting 2016-05-11 09:56:23 -04:00
Robert Raposa
afdec6a99b Enhance Jenkins integration of safe template linting
- Add rule based thresholds
- Add safecommit to Jenkins
2016-05-10 15:50:45 -04:00
Robert Raposa
73966d1a05 Add output of violation counts by rule 2016-05-10 15:35:57 -04:00
Calen Pennington
ccaafce05b Merge pull request #12205 from cpennington/disable-caching-in-tests
Disable caching in LMS tests
2016-05-06 15:22:48 -04:00
Jesse Zoldak
d7e9db66c9 Lower the jshint threshold to 7550 2016-05-06 09:56:23 -04:00
Calen Pennington
e87a8a0de3 Make tests run in verbose mode 2016-05-04 14:51:31 -04:00
Robert Raposa
60d11bf2fd Fix Python false positives with AST.
- Use AST to parse Python.
- Refactor Mako to use Python linting.
- Add optional verbose script argument.
- Skip tests.py files when linting.
2016-05-03 15:17:09 -04:00
Robert Raposa
fb13dc6499 Move MakoLinter. 2016-05-02 05:04:51 -04:00
Robert Raposa
1dfe0e8a4e Merge pull request #12254 from edx/robrap/linter-javascript-context
TNL-4427: Add additional JavaScript context tags
2016-04-28 18:00:20 -04:00
Robert Raposa
17a920b3a6 Merge pull request #12246 from edx/robrap/safe-commit
TNL-4317: Add helper for checking git commit is safe
2016-04-28 16:54:38 -04:00
Robert Raposa
b67c133910 Add additional JavaScript context tags 2016-04-28 12:16:10 -04:00
Robert Raposa
ac935e02a6 Add script for checking git commit is safe 2016-04-28 10:52:43 -04:00
Ben Patterson
ddbd7f9174 Designate 4th shard. 2016-04-28 10:09:32 -04:00
Robert Raposa
374dcb3264 Add Python linting 2016-04-27 17:40:30 -04:00
Robert Raposa
ec442789c0 Add Jenkins support for Safe Templates Linter 2016-04-26 12:36:25 -04:00
Ben Patterson
45c2976180 Use custom firefox path for bok-choy tests (firefox 42)
This is a backwards-compatible window for this upgrade. It will
later be replaced with using the default location (whatever's on
PATH)
2016-04-24 08:32:33 -04:00
Christine Lytwynec
66e2d06235 Merge pull request #12060 from edx/clytwynec/ac-367
Clytwynec/ac 367
2016-04-22 09:49:26 -04:00
Robert Raposa
d1bda204e4 Enhance Mako linting
- Lint JavaScript context for JavaScript violations
- Lint for Mako specific JavaScript rules
- Skip commented lines
- Change unicode to decode.utf8
- Count lint violations
2016-04-21 01:23:50 -04:00
Robert Raposa
11982461aa Add JavaScript linting rules
- check proper use of JQuery functions
- check for concatenation with HTML strings
- add sort for output
- lint CoffeeScript
2016-04-20 16:29:55 -04:00
Robert Raposa
14abf32b4b Add check for HTML entities 2016-04-16 15:24:56 +00:00
Robert Raposa
70a64aee2b Fix code review comment 2016-04-12 16:34:00 -04:00
Robert Raposa
b5a674d941 Fix parsing defect 2016-04-12 15:20:24 -04:00
Robert Raposa
f9ab191c33 Fix mako-wrap-html
- Make mako-wrap-html fire when '<' found anywhere in unwrapped string
- Fix typo
- Fix quality errors
- Fix defect found when Python string broken over lines
2016-04-12 13:06:11 -04:00
Robert Raposa
46c113ce60 Add check for strings that should be wrapped with HTML()
Also include the following:
- new rule for strings that should be wrapped with HTML()
- allow expressions to use "| n, unicode"
- refactor string parsing into separate class
- switch end_index to be the index following the expression
2016-04-12 10:48:33 -04:00
Christine Lytwynec
a14718bb92 Add pa11ycrawler command 2016-04-11 15:47:26 -04:00
Robert Raposa
96fe8afbde Enhance linter for HTML() and Text()
- Add capability to run linter on file or directory
- Add rule for HTML() requiring Text()
- Add rule for HTML() and Text() being closed before format()
- Add rule for Text() unnecessary without HTML()
- Enhance expression parsing
- Add real arg parser for script
- Clean up unit tests
2016-04-11 13:56:35 -04:00
Ned Batchelder
fac216c35b Lower the overall pylint count to 4175 2016-04-08 12:05:38 -04:00
Robert Raposa
a6ac06f210 Remove outdated safe template recommendations
- Remove <%include> linting
- Remove dump_html_escaped_json
2016-04-06 14:57:48 -04:00
Robert Raposa
916723fcaa Enhance safe template linter
- Check includes for Mako templates
- Check display_name_with_default_escaped uses
- Add exceptions for Underscore and <%=
- Skip templates that are Django and not Mako
- Add pragma to disable errors
- Enhance unit tests
- Remove violation mako-js-string-missing-quotes
- Refactor line processing into StringLines
2016-03-30 14:16:51 -04:00
Ben Patterson
161b8f94e1 Merge pull request #11950 from open-craft/omar/reset-test-db
Fail fast if the reset-test-db script fails
2016-03-26 12:33:00 -04:00
Omar Khan
7810131457 Fail fast if the reset-test-db script fails 2016-03-25 19:04:29 +07:00
Robert Raposa
0707e0dd73 Add check for multiple page tags 2016-03-24 16:40:11 -04:00
Eric Fischer
7cfa0fa111 Safe template linter should use DOTALL
MULTILINE has to do with how '^' and '$' behave, DOTALL will make the
'.' match newlines as well. This catches several failures that were
previously missed.
2016-03-23 15:59:29 -04:00
Peter Fogg
6661063b5a Minor fixes to the safe template linter. 2016-03-23 11:38:45 -04:00
Robert Raposa
f150fd9b3a Merge pull request #11800 from edx/robrap/safe-template-linter
TNL-4214: Add safe template linter
2016-03-22 10:40:29 -04:00
Robert Raposa
52efa68b8b Change to output as you go 2016-03-21 22:51:15 -04:00
Robert Raposa
0538dea994 Fix review comments
Changes include:
- Fix code review comments
- Add comments
- Rename variables and files
2016-03-21 22:31:57 -04:00