Commit Graph

11 Commits

Author SHA1 Message Date
Feanil Patel
3cd9b8c41a Update ownership mappings.
Add mapping from django apps to repos so we can look up owners by this repo
in the ownership mapping.
2020-11-13 12:05:14 -05:00
Robert Raposa
eea711e5a4 ARCHBOM-1551: update generate_code_owner_mappings.py (#25309)
update generate_code_owner_mappings.py:

* Uses updated 'owner.theme' and 'owner.squad' columns.
* Outputs new CODE_OWNER_THEMES to detail themes.
* Output lowercase names only

ARCHBOM-1551

Co-authored-by: Tim McCormack <tmccormack@edx.org>
2020-10-14 09:34:01 -04:00
Tim McCormack
f29e418264 Revert "Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils (#25010)" (#25025)" (#25055)
This reverts commit 986a448d9e.
2020-09-28 13:53:57 +00:00
Ahtisham Shahid
986a448d9e Revert "ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils (#25010)" (#25025)
This reverts commit ba9ee4e151.

Fixed Style lint issue
2020-09-21 13:48:00 +05:00
Tim McCormack
ba9ee4e151 ARCHBOM-1494: Refer to custom attributes, not metrics, especially with edx-django-utils (#25010)
This uses the new names introduced in edx-django-utils
3.8.0 (edx/edx-django-utils#59), which we're already using, as
well as updating a few other locations where we incorrectly refer
to New Relic custom metrics instead of custom attributes.

Includes a couple of unrelated lint fixes in a file I modified.
2020-09-18 13:33:50 +00:00
Robert Raposa
ef51a44794 move CodeOwnerMetricMiddleware from LMS (#24508)
The CodeOwnerMetricMiddleware is being moved from
edx-platform to edx-django-utils so it can be used
in multiple IDAs.

ARCHBOM-1356
2020-07-17 11:35:40 -04:00
Robert Raposa
7e56d89bcc remove temp_view_func_compare custom metric (#24211)
In an earlier PR, we moved logic from process_view to process
request, so mapping would happen earlier in the middleware
lifecycle, and the code_owner metric would be set for requests
that never made it to process_view.

The temp_view_func_compare custom metric was added temporarily to
ensure this earlier refactor did not introduce any unaccounted for
differences. It did not, so we are removing this temporary metric.

ARCHBOM-1263
2020-06-12 08:53:20 -04:00
Robert Raposa
b721e186f3 ARCHBOM-1263: enhance code owner middleware (#24184)
* conservative move to process_request
* added temp_view_func_compare metric to be extra conservative

ARCHBOM-1263
2020-06-10 10:36:13 -04:00
Robert Raposa
4d30876d06 ARCHBOM-1263: refactor ownership mapping from middleware (#24175)
- move ownership mapping code to separate module
- simplify `__module__` mocking.

ARCHBOM-1263
2020-06-09 09:59:37 -04:00
Robert Raposa
03032d4979 ARCHBOM-1247: ownership mapping for external apps (#24148)
- add clean script to help list unmapped Django apps.
- use clean script to source new app mappings.
- update generate script to include 3rd-party app ownership.

ARCHBOM-1247
2020-06-09 09:15:16 -04:00
Robert Raposa
59e0f6efcf ARCHBOM-1244: Add code_owner custom metric (#24084)
* includes ADR for Monitoring by Code Owner
* add monitoring middleware to add the following custom metrics:
- code_owner: The owning team mapped to the current view.
- code_owner_mapping_error: If there are any errors when trying to
        perform the mapping.
- view_func_module: The __module__ of the view_func, which can
        be used to find missing mappings.
* add script to generate `settings.CODE_OWNER_MAPPINGS` from
     a csv file.

ARCHBOM-1244
2020-06-01 12:27:38 -04:00