Commit Graph

1303 Commits

Author SHA1 Message Date
Peter Fogg
871ab87bf2 Fix saving notification CSS. 2013-07-12 09:01:03 -04:00
Peter Fogg
8b13ff3dff Merge pull request #376 from edx/peter-fogg/rename-notification-save
Rename CMS.Views.Notification.Saving to Mini.
2013-07-11 14:25:44 -07:00
Peter Fogg
5b4524d75e Merge pull request #301 from edx/peter-fogg/explicit-course-settings
Peter fogg/explicit course settings
2013-07-11 14:09:07 -07:00
Peter Fogg
42ff1c2237 Merge pull request #366 from edx/peter-fogg/stud-116
Use new feedback notification when changing section release dates.
2013-07-11 13:34:07 -07:00
Peter Fogg
6e94960488 Fix many validation bugs and failing tests. 2013-07-11 16:09:59 -04:00
Peter Fogg
c2f0b7d4e9 Fix validation in many cases, and ensure that the notification bar pops up correctly. 2013-07-11 15:53:51 -04:00
Peter Fogg
7c9648babd Hide saving notification only when AJAX request completes. 2013-07-11 13:27:15 -04:00
Peter Fogg
9c8f63726f Rename CMS.Views.Notification.Saving to Mini, in line with its more diverse modern usage. 2013-07-11 13:13:08 -04:00
Peter Fogg
f3837009af Remove ellipsis from internationalized notifications. 2013-07-11 11:26:17 -04:00
Peter Fogg
ec13349ae3 Remove outdated deleteKeys from advanced settings. 2013-07-11 09:11:59 -04:00
Peter Fogg
3d4f9268da Make sure that changing grading cutoffs triggers a save confirmation, and reliable reverting of changes. 2013-07-11 09:11:59 -04:00
Peter Fogg
9094f1890b Change course settings to require explicit save.
Rather than asynchronously saving when a setting is updated, we now
prompt the user to confirm their changes and only persist the data if
they hit the save button. Lettuce tests are updated to expect this
behavior and some new ones are added.
2013-07-11 09:11:07 -04:00
Peter Fogg
164a469e9d Factor showNotificationBar out into ValidatingView.
When all settings require an explicit save, this functionality will be
shared between each view (with slight changes, e.g. click handlers.)
2013-07-11 09:11:07 -04:00
Peter Fogg
975e28e9dc Remove undefined variable. 2013-07-10 16:31:43 -04:00
Peter Fogg
66b73c861f Use new feedback notification when changing section release dates. 2013-07-10 16:07:25 -04:00
David Baumgold
18474986f3 Removed deprecated mixins from _textbooks.scss 2013-07-10 13:00:07 -04:00
Frances Botsford
a0962cc3b9 updated sass transitions to use newer bourbon syntax 2013-07-10 09:18:00 -04:00
Brian Talbot
a09866a48f Studio: refining timing variable comment in Sass 2013-07-10 09:18:00 -04:00
Brian Talbot
c10fc54509 Studio: abstracts and formalizes set animation/transition Sass variables 2013-07-10 09:17:59 -04:00
Brian Talbot
d046fdf743 resolves local Sass warnings/errors around missing mixins referenced in xmodule styling 2013-07-10 09:17:59 -04:00
Brian Talbot
b97c1bf5e3 Studio: corrects Sass @extend references 2013-07-10 09:17:59 -04:00
Brian Talbot
41d9fa3785 Studio: syncs up syntax, ordering, and timing for all Sass transition mixins 2013-07-10 09:17:59 -04:00
Brian Talbot
ed93fcb89a Studio: adds back in transform-origin prop to dropdown nav icons 2013-07-10 09:17:59 -04:00
Brian Talbot
ee481dfdb5 Studio: resolves notification animation placement error 2013-07-10 09:17:59 -04:00
Brian Talbot
f708c42ec6 Studio: revises anim syntax, adds utility anims, and revises rotate transitions for nav 2013-07-10 09:17:59 -04:00
Brian Talbot
4a0a067327 Studio: revises syntax of calling preset animations for notifications 2013-07-10 09:17:59 -04:00
Brian Talbot
b42074716b Studio: updates keyframes/animations syntax for all animations 2013-07-10 09:17:58 -04:00
David Baumgold
5bd79a8669 Changed @include box-shadow() to box-shadow
Bourbon's box-shadow mixin has been deprecated, and they recommend to use the
official spec.
2013-07-10 09:17:58 -04:00
David Baumgold
41374838cb Changed @include border-radius() to border-radius
The official border-radius mixins were deprecated and removed in Bourbon 3.0.
https://github.com/thoughtbot/bourbon/pull/95
2013-07-10 09:17:58 -04:00
Brian Talbot
cef33bf285 Studio: updates shame file with related future maintenance work 2013-07-09 19:16:44 -04:00
Frances Botsford
6814163a45 cleanup and tweaks from feeback to PDF Textbooks FED and Sass 2013-07-09 19:16:44 -04:00
David Baumgold
1a0d6d21bb Forgot to call show() on saving notification 2013-07-09 19:16:43 -04:00
David Baumgold
8d809dbad6 Remove commented-out code 2013-07-09 19:16:43 -04:00
David Baumgold
cfa094e424 Validation tests for Backbone models 2013-07-09 19:16:43 -04:00
David Baumgold
eba5928009 Added a comment 2013-07-09 19:16:43 -04:00
David Baumgold
fe8587566f All textbook chapters must have name and asset_path
Previously, for a textbook with only one chapter, we allowed that chapter to
not have a title -- under the assumption that it would be shown as a monolithic
textbook, instead of a chaptered textbook. However, the UI doesn't support that
idea, the code was getting a bit messy, and there was no real benefit to the idea
of not having to specify a chapter title. This commit removes that special case,
and ensures that all textbook chapters must have a name and an asset path.
2013-07-09 19:16:43 -04:00
David Baumgold
f9a10855d9 Add notes about JS validation functions returning non-i18n error messages 2013-07-09 19:16:42 -04:00
David Baumgold
fa62f48e57 Fix Jasmine test failures 2013-07-09 19:16:11 -04:00
David Baumgold
e7088d50fd Display error message when trying to upload a non-PDF file as a PDF textbook 2013-07-09 19:16:11 -04:00
David Baumgold
7506562f50 Another lettuce test, and fixes to make it work 2013-07-09 19:16:11 -04:00
David Baumgold
ca2339f15e Remove unneeded arguments
They are the defaults now
2013-07-09 19:16:10 -04:00
Frances Botsford
b41d23747a PDF Textbooks: implemented "View Live" link 2013-07-09 19:16:09 -04:00
David Baumgold
2a92a14054 Wrote simple lettuce tests for pdf textbooks 2013-07-09 19:16:09 -04:00
Frances Botsford
1b945dd6e8 changes to textbook upload buttons, success message and styling 2013-07-09 19:16:09 -04:00
David Baumgold
2b9ed46440 Save chapter information more frequently 2013-07-09 19:16:09 -04:00
David Baumgold
11c5c14998 Add error class to invalid fields on PDF textbooks form 2013-07-09 19:16:09 -04:00
Frances Botsford
2321a2c563 more updates to PDF textbook UI 2013-07-09 19:16:09 -04:00
David Baumgold
a608d8a38d PDF Textbooks: handle model deletion
Previously, when a model was deleted, the entire collection would save itself
to the server again. Now, we just call model.destroy(), which doesn't affect
other models.
2013-07-09 19:16:08 -04:00
David Baumgold
8f2077b579 Test for Textbook.reset method 2013-07-09 19:16:08 -04:00
David Baumgold
70a011770e Show a warning if the user tries to leave the page with unsaved textbook changes 2013-07-09 19:16:08 -04:00