Commit Graph

5284 Commits

Author SHA1 Message Date
Usama Sadiq
23659d5ba8 Revert "feat!: upgrade Django version to 4.2 (LTS) (#34162)" (#34165)
This reverts commit 1fc2e8a771.
2024-02-01 19:29:56 +05:00
Muhammad Soban Javed
1fc2e8a771 feat!: upgrade Django version to 4.2 (LTS) (#34162)
* feat!: upgrade Django version to 4.2 (LTS)
---------

Co-authored-by: iamsobanjaved <iamsobanjaved@users.noreply.github.com>
2024-02-01 16:10:34 +05:00
ayesha waris
9f136a4149 feat: added notifications when response is endorsed or answered (#34082)
* feat: added notification when response is endorsed or answered

* test: added and fixed test cases

* fix: fixed lint errors

* refactor: changed method name for readibility

* feat: added notification when my response is endorsed

* test: fixed failed test cases
2024-02-01 13:33:16 +05:00
Deborah Kaplan
33cd62e68c Merge pull request #34129 from openedx/dkaplan1/APER-3146_investigate-fix-exception-handling-in-program-cert-revocation
feat: fix exception handling in program cert revocation
2024-01-31 13:59:20 -05:00
Muhammad Soban Javed
790e364097 Revert "chore!: upgrade Django version to 4.2 (LTS)" 2024-01-31 17:14:43 +05:00
Awais Qureshi
82edbc635c Merge branch 'master' into iamsobanjaved/django-42-lts 2024-01-31 13:46:58 +05:00
Deborah Kaplan
b75f8b0ed1 feat: tweaks from code review
wording, switching to using a constant, fixing a string concat

FIXES: APER-3146
2024-01-30 21:34:56 +00:00
Adolfo R. Brandes
cbe865a77f Merge pull request #34036 from raccoongang/ruzniaievdm/feat/unit-page-drf
feat: [FC-0044] Unit page API as DRF
2024-01-30 19:23:12 +00:00
Deborah Kaplan
f7a9efbf6b feat: lint
autoformat errors

FIXES: APER-3146
2024-01-30 18:59:13 +00:00
Deborah Kaplan
adae7e3e25 feat: relinting
Trying with new autoformat settings.

FIXES: APER-3146
2024-01-30 17:39:57 +00:00
Deborah Kaplan
bde84117c3 feat: linting error
* unused import
* format

FIXES: APER-3146
2024-01-30 16:36:14 +00:00
Deborah Kaplan
02baf07a03 Merge branch 'master' into dkaplan1/APER-3146_investigate-fix-exception-handling-in-program-cert-revocation 2024-01-30 10:56:16 -05:00
Deborah Kaplan
918f32ab40 feat: fixed one test
* fixed one test to accommodate a slightly modified workflow
* allowed the automated linter  to match current standards

Note:  as part of this process, I realized a lot of the tests in `programs/tests/test_tasks.py` are somewhat problematic. Some aren't real unit tests (allow calls to something other than the system under test), at least one for that reason it won't run on local at all, and some mock the wrong part of the system  or just don't match current flow.  I'm not modifying them as part of this, but they should be looked at.

FIXES: APER-3146
2024-01-30 15:53:29 +00:00
Awais Qureshi
79f1c66553 Merge branch 'master' into iamsobanjaved/django-42-lts 2024-01-30 12:53:33 +05:00
Ahtisham Shahid
039583f88f feat: added reported notification type (#34067) 2024-01-30 12:07:49 +05:00
Syed Sajjad Hussain Shah
cb2a34e51f feat: logout other sessions on email change (#33846)
* feat: logout other sessions on email change

* fix: updated the approach for session invalidation

* fix: update and add tests

* fix: update tests with descriptive comments

* feat: add integration tests

* fix: store email in session update

* fix: add setting for tests

* fix: fix tests

* feat: Upgrade Python dependency edx-drf-extensions (#34135)

Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`

Co-authored-by: syedsajjadkazmii <syedsajjadkazmii@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: syedsajjadkazmii <syedsajjadkazmii@users.noreply.github.com>
2024-01-29 14:43:51 +05:00
Saad Yousaf
928e810b33 Revert "temp: add temporary logs for course wide notifications" 2024-01-29 12:42:39 +05:00
Deborah Kaplan
ae3ce9c498 feat: fix exception handling in program cert revocation
To determine whether or not we need to  revoke any program certificates, we first run get_revokable_program_uuids. This calls get_certified_programs, which calls get_credentials, which uses the OpenEdx Core  utility method get_api_data. get_api_data makes the API call inside a try block, does raise_for_status  also inside the try block, and then catches the exception, logs it, and returns an empty result to the caller.

This means that on a failure to call the credentials API, get_credentials can’t  tell the difference between a failure to hit the API (because credentials is, as it sometimes is during a notify_programs run, overloaded), or a learner with no program certificates. In this particular case, this is absolute failure, incorrect behavior.

* Adds a new flag, `raise_on_error`  which will make `get_api_data` log the exception and then re-raise the HTTPError,  defaulting to false in order to avoid changing the behavior on any other callers
* Also: my editor reformatted all of the touched files to our modern code standards, and it seemed appropriate to let it do that.
* Also: added type hints in some cases, because they helped me write the code and debug. Our test suite definitely  reports mypy  results on type errors so we are verifying that hints are correct.

FIXES: APER-3146
2024-01-26 22:20:30 +00:00
Chris Chávez
5838d68efc feat: Tagging UX refinements - refresh tag count on edit (#34059)
* style: drawer-cover color updated for all tagging drawers
* feat: Update TagList component when a tag is updated on Manage tags drawer
* feat: Refactor TagCount to be able to refresh the count
* feat: Sync tag count in units
2024-01-25 10:33:47 -08:00
Jillian
7535f9d581 feat: tagging: serialize object permissions to REST API (#34004) 2024-01-25 10:12:17 -08:00
Muhammad Soban Javed
67d53dce26 chore!: upgrade Django version to 4.2 (LTS)
This reverts commit 6f32d0e6f1.
2024-01-25 18:17:43 +05:00
Justin Hynes
426ee163bc revert: add brand_color variable for the email templates (#33421)"
This reverts commit 4ec70eb98b.

This commit introduced a new setting (`brand_color`) that does not appear to be set and is causing issues with account deletion and other parts of the courseware.

Reverting until we can understand the change better.
2024-01-24 18:47:02 +00:00
Yusuf Musleh
2323b3b21a feat: Add lang auto tagging for v2 library blocks (#34056) 2024-01-23 10:00:40 -08:00
Muhammad Soban Javed
6f32d0e6f1 Revert "chore!: upgrade Django version to 4.2 (LTS)" (#34095) 2024-01-23 19:07:53 +05:00
Muhammad Soban Javed
fc8e40fb10 chore!: upgrade Django version to 4.2 (LTS) (#33969)
* chore!: upgrade Django version to 4.2 (LTS)

* feat: Upgrade Python dependency Django

chore!: upgrade Django version to 4.2

Commit generated by workflow `openedx/edx-platform/.github/workflows/upgrade-one-python-dependency.yml@refs/heads/master`

* chore: Update common.py

* chore: Update common.py

---------

Co-authored-by: Muhammad Soban Javed <iamsobanjaved@gmai.com>
Co-authored-by: iamsobanjaved <iamsobanjaved@users.noreply.github.com>
Co-authored-by: Awais Qureshi <awais.qureshi@arbisoft.com>
2024-01-23 16:53:34 +05:00
bydawen
4ec70eb98b feat: add brand_color variable for the email templates (#33421)
* feat: add brand_color variable for the email templates

* test: fix tests assertations

---------

Co-authored-by: Eugene Dyudyunov <evgen.dyudyunov@raccoongang.com>
2024-01-23 13:21:06 +05:00
Justin Hynes
ee380b7563 feat: Use built-in retry features of Celery when retrying Credentials grading tasks 2024-01-22 18:09:44 +00:00
Kyle D. McCormick
ef0fc97a2d fix: in generate_block_key, get the usage key's block_id, not usage_id
UsageKeys don't have a usage_id field. This line would have crashed
if run.
2024-01-16 09:37:40 -05:00
Kyle D. McCormick
e8b60aef60 fix: move BlockKey and derived_key to avoid cyclical import
After we merged this PR: https://github.com/openedx/edx-platform/pull/33920
this error began popping up in logs:

    Unable to load XBlock 'staffgradedxblock'
    ....
    ImportError: cannot import name 'get_course_blocks' from
    partially initialized module 'lms.djangoapps.course_blocks.api'
    (most likely due to a circular import) ...

The root cause was the new imports of `derived_key` and `BlockKey` into
xmodule/library_content_block.py. Those new imports come from
xmodule/modulestore/store_utilities.py, which runs
`XBlock.load_classes()` at the module level, which fails because we are
still in the process of loading xmodule/library_content_block.

As a solution, we move both `derived_key` and `BlockKey` to
xmodule/util/keys.py. We could potentially move that file to opaque-keys
eventually, depending on how well we think that those concepts generalize.

Also:

* We rename the function from derived_key to derive_key, as
  functions should be verbs.
* We combine the first to parameters of derive_key (a source ContextKey
  and a source BlockKey) into a single parameter (a source UsageKey). In
  my opinion, this makes the function call easier to understand.
2024-01-16 09:37:40 -05:00
Lewis M. Kabui
780e908bbb fix: Replace deprecated .warn method with .warning (#34057)
The `logging.Logger.warn` method has been deprecated since Python 3.3
and is due to be removed all together in Python 3.13. See
https://github.com/python/cpython/pull/105377

`logging.Logger.warning` is the preferred and recommended way to log
warnings.

Fixes https://github.com/openedx/public-engineering/issues/149

Co-authored-by: Lewis M. Kabui <lewisemm@users.noreply.github.com>
2024-01-16 14:27:06 +05:00
Chris Chávez
90879d167f feat: Tag count in components on Studio Unit page(#33928) 2024-01-12 09:35:23 -08:00
Feanil Patel
e7fc0c6b6f Merge pull request #33698 from Zeit-Labs/i18n-service-oep58
feat: `atlas pull` for XBlock translations | FC-0012
2024-01-12 09:50:15 -05:00
ayesha waris
2fd1f7bd90 chore: removed enable_course_live and enable_big_blue_button flag flags (#33998)
* chore: removed enable_course_live flag

* chore: removed enable_big_blue_button flag

* fix: fixing failed test cases
2024-01-12 15:24:46 +05:00
ayesha waris
53270f17b3 chore: removed and merged multiple flags into enable_discussions_mfe flag (#33983) 2024-01-12 15:07:00 +05:00
Omar Al-Ithawi
a5251cc705 feat: atlas pull for XBlock translations 2024-01-12 12:49:46 +03:00
Attiya Ishaque
5b06de4b97 feat: add work experience field. (#34034) 2024-01-11 15:53:31 +05:00
ruzniaievdm
ff8d3eae72 feat: Unit page API as DRF 2024-01-10 11:53:36 +02:00
Ahtisham Shahid
2eabfe10c0 fix: remove sender id from audiance (#34005)
fix: resolved linter errors
2024-01-10 14:52:16 +05:00
Yusuf Musleh
8d2ddd73ec feat: Add tags count for v2 library components (#33979) 2024-01-09 10:23:30 -08:00
Ahtisham Shahid
c2383fa0b5 feat: Show notification types with respect to user form roles (#33927) 2024-01-02 15:09:50 +05:00
SaadYousaf
8a9e19ad8f temp: add temporary logs for course wide notifications 2023-12-29 16:53:39 +05:00
SaadYousaf
2d353f5594 feat: move new forum content creation notifications to use course wide notification event 2023-12-20 14:25:00 +05:00
Ahtisham Shahid
c287e0a8a8 fix: do not show legacy in case openedx discussion provider is selected (#33906)
* fix: do not show legacy in case openedx discussion provider is selected
2023-12-19 13:18:57 +05:00
connorhaugh
2eac2ef638 feat: keep learner state associated after libraries migration (#33920)
* fix: preserve learner state after v2 migration

Co-authored-by: Kyle McCormick <kyle@axim.org>

---------

Co-authored-by: Kyle McCormick <kyle@axim.org>
2023-12-18 15:14:28 -05:00
Yusuf Musleh
9e14fa4ac3 feat: Add ability to get unassigned taxonomies (#33945)
This adds a query param to fetch unassigned taxonomies, i.e. taxonomies
that do not belong to any org.
2023-12-18 11:28:04 -08:00
Braden MacDonald
5ab6238243 fix: handle paste of library content blocks correctly (#33926) 2023-12-18 09:48:46 -08:00
Feanil Patel
5ec8737856 chore: Remove old datadog related settings.
Datadog was removed 6+ years ago but some settings and related keys got
left behind.  Get rid of them since we don't need them and also to
prevent people from assuming it's okay to hardcode datadog settings into
our codebase.
2023-12-14 12:17:37 -05:00
Diana Huang
c6485d1d27 feat: renamed DeprecatedRestApiClient from EdxRestApiClient (#33916)
* feat: renamed DeprecatedRestApiClient from EdxRestApiClient

* chore: Updating Python Requirements (#33917)

* fix: Put slumber in the proper alphabetical order.

---------

Co-authored-by: Yagnesh <yagnesh.nayi@manprax.com>
Co-authored-by: edX requirements bot <49161187+edx-requirements-bot@users.noreply.github.com>
2023-12-12 13:32:09 -05:00
Robert Raposa
431b9dec15 docs: update ADR for USE-JWT-COOKIE replacement (#33680)
Since a part of this ADR details the USE-JWT-COOKIE
header which has been removed, this ADR was updated
with links to the newer ADR.

The status will remain accepted.

A change history was also added for this change,
as well as documenting some past changes.
2023-12-12 12:06:26 -05:00
Erica Nwoga
a74f510f71 feat: post handler for agreements api (#33488) 2023-12-11 13:58:35 -05:00