Clean up fixtures automatically between tests
- Nesting test fixture markup within a DIV allows Jasmine to
automatically restore the fixture to a clean state between each test
run.
Fix id attribute collision typo
- This looks like a copy/pasta gone wrong; the two test INPUT elements
were both declared with the same id, `input_1`.
Remove trailing whitespace
The behavior previously tested here was to check that if a JSInput
element was marked as not processed, re-walking the DOM *should* have
reinitialized it. Unfortunately, this behavior is not supported by the
underlying JSChannel library. In fact, if JSChannel detects an existing
channel with the same origin and scope, it throws an uncaught exception,
leaving the DOM in a "broken" state.
JSInput will prevent duplicates from being added, as long as we don't
manually update the `data-processed` attribute. This behavior is already
being tested.
Select DOM elements with wildcard syntax
- DOM lookups were being done with non-existent literal selectors, so it
was returning empty lists. As assertions were to be made while
iterating over the list of elements, nothing was actually being
verified.
- Common code has been centralized in the setup function. By declaring
CSS selectors once, we minimize the odds of inadvertently using the
wrong selector, as happened here.
- Had these tests actually been iterating over a non-empty list, this
would have thrown undefined exceptions. jQuery.each calls its handler
with an index and an item/object as the arguments. However, the object
is a DOM-object, not a jQuery-object. These tests break, as they had
assumed the latter.
This test currently fails, meaning that the existing tests weren't
testing what they claimed.
Assertions are made for each element returned by the CSS selectors.
However, the selectors are assumed to be wildcard matches, but are
actually literal selectors. As there are no matched elements, this
causes the assertions to be (silently) checked zero times, without
failure.
- Fixed camel case for variable name
- Fixed indentation in imageannotation.html
- Changed all mentions of Instructor Username to Email
- Turned annotation_mode into phrase
- Fixed indentation in imageannotation.html
- Added comments in imageannotation.html
- Changing annotation_mode in OSDA
- Added component to view
- Added correct images for OSD
- Fixed path to codemirror
- Tinymce fullscreen works now
- Pep8/Pylint Fixes
- Default image changed and added call to super
to successfully call a function with parameters by setTimeout,
it needs to be a function that will be called by setTimeout internally.
this patch actually enables multiple tries for calling the setState function.
Instead of noting users that are already in a cohort and not changing
such users, clobber the previous cohort and display a message indicating
the previous cohort membership.
JIRA: FOR-452
Separating and documenting tinyMCE font imports from customized vendor code and customized render styling css files (because font must load first in iframe).
Add the TinyMCE font file to the CMS pipeline.
Changed tiny-MCE to not load CSS files dynamically.
Added CSS files for tiny-MCE in env files.
Moved TinyMCE files to directory structure required by Jake command.
Changed clients of "tinymce.min.js" to use "tinymce.full.min.js" instead.
Updated CHANGELOG to indicate tinymce version 4.0.20.
Renamed tinymce.css.
Directions for creating tinymce.full.min.js and commenting of edX changes.
Updated comments related to disabling dynamic JS and CSS file loading in tinymce.
Allow TinyMCE to handle CSS within the iframe.
Detailed commit messages:
deleted old tinymce
new tinymce
js changes to support new tinymce
scss changes for alignments
Include all the controls on the toolbar that we previously had.
Changes to support Bulk e-mail usage.
adding new studio skin for TinyMCE4
Get handling of static image links working again.
Delete old Studio skin.
Version 1.3 of CodeMirror plugin.
Modify paths for location of CodeMirror files.
Fire events when CodeMirror Editor is open and closed.
Needed to switch static links back and forth.
Remove CodeMirror tabbed editor.
fixed tinymce visual editor css
Change how we detect that an image has been inserted.
made the codemirror look more studio-like
reordered the tinymce buttons
Update unit tests.
Update acceptance test for image plugin.
Make sure to strip out temporary caret.
It can get left behind in style blocks.
Test for style block being maintained.
Allow TinyMCE to create p's, else formatting doesn't work.
Add tests for toolbar buttons and converting links.
Add test for code format toolbar button.
Remove unnecessary code.
Remove unused testing templates and unused tabs.
Update tinymce paths.
Fire an event with the link plugin closes so we can rewrite links.
pep8
Updates from code review.
Change the name of the button to "Edit HTML".
Changed menu name for consistency, but we don't show it.
Changed name of "code" toolbar button to "Code block".
Switch from tabbed Visual/HTML Editor for HTML modules to showing the code editor as a plugin within TinyMCE (triggered from toolbar). STUD-1422
Fire events before and after the image dialog is shown.
We use this to rewrite links.
Change the event handling for image plugin.
Fixes FireFox bug, and allows us to correct the image path when we show the plugin (as opposed ot only correcting path when we close the plugin).
Code review feedback.
Fire events before and after the link dialog is shown.
This allows us to convert the static links.
Remove unnecessary helper method.
keeping the component editor inside the component window
Use compressed CodeMirror file.
replaced code icon in TinyMCE editor; simplified UI on TMCE toolbar
Change code editor icon to say HTML.
Move code style block button.
Update tests for minor UI changes.
Code editor button no longer shows an icon, and code style toolbar button location has moved.
Fix typos.
