Commit Graph

3793 Commits

Author SHA1 Message Date
Se Won Jang
11d260910f Implemented Validation for Course Advanced Setting
This commit adds validation for course advanced settings. Currently when course
administrators make invalid changes in the Settings/Advanced Settings tab,
they're not notified through a new modal window of the list of invalid settings
changes.

* Extending CourseMetadata
    - Previously, we only had update_from_json method in CourseMetadata.py,
      and it was only validating one field every POST request.
    - Now we have validate_and_update_from_json method that encapsulates the
      functionality of update_from_json into a validation call
    - To avoid discrepancy of validation standards between modules, validation
      uses the from_json method implemented to each field in xblock.

* Different Response in advanced settings ajax requests
    - After receiving a POST ajax request, course.py calls
      validate_and_update_from_json, and sends a json object of either:
        1) valid course metadata model
        2) error objects

* Error Messages shown in validation-error-modal
    - error objects passed through ajax are shown in a separate modal.
2014-08-26 11:24:38 -07:00
Nimisha Asthagiri
e42a3f15db Update opaque-keys library to use block_id for html_id for new keys.
Catch more places where get_children was giving us version aware references.
LMS-11237
2014-08-25 17:41:57 -04:00
Alexander Kryklia
095b07275e Unflag Group Configurations, Render only existing children in staff view of split_test. 2014-08-22 16:43:54 -04:00
Ben McMorran
e8fd9c08c1 Merge pull request #4934 from edx/benmcmorran/course-settings-error
Fix error when changing course details on split
2014-08-22 14:47:15 -04:00
Ben McMorran
e933c9fe18 Fix error when changing course details on split 2014-08-22 10:22:57 -04:00
muhammad-ammar
4815adb641 Merge pull request #4869 from edx/ammar/bok-choy-video-transcript-tests-batch2
Bok-Choy Video Transcript Tests Batch 2
2014-08-22 15:39:27 +05:00
Oleg Marshev
7506a479c6 Allow one group in a group configuration. 2014-08-22 11:52:35 +03:00
Muhammad Ammar
75a0d52472 Bok-Choy Video Transcript Tests Batch 2 2014-08-22 07:28:48 +00:00
Waheed Ahmed
f686e7d0b9 Passed cls=EdxJSONEncoder on json.dumps to fix save, edit and import.
STUD-2096
2014-08-22 12:23:46 +05:00
Ben McMorran
62643a5941 Fix broken rerun test 2014-08-21 15:43:22 -04:00
Ben McMorran
ff525bea96 Fix field serialization 2014-08-21 12:11:30 -04:00
Ben McMorran
b6d9ef3ed7 More PEP8/pylint cleanup 2014-08-21 12:11:29 -04:00
Don Mitchell
3b6b4668dd On rerun, override the course start date
LMS-11011
2014-08-21 12:11:29 -04:00
Don Mitchell
85f5c49bb7 Unit tests for rerun
along w/ fixes to make them work
LMS-11011
2014-08-21 12:11:29 -04:00
Ben McMorran
de52f82352 PEP8/pylint cleanup 2014-08-21 12:11:28 -04:00
Ben McMorran
4e41a42c76 Rename unsucceeded to in_process 2014-08-21 12:11:28 -04:00
Don Mitchell
78879ebc18 Asset urls must start w/ slash
LMS-11233
2014-08-21 12:11:27 -04:00
Ben McMorran
2839ad8711 PR cleanup 2014-08-21 12:11:26 -04:00
Ben McMorran
46932ee0f9 Replace data-test-course and data-test-unsucceeded with data-course-key 2014-08-21 12:11:26 -04:00
Mat Peterson
6096bae755 Skipping rerun test on feature flag conditional 2014-08-21 12:09:13 -04:00
Mat Peterson
0088978281 Set GlobalStaff permissions on reruns 2014-08-21 12:09:13 -04:00
Mat Peterson
e8763ef715 Do TODOs in test_contentstore.py 2014-08-21 12:09:13 -04:00
Mat Peterson
18a6a0487b added JS to outline page after bulk publishing rewrite 2014-08-21 12:09:12 -04:00
Mathew Peterson
9f8f64cffe Course Reruns UI
Studio: adding course re-run-centric static template rendering

* initial HTML for dashboard states
* initial HTML for new course re-run view/form
* initial HTML placeholder for outline alert UI

Conflicts:
	cms/templates/index.html

Studio: adding styling for course re-run-centric views

* adding new view/page mast-wizard type
* refactoring create course/element form styling
* adding course re-run view specific styling
* adding courses processing styling (w/ alerts and status)

Course rerun server-side updates: support display_name and DuplicateCourseError.

Studio: further design revisions and tweaks from feedback

* removing new window attribute from re-run control
* removing links from processing courses
* revising look/feel of dismiss action on dashboard + alert
* correcting font-weight of dashboard processing title
* adding extra space to course rerun action on dashboard
* re-wording secondary cancel action on rerun view

Conflicts:
	cms/templates/index.html

Added interation on unsucceeded courses in dashboard

Studio: removing 'rel=external' property from course re-run actions

Studio: removing hover styles for processing courses

Fixed value bug in split and set course listing to display run

moved task.py for rerun
2014-08-21 12:09:12 -04:00
polesye
732bcbdeb6 STUD-1911, STUD-1932: Publish sections, subsections and units from course outline. 2014-08-21 17:34:06 +03:00
muhammad-ammar
06842be865 Merge pull request #4859 from edx/ammar/bok-choy-video-transcript-tests
Bok-Choy Video Transcript Tests Batch1
2014-08-21 12:01:04 +05:00
Daniel Friedman
0829acb8dd Merge pull request #4872 from edx/dan-f/course-outline-start-date
View course start date from course outline
2014-08-20 10:44:36 -04:00
Muhammad Ammar
cfeb7102a6 Bok-Choy Video Transcript Tests 2014-08-20 12:11:21 +00:00
muhammad-ammar
ca3bd2f83f Merge pull request #4496 from edx/ammar/bok-choy-cms-video-editor-tests
Bok-Choy CMS Video Editor Tests
2014-08-20 13:19:10 +05:00
Daniel Friedman
0d63d0c1c1 Provide course outline template with start date 2014-08-19 12:42:43 -04:00
David Baumgold
b9eaf32985 Merge pull request #4875 from edx/db/edx-wiki-to-openedx
Update comments to point to openedx.atlassian.net
2014-08-19 10:23:27 -04:00
Don Mitchell
3c3a316f08 Make it branch agnostic
LMS-11210

Conflicts:
	common/lib/xmodule/xmodule/modulestore/split_mongo/split_draft.py
2014-08-18 16:19:46 -04:00
David Baumgold
2e02cefc90 Update comments to point to openedx.atlassian.net
And whitespace corrections (automatically made by my editor, and I'm too lazy
to remove them)
2014-08-18 15:34:06 -04:00
Muhammad Ammar
f93e4f2775 Bok-Choy CMS Video Editor Tests 2014-08-18 15:44:30 +00:00
Ben McMorran
12a5781725 Add ability to set staff lock from course outline 2014-08-16 15:58:42 -04:00
Don Mitchell
23d78fe7fc Merge pull request #4803 from edx/dhm/import_split_test
Dhm/import split test
2014-08-15 17:23:33 -04:00
Alexander Kryklia
ccf85a9431 Merge pull request #4777 from edx/anton/sync-groups-and-verticals
Anton/sync groups and verticals
2014-08-15 20:15:12 +03:00
polesye
867a5c051f Sync children vertical names with group names in split test module. 2014-08-15 19:34:55 +03:00
Calen Pennington
50082387eb Add a request-token to identify which xblock html was rendered as part of the current request
[STUD-2903]
2014-08-15 11:04:52 -04:00
Oleg Marshev
a94e942480 BLD-1125: Validation of content experiments after managing a group. 2014-08-14 16:34:21 +02:00
cahrens
a35cbf1c63 Verify loading indicator has been hidden.
STUD-2090
2014-08-13 13:51:36 -04:00
Don Mitchell
aa1b9fece9 Properly (de)serialize references in old mongo
LMS-11204
2014-08-13 11:26:12 -04:00
cahrens
ee836d4c40 Merge branch 'release' from 2014-08-12 release. 2014-08-12 13:51:58 -04:00
Tim Babych
e7fbf1327f Merge pull request #4778 from edx/tim/improve-python-group-configuration-tests
Use UrlResetMixin to test GroupConfiguration feature
2014-08-11 21:10:47 +03:00
Don Mitchell
05bddae34a Merge pull request #4633 from edx/dhm/create_xthing
Make import/export work with split mongo, replace create_xmodule with create_xblock
2014-08-11 12:53:59 -04:00
Don Mitchell
192d701899 Code review changes re split import/export, create_xblock 2014-08-11 12:13:31 -04:00
Tim Babych
06cb6008f0 Use UrlResetMixin to test GroupConfiguration feature 2014-08-11 19:12:30 +03:00
Alexander Kryklia
9643120390 Reenable user partition in Advanced Settings. 2014-08-11 16:41:29 +03:00
Muhammad Ammar
936bd4d5ad Bok-Choy CMS Video Tests 2014-08-11 07:50:19 +00:00
Don Mitchell
f69ef41c21 Disable fetching by version guid for now 2014-08-08 15:00:48 -04:00