Vik Paruchuri
530ac51c1c
Add .error callback back in
2013-05-07 17:33:34 -04:00
Vik Paruchuri
2648a19cc2
Fix check for use for single location
2013-05-07 17:08:14 -04:00
Vik Paruchuri
e0d1eca6aa
Delete two lines. without this, the xblock fields are never created in cases where the module is "fresh" (ie has no existing data)
2013-05-07 16:56:08 -04:00
Vik Paruchuri
1398b55713
Comment touched modules
2013-05-07 15:48:19 -04:00
Vik Paruchuri
9e03280f50
Make peer grading fields stringy and fix js to avoid strange error
2013-05-07 15:33:15 -04:00
cahrens
9e1c935b60
Merge branch 'master' into feature/christina/fields
2013-05-07 12:39:45 -04:00
Christina Roberts
729ca900e6
Merge pull request #1920 from edx/feature/christina/fields
...
Pass additional field information from editable_metadata_fields, remove system_metadata_fields variable.
2013-05-07 09:38:34 -07:00
Jay Zoldak
c2cd75469b
Change the methodology to ignore .js files by default. Any .js files that are coded can be handled individually.
2013-05-06 17:05:47 -04:00
cahrens
594d28a653
Pass default value through.
2013-05-06 16:03:41 -04:00
Will Daly
4f33b8e0c0
Fixed a UnicodeEncodeError that occurred when generating cache keys
...
from non-ASCII unicode code submissions.
2013-05-06 15:04:20 -04:00
Jay Zoldak
522751e425
Ignore the js files that are compiled from coffeescript when running the xmodule jasmine tests
2013-05-06 14:28:05 -04:00
Greg Price
ec3c8458e7
Merge pull request #1911 from edx/feature/gprice/feedback-button
2013-05-06 11:03:41 -07:00
Greg Price
00729a8c13
Add an omnipresent help tab to the LMS
...
The help tab opens a modal dialog that directs the user at various resources
(e.g. the site FAQ and course forums) and allows the user to submit feedback
to the feedback endpoint (which will ultimately create a ticket for the
student support team).
2013-05-06 13:35:52 -04:00
cahrens
84ff2a0941
Merge branch 'master' into feature/christina/fields
2013-05-06 12:42:18 -04:00
Ned Batchelder
e3de0dc847
A fuller unit test with a real 8.02x problem.
2013-05-06 11:39:22 -04:00
Ned Batchelder
403218ec6b
If sandboxed code raises an exception, the exception will be cached.
2013-05-06 11:39:21 -04:00
Ned Batchelder
001ef7b0fe
Use only safe characters for the cache key
2013-05-06 11:39:21 -04:00
Ned Batchelder
d7ea1dafe8
On second thought, make can_execute_unsafe_code a function returning a boolean.
2013-05-06 11:39:21 -04:00
Ned Batchelder
f1fac732cf
A new boolean on XModuleSystem that determines whether to allow execution of untrusted unsandboxed code.
2013-05-06 11:39:21 -04:00
Ned Batchelder
f4d84e67e1
Build the XModuleSystem anew for each test so we can fiddle with it safely.
2013-05-06 11:39:21 -04:00
Ned Batchelder
0ba4b680f9
Minor fixes of test_system in xmodule tests
2013-05-06 11:39:21 -04:00
Ned Batchelder
477fe670dd
All re-randomization has to be bucketed to get a reasonable cache hit rate.
2013-05-06 11:39:20 -04:00
Will Daly
0b2aedb4fe
Added datadog monitoring of safe_exec() time
2013-05-06 11:39:20 -04:00
Ned Batchelder
baa6b4e3e4
The cache key for safe_exec has to be hashed to keep it a reasonable size.
2013-05-06 11:39:20 -04:00
Ned Batchelder
09fbbe7bfa
Codejail is in its own repo now.
2013-05-06 11:39:20 -04:00
Ned Batchelder
adde939831
Clarify some comments in tests.
2013-05-06 11:39:20 -04:00
Ned Batchelder
726e8db13e
Add more docs
2013-05-06 11:39:20 -04:00
Ned Batchelder
fb5343237a
jail_code can execute a provided file also.
2013-05-06 11:39:20 -04:00
Ned Batchelder
9683098f3d
Python should have -E, not sure of a clean way to do it, but this at least only applies it to python.
2013-05-06 11:39:20 -04:00
Ned Batchelder
bde976dad2
Refactor code_jail to accommodate non-Python code.
2013-05-06 11:39:19 -04:00
Ned Batchelder
55e910aafc
Not sure why my branch was ahead of master for the version of distribute. Make them the same.
2013-05-06 11:39:19 -04:00
Ned Batchelder
bcdc11c3a5
Hint functions are now run in the sandbox.
2013-05-06 11:39:19 -04:00
Ned Batchelder
ed13f0a0f1
Catch up to new exception handling in responses.
2013-05-06 11:39:19 -04:00
Ned Batchelder
5e7d328e7f
Use the Django cache for sandboxed code execution.
2013-05-06 11:39:19 -04:00
Ned Batchelder
c8b908a244
capa.safe_exec can use a cache.
2013-05-06 11:39:19 -04:00
Ned Batchelder
5e8e31b2d1
Add a cache attribute to ModuleSystem
2013-05-06 11:39:19 -04:00
Ned Batchelder
182a1a1899
Cleanups
2013-05-06 11:39:19 -04:00
Ned Batchelder
0021b0acb3
Refactor to move assumed_imports into capa, so that code_jail is more pure.
2013-05-06 11:39:19 -04:00
Ned Batchelder
89f6ef8407
Move capa/safe_exec into its own directory, in prep for moving code here.
2013-05-06 11:39:18 -04:00
Ned Batchelder
d925604113
Clarify provenance
2013-05-06 11:39:18 -04:00
Ned Batchelder
efaa0eea03
More fixes to the merge, now all tests pass.
2013-05-06 11:39:18 -04:00
Ned Batchelder
be79810ff6
Fix one problem from the merges
2013-05-06 11:39:18 -04:00
Will Daly
f62dad2f57
Added symbolic response tests
2013-05-06 11:39:18 -04:00
Ned Batchelder
e61a6fe787
Make it possible for customresponse check functions to get extra arguments, though they need to be declared in the XML.
2013-05-06 11:39:18 -04:00
Ned Batchelder
c49b0c5027
Have to make the globals json-safe before sending them to the sandbox.
2013-05-06 11:39:18 -04:00
Ned Batchelder
7aa493ec85
A start on getting these tests to run again.
2013-05-06 11:39:18 -04:00
Ned Batchelder
283fc47a95
Jailed code importing random explicitly would get the wrong seed.
2013-05-06 11:39:17 -04:00
Ned Batchelder
f3e8d5bb7a
Didn't mean to put this in
2013-05-06 11:39:17 -04:00
Ned Batchelder
478f967af4
We would fail if a global was defined with a non-jsonable value inside a jsonable one. Now we don't/
2013-05-06 11:39:17 -04:00
Ned Batchelder
b95ea4422b
Prevent a print statement from accidentally borking the sandbox.
2013-05-06 11:39:17 -04:00
