Search indexing is prohibitively slow for large CCX courses, even
taking hours in the case of some particularly large ones with
thousands of blocks. Temporarily disabling this functionality until
it can be made more performant (PSRE-288), so that we're not
blocking the workers from doing more latency-sensitive work.
There is a separate effort to put search indexing in its own set
of workers.
Instead of going up the stacktrace to find the module names of waffle
flags and switches, we manually pass the module __name__ whenever the
flag is created. This is similar to `logging.getLogger(__name__)`
standard behaviour.
As the waffle classes are used outside of edx-platform, we make the new
module_name argument an optional keyword argument. This will change once
we pull waffle_utils outside of edx-platform.
Note that the module name is normally only required to view the list of
existing waffle flags and switches. The module name should not be
necessary to verify if a flag is enabled. Thus, maybe it would make
sense to create a `add` class methor similar to:
class WaffleFlag:
@classmethod
def add(cls, namespace, flag, module):
instance = cls(namespace, flag)
cls._class_instances.add((instance, module))
The LEPL dependency was triggering a lot of deprecation warnings of the
form:
venv/lib/python3.5/site-packages/lepl/matchers/support.py:497:
DeprecationWarning: inspect.getargspec() is deprecated, use
inspect.signature() instead
argspec = getargspec(func)
It turns out that LEPL was only used by the rfc6266_parser package, which
itself was only used in one place to generate utf8-compliant
Content-Disposition headers.
This issue was noticed here:
https://github.com/SWW13/python-rfc6266-parser/issues/2
Unfortunately it is quite difficult to extract LEPL from the
rfc6266-parser package.
The rfc6266-parser package (https://pypi.org/project/rfc6266-parser/) is
itself a fork of the now-unmaintained rfc6266 package
(https://pypi.org/project/rfc6266/). Thus, it became high time to get
rid of this package. The FileResponse object can appropriately set the
Content-Disposition header, and thus replace the rfc6266 functionality,
since Django 2.0: https://code.djangoproject.com/ticket/16470
In our testing, the FileResponse object correctly set the
`filename*=utf-8''` value, following the RFC. The only difference is
that it does not provide "filename" fallback value, as expressed in the
RFC: https://tools.ietf.org/html/rfc6266#appendix-D
With rfc6266_parser:
>> import rfc6266_parser
>> rfc6266_parser.build_header("my_file_é.csv", filename_compat="video_urls.csv")
b"attachment; filename=video_urls.csv; filename*=utf-8''my_file_%C3%A9.csv"
With FileResponse we have:
>> from django.http import FileResponse
>> import io
>> response = FileResponse(io.StringIO(), as_attachment=True, filename="my_file_é.csv", content_type="text/csv")
>> response.get("Content-Disposition")
"attachment; filename*=utf-8''my_file_%C3%A9.csv"
We consider that this is a sufficiently minor difference, that will
impact very few browsers.
* remove waffle flag for proctoring providers
removed waffle flag
removed tests
updates for requested changes
corrected mistake
Add edX Django Rest Framework Extensions CSRF App URLS to Studio
MST-334 Make sure the CSRF hooks are in INSTALLED_APPS on Studio (#24607)
ENT-2894: Use new welcome template when redirected from enterprise proxy login view (#24587)
* using new welcome template when redirected from enterprise proxy login view
* enabling safe redirects to enterprise learner portal from login in devstack
* ading admin portal to login redirect whitelist
* running make upgrade to version bump edx-enterprise
fix(i18n): update translations
Updating Python Requirements
[REV-1257] Add upsell tracking for upgrading all programs button on program dashboard (#24589)
Added upsell tracking to the course upgrade all button on the program dashboard so we have a better understanding of when users are clicking our upsell links.
POST proctored exam settings (#24597)
allow blank escalation email (#24613)
[BD-10] Remove _uses_pattern_library property from EdxFragmentViews (#24536)
[BD-10] remove edx-pattern-library from JS bundles (#24165)
Co-authored-by: Sankar Raj <sankar.raj@crystaldelta.com>
Make the ExperimentWaffleFlag respect course masquerading when checking if it's active for a specific enrollment
[REV-1205] Add doc location comment so future devs can easily find it (#24615)
AA-204: passing correct section information to frontend to complete outline portion of tab
AA-204: adding tests
AA-204: fixed up documentation and tests
[BD-10] Remove uses bootstrap method (#24535)
Remove pattern library of certificate styles.
update search description on new search string (#24619)
* update search description on new search string
* disable xss-lint rule for jquery.html
make comment more general, to allow for future changes (#24618)
[BD-10] [DEPR-92] Remove pattern library of pavelib folder (#24591)
[BD-10] [DEPR-92] Remove directories that includes pattern-library. (#24602)
Add SSO Records endpoint for support tools
Bucket users regardless of enrollment in courseware MFE experiment
Updating Python Requirements
Change the default value of allow_proctoring_opt_out (#24626)
MST-333
ENT-3143: display message banner guiding user to their enterprise LP if enabled (#24625)
* display message banner guiding user to their enterprise LP if enabled
* adding new sass class name to use same styling as recovery email alert
Add "Source from library" XBlock
This lets the user import a block from a blockstore-based content library into a (modulestore based) course, by copying the block into the course.
Revert "[BD-10] [DEPR-92] Remove pattern library of certificate styles." (#24633)
Revert "[BD-10] [DEPR-92] Remove directories that includes pattern-library. (#24602)"
This reverts commit e4f28debb7.
Revert "[BD-10] [DEPR-92] Remove pattern library of pavelib folder (#24591)" (#24635)
This reverts commit 6980291d96.
allow plus or minus one (#24637)
geoip2: update maxmind geolite country database
fix keyerror with request.session (#24642)
* fix keyerror with request.session
* improve the conditional
AA-127: Created MFE Outline Tab Waffle Flag
Note: The team settled on raising a 404 when the waffle flag is disabled.
Upon receiving the 404, the frontend will redirect to the LMS.
Fixes session caching for enterprise portal links by only caching for auth'd learners
BUG: fixes for saml provider config/data lookup
Fix xss in edit member template
Fix xss while rendering file-upload
Fix xss in date
Fix xss in base site template
* revert
* removed from test_views
* Enforce limit on number of blocks allowed in library (blockstore)
* Enforce limit on number of blocks allowed in library (modulestore)
* Changes from review feedback
* testing
* updates to drop down
* unit tests. env changes were copied based on other MFEs in LMS
* added exam settings link to other course settings pages
* fixed pylint errors
* updates for requested changes
* updates for requested changes, as well as changes for xss linter
Add a field to VEM config model that will decide the percentage of
courses allowed to go to VEM pipeline. The courses that don't meet the
criteria will go to VEDA.
PROD-1722
* Disable changing special exam type after release date
Do some client-side validation to make sure that exams
that *are* or *ever were* special may not be changed
to a special exam type (other than the current one)
after release date.
MST-258
Co-authored-by: Zach Hancock <zhancock@edx.org>