Ben Patterson
aebb35d361
Use jshint in paver, include in builds.
...
JShint will be executed with paver run_jshint, which will use a defined set of
directories (likewise defined are directories to ignore). A limit can be imposed
on the total number of violations. Note that this change does NOT include adding
jshint to diff-quality or `paver run_quality`.
2015-05-22 16:06:13 -04:00
Ned Batchelder
24e0c2c80f
Run pylint on all our code, and only our code. TE-855
...
With the old logic, we weren't running pylint on openedx at all. We
were also running it on lms/lib/comment_client twice, and on the
installed xblock third-party library.
2015-05-04 15:23:55 -04:00
Sarina Canelake
e77211b713
Run pep8 on all files, and fix uncovered errors
2015-03-23 15:50:29 -04:00
Sarina Canelake
bd090a6e58
Fix paver quality tests to reflect removed diff-quality call
2015-03-23 15:37:56 -04:00
Sarina Canelake
a51fbc8123
Refactor pep8 to run instead of diff-quality pep8
2015-03-23 11:01:32 -04:00
Sarina Canelake
1b65afdd04
Give run_pep8 more readable output
...
Jenkins "Quality Report" pep8 output now lists all pep8 violations,
not just the number of violations.
2015-03-23 11:01:32 -04:00
Ben Patterson
1d00508671
Merge pull request #7147 from edx/benp/static-code-analysis-radon
...
Benp/static code analysis radon
2015-03-05 06:48:25 -05:00
Christine Lytwynec
8919d3f8f7
Store count of pep8 and pylint violations to files in reports dir
2015-03-03 10:47:22 -05:00
Ben Patterson
ff2dd93405
Simplify reporting and execution of pep8.
...
We are not using the limit flag in the actual run_pep8 method; removing
that from scripts. Operationally, pep8 has been enforcing a limit of
zero for awhile; this finishes that realization.
Also, all pep8 reports now appear under the reports/pep8 folder, rather than
per-system.
2015-03-02 13:21:35 -05:00
Ben Patterson
7a2384cfd1
Make pep8 failure output easier to understand.
2015-03-02 13:14:23 -05:00
Ben Patterson
efbabdb7bb
Revert "Extend quality checks to cover more directories"
...
This reverts commit 19c767eb52
2015-03-02 11:20:53 -05:00
Ben Patterson
9c04df5c7e
Revert "Refactor quality checks"
...
This reverts commit 747756a911
2015-03-02 10:30:21 -05:00
stv
747756a911
Refactor quality checks
2015-02-27 11:49:48 -08:00
stv
19c767eb52
Extend quality checks to cover more directories
2015-02-27 10:04:52 -08:00
stv
a557c5d368
Parameterize system list for quality checks
2015-02-27 10:04:52 -08:00
Ben Patterson
471bd2c0a8
Enable code complexity reporting.
2015-02-27 07:02:04 -05:00
David Baumgold
d6b187d147
Update pylint to 1.4.0
2015-01-08 16:24:44 -05:00
Calen Pennington
980f30c17f
Move lms.lib.xblock into lms.djangoapps.lms_xblock in preparation add database backed configuration to it
2014-12-12 21:45:21 -05:00
Christine Lytwynec
5007e98034
Merge pull request #6173 from edx/clytwynec/add_find_fixme_method
...
add find_fixme task
2014-12-10 11:08:25 -05:00
Christine Lytwynec
7f23c88dd3
add find_fixme task
2014-12-10 10:43:16 -05:00
Christine Lytwynec
25d76da4ef
add disable fixme to pylintrc
2014-12-08 09:19:19 -05:00
Kevin Luo
2262906e0b
Add compare-branch option to paver run_quality
2014-12-04 15:13:04 -08:00
David Baumgold
d981f98b9c
Merge pull request #5814 from edx/disable-pylint-todo-comments
...
Pylint: ignore TODO comments
2014-11-12 10:51:40 -05:00
stv
cf9308144d
Fix PEP8: E302 expected 2 blank lines, found 1
2014-11-10 11:00:11 -08:00
David Baumgold
9902dcb10f
Disable FIXME errors on paver run_quality
...
Not on `paver run_pylint`
2014-11-06 09:32:40 -05:00
David Baumgold
58fd091823
Disable TODO comments in paver quality only
2014-11-06 09:32:40 -05:00
Ben Patterson
493672b173
Reduce complexity in run_quality.
2014-11-04 16:01:30 -05:00
Ben Patterson
9642468c98
Optimize run_quality calls
...
Leverages recent changes in diff-cover to reduce number of diff-quality runs
2014-10-27 07:06:58 -04:00
Ben Patterson
a8c0c2b71c
paver run_quality should run both pep8 and pylint diffs with -p flag
...
TE-555
2014-10-24 08:46:00 -04:00
Ben Patterson
6bcaf61b0c
Introduce new switch for paver run_quality command.
...
When using -p, the underlying diff-quality command will pass that
number as a value for --fail-under.
For example,
paver run_quality -p 75
Will pass 75 into the --fail-under switch on diff-quality.
Also upgrades diff-cover in order to take advantage of this funcitonality.
2014-10-15 12:40:59 -04:00
Ben Patterson
1f196523f3
Paver: pep8/pylint violations limit switch. Fail if limit is breached.
...
This adds the -l switch, wherein a violations limit is passed in. For
example:
paver run_pep8 -l 700
Will fail if more than 700 violations are found.
By default, this limit is not enforced (i.e. if the -l switch
is not passed into the command, then a limit will not be put
into effect for that run)
2014-09-30 17:38:33 -04:00
Christine Lytwynec
2e2136d39c
Deprecated unit tests from rake to paver
2014-06-06 15:35:32 -04:00
Christine Lytwynec
f9f6e09644
fix for pylint/pep8 defaults
2014-05-23 13:19:28 -04:00
Christine Lytwynec
550d054300
added and updated pavelib/quality.py from dglance branch, deprecated rake quality tasks
2014-05-23 13:19:27 -04:00
Jay Zoldak
4771242d57
Revert "added and updated pavelib/quality.py from dglance branch, deprecated rake quality tasks"
...
This reverts commit 7fd2305f39
2014-05-23 08:40:43 -04:00
Christine Lytwynec
7fd2305f39
added and updated pavelib/quality.py from dglance branch, deprecated rake quality tasks
2014-05-20 16:22:28 -04:00
