Commit Graph

3192 Commits

Author SHA1 Message Date
chrisndodge
57d82dea10 Merge pull request #330 from edx/fix/cdodge/delete-course-delete-drafts
[STUD-380] Fix/cdodge/delete course delete drafts
2013-07-08 07:24:24 -07:00
Carlos Andrés Rocha
06529054de Merge hotfix 2013-07093 into master
Conflicts:
	common/lib/xmodule/xmodule/crowdsource_hinter.py
	common/lib/xmodule/xmodule/css/crowdsource_hinter/display.scss
	common/lib/xmodule/xmodule/js/src/crowdsource_hinter/display.coffee
	common/static/coffee/src/logger.coffee
	common/templates/hinter_display.html
	lms/envs/test.py
	lms/urls.py
2013-07-03 18:55:21 -04:00
Ned Batchelder
31a72093e0 Fix broken tests by simplifying the CourseFactory
The data argument was being treated specially, but that was just
because we didn't have **kwargs support.  Now we do.  There are
two uses of data=, one we convert to kwargs, the other was actually
unused, so remove it completely.
2013-07-03 17:04:18 -04:00
Chris Dodge
3acff0a77a remove unnecessary type check on the module store. XML module stores will throw an exception when deleting an item... 2013-07-03 16:27:30 -04:00
Chris Dodge
e92799bb2e switch from prints to logging.debug. Also refactor some duplicate code 2013-07-03 16:12:23 -04:00
Ned Batchelder
a453de2fca Merge pull request #323 from edx/ned/fix-lms-530
Fix LMS-530: Reflected XSS in chapter and page numbers
2013-07-03 12:28:19 -07:00
Calen Pennington
573abb8091 Merge pull request #321 from edx/cale/pylint-errors
Pylint errors
2013-07-03 12:16:29 -07:00
Ned Batchelder
1d5dfaa131 Add tests for image books, and more tests for the other kinds too. 2013-07-03 14:42:41 -04:00
Chris Dodge
bcc2268216 add code to actually go through and delete the draft modules 2013-07-03 11:23:44 -04:00
caesar2164
b3723b1a22 Merge pull request #288 from edx/giulio/accessibility-2
Round 2 Accessibility Changes
2013-07-02 13:41:50 -07:00
Renzo Lucioni
51f694b18d Remove Segment.io whitelist from Logger 2013-07-02 13:49:33 -04:00
Renzo Lucioni
42efd33cfa Refactor Segment.io integration with sequentials and instructor dashboard pages 2013-07-02 13:49:33 -04:00
Giulio Gratta
7452381f1c making sequence titles available to non-sighted users 2013-07-02 09:26:40 -07:00
Ned Batchelder
cd0aa7f360 Make CourseFactory more useful: accept arbitrary kwargs. 2013-07-02 11:36:46 -04:00
Calen Pennington
87edb5aeac Pylint errors 2013-07-02 10:35:27 -04:00
Felix Sun
560cd9b068 Fixed bug when user votes w/o permission - now displays a friendly error message instead of failing.
Fixed bug when hinter module displays a hint, then is asked to display nothing.  (Used to not update in this case.)
2013-07-02 09:54:56 -04:00
Felix Sun
15317de252 Made explanation for hints field in crowdsource_hinter.py more clear.
Fixed various commenting things.

Removed an unused function in the crowdsourced module coffeescript.

Improved commenting in hint_manager.

Fixed pep and pylint violations.
2013-07-01 19:05:31 -04:00
Carlos Andrés Rocha
d6631e5c3d Improve styling of the crowdsource hinter 2013-07-01 19:05:31 -04:00
Felix Sun
77e4e2a009 Edited text of crowdsourced hinter template to Piotr's suggestions. Added some HTML formatting to same. 2013-07-01 18:03:36 -04:00
Felix Sun
728ccd4bca Fixed some docstring formatting things.
Expanded test coverage a little.
2013-07-01 18:03:36 -04:00
Felix Sun
801853f691 Fixed a small, but dangerous, string-to-integer casting bug in hint_manager.
Expanded tests of hint_manager.

Enabled the hint_manager by default in development environments.
2013-07-01 18:03:36 -04:00
Felix Sun
4071a57f68 Fixed broken tests. Made the hint manager enabled in testing environments - this lets us test the hint manager. 2013-07-01 18:03:36 -04:00
Felix Sun
696cc3a4db Fixed numerous code-formatting issues and pep8 violations.
Began enforcing one-vote-per-person.  This can be disabled with debug="True" in the <crowdsource_hinter> tag.

Started tests of the hint manager.
2013-07-01 18:03:36 -04:00
Felix Sun
2c16801a25 Properly fomatted the tab-based UX for hint-voting.
Chiseled a little at writing template tests.
2013-07-01 18:03:36 -04:00
Felix Sun
d57380dd2e Moved the hinter rendering onto a mako template.
Hinter now displays vote count after voting.

Began testing templates.
2013-07-01 18:03:36 -04:00
Felix Sun
4a406901b3 Moved the crowdsourced hinter module into mako template form.
Fixed some bugs in the tests for crowdsourced hinter.
2013-07-01 18:03:36 -04:00
Felix Sun
376aaa1d8f Made correct/incorrect determination in coffeescript a little more sensitive. Still very hacky. 2013-07-01 18:03:36 -04:00
Felix Sun
93d457de54 Fixed epic git rebase meltdown. No new features. 2013-07-01 18:03:35 -04:00
Felix Sun
2088da4edc Made tests of the crowdsource hinter module more standardized and easier to read. Fixed database non-initialization bug in crowdsource hinter module. 2013-07-01 18:03:35 -04:00
Felix Sun
aba99084f2 Finished prototype of hint moderation view. Began re-writing tests of the crowdsource hinter module. (Old tests no longer cover all the code, now that moderation has been added.) 2013-07-01 18:03:35 -04:00
Felix Sun
0c0de20a2f Began work on instructor view to hinting system.
Added moderation feature - you can now choose to hold all hints for moderator approval before showing.
2013-07-01 18:03:35 -04:00
Felix Sun
415ea63bc0 Working prototype of crowdsourced hinting module.
Conflicts:
	common/static/coffee/src/logger.coffee
2013-07-01 18:03:35 -04:00
Calen Pennington
1a7b833146 Merge pull request #269 from edx/dhm/incidental-functionality-improvements
Incidental functionality improvements from Next Gen Modulestore work
2013-07-01 13:04:20 -07:00
Jean Manuel Nater
72b4561e3a Moved xml_store_config, mongo_store_config, and draft_mongo_store_config to xmodule/modulestore/tests/django_util.py
Removed some repeated instances of xml_store_config.
Reverted some changes to mongo_store_config so each modulestore gets it's own uuid.
2013-07-01 14:45:53 -04:00
Don Mitchell
ddfbe59814 Make DraftModuleStore mongo only
DraftModuleStore was originally designed as a mixin, but never used that
way, and with the upcoming changes to use the versioned module store,
never will be. This changes removes a circular dependency between
mongo.py and draft.py.
2013-07-01 12:33:08 -04:00
Don Mitchell
7892fd7421 Remove extraneous test for already handled edge case 2013-07-01 12:31:36 -04:00
Don Mitchell
3188bb0645 WIP: Use approximate comparison when checking for changes to start dates 2013-07-01 12:31:35 -04:00
Felix Sun
0c4d6ba6d9 Made explanation for hints field in crowdsource_hinter.py more clear.
Fixed various commenting things.

Removed an unused function in the crowdsourced module coffeescript.

Improved commenting in hint_manager.

Fixed pep and pylint violations.
2013-07-01 11:52:52 -04:00
Carlos Andrés Rocha
0b25e76194 Improve styling of the crowdsource hinter 2013-07-01 10:34:20 -04:00
Felix Sun
aae5758a99 Edited text of crowdsourced hinter template to Piotr's suggestions. Added some HTML formatting to same. 2013-07-01 10:25:05 -04:00
Felix Sun
970a7f0916 Fixed some docstring formatting things.
Expanded test coverage a little.
2013-07-01 10:25:04 -04:00
Felix Sun
b6760cebca Fixed a small, but dangerous, string-to-integer casting bug in hint_manager.
Expanded tests of hint_manager.

Enabled the hint_manager by default in development environments.
2013-07-01 10:25:04 -04:00
Felix Sun
6890563d43 Fixed broken tests. Made the hint manager enabled in testing environments - this lets us test the hint manager. 2013-07-01 10:25:04 -04:00
Felix Sun
ab303e7567 Fixed numerous code-formatting issues and pep8 violations.
Began enforcing one-vote-per-person.  This can be disabled with debug="True" in the <crowdsource_hinter> tag.

Started tests of the hint manager.
2013-07-01 10:25:04 -04:00
Felix Sun
242d0c28ae Properly fomatted the tab-based UX for hint-voting.
Chiseled a little at writing template tests.
2013-07-01 10:25:04 -04:00
Felix Sun
c79ca38f6e Moved the hinter rendering onto a mako template.
Hinter now displays vote count after voting.

Began testing templates.
2013-07-01 10:25:04 -04:00
Felix Sun
bb922ed8d8 Moved the crowdsourced hinter module into mako template form.
Fixed some bugs in the tests for crowdsourced hinter.
2013-07-01 10:25:04 -04:00
Felix Sun
ad40905a38 Made correct/incorrect determination in coffeescript a little more sensitive. Still very hacky. 2013-07-01 10:25:04 -04:00
Felix Sun
475ac62c79 Fixed epic git rebase meltdown. No new features. 2013-07-01 10:25:04 -04:00
Felix Sun
6ccfa2e38d Made tests of the crowdsource hinter module more standardized and easier to read. Fixed database non-initialization bug in crowdsource hinter module. 2013-07-01 10:25:03 -04:00