Commit Graph

20897 Commits

Author SHA1 Message Date
Usama Sadiq
baabbc5ffb Merge pull request #23625 from edx/usamasadiq/bom-1496
Django2.2 Post request update
2020-04-06 17:40:16 +05:00
Nick
0f8e871734 Merge pull request #23611 from edx/ndalfonso/AA-fix-mobile-banner
AA fix mobile reset dates banner
2020-04-06 08:28:53 -04:00
M Zulqarnain
753b14e39b Merge pull request #23627 from edx/BOM-1497-98-99
BOM-1497 : POST None failures fixed
2020-04-06 17:09:04 +05:00
Awais Jibran
6205687aea Merge pull request #23624 from edx/aj/fix-reverse-error
Fixes `NoReverseMatch` exception.
2020-04-06 17:07:34 +05:00
usamasadiq
32a8c33055 Django2.2 Post request update 2020-04-06 16:10:26 +05:00
Zulqarnain
19f63a9682 Post None failure fix 2020-04-06 15:47:47 +05:00
Awais Jibran
934e58fb54 Fixes NoReverseMatch exception.
`django.urls.exceptions:NoReverseMatch lms.djangoapps.discussion.tasks.send_ace_message`
PROD-1224
2020-04-06 13:41:54 +05:00
Ahtisham Shahid
123b2bb0db Merge pull request #23540 from edx/ahtisham/PROD-1412
Removed tech email form error templates
2020-04-06 12:50:44 +05:00
Awais Qureshi
9fc3dcb5d6 BOM-1490
None is not a valid value for posting.
2020-04-04 21:07:55 +05:00
Adam Blackwell
bb09c07c68 Revert "Certification verification enabled"
This reverts commit 3f1220276d.
2020-04-03 18:57:58 -04:00
Nicholas D'Alfonso
fe8d28bccf AA fix mobile reset dates banner 2020-04-03 15:22:50 -04:00
SaadYousaf
738dbae563 add investigation logs. 2020-04-03 21:13:53 +05:00
Dillon Dumesnil
cd1e5994d8 Merge pull request #23602 from edx/revert-23574-ddumesnil/lms-api-staff
Revert "Update the LMS courses API for staff permissions"
2020-04-03 07:46:11 -07:00
Simon Chen
6a2b3bdbee Add some feedback from edX Support to the Program Enrollment Inspector 2020-04-03 10:44:59 -04:00
Dillon Dumesnil
9b5ab66ace Revert "Update the LMS courses API for staff permissions" 2020-04-03 07:18:38 -07:00
Hammad Ahmad Waqas
7bd3900476 Merge pull request #23592 from edx/hammad/ENT-2740
ENT-2740 | Flaky tests due to UNIQUE constraint failed on enterprise_enterprisecourseenrollment.id
2020-04-03 14:22:06 +05:00
adeelehsan
6fcf9779b7 Merge pull request #23591 from edx/aehsan/prod-1395/certificate_verification_enabled_for_software_secure
Certification verification enabled
2020-04-03 12:56:29 +05:00
HammadAhmadWaqas
c09b382e52 fixing flakiness of tests due to redundant id created by faker. 2020-04-03 12:50:47 +05:00
adeelehsan
3f1220276d Certification verification enabled
Previously software secure was using self sign certificates.
Now they are not using it that's why we are enabling ssl
certificate verfication.

PROD-1395
2020-04-03 11:11:13 +05:00
Nick
26f0176ddd Merge pull request #23550 from edx/ndalfonso/AA-85-reset-dates-mobile
AA-85 mobile reset dates
2020-04-02 09:53:50 -04:00
Dillon Dumesnil
0a39e6dba8 Merge pull request #23574 from edx/ddumesnil/lms-api-staff
Update the LMS courses API for staff permissions
2020-04-02 06:27:41 -07:00
SaadYousaf
3c1f7ec5e9 add logs to optimized ProblemGradeReport code. 2020-04-02 14:39:43 +05:00
Nicholas D'Alfonso
ac9d2bfd30 AA-85 mobile reset dates
- render reset dates banner in webview for mobile app.
- improve banner redirect mechanism
2020-04-02 00:37:54 -04:00
Dillon Dumesnil
78a1b835fa Update the LMS courses API for staff permissions
We want to allow staff to see all courses in the LMS.
This changes the behavior from staff being treated like
an AnonymousUser (unless an username query parameter is
provided) to being treated like staff.

I also added in some tests for the other paths in this
function that did not seem to be tested.
2020-04-01 13:45:37 -07:00
Jansen Kantor
c096464a3c EDUCATOR-4976 (Part 1): Add teamset type validation to has_specific_team_access (#23539)
Add teamset type validation to has_specific_team_access
2020-04-01 16:40:03 -04:00
Jeremy Bowman
9ef0aa4880 Downgrade to pytest-django 3.8.0 for now (#23566)
We'll upgrade this again along with pytest once pytest-dev/pytest#6925 is resolved.

Also, it looks like a flaky error in test class DB setup outside a transaction was mucking things up for the rest of the test shard. I didn't try to fix the flakiness, but this should at least limit the blast radius to just that test class. We really need to start using setUpTestData() more consistently.
2020-04-01 14:17:27 -04:00
David Ormsbee
11025c4d1a Merge pull request #23559 from edx/ormsbee/csm_write_optimization
Make XBlock views/handlers non-atomic requests.
2020-04-01 11:02:46 -04:00
Saad Yousaf
e4c00dd335 Merge pull request #23563 from edx/saad/PROD-1287-remove-flaky-test
[PROD-1287] - Remove flaky test lms.djangoapps.instructor_task.tests.test_tasks_helper.TestProblemGradeReport.test_grading_failure
2020-04-01 17:49:28 +05:00
SaadYousaf
8c4ae15766 remove flaky test. 2020-04-01 15:46:20 +05:00
Ahtisham Shahid
f6be77d493 Removed tech email form error templates
fixed tests

fixed test fail

Fixed failing tests
2020-04-01 14:53:01 +05:00
Awais Qureshi
30a2ae8aec BOM-1438
Fix course_id string.
2020-04-01 14:42:35 +05:00
David Ormsbee
5ea71beeb1 Make XBlock views/handlers non-atomic requests.
We're seeing slow commits on production for courseware_studentmodule
updates. Based on the slow queries during those times, we think it
might be because multiple worker processes are trying to update the
same rows from within long-running transactions (since courseware
is relatively slow).

The risk with this is that since the whole view execution is no
longer wrapped in a big implicit transaction, it's possible that
XBlock state will update and things that key off of that (e.g.
completion progress information or pre-req milestones) will fail
in a way that will leave the database in an unplanned-for state,
though this is already the case for those actions that trigger
asynchronous tasks like grades recalculation.

The query counts for the index view test were adjusted down
because save points count towards the total and we're no longer
setting them at the top level around the view as a whole.
2020-03-31 21:22:58 -04:00
Nimisha Asthagiri
d8774e4f8d Merge pull request #23555 from edx/arch/django2-bulk-email
Django2 bulk_email: bytestring conversion
2020-03-31 16:55:33 -04:00
Nimisha Asthagiri
90a330d0ad Django2 bulk_email: bytestring conversion 2020-03-31 16:04:45 -04:00
Nimisha Asthagiri
e320af0272 Merge pull request #23552 from edx/arch/django2-badges
Django2 Badges: fix course_id string
2020-03-31 15:46:11 -04:00
Manjinder Singh
b1baf5db77 Converting variable to string before assignment in tests (#23546)
* Converting variable to string before assignment in tests

Django 2 is stricter of string typing, so it will no longer do implicit conversions in some cases.
While the release notes only mention dropping bytestring support in some places, they seem to have also dropped implicit conversion to str for whole host of things.
2020-03-31 15:31:52 -04:00
Nimisha Asthagiri
8a0d57eec3 Django2 Badges: fix course_id string 2020-03-31 14:23:53 -04:00
Nimisha Asthagiri
da55a740a1 Django2 experiments app: Fix course_id string 2020-03-31 13:42:02 -04:00
Saad Yousaf
521f5f2dc8 Merge pull request #23531 from edx/saad/PROD-1287-fix
[PROD-1287] - Optimize problem_grade_report code - FIX.
2020-03-31 14:35:08 +05:00
adeelehsan
8d840e6f55 Merge pull request #23529 from edx/revert-23509-aehsan/prod-1222/added_logs_for_investigation
Revert "Added logs for investigation"
2020-03-31 12:31:05 +05:00
Nathan Sprenkle
02392879b7 Team Management Upload A11y Improvements (#23502)
* Expose team management file input for better a11y
* Disable upload button when file not selected
2020-03-30 17:03:15 -04:00
SaadYousaf
6fb9d199a0 optimize code for problem_grade_report. 2020-03-30 20:33:49 +05:00
adeelehsan
82bf1d744a Revert "Added logs for investigation" 2020-03-30 19:15:26 +05:00
Saad Yousaf
a458491f04 Revert "[PROD-1287] - initial work to optimise problem_grade_report code." 2020-03-30 19:05:54 +05:00
Danial Malik
8d951ae8ae Import private.py in devstack_docker.py files instead of devstack.py (#23512)
Background: I use private.py a lot in my devstack for my private configurations. But issues are raised when I need to change/override a setting that is defined in devstack_docker.py file. Since that file's contents are loaded after private.py, my private.py is useless against the settings in devstack_docker.py.

Description: Now that the devstack is dockerized, I think it makes more sense to import the private.py in the devstack_docker.py files i.e. at the end of configuration files hierarchy.
2020-03-30 09:38:25 -04:00
M Zulqarnain
0aba1af792 Merge pull request #23526 from edx/zulqarnain/BOM-1422
BOM-1420 : Fix Django 2.x tests in Discussion app
2020-03-30 17:48:47 +05:00
Zulqarnain
34bece208a Fix discussion notif pref tests 2020-03-30 16:01:06 +05:00
Saad Yousaf
4c5006988f Merge pull request #23267 from edx/saad/PROD-1287
[PROD-1287] - initial work to optimise problem_grade_report code.
2020-03-30 15:14:10 +05:00
Waheed Ahmed
a23a31c2be Allow Block Structures Collect to work in Studio.
The collect process was broken before this commit because Studio's
runtime does not permit handler_url invocation on "thirdparty"
XBlocks.

PROD-1393
2020-03-30 13:24:34 +05:00
SaadYousaf
4e4bffe404 initial work to optimise problem_grade_report code. 2020-03-30 13:14:01 +05:00