Commit Graph

401 Commits

Author SHA1 Message Date
Arjun Singh
b6f9dcdf74 fix inline closed threads 2012-09-14 01:25:02 -07:00
Arjun Singh
1f55763b56 Removing tags for now 2012-09-14 00:44:31 -07:00
Arjun Singh
8506cbcd15 Response editing 2012-09-14 00:11:32 -07:00
Arjun Singh
6b8e2c78ab Allow students to delete threads / respones; prepare for edit view for response comments (but not complete) 2012-09-13 21:58:59 -07:00
Ibrahim Awwal
d92a070ab1 Obey current search query and sort order when retrieving additional pages. 2012-09-13 18:34:01 -07:00
Ibrahim Awwal
236756e4ca Default argument value for options in Discussion so that inline discussions can still
work without modification. Eventually we'll want to switch the pagination there to
match the pagination on the main forum though.
2012-09-13 17:53:30 -07:00
Matthew Mongeau
5b9967e5a0 Paging wip 2012-09-13 17:35:29 -04:00
Tom Giannattasio
6c481b8aa3 fixed post list sort active state bug 2012-09-13 15:41:25 -04:00
Tom Giannattasio
cb9697ba58 fixed jump to top bug on edit form cancel button click 2012-09-13 15:16:17 -04:00
Tom Giannattasio
d2c6ae9391 tweaked inline tag styles; added href to tags 2012-09-13 15:01:54 -04:00
Tom Giannattasio
991e3fd1b7 fixed sidebar height glitch 2012-09-13 11:37:08 -04:00
Tom Giannattasio
ffd60fbd7e added margin to tags 2012-09-13 11:19:57 -04:00
Tom Giannattasio
6e217b315d added conditional to render tags wrapper only if there are tags 2012-09-13 10:59:47 -04:00
Tom Giannattasio
a152041ef8 fixed inline thread replace error 2012-09-13 10:25:10 -04:00
Ibrahim Awwal
aa6e878626 Fix repeated edits on inline threads. 2012-09-13 05:50:43 -07:00
Ibrahim Awwal
b03bcae4a2 Re expand thread if edit is canceled.
Should rework how inline threads are expanded/collapsed a little so that this kind of
thing is not needed.
2012-09-13 05:45:32 -07:00
Ibrahim Awwal
5fd45a50bc Enable editing for inline threads.
Currently there's a bug where editing more than once without reloading the page
causes it to successively get more and more broken.
2012-09-13 05:36:46 -07:00
Ibrahim Awwal
30b4918e77 Fix tags updating after editing a post. 2012-09-13 04:14:19 -07:00
Ibrahim Awwal
62b047f3c2 Refactored DiscussionThreadInlineView to inherit from DiscussionThreadView and
use subviews for rendering. Functionality should be the same. Changed a few things
in DiscussionThreadView to make this a little easier.
2012-09-13 03:11:30 -07:00
Ibrahim Awwal
58fc3eca12 Fix staff markers for inline threads and double staff markers for threads with deeply nested comments. 2012-09-13 02:20:35 -07:00
Ibrahim Awwal
712e59a68d Merge branch 'feature/arjun/new-discussions' of github.com:MITx/mitx into feature/arjun/new-discussions
Conflicts:
	lms/djangoapps/django_comment_client/forum/views.py
	lms/static/sass/_discussion.scss
2012-09-12 15:18:34 -07:00
Ibrahim Awwal
9a0798b68f Remove old backbone views (the last place they were being used was the profile page). 2012-09-12 15:16:44 -07:00
Ibrahim Awwal
b4828db1e3 User profile page redone to act like the inline discussion, except threads are
loaded into the page in a data attribute instead of loaded on request via ajax.
The user profile page also does not provide facilities for adding
comments/responses, which I think would clutter the page too much.

Also removed some unused stuff from views.py.
2012-09-12 15:16:35 -07:00
Matthew Mongeau
ba56afae7c Clear search when clicking topic dropdown. 2012-09-12 16:57:19 -04:00
Matthew Mongeau
d425f525b8 Display tags. 2012-09-12 16:43:52 -04:00
Matthew Mongeau
1a402f7fda Mark responses and comments as staff 2012-09-12 11:09:36 -04:00
Tom Giannattasio
87dcd07112 delayed appearance of spinner in thread so things are less jumpy 2012-09-12 10:07:16 -04:00
Tom Giannattasio
d88de52181 fixed jump to top on browse buttons 2012-09-12 09:41:34 -04:00
Tom Giannattasio
ff94541e40 tweaked inline hide/show and new post buttons 2012-09-12 09:41:34 -04:00
Arjun Singh
452414da37 Kill requests for loading responses when selecting another thread. This ensures that the thread you're viewing has the right responses loaded. 2012-09-12 06:13:46 -07:00
Ibrahim Awwal
1be378e697 Render comment replies properly, and update them after receiving a response. 2012-09-11 14:31:03 -07:00
Ibrahim Awwal
a91a5df499 Use regular javascript attributes for parent reference rather than setting
Backbone.Model attributes because Model attributes get serialized into
JSON which is wasteful.
2012-09-11 13:57:51 -07:00
Ibrahim Awwal
2c6c64d533 Sort comment replies in chronological order, keeping the parent references. 2012-09-11 13:12:01 -07:00
Carlos Andrés Rocha
2900c169cc Load inline comments templates at render time and not during page load 2012-09-11 15:58:16 -04:00
Matthew Mongeau
f4ba65c5d5 Show and hide search correctly. Added loading icon. 2012-09-11 13:30:00 -04:00
Tom Giannattasio
a0eefd1ea2 tweaked inline responses and new response toolbar 2012-09-11 10:59:40 -04:00
Ibrahim Awwal
2d105265f9 Add @references for deeply nested (3+) comments. 2012-09-11 05:43:21 -07:00
Ibrahim Awwal
fc459f7e44 Displays deeply nested comments inline.
This just puts them in three traversal order rather than chronological order.
Not sure which makes the most sense, but I'll implement both ways.
2012-09-11 05:08:55 -07:00
Ibrahim Awwal
ce16d22451 Fix anonymous posts on the inline discussion view. 2012-09-11 04:09:53 -07:00
Ibrahim Awwal
8b7940f413 Fixed context links after searching for real, and removed some more dead code. 2012-09-11 03:40:33 -07:00
Arjun Singh
a49b638027 Edit post works now. 2012-09-11 01:07:03 -07:00
Matthew Mongeau
79775c6ea8 Remove all number. Toggle search and dropdown. 2012-09-10 21:51:25 -07:00
Ibrahim Awwal
0da2f60a5e [Fixes #35791223] Clear the WMD preview after posting a new post. 2012-09-10 17:29:34 -07:00
Ibrahim Awwal
96eb40384f Fix markdown in thread view. 2012-09-10 16:45:48 -07:00
Arjun Singh
7ad9b39b98 Merge master 2012-09-10 15:33:59 -07:00
Ibrahim Awwal
042ab6d2ef Suppress underscore errors when not on the right page. Ideally page specific JS execution would take care of this. 2012-09-10 14:08:18 -07:00
Ibrahim Awwal
259e6e46ad Fix discussion module
It worked in Chrome because Chrome appears to magically infer some missing
arguments to methods. This is the second time this happened, should be more
careful about it in the future, because it causes confusion when features
work for some students but not others.
2012-09-10 12:59:14 -07:00
Tom Giannattasio
19bd60e905 tightened dropdown topic name treatment 2012-09-10 12:23:47 -07:00
Matthew Mongeau
5e0913547f Add backbone checks. 2012-09-10 12:23:29 -07:00
Tom Giannattasio
d0c2d31558 new show/hide button for inline discussions 2012-09-10 12:12:46 -07:00