Commit Graph

22725 Commits

Author SHA1 Message Date
Michael Terry
33445240d9 feat: drop unused EmailMarketingConfiguration model
This follows on the commit that gutted the email_marketing djangoapp
by actually dropping the model from code and database.

The djangoapp could now be removed after Maple releases.

AA-607
2021-05-04 08:42:21 -04:00
Michael Terry
033b9474ac Merge pull request #27502 from edx/mikix/drop-email-marketing
feat!: remove all email_marketing djangoapp code
2021-05-04 08:39:08 -04:00
Michael Terry
35f78a3241 feat!: remove all email_marketing djangoapp code
This djangoapp was designed for talking to sailthru, in a fairly
edx.org-specific way. Nowadays, edx.org doesn't need this code and
if other installations do, it's better off as a more distinct
plugin anyway, rather than direct support in the platform.

I've moved the one signal that was still useful (calling
segment.identify() whenever user fields change) into user_authn.

And I've left the EmailMarketingConfiguration model alone for now,
but will remove that shortly. Nothing uses it as of this commit.

AA-607
DEPR-139
2021-05-03 16:39:01 -04:00
Carla Duarte
6a2adde87c Merge pull request #27477 from edx/ciduarte/AA-723
fix: include VerifiedModeSerializerMixin in Progress Tab API [AA-723]
2021-05-03 13:57:28 -04:00
Christie Rice
82bf0411ca test: Use allowlist factory (#27490)
MICROBA-1021
2021-05-03 12:53:36 -04:00
Carla Duarte
b7081f4ecd fix: include VerifiedModeSerializerMixin in Progress Tab API [AA-723] 2021-05-03 12:50:31 -04:00
Michael Terry
12e9763446 Merge pull request #27487 from edx/mikix/fix-gated-content-check
fix: properly set contains_gated_content field on xblocks again
2021-05-03 11:50:40 -04:00
Christie Rice
912f2fa431 feat!: Enable the allowlist for all courses (#27468)
MICROBA-1013
2021-05-03 11:15:04 -04:00
Michael Terry
6e52aafc8c fix: properly set contains_gated_content field on xblocks again
This has been broken for a couple months, preventing proper display
of verified-only assignments on the dates tab and elsewhere.

AA-780
2021-05-03 10:17:17 -04:00
Christie Rice
b43c1ab27c test: Update allowlist tests, and remove verification of certificates app functionality (#27486)
MICROBA-1013
2021-05-03 09:26:22 -04:00
Matt Tuchfarber
1842cc08c6 fix: Hide cert availability on self paced courses (#27489)
If a certificate available date was set on a self paced course, it would
show text to the learner saying that the grades would be available in
the future when that was inaccurate.
2021-05-03 08:52:32 -04:00
Usama Sadiq
a1f80a00c7 refactor: pyupgrade second iteration (#27443) 2021-05-03 17:14:25 +05:00
Usama Sadiq
60f49d4048 refactor: pyupgrade second iteration (#27442) 2021-05-03 17:13:15 +05:00
Usama Sadiq
11ec4a9aaa refactor: pyupgrade second iteration (#27441) 2021-05-03 17:11:32 +05:00
Usama Sadiq
228c54d222 refactor: pyupgrade second iteration 2021-05-03 14:55:47 +05:00
Usama Sadiq
3ff951940d refactor: pyupgrade second iteration 2021-05-03 14:55:37 +05:00
stvn
9f1debac14 Merge PR #27343 bd03/api/legacy
* Commits:
  docs: Remove completed TODO discussions item
  feat: Add support to Discussions API for legacy cohort settings
  refactor: Remove get_course_discussion_settings helper
  refactor: Remove set_course_discussion_settings helper
  refactor: Add better DRF support to legacy discussions settings
2021-04-30 12:33:13 -07:00
Matt Tuchfarber
39bca7bba4 Merge pull request #27433 from edx/tuchfarber/fix_facebook_share
fix: Add callback function to Facebook share
2021-04-30 15:15:30 -04:00
stvn
1b76999c2f refactor: Remove get_course_discussion_settings helper 2021-04-30 11:47:34 -07:00
stvn
146887df1b refactor: Remove set_course_discussion_settings helper 2021-04-30 10:54:59 -07:00
stvn
6156064492 refactor: Add better DRF support to legacy discussions settings
so that we can re-use the existing serializer as a portability-shim in
the new API.
2021-04-30 10:54:55 -07:00
Matt Tuchfarber
b3e76dc151 fix: Facebook share button on course certificates.
Facebook requires a callback when using the `.ui()` method now. I don't
know when this changed, but the share button is currently broken on
course certificates.

Facebook documentation of the `.ui()` method:
https://developers.facebook.com/docs/javascript/reference/FB.ui/
2021-04-30 13:34:58 -04:00
Syed Muhammad Dawoud Sheraz Ali
0eb209d049 Merge pull request #27483 from edx/dsheraz/PROD-2334
feat: add pacing info in course enrollment serializer
2021-04-30 21:53:15 +05:00
DawoudSheraz
573d34c593 feat: add pacing info in course enrollment serializer 2021-04-30 19:45:47 +05:00
Usama Sadiq
f74d7c9ea7 refactor: pyupgrade second iteration 2021-04-30 15:35:47 +05:00
Dillon Dumesnil
874242a1d4 Merge pull request #27456 from edx/ddumesnil/update-enrollment-activated-segment-aa-775
feat: AA-775: add course start and pacing to enrollment.activated segment event
2021-04-29 06:57:14 -07:00
Justin Hynes
5db0b9f7c7 Merge pull request #27464 from edx/jhynes/microba-1181_fix
fix: fix issue where we were not generating a certificate `verify_uuid` when needed
2021-04-28 13:47:56 -04:00
Justin Hynes
5fe4e5c50b fix: fix issue where we were not generating a certificate verify_uuid when needed
[MICROBA-1181]
- change how we determine if we need to generate a verify_uuid for a learner's certificate record
2021-04-28 11:46:19 -04:00
Dillon Dumesnil
1f58bbe522 feat: AA-775: add course start and pacing to enrollment.activated segment event 2021-04-28 11:29:22 -04:00
Nathan Sprenkle
3ce04b7983 docs: update grades docs (#27341)
* docs: fix formatting inconsistencies in grade data model docs

* docs: add subsection grade override model

* docs: add gradebbook info to grades / background

* docs: fix formatting issues in grades / background
2021-04-28 11:22:13 -04:00
Kyle McCormick
3fbaf72601 fix: only show 'View in New Exp.' to global staff if MFE preview enabled (#27399)
Since the ENABLE_COURSEWARE_MICROFRONTEND Django setting
was removed, the "View in New Experience" button began
to always appear in Legacy courseware for global staff
members in *all* environments.

This was OK for edx.org's purposes, since the Learning MFE
is deployed in all of our production environments.
However, many (perhaps most) Lilac Open edX instances will
*not* deploy the Learning MFE. So, we need to make sure that
this button is not shown by default.

Since we cannot programmatically tell from LMS whether
or not the Learning MFE is deployed, we will depend on
the value of the `courseware.microfrontend_course_team_preview`
flag, which is already being used to decide whether
course staff can see the "View in New Experience" button.

Whether or not the button is shown, global staff will
still be permitted to browse courses in the Learning
MFE if it is deployed.

https://github.com/openedx/build-test-release-wg/issues/49
2021-04-28 09:17:18 -04:00
Justin Hynes
a2c7de459a Merge pull request #27434 from edx/jhynes/microba-1139_cert-error-cleanup
fix: Clean up old errors from certificate records now in `downloadable` status
2021-04-28 07:37:16 -04:00
Matthew Piatetsky
3fdb92f3f1 Merge pull request #27323 from edx/AA-719
[AA-721] Add necessary data for new progress page
2021-04-28 07:16:26 -04:00
Justin Hynes
563b48c50c [MICROBA-1139]
* Change order of object Manager declarations in the GeneratedCertificate model. Declaration order matters and It appears that having the "base" `objects` declaration after the other Custom Managers creates an issue where I cannot access `objects` in a migration without this change.
* As part of the manager migration there is a cleanup function that resets the `error_reason` field to an empty string for all certificates in the `downloadable` state that currently have an error listed in the record.
2021-04-27 15:55:51 -04:00
Christie Rice
a6d9275cde fix: Ignore passing signal if the cert status is already downloadable (#27403)
MICROBA-1106
2021-04-27 10:24:30 -04:00
Christie Rice
6e1f700cdc feat: Generate more certificate status for V2 course certs (#27326)
MICROBA-1106
2021-04-27 09:40:06 -04:00
Bianca Severino
5c6bdb4db8 Merge pull request #27419 from edx/bseverino/idv-remove-utm-parameters
[MST-740] Toggle verification approved emails from ACE
2021-04-26 15:26:45 -04:00
Bianca Severino
a8957fd118 refactor: remove verification approved emails from ACE 2021-04-26 14:55:47 -04:00
Dillon Dumesnil
82414f5b5e Merge pull request #27401 from edx/ddumesnil/enable-dates-tab-aa-741
feat: AA-741: Enables the dates tab for all enrolled learners
2021-04-26 10:56:08 -07:00
Matthew Piatetsky
8ff937c341 feat: Add new data to course home and progress endpoints to support the progress page certificate status component
AA-719
2021-04-26 09:43:25 -04:00
Justin Hynes
8902a945ea docs: Add ADR for recent cert revocation and regeneration changes
[MICROBA-1080]
- Add additional context in the `invalidate` and `mark_notpassing` functions related to recent work
2021-04-23 11:33:07 -04:00
Dillon Dumesnil
0a08852600 feat: AA-741: Enables the dates tab for all enrolled learners
Removes the relative dates flag check as it is no longer
necessary to show the dates tab
2021-04-22 15:22:26 -04:00
Justin Hynes
35cfca0be1 Merge pull request #27357 from edx/jhynes/microba-1164_revoke-program-certs-bugfix
fix: fix bug with `revoke_program_certificates` task
2021-04-22 07:38:32 -04:00
Julia Eskew
efa13ff1d2 fix: TNL-8233: Change exception raised at problem creation failure from generic exception to LoncapaProblemError. (#27361)
Raising this specific exception will cause the failure to be handled more gracefully by problem rescoring code.
2021-04-21 16:13:23 -04:00
Justin Hynes
a7bc9d1cc1 fix: fix bug with revoke_program_certificates task
[MICROBA-1164]
* cast `course_key` as a string when scheduling the `revoke_program_certificates` task
* Update existing unit tests
* Move test utility method in test_tasks.py out from the middle of the test cases
* Fix spelling in test function name
2021-04-21 14:43:03 -04:00
Albert (AJ) St. Aubin
a21d0ff224 [bug] Updated confusing text about when a certificated is available
Currently when a certificate availability date is set the text on the
course dasboard is confusing to the learner and could lead them to the
wrong conclusions. The cert should not be available until on or after
the available date.
2021-04-21 12:43:53 -04:00
Usama Sadiq
ab41a7daee refactor: Apply lint-amnesty on pylint violations 2021-04-20 21:43:59 +05:00
Ali Akbar
9e8684cc72 Merge pull request #27367 from edx/aakbar/xss-disable-2
Refactor: disable xsslint for numerous files
2021-04-19 15:51:30 +05:00
Ali-D-Akbar
de87916768 refactor: disable xsslint: PROD-2310 2021-04-19 12:37:08 +05:00
Awais Jibran
9722e37492 Enable Course Olx Validation during Course Import (#27300)
* Enable import failure and email with Errors/Warnings

This PR enables course import failure in case of olx validation errors. Here is the flow.
  * Course Import tries to import foo.tar.gz into their course shell
  * Course olx contains validation errors
  * During course import, olx is validated and import is failed with the error message "Course olx validation failed. Please check your email."
  * System generates an email with ERRORs & WARNINGs in the body of the email.

This PR also adds a waffle flag contentstore.bypass_olx_failure. The purpose of this test flag is to allow course teams to unblock by enabling them to bypass the
the olx-validation failure.
The workaround is shared on the ticket TNL8214.

* Disable olx validation out of the box.
2021-04-16 18:45:59 +05:00