Commit Graph

2353 Commits

Author SHA1 Message Date
Dave St.Germain
954c8e1a67 Merge pull request #19771 from edx/dahlia/masters-track
Added master's track
2019-02-25 10:11:24 -05:00
David Ormsbee
40e1e1e59e Improve SafeCookieData Error Logging
1. Use request.session instead of request.user, since request.user
won't necessarily be properly set.

2. Be extra paranoid by putting logging after session cookie deletion,
so that even if there is some error related to logging, the important
work will complete and the browser won't get left in a broken state.

3. Write out the full contents of the Cookie header (up to 4096 bytes)
in the log as a base64 encoded string. This way we can look at broken
cookie states and diagnose what's breaking them (the Python parser will
just silently skip anything past a corrupted cookie entry). We base64
encode mostly to prevent people from maliciously injecting garbage into
our logs.
2019-02-24 13:57:19 -05:00
David Ormsbee
475a4bd659 Merge pull request #19860 from edx/ormsbee/log_ssmw_delete_cookie
Log when SafeSessionMiddleware deletes cookies
2019-02-22 19:26:40 -05:00
David Ormsbee
1d7c082562 Merge pull request #19859 from edx/ormsbee/cookie_logging
Add cookie size monitoring New Relic metrics.
2019-02-22 19:26:31 -05:00
David Ormsbee
76620e0bf2 Add cookie size monitoring New Relic metrics.
This adds middleware that will create custom parameter metrics in
New Relic to track the size of all the cookies being received for
our domain. The custom fields are "cookies_total_size" and a
separate named parameter for every cookie size, e.g.
"cookies.csrftoken.size".

This is intended to help us track cookie growth and better diagnose
issues where users lose their sessions. It is toggled by the
'request_utils.capture_cookie_sizes' Waffle Flag.
2019-02-22 18:18:41 -05:00
David Ormsbee
fc52fcccab Log when SafeSessionMiddleware deletes cookies 2019-02-22 17:12:18 -05:00
Farhanah Sheets
5b38c7e39e Merge pull request #19825 from edx/aehsan/learner-6238/update_deprecated_pygeoip_to_geoip2
update pygeopip to geoip2
2019-02-21 13:02:47 -05:00
Calen Pennington
cd107d3cf9 Merge pull request #19751 from edx/unicode10
enable unicode format string linter
2019-02-21 06:07:11 -05:00
Zia Fazal
4fc64f9783 Merge pull request #19775 from edx/ziafazal/WL-1882
WL-1882:Management command to sync contacts with hubspot
2019-02-21 15:24:06 +05:00
Zia Fazal
7d1dd344d8 Management command to sync contacts with hubspot
Added unit tests

Fixed pylint quality violation

Added doctstring to add_arguments
2019-02-21 12:10:06 +05:00
Calen Pennington
78c8950ea3 Clean up a few remaining unicode format string errors 2019-02-20 15:28:14 -05:00
adeelehsan
3e2764d9c0 update pygeopip to geoip2
Update deprecated pygeoip
to geoip2 and all usages
of it

Learner-6238
2019-02-21 00:42:05 +05:00
Matt Hughes
17f0a4fb52 Allow educators to partition masters students as content groups
JIRA:EDUCATOR-4022
2019-02-20 12:40:53 -05:00
emma-green
cbf3f78325 Revert "WIP:Cache course runs to programs" 2019-02-20 12:03:07 -05:00
emma-green
304fba5959 Merge pull request #19677 from edx/emma-green/REVEM-176/cache-course_runs-to-programs
WIP:Cache course runs to programs
2019-02-20 09:55:36 -05:00
adeelehsan
f265d58cb1 Merge branch 'master' into aehsan/LEARNER-6943/adding_logs_to_check_discovery_response 2019-02-20 12:37:15 +05:00
Jeremy Bowman
974ae50bf4 Merge pull request #19620 from cclauss/new-style-exceptions
Old style exceptions --> new style for Python 3
2019-02-19 16:31:35 -05:00
Emma Green
f2139bbe2f add courses to programs to cache 2019-02-19 15:17:23 -05:00
Calen Pennington
f90be0031f Don't sys.exit in management commands, in case they get called from other code 2019-02-19 14:26:32 -05:00
adeelehsan
86ae3a9f20 Adding logs
adding logs to check response
returned by discovery

LEARNER-6943
2019-02-19 22:50:34 +05:00
bmedx
7df1e05f49 Fix xxslint errors in touched files 2019-02-19 11:24:24 -05:00
Julia Eskew
368f221f0a Initial start on annotations. 2019-02-19 11:24:21 -05:00
cclauss
c0c935b685 Old style exceptions --> new style for Python 3 2019-02-19 13:09:23 +01:00
Bessie Steinberg
1a94a69560 ENT-1512: Make Recovery Email Retireable 2019-02-15 14:21:32 -05:00
Calen Pennington
832d354962 Merge pull request #19750 from edx/unicode9
fix unicode strings in openedx/ part 2
2019-02-15 10:57:29 -05:00
Matthew Piatetsky
444799fb0e fix unicode strings in openedx/ part 2 2019-02-15 10:15:51 -05:00
Saleem Latif
00b0baabbb Updating recovery email address from an already verified email address auto verifies the new address 2019-02-15 11:48:11 +05:00
Abdul Mannan
583bede6b9 Add email address to LMS account registeration event 2019-02-15 00:15:53 +05:00
Matthew Piatetsky
f294b1a374 fix unicode strings in openedx/ part 1 2019-02-13 10:47:35 -05:00
Nimisha Asthagiri
4b4957ad9f Merge pull request #19738 from edx/arch/per-field-visibility
Account API: Support Per-field Visibility
2019-02-13 10:05:49 -05:00
Nimisha Asthagiri
34201c62e8 Merge pull request #19790 from edx/pwnage101/read-from-extra-list-of-logout-uris
Additionally logout from a settings list of extra logout URIs
2019-02-12 22:49:36 -05:00
Troy Sankey
10afe5e52f Additionally logout from a settings list of extra logout URIs
Currently, the LMS logout endpoint should iframe in the logout pages of
all the IDAs you were logged into. In short, this was made possible with
DOP because keeping track of the logout URIs and leaving a trail of
evidence in the user cookies was part of what we added in our fork of
DOP.  In the case of DOT, we don't have time or desire to fork DOT to
mirror this behavior, so our stop-gap solution is to log out the user
from a list of logout URIs in settings.
2019-02-12 19:44:41 -05:00
Douglas Hall
b22c1ed0d6 Merge pull request #19746 from edx/douglashall/user_account_api_auth
Modify order of user account api authentication classes.
2019-02-12 17:24:26 -05:00
Michael Youngstrom
d21a57715d Merge pull request #19793 from edx/youngstrom/remove-commonlib-shards
Remove shards from commonlib-unit tests
2019-02-12 17:15:33 -05:00
Douglas Hall
12a5b4cc8d Modify order of Account API authentication classes 2019-02-12 16:37:57 -05:00
Michael Youngstrom
4bbd1dee0b Remove shards from commonlib-unit tests 2019-02-12 14:28:35 -05:00
Rabia Iftikhar
22dea124dd Merge pull request #19709 from edx/ri/EDUCATOR-3965-update_course_schedules
EDUCATOR-3965 fix update course schedules on course start date changed
2019-02-13 00:01:51 +05:00
Nimisha Asthagiri
74eabcf6bb Account API: support per-field visibility 2019-02-12 11:41:29 -05:00
Stu Young
5ac3ef7158 Merge pull request #19770 from edx/revert-19018-opencraft/taranjeet/opt-out-weekly-highlight-messages
Revert "Add api support to let users opt out of email updates."
2019-02-12 10:17:11 -05:00
Awais Jibran
d82314f902 fixing quality 2019-02-12 18:45:18 +05:00
Awais Jibran
717712391f Fixing conflicts 2019-02-12 17:50:58 +05:00
rabiaiftikhar
fdcad0d13c EDUCATOR-3965 fix update schedules on course start date changed 2019-02-12 13:47:22 +05:00
Nimisha Asthagiri
0e79129796 Account API: Enhance Social Link API 2019-02-11 20:17:04 -05:00
Jeremy Bowman
406aa21018 Merge pull request #19763 from singuliere/INCR-40-ipaddress
INCR-40 use ipaddress instead of ipaddr
2019-02-09 21:29:42 -05:00
singuliere
d00cb9bda8 INCR-40 use ipaddress instead of ipaddr 2019-02-09 13:10:06 +01:00
Stu Young
e8374ad944 Merge pull request #19773 from open-craft/jill/flaky-tests-email-updates
Fixes flaky tests in schedules.tests.TestCourseUpdateResolver
2019-02-08 15:39:53 -05:00
David Ormsbee
4aa6446533 Merge pull request #19385 from open-craft/pooja/implement-public-cohort
Implement public cohort for anonymous and unenrolled users
2019-02-08 13:28:02 -05:00
Jillian Vogel
6dfbf94b87 Fixes flaky tests added by https://github.com/edx/edx-platform/pull/19018
using CacheIsolationTestCase
2019-02-08 13:57:25 +10:30
Pooja Kulkarni
9ddb1cc074 Implement public cohort
This PR is based on #19284 and is part of the
series of work related to the proposal #18134.

This PR avoids the assignment of
anonymous/unenrolled users to any cohort when
course is public. Anonymous or unenrolled users
will only see content that does not have a
content group assigned.
The "View Course" link to the course outline
is shown on the course about page for a course
marked public/public outline.
It also makes course handouts available for
public courses (not for public_outline).
This PR also hides the different warnings and
messages asking the user to sign-in and enroll
in the course, when the course is marked public.
It modifies the default public_view text to
include the component display_name when
unenrolled access is not available.
2019-02-07 21:42:21 +05:30
Robert Raposa
a213104790 add user_id scope and claim for JWT cookies
The following changes are made to add LMS user_id:
* Adds user_id scope to the JWT to provide the LMS user_id.
* JWT cookies always use the user_id claim.

ARCH-379
2019-02-07 10:44:35 -05:00