Commit Graph

196 Commits

Author SHA1 Message Date
stv
9112de2309 Deprecate ImageModal HtmlModule
Stop displaying the template in CMS.

This has no effect on already-existing components; it merely prevents
new components from being created with this template.

All functionality has been replaced by the XBlock version [1][2].

Backstory:

This was written by Stanford, circa 2013; it was always a bit of
a hack. While it masquerades as if it were an XBlock/XModule, it's
really a YAML template for the HTML module. It depends on JS/CSS
that is embedded as a first-class citizen of the platform. This has
all caused confusion. Worse, it's a pain to edit/configure/update,
since it uses none of the XBlock infrastructure.

Nearly two years ago, we XBlock-ified the component and have
been running it ever since [1][2]. As such, we no longer support
this "component" and would suggest edX follow suite. Consider this
a request-for-comments on the path forward.

Process:

Deprecation of this module would follow a few steps:

1. Prevent new components from being added in Studio with this template.
    - This PR represents step 1.
    - This is backward compatible; it will have no effect on
      existing components.
2. (optional) Install the XBlock version.
    - This allows new ImageModal components to be added, now via the
      XBlock.
3. (optional) Identify and convert existing HTML modules to XBlocks [3].
    - We have enough of the legacy components in use that we can't
      just break support by removing this feature; we need a
      conversion process.
    - Because these are really just HTML modules with special
      contents, we have to query based on file contents (see, I told
      you this thing was hacky!):
        - All such components must contain an HTML anchor tag with
          the class `modal-content`.
    - Beyond the query, we don't intend to automate the actual
      conversion. Our use of the original component is limited
      enough that it's probably not worth converting from one module
      type to the other. Exacerbating the situation, because it's
      HTML, other changes could have been made to the module that
      would prevent automatic parity. As such, we'll work with our
      CoureOperations team to convert these manually at Stanford.
4. Remove all references.
    - At this point, we can safely remove all supporting static
      assets like CSS, JS, etc.
5. Enjoy less technical debt.

[1] https://github.com/Stanford-Online/xblock-image-modal
[2] https://pypi.python.org/pypi/xblock-image-modal/
[3] The one saving grace of the legacy component is that it was designed
    to degrade gracefully. Specifically, the HTML itself is just an
    image inside a link. The extra platform JavaScript progressively
    enhances the display, if the relevant CSS classes are found. As
    such, even if you removed all supporting CSS/JS from the platform
    tomorrow, existing legacy components would simply render as an image
    that links to a larger copy of itself. This is deemed an acceptable
    failure mode; graceful degradation FTW!
2018-10-03 16:47:38 -07:00
Jeremy Bowman
713d64e1e2 TE-2702 Update Read the Docs links to HTTPS 2018-08-15 17:34:01 -04:00
Michael Terry
4bd3033185 Update list of supported browsers
Update the list of supported browsers in the example about page
template.
2018-04-13 13:03:34 -04:00
cahrens
aa8d222678 New example jsinput problem.
TNL-5893
2017-01-05 16:09:22 -05:00
cahrens
156b43ec0f Allow passing through title to iFrame.
Also changes section to div.

TNL-6044
2016-12-05 12:53:57 -05:00
muhammad-ammar
c3b6b10478 Problem (capa) feedback UX revamp.
TNL-4877
2016-10-06 17:34:43 -04:00
Jesse Shapiro
47d18c35fe Add DnDv2 to advanced problems; relabel DnDv1 as deprecated 2016-10-05 09:22:35 -04:00
Ehtesham
1b960e3e17 requiring codemirror compressed with all addons included 2016-09-02 21:40:20 +05:00
muhammad-ammar
19cc68c8c3 make numerical and math expression input accessible
TNL-4973
2016-09-02 19:44:24 +05:00
Ehtesham
31be6fad43 make CAPA dropdown problems accessible 2016-09-02 19:44:24 +05:00
muhammad-ammar
e1a595d88a make textinput accessible
TNL-4972
2016-09-02 19:44:23 +05:00
muhammad-ammar
7240b6256c Associate descriptions with question text
TNL-5014
2016-09-02 19:44:22 +05:00
muhammad-ammar
d14928cc61 separation based on responsetypes poc
FEDX-176
2016-09-02 19:44:22 +05:00
Alison Hodges
95894da528 Updates and corrects href links to readthedocs 2016-05-17 15:01:00 -04:00
Alison Hodges
a422ad60f7 corrects guide name in template 2016-05-06 14:48:59 -04:00
Alison Hodges
afc5686391 Updates link to learner info in Numerical Input template 2016-05-05 22:29:57 -04:00
Vedran Karačić
5fafdbf5ec Merge pull request #12027 from edx/vkaracic/update-browser-link
Update browser support link
2016-04-04 17:33:29 +02:00
Vedran Karacic
66ff1667be Update browser support link. 2016-04-04 14:36:17 +00:00
Ned Batchelder
d47f872ab7 Fix links to moved sections of the developer guide 2016-04-01 15:33:24 -04:00
Chris Rodriguez
c619e1ec6b Adding UXPL classnames to headings 2016-02-29 15:43:17 -05:00
Chris Rodriguez
81d86eea42 Changing H2 to H3 in problem templates 2016-02-02 15:41:02 -05:00
Sarina Canelake
256dc5b6f8 Reword default about page questions 2015-11-19 15:44:54 -05:00
Christina Roberts
cb21756393 Merge pull request #9063 from edx/christina/tnl-231
Delete mention of direction from checkboxgroup.
2015-07-24 16:58:26 -04:00
cahrens
85b8a88152 Delete mention of direction from checkboxgroup.
It was never implemented.
TNL-231
2015-07-24 14:44:08 -04:00
cahrens
8276172802 Set default value of showanswer to Never since it doesn't work.
TNL-645
2015-07-24 13:32:56 -04:00
muhammad-ammar
5a8b158900 Visual change to new Hints and Feedback problem types
TNL-2619
2015-07-13 12:18:25 +05:00
Alison Hodges
caa6a07d15 Fixes DOC-1957 2015-06-29 13:48:11 -04:00
Nick Parlante
98730f3141 Fix hint-problem tab bug TNL-2542
Revert the removal of hint templates.
Move the 'tab' attribute in the new-problem yaml
files out one level, out of the 'metadata' section.
2015-06-26 09:22:04 -07:00
Sarina Canelake
548d0b662a Remove hinting templates as 'tab:' definition fails on Split 2015-06-22 11:20:08 -04:00
Nick Parlante
77f3069655 Extended Feedback and Hints for Problems
Extends the common capa response types (string, numeric, multiple
choice, checkbox, dropdown) with feedback and hint
capabilities. "Feedback" refers to feedback shown to the student when
they check the problem, looking at their specific answer. "Hints"
refers to a Hint button in LMS which the student can click at any time
to see hints for that problem. The implementation extends the markdown
syntax to include feedback and hints. There are new Feedback-and-Hint
specific templates in Studio when the author clicks to add a new
problem.
2015-06-17 16:25:04 -07:00
Mark Hoeber
238c8152b3 Update studio templates to remove fieldset and legend tags 2015-06-16 20:42:12 -04:00
Colin-Fredericks
cc2d4cad01 DOC-2044 Fixing factor-of-ten error 2015-06-04 07:14:28 -04:00
Adam Palay
0aba5874e6 Revert "Fieldset and legend solution is lost when edit Problem"
This reverts commit 16a248b997.
2015-05-29 18:50:34 -04:00
Ahsan Ulhaq
16a248b997 Fieldset and legend solution is lost when edit Problem
when user try to update a problem the fieldset and legend solution for that
problem is lost because legend and fieldset are not added in the markdownToXml.
So added new markups where fieldset is to be added and used ```>><<``` markup for
legend.

AC-103
2015-05-19 11:46:28 +05:00
Mark Hoeber
356b10c271 Update component templates for accessibility and content 2015-04-27 14:45:36 -04:00
applecool
c4cdfe210f Fix for TNL-1639 2015-04-13 11:41:07 -04:00
Mark Hoeber
12e3cc9d62 Update IFrame, Zooming Image, and Full Screen Image Templates 2015-03-10 20:58:01 -04:00
ahsan-ul-haq
c7c3e44076 Merge pull request #6932 from edx/ahsan/tnl-1073-Placeholder-text-iframe-inaccessible-content
Placeholder text for <iframe> encourages inaccessible content
2015-02-10 16:35:35 +05:00
Ahsan Ulhaq
cded2eb546 Changes in iframe placeholder text 2015-02-09 20:46:08 +05:00
Ahsan Ulhaq
4198b0a33f Placeholder text for <iframe> encourages inaccessible content
Iframe unit in the studio have accesibility issue as there was no title for
Iframe provided as well as placeholder does not specify what changes to made
to add new iframe

TNL-1073
2015-02-09 20:41:32 +05:00
Ahsan Ulhaq
8f71cb6015 Adaptive hint inaccessible
Remove the <p> and label from textline

tnl-1074
2015-02-04 21:42:20 +05:00
Ahsan Ulhaq
9b9301a5d4 Problem with Adaptive Hint is inaccessible
There were no label added for problem with adaptive hint so for the question
added the label and insteat of using for attribute used the label as the
parent of input field

TNL-1074
2015-02-04 21:41:25 +05:00
Zia Fazal
ca3d84a5d4 New pre-requisite course feature via milestones app 2015-01-15 15:17:38 -05:00
Sarina Canelake
db09c5529f Replace 'mit_dome.jpg' and 'simple_graph.png' with a default placeholder image 2014-12-09 22:28:09 -05:00
Sarina Canelake
7779f742c9 Rename pl-faculty.png to placeholder-faculty.png
OPEN-328
2014-12-09 22:28:09 -05:00
Waheed Ahmed
430aa4f834 Added alt attribute in image map input problem.
TNL-822
TNL-825
2014-11-20 16:58:26 +05:00
Adam Palay
becd4c1b9a update latex problem data (TNL-264) 2014-10-21 16:58:30 -04:00
Dave St.Germain
978ed1064c Removed spacebar event handler, because it did more harm than good. 2014-08-28 15:11:47 -04:00
jmclaus
58ca939ba6 Merge pull request #4292 from terman/jsinput
Supply initial_state attribute for jsinput tag
2014-07-30 16:56:45 +02:00
stv
0aba4f7ec6 Wrap JSInput Python code in CDATA section
Python code can commonly contain characters that are invalid XML, such
as '<' and '>'. This has proven to be a pain point for instructors
implementing custom Python grading functions for their JSInput problems
(see sample code below).

This change creates a more robust template from which to make
modifications.

```python
    # This is an XML syntax error, when not inside a CDATA section.
    if i < 0:
        print('negative')
```
2014-07-25 12:11:33 -04:00