Commit Graph

17091 Commits

Author SHA1 Message Date
David Ormsbee
7c9f4a2533 Merge pull request #21178 from edx/ormsbee/remove_dashbaord_cookie_reset
Remove user cookie reset on Student Dashboard.
2019-07-22 10:40:42 -04:00
Ayub
16c7227c07 Merge pull request #21068 from edx/INCR-403
INCR-403 python3 compatibility
2019-07-22 14:52:04 +05:00
Ayub
560da82837 Merge pull request #21067 from edx/INCR-402
INCR-402 python3 compatibility
2019-07-22 14:47:18 +05:00
Aarif
04bcfa5c3e Merge pull request #21083 from edx/INCR-422
INCR-422 Python 3 compatibility
2019-07-22 14:33:48 +05:00
Aarif
d77b2fe9cc Merge pull request #21082 from edx/INCR-415
INCR-415 Python 3 compatibility
2019-07-22 13:53:15 +05:00
David Ormsbee
0f51b58f75 Remove user cookie reset on Student Dashboard.
The enrollmentStatusHash cookie value was created in commit f0030334
as an optimization, in order to determine whether the marketing site
needs to refresh the list of a student's enrolled courses with a
call to the LMS. To ensure that this value was kept up to date,
commit d7a7bcc1 reset the user's cookies every time they go to the
learner dashboard page (which used to be the next page loaded after
you enrolled in a course). This didn't just reset the
enrollmentStatusHash though -- it recalculated all the cookie
values, as if you had just logged in.

A number of things have changed since then:

1. Enrolling in a course now goes to that course's info/navigation
   page, rather than going to the student dashboard.
2. It doesn't appear that the value of enrollmentStatusHash is
   actually being examined anywhere -- it's set in a cookie on the
   LMS and read/written by the edX marketing front end code, but
   the value is never looked at to make any decisions.
3. The introduction of add_email_marketing_cookies (which triggers
   off of the CREATE_LOGON_COOKIE signal) has made cookie resets
   far more expensive, as there is a blocking call to Sailthru if
   you have that enabled in EmailMarketingConfiguration (which
   edx.org does). This can add over two seconds to the server
   processing time for the student dashboard at certain times of
   day.

Given this, I'm removing both the call to resetting the cookie on
the student dashboard page, as well as setting the value for
enrollmentStatusHash.
2019-07-21 20:16:19 -04:00
Uzair Rasheed
eed0dfbbe4 Merge pull request #21149 from edx/PROD-305/add-credit-mode-enrollment
Add credit mode in support enrollment tool.
2019-07-21 00:45:52 +05:00
Feanil Patel
7ae8221a47 Merge pull request #21055 from amitvadhel/INCR-411
INCR-411: Updates on Python 3.x
2019-07-19 10:18:04 -04:00
aarif
ccff822a28 ran python-modernize and isort on files mentioned in INCR-396 2019-07-19 10:04:05 -04:00
Ayub khan
83bc838fae python 3 compatibility 2019-07-19 10:02:38 -04:00
Ayub khan
33bcb76a26 INCR-400 python3 compatibility 2019-07-19 10:00:39 -04:00
Feanil Patel
d1556fc86d md5 needs bytes in python 3 but a sting is fine in python2. 2019-07-19 09:48:10 -04:00
Feanil Patel
d9c9d7bab9 Deal with NoneType access.
The `NoneType` object is not available from the `types` module in
python 3. This is a workaronud to deal with that.
2019-07-19 09:48:10 -04:00
uzairr
07821927e2 Add credit modein support enrollment tool.
Currently, enrollment support tool is only allowing support members
to change course enrollment only one of the two modes i.e. audit and
verified.To move a learner other than these modes,they need to ping
devops.To broaden the scope of enrollment support tool,changes have
been done so that enrollment would be changed to other modes as well.

PROD-305
2019-07-19 18:14:35 +05:00
DawoudSheraz
7131809fec add submission deadline methods in InheritanceMixin 2019-07-19 16:06:06 +05:00
Awais Qureshi
3ed1399216 Merge pull request #21065 from edx/awais786/INCR-398
INCR-398
2019-07-19 11:33:43 +05:00
amitvadhel
7d05a9666a INCR-411: Disable python-wrap-html for xss-lint 2019-07-18 21:29:32 +03:00
zaidbamber161
d3b1fd24f7 Fixed CDN urls to Static urls. 2019-07-18 17:48:00 +05:00
Awais Qureshi
af50c3c043 Merge pull request #21063 from edx/awais786/INCR-397
INCR-397
2019-07-18 14:34:43 +05:00
Awais Qureshi
8b278f3ac2 Merge pull request #21062 from edx/awais786/INCR-395
INCR-395
2019-07-18 12:19:30 +05:00
Awais Qureshi
288195e1be Merge pull request #21060 from edx/awais786/INCR-394
INCR-394
2019-07-18 12:15:37 +05:00
edX Transifex Bot
30ec66e988 geoip2: update maxmind geolite country database 2019-07-17 16:52:32 -04:00
Stu Young
10d583fe4e add pytest decorator for skipping py3 test (#21151)
* add pytest decorator for skipping py3 test

* quality
2019-07-17 12:09:01 -04:00
David Ormsbee
a712f1f93b Remove full table scan of VerificationDeadline. (#21119)
* Remove full table scan of VerificationDeadline.

Before this commit, we were doing a full table scan of
student_verificationdeadline, loading the results into a giant
dict, and reading/writing that to the cache. This was fine when the
code was introduced and there were dozens of courses, but now that
we're over 12K courses, it's becoming a major performance issue for
the Student Dashboard.

This uses a subquery to the course enrollment table so that we're
only ever pulling back the deadlines to a student's enrolled courses
for any given request. It removes the cache access entirely.
2019-07-17 10:25:08 -04:00
aarif
642e3b8bfc ran python-modernize and isort on files mentioned in INCR-422
changes made to comply with quality
2019-07-16 10:09:08 +00:00
aarif
46fe6fdcea ran python-modernize and isort on files mentioned in INCR-415
changes made to comply with quality

changes made to comply with quality

changes made to comply with quality
2019-07-16 10:06:16 +00:00
Jillian Vogel
d3ce0b759e SE-1151 Campus.il Inlines all 36 discussion underscore templates (fixed) (#21094)
Inlines all 36 discussion underscore templates

imported by lms/templates/discussion/_underscore_templates.html
to reduce file system load when displaying inline discussion blocks.

Ignored error where fix required changing the translated text string,
due to differences between underscore and HtmlUtils format strings.
2019-07-15 20:51:42 -04:00
zaidbamber161
d4c41008b4 Updated logs information 2019-07-15 15:50:37 +05:00
zaidbamber161
f02b34c1a1 Updated logs information 2019-07-15 15:50:37 +05:00
zaidbamber161
f86d0c8e16 Fixed quality test 2019-07-15 15:50:37 +05:00
zaidbamber161
bc7e2a900c Added logs for XQueue 2019-07-15 15:50:37 +05:00
Alan Zarembok
1e6d6de4c1 Merge pull request #21093 from edx/azarembok/handle-capa-exceptions
PROD-448: Capa problems become uneditable.
2019-07-11 17:34:31 -04:00
Alan Zarembok
95616d7d11 PROD-448: Gracefully handle exceptions from user-supplied code in
advanced problems so that they do not become uneditable.
2019-07-11 14:45:58 -04:00
Matt Tuchfarber
b1998e202e Merge pull request #20945 from edx/tuchfarber/remove_journals
Remove all references to Journals
2019-07-11 11:08:24 -04:00
Amit
0044bef4fd INCR-393: Updates on Python 3.x (#21054) 2019-07-11 10:21:47 -04:00
Ayub khan
102dca6ae6 INCR-403 python3 compatibility 2019-07-11 14:45:01 +05:00
Ayub khan
6661745e77 INCR-402 python3 compatibility 2019-07-11 14:42:14 +05:00
arbisoft
e87dc6cc77 Fixing python-modernize issues. 2019-07-11 14:24:38 +05:00
arbisoft
004d856316 Fixing python-modernize issues. 2019-07-11 14:04:05 +05:00
arbisoft
c82b0110b0 Fixing python-modernize issues. 2019-07-11 13:37:11 +05:00
arbisoft
503622c5d2 Fixing python-modernize issues. 2019-07-11 12:59:47 +05:00
amitvadhel
182a177b4e INCR-411: Updates on Python 3.x 2019-07-11 00:15:33 +03:00
edX Transifex Bot
3298119374 geoip2: update maxmind geolite country database 2019-07-10 20:33:14 +00:00
Edward Zarecor
ecb5d000a3 Merge pull request #20931 from edx/e0d/fix-circuit-js
Adding changes from CT to fix circuit simulator on moder chrome.
2019-07-10 12:28:24 -04:00
David Ormsbee
930d7f2867 Revert "SE-1151 Campus.il Inlines all 36 discussion underscore templates (#20742)"
This reverts commit 44562a1592.
2019-07-10 11:45:28 -04:00
Edward Zarecor
2596b67664 updating to ensureHTML 2019-07-10 10:07:52 -04:00
Matt Tuchfarber
2583d317db Remove all references to Journals 2019-07-09 14:19:25 -04:00
edX cache uploader bot
a72198d915 Updating Bokchoy testing database cache (#21006) 2019-07-09 13:03:53 -04:00
Edward Zarecor
9153703212 Adding changes from CT to fix circuit simulator on moder chrome. 2019-07-09 10:04:42 -04:00
Aarif
831be7d7e6 Merge pull request #20963 from mraarif/INCR-319
INCR-319 - python 3 compatibility
2019-07-09 12:03:24 +05:00