Commit Graph

12434 Commits

Author SHA1 Message Date
Bianca Severino
8523ffda91 Merge pull request #27651 from edx/bseverino/drop-expiry-date
[MST-785] Remove expiry_date from SoftwareSecurePhotoVerification
2021-05-17 13:34:24 -04:00
Justin Hynes
e0cfae745f Merge pull request #27646 from edx/jhynes/microba-1209_function-cleanup
refactor: consolidate (mostly) duplicated function
2021-05-17 12:59:42 -04:00
Bianca Severino
bba7ea5d37 fix: remove expiry_date from SoftwareSecurePhotoVerification 2021-05-17 12:56:28 -04:00
Justin Hynes
563a762625 Merge pull request #27643 from edx/jhynes/microba-1238_cleanup-external
refactor: update function calls outside of certificates app for updated `generate_user_certificates` and `regenerate_user_certificates` functions
2021-05-17 12:34:45 -04:00
Dillon Dumesnil
35d62ff365 Merge pull request #27602 from edx/ddumesnil/improve-course-goals-aa-768
feat: AA-768: Add history to Course Goals model and update events
2021-05-17 09:29:39 -07:00
Dillon Dumesnil
d46f6369ea feat: AA-768: Add history to Course Goals model and update events
Also removes the remove_course_goal method as it is no longer
used anywhere and removes the functionality of deleting course goals
if a user unenrolls. Adds in fields for eventing to make them more
useful.
2021-05-17 11:55:27 -04:00
Justin Lapierre
58c57342ab Merge pull request #27218 from open-craft/0x29a/bb3611/improve_zip_file_content_structure
[BD-05][TNL-7915][BB-3611] Improve ZIP File content structure
2021-05-17 10:01:56 -04:00
Bianca Severino
f72054eee0 Merge pull request #27614 from edx/bseverino/remove-expiry-date
[MST-785] Remove references to expiry_date in IDV
2021-05-17 09:56:38 -04:00
Justin Hynes
d4f3e11092 refactor: consolidate (mostly) duplicated functions
[MICROBA-1209]
Part of the modulestore cleanup/removal in the certificates app. The function `list_with_level_from_course_overview` was temporary. Cleaning this up. Modifying the original `list_with_level` to accept a course-id/course-key as it doesn't actually need the entire course object.
* Update `list_with_level` function to accept a course run id/course-key
* Remove `list_with_level_from_course_key` function (and update any functions using it to use `list_with_level` again)
2021-05-17 09:50:39 -04:00
Justin Hynes
313a295c95 refactor: update function calls outside of certificates app for updated generate_user_certificates and regenerate_user_certificates functions
[MICROBA-1238]
* remove unused `course` argument from `generate_user_certificates` function in the certificates app
* remove unused `course` argument from `regenerate_user_certificates` functioni n the certificates app
* remove `course` argument if passed in edx-platform apps outside of the certificates app
2021-05-17 09:39:36 -04:00
Justin Hynes
ae750fb9d2 Merge pull request #27626 from edx/jhynes/microba-1238_cleanup
refactor: remove unused `course` arguments from certificate generation functions
2021-05-17 09:38:29 -04:00
0x29a
6aa70b764d feat: remove course_id argument and upgrade ora2 dependency 2021-05-17 15:21:03 +02:00
Dillon Dumesnil
e885733881 Merge pull request #27622 from edx/ddumesnil/update-completion-aa-802
feat: AA-802: Update the BlockCompletionTransformer
2021-05-17 06:05:29 -07:00
Justin Hynes
70810879e0 refactor: remove unused course arguments from certificate generation functions
[MICROBA-1238]
- Remove unused `course` arguments from certificate generation functions

Part of our cleanup after removing use of the modulestore from the Certificates app.
2021-05-14 15:38:43 -04:00
Dillon Dumesnil
6f773d1eca feat: AA-802: Update the BlockCompletionTransformer
We discovered a subsection that contained a unit without any content
inside, but because of our logic requiring children, it would never be
marked complete (meaning the subsection, section, and course could thus
never be marked complete). This fixes that by removing the children
check from setting completion, but first gating that code path on the
xblock being an aggregator (to prevent leaves from marking as true
simply because there are no children).

Test fixes include adding a test for the empty aggregator case as
well as some changes to not have an entire course marked complete
because they are all empty aggregators.
2021-05-14 11:22:07 -04:00
Justin Hynes
7edaf8aae3 Merge pull request #27612 from edx/jhynes/microba-1208_consolidate-functions
refactor: consolidate duplicate utility functions in certificates app
2021-05-14 07:34:11 -04:00
Carla Duarte
2d2ceb8728 Merge pull request #27601 from edx/ciduarte/AA-790
fix: handle unenrolled users in course home APIs (AA-790)
2021-05-13 14:44:52 -04:00
Carla Duarte
2f8572d540 fix: handle unenrolled users in course home APIs (AA-790) 2021-05-13 14:08:44 -04:00
Giovanni Cimolin da Silva
9a334a383e feat: Add changes for waiting step details
Bump ORA version and fix method signature.
2021-05-13 09:27:53 -03:00
Justin Hynes
dd06820cad refactor: consolidate duplicate utility functions in certificates app
[MICROBA-1208]
* consolidate `has_html_certificates_enabled` and `has_html_certificates_enabled_from_course_overview`, the latter of the two functions was created for use during our transition away from using the modulestore in the certificate app.
2021-05-13 07:52:02 -04:00
Binod Pant
da9afe6290 fix: 🐛 ENT-4525 fix learner portal experience when missing courseEnrollment records (#27611)
* fix: 🐛 ENT-4525 fix learner portal experience courseEnrollment records are missing

sometimes integrations may create EnterpriseCourseEnrollments but for some reason missing courseEnrollment, in this case we want to just filter out the EnterpriseCourseEnrollments instead of erroring the learner poratl

ENT-4525

* fix: pylint fixes

pylint fixes
2021-05-13 07:27:17 -04:00
Bianca Severino
69b6cf8d42 feat: remove references to expiry_date in IDV 2021-05-12 16:42:32 -04:00
Justin Hynes
462ccf46ab Merge pull request #27607 from edx/jhynes/microba-1178_modulestore-cont
refactor: remove use of modulestore in certificates app
2021-05-12 14:10:36 -04:00
Justin Hynes
ee5c881a46 refactor: remove use of modulestore in certificates app
[MICROBA-1178]

* Remove use of modulestore in `queue.py`
* Remove use of modulestore in `ungenerated_certs.py`
* Remove use of modulestore in `resubmit_error_certificates.py`
* Update unit tests in `test_cert_management.py`
2021-05-12 13:35:32 -04:00
Christie Rice
4854b2eb17 refactor: Use api instead of calling the certificate whitelist model directly (#27606)
MICROBA-1212
2021-05-12 11:40:32 -04:00
Diana Huang
7f10a9b571 Merge pull request #27577 from edx/diana/clean-student-migrations
refactor: Remove squashed student migrations.
2021-05-12 10:37:20 -04:00
Christie Rice
1473973b2b refactor: Rename whitelist to allowlist (#27533)
MICROBA-1021
2021-05-12 09:51:26 -04:00
Diana Huang
3eb2078c38 refactor: remove squashed student migrations
We squashed migrations in the student djangoapp a while back.
This is the followup work to remove the migrations that were
squashed and to convert the squashed migration into a 'normal'
migration.

ARCHBOM-1177
2021-05-11 15:19:17 -04:00
Diana Huang
55a3469d37 refactor: Remove shoppingcart djangoapp.
Now that we have passed the named release boundary,
removing these migrations is no longer a breaking change.

https://openedx.atlassian.net/browse/DEPR-43
2021-05-11 14:07:13 -04:00
Usama Sadiq
4f4be6538a BOM-2477: pylint warnings lint-amnesty (#27585) 2021-05-11 17:22:40 +05:00
Justin Hynes
d09639fe77 Merge pull request #27563 from edx/jhynes/microba-1178_modulestore-removal-utils
refactor: remove use of modulestore in certificates app
2021-05-11 07:34:23 -04:00
Christie Rice
4dae1abd67 fix: Remove unused allowlist flag (#27576)
MICROBA-1073
2021-05-10 15:04:11 -04:00
Matthew Piatetsky
526982c548 Merge pull request #27505 from edx/AA-759
[AA-759] feat: Add flag for AA-759 streak celebration discount experiment
2021-05-10 14:43:40 -04:00
Matthew Piatetsky
9c5992521a feat: Add flag for AA-759 streak celebration discount experiment
AA-759
2021-05-10 13:11:07 -04:00
Christie Rice
4867535d2d refactor: Use certificates api method instead of the model, and rename whitelist to allowlist. Also move method to certificates app to prevent circular import. (#27532)
MICROBA-1021
2021-05-10 13:02:43 -04:00
Justin Hynes
80833406c7 refactor: remove use of modulestore in certificates app
[MICROBA-1178]

* remove use of modulestore in `utils.py` of the certificates django app
2021-05-07 15:30:03 -04:00
Dillon Dumesnil
5085580697 Merge pull request #27554 from edx/ddumesnil/start-end-date-comments
refactor: Switch to using course_overview start and end everywhere
2021-05-07 10:46:25 -07:00
Vladas Tamoshaitis
ec98847c74 feat: Add Waffle flag to enable/disable special exams on MFE learning (#27545)
* feat: Use forked RG version of edx_proctoring in devstack

* Add waffle flag for special exams for mfe (#2371)

* feat: add waffle flag for special exams for mfe

* fix: waffle flag name, add coma to imports

Co-authored-by: Vladas Tamoshaitis <vladas.tamoshaitis@raccoongang.com>

* fix: revert requirements for master branch

* fix: revert dev requirements

* fix: trailing comma after imported item

* feat: add special exams waffle flag test

* fix: use ENABLE_SPECIAL_EXAMS global settings flag

* fix: toggle description

* fix: naming of waffle flag helpers to reflect relation with mfe

* fix(tests): assertion operators order

Co-authored-by: Sagirov Eugeniy <sagirov19@gmail.com>
Co-authored-by: Sagirov Evgeniy <34642612+UvgenGen@users.noreply.github.com>
Co-authored-by: Vladas Tamoshaitis <vladas.tamoshaitis@raccoongang.com>
2021-05-07 08:52:53 -04:00
Justin Hynes
50bbbc6aa6 Merge pull request #27526 from edx/jhynes/microba-1178_modulestore-generation
refactor: Remove use of modulestore in certificates app (cont)
2021-05-07 08:00:44 -04:00
Dillon Dumesnil
89c463ff29 refactor: Switch to using course_overview start and end everywhere
In DE-1822, we believed we needed to switch to start_date and end_date.
It was determined this was not the case, so this updates the comment
to ensure future users use the correct fields (start and end) and
updates any pieces of code that may have used start_date or end_date.
2021-05-06 16:42:10 -04:00
Kshitij Sobti
161e3560dd feat: Add REST endpoints for problem response report generation that can be driven by MFEs. (#27313) 2021-05-06 14:05:14 -04:00
Michael Terry
6af535f476 Merge pull request #27517 from edx/mikix/delete-marketing-model-2
feat: drop unused EmailMarketingConfiguration model
2021-05-06 10:20:32 -04:00
Christie Rice
ce591fd3ea refactor: Rename whitelist to allowlist (#27504)
MICROBA-1021
2021-05-05 10:51:31 -04:00
Gábor Boros
6ccdaca345 [SE-4101] fix: address VisibleBlocks caching race condition (#27359)
* fix: address VisibleBlocks caching race condition

* sets visual block creation in an atomic transaction

* refactor: add logging statement to bulk create

Co-authored-by: Raul Gallegos <raul@opencraft.com>
2021-05-05 10:26:35 -04:00
Justin Hynes
f64c7332f8 refactor: Remove use of modulestore in certificates app
[MICROBA-1178]
* Remove use of modulestore in `../certificates/generation.py`.
* Remove use of modulestore in `../certificates/views/support.py`.
* Remove use of modulestore in `../certificates/views/xqueue.py`.
2021-05-05 09:55:56 -04:00
Uzair Rasheed
c450de4062 Merge pull request #27496 from edx/update-login-api
upgrade login api
2021-05-05 13:15:22 +05:00
Michael Terry
78c6be8bee Merge pull request #27422 from edx/mikix/handler-will-recheck-access
fix: the get_completion JS handler should not ignore FBE blocks
2021-05-04 15:54:36 -04:00
Michael Terry
3d1b582092 feat: drop unused EmailMarketingConfiguration model
This is the second attempt at it. The first had to be reverted to
avoid some blue/green deploy issues.
2021-05-04 13:56:59 -04:00
Julia Eskew
599d21b7bb feat: Deny course staff visibility of legacy courseware. (#27469)
Currently, course staff can always view their courses
in the Legacy courseware experience.

With this change, course staff will *not* be able
to view their courses if the New (MFE) courseware
experience has been enabled for them.

This does not affect global staff, and it does not
affect courses that are still running in the Legacy
experience.

Adds a new parameter returned by the course metadata API
used by the courseware MFE to determine if the button to
show legacy experience should be displayed or not.

TNL-8203
2021-05-04 13:55:34 -04:00
Justin Hynes
6313c1ba67 Merge pull request #27501 from edx/jhynes/microba-1178_modulestore
refactor: reduce certificate django apps dependence on the modulestore (generation_handler)
2021-05-04 13:03:15 -04:00