Commit 994ccd1 contained a bug that caused new posts created via the
courseware interface to not get posted to the correct topic. They would
appear to work but would actually be posted to the "undefined" topic.
This has now been fixed.
JIRA: FOR-154
The filter box will now remain fixed while the rest of the menu scrolls.
This also fixes a minor cosmetic bug in which the thread list would
overflow its container if the user opened the browse menu, scrolled the
page, and then closed the browse menu.
The home button is removed, the search box is always displayed, and many
visual adjustments are made, along with a large amount of refactoring.
Originally reviewed in #4211
Thread entries now show an activity count that includes the original
post, and only one of the vote count and activity count is displayed
based on the user's selected sort. The sorting and filtering options now
both use a select and are somewhat more verbose, and the visual styling
of the sort/filter bar is updated.
Originally reviewed in #4165 with a bugfix in #4211
The rendering of the link happens in an event handler, and the
collection's attributes were not getting set properly before the reset
event triggering the rendering occurred.
Originally reviewed in #4072
A thread will be labeled if it is pinned, if the user is following it,
or if it was authored by a staff member or community TA. This also
slightly changes the color used for community TA labels.
Originally reviewed in #4072
Use larger and lighter title font, decrease padding, and use lighter
solid backgrounds instead of gradients. Also, refactor SASS code to
conform better to our new style, including using more specific class
names.
Originally reviewed in #4072
Declare variables locally
- The `allSections` variable was leaking into the global scope, due to a
typo in the declaration.
- `dataProcessed` can be declared more narrowly within the callback.
Clean up fixtures automatically between tests
- Nesting test fixture markup within a DIV allows Jasmine to
automatically restore the fixture to a clean state between each test
run.
Fix id attribute collision typo
- This looks like a copy/pasta gone wrong; the two test INPUT elements
were both declared with the same id, `input_1`.
Remove trailing whitespace
The behavior previously tested here was to check that if a JSInput
element was marked as not processed, re-walking the DOM *should* have
reinitialized it. Unfortunately, this behavior is not supported by the
underlying JSChannel library. In fact, if JSChannel detects an existing
channel with the same origin and scope, it throws an uncaught exception,
leaving the DOM in a "broken" state.
JSInput will prevent duplicates from being added, as long as we don't
manually update the `data-processed` attribute. This behavior is already
being tested.
Select DOM elements with wildcard syntax
- DOM lookups were being done with non-existent literal selectors, so it
was returning empty lists. As assertions were to be made while
iterating over the list of elements, nothing was actually being
verified.
- Common code has been centralized in the setup function. By declaring
CSS selectors once, we minimize the odds of inadvertently using the
wrong selector, as happened here.
- Had these tests actually been iterating over a non-empty list, this
would have thrown undefined exceptions. jQuery.each calls its handler
with an index and an item/object as the arguments. However, the object
is a DOM-object, not a jQuery-object. These tests break, as they had
assumed the latter.
This test currently fails, meaning that the existing tests weren't
testing what they claimed.
Assertions are made for each element returned by the CSS selectors.
However, the selectors are assumed to be wildcard matches, but are
actually literal selectors. As there are no matched elements, this
causes the assertions to be (silently) checked zero times, without
failure.
- Fixed camel case for variable name
- Fixed indentation in imageannotation.html
- Changed all mentions of Instructor Username to Email
- Turned annotation_mode into phrase
- Fixed indentation in imageannotation.html
- Added comments in imageannotation.html
- Changing annotation_mode in OSDA
- Added component to view
- Added correct images for OSD
- Fixed path to codemirror
- Tinymce fullscreen works now
- Pep8/Pylint Fixes
- Default image changed and added call to super
