Commit Graph

21294 Commits

Author SHA1 Message Date
Michael Terry
7fbe2ff6da Merge pull request #24234 from edx/mikix/instructor-dashboard-pls
AA-184: Fix extension dashboard for self-paced courses
2020-06-22 08:56:27 -04:00
edX Transifex Bot
4f6aad45c8 fix(i18n): update translations 2020-06-21 17:35:47 -04:00
David Ormsbee
e69a5fce56 Merge pull request #24220 from open-craft/samuel/fix-youtube-metadata-api
SE-2634 Fix crashes in yt_video_metadata
2020-06-19 12:24:28 -04:00
David Ormsbee
0b4cf7e06c Merge pull request #23039 from open-craft/samuel/fix-unescaped-selector
SE-2176 Fix elem not selected if id contains special chars
2020-06-19 12:13:20 -04:00
Michael Terry
d4506b73f4 AA-184: Fix extension dashboard for self-paced courses
- Have it load dates from edx-when, not just write to it. This
  fixes self-paced courses where edx-when is only place dates are
  kept.
- Have it read original date for a homework from edx-when when
  resetting a date. This fixes the message it gives the instructor
  about whether it was successfully reset.
- Have it recursively set a date, rather than assuming that dates
  are only ever set on the subsection layer. This fixes setting
  dates on self-paced courses (where dates are set all the way
  down) and just in case somebody somewhere edits the course xml
  to have a date where it's not expected.
2020-06-19 11:34:52 -04:00
Dillon Dumesnil
a1e0dcc495 Merge pull request #24241 from edx/ddumesnil/AA-194
AA-194: Updating edx-when version
2020-06-19 07:48:47 -07:00
Dillon Dumesnil
1f035ab420 AA-194: Updating edx-when version
Updating edx-when version to pull in a change related to not
returning dates if the enrollment happened after course end
(if no enrollment end date is set)
2020-06-19 07:28:12 -07:00
Leonardo Martinez
b4fee68283 Fix the DeprecationWarning for unescape (#23936)
This PR solves the DeprecationWarning mentioned in:
https://build.testeng.edx.org/job/edx-platform-python-pipeline-master/warning_5freport_5fall_2ehtml/

HTMLParser was renamed in html.parser in Python3:
https://docs.python.org/2/library/htmlparser.html#module-HTMLParser

* html_parser.HTMLParser().unescape from six.moves has been deprecated

* instead use html.unescape from Python3

Documentation for unescape in Python3:
https://docs.python.org/3/library/html.html#html.unescape

- html_parser from six.moves has been deprecated

- instead use html.parser from Python3

- Order imports using isort

- Delete unused import crum
2020-06-19 09:27:45 -04:00
stvn
2f7372202b Update masquerade API to show only active partitions 2020-06-18 14:54:50 -07:00
stvn
994b2b002f Add explicit masquerade support to courseware API 2020-06-18 14:54:49 -07:00
stvn
a69855e9ad Merge PR #24245 cleanup/log.warn
* Commits:
  Replace references to 'log.warn' with 'log.warning'
2020-06-18 14:50:37 -07:00
Daniel Francis
82c0ca0da8 Fixing implicit parser name for Beautiful Soup (lms, openedx) (#24100)
Fixing 56 GuessedAtParserWarnings, in commit edx#24098

Background: BeautifulSoup automatically picks the fastest parser available. By default, it picks the "lxml" parser.

Per the [BeautifulSoup](https://www.crummy.com/software/BeautifulSoup/bs4/doc/#installing-a-parser) documentation:

> Beautiful Soup supports the HTML parser included in Python’s standard library, but it also supports a number of third-party Python parsers. One is the lxml parser. Depending on your setup, you might install lxml with one of these commands.
> Another alternative is the pure-Python html5lib parser, which parses HTML the way a web browser does. 

Context: We changed two statements, one in lms and another in openedx. Both statements fire up BeautifulSoup. Now we explicitly ask for "lxml," following the recommendation on BeautifulSoup's documentation:

> If you can, I recommend you install and use lxml for speed. If you’re using a very old version of Python – earlier than 2.7.3 or 3.2.2 – it’s essential that you install lxml or html5lib. Python’s built-in HTML parser is just not very good in those old versions.

Before:
`soup = BeautifulSoup(content)`

After:
`soup = BeautifulSoup(markup=content, features="lxml")`

The warnings are gone, tests are passing in local.
2020-06-18 15:41:07 -04:00
Nathan Sprenkle
5cedc64f41 Correct team count for private team-sets in Teams tab (#24216)
* Hide private team-sets from users not on a team

* Modify add team count to factor in team visibility

* Fix bug that broke search w/in private team-sets
2020-06-18 15:21:58 -04:00
stvn
0ae91c0921 Replace references to 'log.warn' with 'log.warning'
to remove some `DeprecationWarning`s from the logs
as the former method as been deprecated since Python 3.3 [1][2].

- [1] https://github.com/python/cpython/blob/3.3/Lib/logging/__init__.py#L1252-L1253
- [2] https://stackoverflow.com/a/15655674
2020-06-18 12:08:15 -07:00
Nick
3c3431a482 Merge pull request #24252 from edx/ndalfonso/fix-dates-banner-translations
Fix Dates Banner Translations
2020-06-18 13:08:40 -04:00
Nicholas D'Alfonso
e0fecb47e4 Fix Dates Banner Translations
- replace unicode apostrophes with single quotes in dates banner.
- change language in button from 'Reset my deadlines' to 'Shift
  due dates'
2020-06-18 12:20:47 -04:00
Jansen Kantor
7e459c7228 EDUCATOR-5069: Display student key in csv export (#24235)
* use external_user_key in teams csv download
2020-06-18 12:13:06 -04:00
Michael Terry
d325943fe5 Merge pull request #24169 from edx/mikix/celebration
AA-137: Support courseware celebrations
2020-06-18 10:49:36 -04:00
Adam Butterworth
a024f56bb9 Merge pull request #24124 from eduNEXT/ama/DEPR-68/DEPR-84
[BD-10] [DEPR-68][DEPR-84] Remove pattern library of learner_dashboard/programs.py
2020-06-18 09:16:14 -04:00
Adam Butterworth
1b60797c49 Merge pull request #24101 from eduNEXT/lmm/depr70
[BD-10] [DEPR-70] Remove waffle flag edx_discussions.use_bootstrap.
2020-06-18 09:15:32 -04:00
Adam Butterworth
98dd03a638 Merge pull request #24077 from eduNEXT/ama/DEPR-78/DEPR-82
[BD-10] [DEPR-78][DEPR-82] Remove pattern library of latest-update-fragment.html and welcome-message-fragment.html
2020-06-18 09:15:20 -04:00
Adam Butterworth
0768acbf40 Remove pattern library of course_experience/course-outline-fragment.html (#24044) 2020-06-18 09:14:38 -04:00
Aura Milena Alba
078dcc4296 Remove use pattern library of EdxFragmentView and discussion/maintenance_fragment. (#24029) 2020-06-18 09:10:18 -04:00
Michael Terry
450072582e AA-137: Support courseware celebrations
- Add a new CourseEnrollmentCelebration model, which ties a
  course enrollment to some booleans about progress celebrations
- Add serialization of the new model to the existing courseware_api
  app's existing course info view
- Add new API in courseware_api to update a celebration model
2020-06-16 15:19:21 -04:00
Alex Wang
931f0ae5f5 add username and email to getProgramEnrollment response (#24186)
MST-234
2020-06-16 11:57:23 -04:00
Samuel Walladge
43f0cd72af Merge remote-tracking branch 'origin/master' into samuel/fix-unescaped-selector 2020-06-16 09:52:38 +09:30
Matt Tuchfarber
9423c2c4d6 Merge pull request #24224 from edx/revert-24210-tuchfarber/add_demographics_banner_to_theme
Revert "Add demographics prompt to edx.org theme"
2020-06-15 15:21:22 -04:00
Carla Duarte
8949ee96da Merge pull request #24193 from edx/ciduarte/AA-181
AA-181: Updating Outline Tab API to include Course Blocks
2020-06-15 15:15:53 -04:00
Nick
badf3281b3 Merge pull request #24122 from edx/ndalfonso/AA-133-mfe-dates-banner
AA-133 mfe dates banner
2020-06-15 15:08:02 -04:00
Matt Tuchfarber
7edac4e4b2 Revert "Add demographics prompt to edx.org theme" 2020-06-15 14:54:54 -04:00
Nicholas D'Alfonso
9a83d0781b AA-133 mfe dates banner
- add serializer mixin to expose date banner info
- add endpoint to reset deadlines for a sepcific course
2020-06-15 14:22:23 -04:00
0x29a
a8b13afe48 Add 'ENABLE_ORA_USERNAMES_ON_DATA_EXPORT' feature toggle in common settigns file 2020-06-15 17:29:32 +02:00
Matt Tuchfarber
fd145713b3 Merge pull request #24210 from edx/tuchfarber/add_demographics_banner_to_theme
Add demographics prompt to edx.org theme
2020-06-15 10:43:52 -04:00
Awais Jibran
5d4df5383b Change switch to waffle flag. 2020-06-15 15:15:10 +05:00
Samuel Walladge
4da0c64cc3 Fix crashes in yt_video_metadata
- yt_video_metadata returned a generic non-json-api-friendly 500 error
  when called on a non-youtube video
- load_metadata_from_youtube was crashing when called from the xblock
  yt_video_metadata endpoint. It passes a webob request, which has a
  different api for retrieving the http referer.
2020-06-15 17:29:57 +09:30
Carla Duarte
4537408383 AA-181: Updating Outline Tab API to include Course Blocks 2020-06-12 14:52:56 -04:00
Matt Tuchfarber
b7cf7808b8 Add demographics prompt to edx.org theme
- Add bootstrap utility function to lms-base-v1 CSS
- Moved coaching sass to edx.org theme
- Banner feature flag and MB program gated
2020-06-12 10:58:37 -04:00
Robert Raposa
7e56d89bcc remove temp_view_func_compare custom metric (#24211)
In an earlier PR, we moved logic from process_view to process
request, so mapping would happen earlier in the middleware
lifecycle, and the code_owner metric would be set for requests
that never made it to process_view.

The temp_view_func_compare custom metric was added temporarily to
ensure this earlier refactor did not introduce any unaccounted for
differences. It did not, so we are removing this temporary metric.

ARCHBOM-1263
2020-06-12 08:53:20 -04:00
Calen Pennington
06e5e2db51 Merge pull request #24144 from cpennington/hide-dates-banner-archived
Hide dates banner archived
2020-06-11 14:03:09 -04:00
edX Transifex Bot
8c9c536e82 fix(i18n): update translations 2020-06-11 11:50:40 -04:00
Calen Pennington
86e2677f26 Use a standard function to find out if a course has ended 2020-06-11 11:40:56 -04:00
Calen Pennington
1cf46e76d0 Don't compare None to a date when a course doesn't have an end date 2020-06-11 11:40:56 -04:00
Calen Pennington
514d10599d Refactor dates_banner conditionals slightly 2020-06-11 11:13:55 -04:00
Calen Pennington
2b2a6cca23 Never show the dates banner on archived courses 2020-06-11 11:13:55 -04:00
edX Transifex Bot
be7abfa271 fix(i18n): update translations 2020-06-11 11:01:12 -04:00
edX Transifex Bot
aa3501c63a fix(i18n): update translations 2020-06-11 09:56:32 -04:00
Calen Pennington
c6695e0b6f Only actually reset user schedule if they have missed deadlines and not missed any gated content deadlines 2020-06-10 15:18:53 -04:00
Calen Pennington
15df17034a Only prompt the user to upgrade if they have missed the deadline of gated graded content 2020-06-10 15:18:53 -04:00
Robert Raposa
b721e186f3 ARCHBOM-1263: enhance code owner middleware (#24184)
* conservative move to process_request
* added temp_view_func_compare metric to be extra conservative

ARCHBOM-1263
2020-06-10 10:36:13 -04:00
Nathan Sprenkle
44b0d832a0 Scope team search to course when removing from team (#24174) 2020-06-10 10:03:27 -04:00