Commit Graph

1274 Commits

Author SHA1 Message Date
Brian Talbot
cef33bf285 Studio: updates shame file with related future maintenance work 2013-07-09 19:16:44 -04:00
Frances Botsford
6814163a45 cleanup and tweaks from feeback to PDF Textbooks FED and Sass 2013-07-09 19:16:44 -04:00
David Baumgold
1a0d6d21bb Forgot to call show() on saving notification 2013-07-09 19:16:43 -04:00
David Baumgold
8d809dbad6 Remove commented-out code 2013-07-09 19:16:43 -04:00
David Baumgold
cfa094e424 Validation tests for Backbone models 2013-07-09 19:16:43 -04:00
David Baumgold
eba5928009 Added a comment 2013-07-09 19:16:43 -04:00
David Baumgold
fe8587566f All textbook chapters must have name and asset_path
Previously, for a textbook with only one chapter, we allowed that chapter to
not have a title -- under the assumption that it would be shown as a monolithic
textbook, instead of a chaptered textbook. However, the UI doesn't support that
idea, the code was getting a bit messy, and there was no real benefit to the idea
of not having to specify a chapter title. This commit removes that special case,
and ensures that all textbook chapters must have a name and an asset path.
2013-07-09 19:16:43 -04:00
David Baumgold
f9a10855d9 Add notes about JS validation functions returning non-i18n error messages 2013-07-09 19:16:42 -04:00
David Baumgold
fa62f48e57 Fix Jasmine test failures 2013-07-09 19:16:11 -04:00
David Baumgold
e7088d50fd Display error message when trying to upload a non-PDF file as a PDF textbook 2013-07-09 19:16:11 -04:00
David Baumgold
7506562f50 Another lettuce test, and fixes to make it work 2013-07-09 19:16:11 -04:00
David Baumgold
ca2339f15e Remove unneeded arguments
They are the defaults now
2013-07-09 19:16:10 -04:00
Frances Botsford
b41d23747a PDF Textbooks: implemented "View Live" link 2013-07-09 19:16:09 -04:00
David Baumgold
2a92a14054 Wrote simple lettuce tests for pdf textbooks 2013-07-09 19:16:09 -04:00
Frances Botsford
1b945dd6e8 changes to textbook upload buttons, success message and styling 2013-07-09 19:16:09 -04:00
David Baumgold
2b9ed46440 Save chapter information more frequently 2013-07-09 19:16:09 -04:00
David Baumgold
11c5c14998 Add error class to invalid fields on PDF textbooks form 2013-07-09 19:16:09 -04:00
Frances Botsford
2321a2c563 more updates to PDF textbook UI 2013-07-09 19:16:09 -04:00
David Baumgold
a608d8a38d PDF Textbooks: handle model deletion
Previously, when a model was deleted, the entire collection would save itself
to the server again. Now, we just call model.destroy(), which doesn't affect
other models.
2013-07-09 19:16:08 -04:00
David Baumgold
8f2077b579 Test for Textbook.reset method 2013-07-09 19:16:08 -04:00
David Baumgold
70a011770e Show a warning if the user tries to leave the page with unsaved textbook changes 2013-07-09 19:16:08 -04:00
David Baumgold
fedbf4585b Prevent saving when textbook is in invalid state 2013-07-09 19:16:08 -04:00
David Baumgold
74b9703def Reset model attributes when textbook editing is cancelled 2013-07-09 19:16:08 -04:00
David Baumgold
9797b34c4e Pluralize CMS.URL.TEXTBOOK 2013-07-09 19:16:08 -04:00
David Baumgold
77ae9a6a78 PDF Textbooks: fetch/save individual textbooks
Created a few RESTful API endpoints, which required creating and assigning
arbitrary IDs to PDF textbooks. Changed the Backbone views to save individual
models, instead of saving a whole collection.
2013-07-09 19:16:07 -04:00
David Baumgold
307c6c1715 CMS.Views.Notification.Saving should have sensible defaults
minShown = 1250, closeIcon = false
2013-07-09 19:16:07 -04:00
David Baumgold
7b502ced1c Add validation functions for PDF Textbook models 2013-07-09 19:16:07 -04:00
David Baumgold
7856db1e09 Provide correct path to Chapter model 2013-07-09 19:16:07 -04:00
David Baumgold
dc5123c836 Allow multiple textbook edit forms on the page simultaneously 2013-07-09 19:16:07 -04:00
David Baumgold
404c36b8f4 PDF textbooks: namespace JS variables for URLs 2013-07-09 19:16:07 -04:00
David Baumgold
696a795c12 Don't remove all chapters on closing EditTextbook view
Previously, the code would dynamically add a chapter on render() if the textbook
had no chapters, and would remove all empty chapters when the edit view was closed.
Now, the render method doesn't modify the model at all anymore (yay!) and when the
edit view is closed, remove all empty chapters but be sure to leave at least one
left.
2013-07-09 19:16:07 -04:00
David Baumgold
0048c82092 Simply context passing for textbooks 2013-07-09 19:16:07 -04:00
David Baumgold
5836286fda PDF textbooks: unified naming conventions 2013-07-09 19:16:06 -04:00
Brian Talbot
414c9d38b6 studio - revises plus icon treatment throughout new-button actions 2013-07-09 19:16:06 -04:00
David Baumgold
a861e01536 Reorganize Jasmine uploader tests 2013-07-09 19:16:06 -04:00
David Baumgold
c2ef6a53f5 PDF textbook upload: show success message for 2 seconds following successful upload 2013-07-09 19:16:06 -04:00
David Baumgold
cae5c324a6 modifications to Backbone textbook structure
Textbooks now have an empty chapterset by default, instead of one with one empty
chapter. The TextbookEdit view dynamically adds an empty chapter if the chapterset
is empty; the close button removes all empty chapters from the chapterset.
2013-07-09 19:16:06 -04:00
Frances Botsford
27f2339537 additional refinements to PDF textbooks, including making the edit buttons work again 2013-07-09 19:16:06 -04:00
David Baumgold
7b02932fea Add tests for CMS.Views.ChapterEdit, save content before opening upload dialog 2013-07-09 19:16:06 -04:00
Frances Botsford
947a4ee714 adding some finesse to the PDF textbooks page 2013-07-09 19:16:05 -04:00
Frances Botsford
e059060cf3 updated textbook page html and sass, and added basic styling for error on wrong file type 2013-07-09 19:16:05 -04:00
David Baumgold
e8b79dc696 PDF textbooks only accept PDF files
All other file types will trigger a validation error
2013-07-09 19:16:05 -04:00
David Baumgold
77db1f8a5a Fixups and test fixes post-rebase 2013-07-09 19:16:04 -04:00
Frances Botsford
4b2eb79de9 revamp of textbook list html, stage 1 2013-07-09 19:16:04 -04:00
David Baumgold
c59d515cdf Added unit tests for file upload widget 2013-07-09 19:16:04 -04:00
David Baumgold
7bb86b6cd2 Fix showSpies and editSpies resetting in tests 2013-07-09 19:16:04 -04:00
David Baumgold
27398a5c6f Added tests for CMS.Views.ListTextbooks 2013-07-09 19:16:04 -04:00
David Baumgold
8ba21ca34a More backbone view tests 2013-07-09 19:16:04 -04:00
David Baumgold
3f0efe70cf Added jasmine-stealth library, v0.0.12 2013-07-09 19:16:03 -04:00
David Baumgold
8227a8c3db Started adding tests for textbook backbone views 2013-07-09 19:16:03 -04:00