Commit Graph

22583 Commits

Author SHA1 Message Date
Christie Rice
b8afc30079 refactor: Combine checks for allowlist and regular certificates (#27204)
MICROBA-1039
2021-04-01 10:00:56 -04:00
Justin Hynes
e4206265cc Merge pull request #27200 from edx/jhynes/microba-1100-cert-generation-mgmt-cmd
feat: Update `cert_generation` mgmt command to read arguments from config model
2021-04-01 08:23:49 -04:00
Justin Hynes
6b38debfeb feat: Update cert_generation mgmt command with ability to read arguments from config model
[MICROBA-1100]
* Add CertificationGenerationCommandConfiguration model that will store the command arguments for the `cert_generation` mgmt command
* Add ability to add entries to the CertificationGenerationCommandConfiguration through Django admin
* Update mgmt command with ability to read arguments from the config model/database
* Fix failing test in `test_cert_generation.py`
* Add new test for missing `users` argument in `test_cert_generation.py`
2021-04-01 07:39:33 -04:00
Bianca Severino
333591301d Merge pull request #27203 from edx/bseverino/remove-proctoring-waffle-flags
[MST-678] Remove proctored exam resume waffle flag
2021-03-31 14:58:20 -04:00
Bianca Severino
73c5866678 fix: remove proctored exam resume waffle flag 2021-03-31 14:14:09 -04:00
Christie Rice
8f50edea6f feat: Implement generation of regular V2 course certificates (#27189)
MICROBA-1039
2021-03-31 14:12:19 -04:00
Asad Iqbal
d5e13195b7 Fix: Find the submission history using learner's email address along with username (#25642)
Co-authored-by: asadiqbal <aiqbal@edx.org>
Co-authored-by: asadiqbal08 <asad.iqbal@arbisoft.com>
2021-03-31 08:46:55 -04:00
jawad khan
5025a3ffd9 feat!: remove "Text Me the App" page from web app because of security concern
Someone at edx was able to quickly send a few texts to himself using the tool.
Each text came from a different number and there was no message about the ability to unsubscribe or stop.
This could potentially be used to spam users as well as potentially result in charges to edX for high volume.

page url https://courses.edx.org/text-me-the-app
LEARNER-8286
2021-03-30 23:38:24 +05:00
Adam Blackwell
dd69020de1 fix: Add space after comma in legacy unenroll message. (#27177) 2021-03-30 10:48:44 -04:00
Christie Rice
8198606138 feat: Refactor code to check both regular and allowlist V2 certs (#27156)
MICROBA-1039
2021-03-30 10:23:23 -04:00
Dillon Dumesnil
feb4c13608 Merge pull request #27154 from edx/ddumesnil/hidden-content-fix-aa-724-part-3
fix: AA-724: Updating the HiddenContentTransformer
2021-03-30 05:41:55 -07:00
Ali Akbar
4a515e983c Merge pull request #26918 from edx/aakbar/PROD-1136
[Support Tool] Update the Enrollments to take Entitlements into account
2021-03-30 13:05:07 +05:00
Michael Terry
5d9e7e9fe5 fix: don't count hierarchy blocks as complete for assignments
When considering whether a subsection is complete as an assignment,
skip any "hierarchy" types (sequential, vertical, etc) that don't
have children. If the user can't see the content, don't risk
marking it as complete.

AA-726
2021-03-29 16:06:11 -04:00
Dillon Dumesnil
c4a96a2fa3 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of this PR is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 3/3 - Removing old collect code with merged due date
2021-03-29 10:15:23 -04:00
Dillon Dumesnil
01839789e0 Merge pull request #27153 from edx/ddumesnil/hidden-content-fix-aa-724-part-2
fix: AA-724: Updating the HiddenContentTransformer
2021-03-29 07:13:40 -07:00
Christie Rice
b452f3d5f3 docs: Add ADR on regular course certificate requirements (#27140)
MICROBA-1039
2021-03-29 09:53:50 -04:00
Ali-D-Akbar
ee5b383ff6 PROD-1136: [Support Tool] Update the Enrollments support tool to take entitlements into account. 2021-03-29 12:26:16 +05:00
Dillon Dumesnil
1614fb2956 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 2/3 - Updating transform method + updating Read version
2021-03-26 14:05:53 -07:00
Dillon Dumesnil
8551528370 Merge pull request #27152 from edx/ddumesnil/hidden-content-fix-aa-724-part-1
fix: AA-724: Updating the HiddenContentTransformer
2021-03-26 14:03:42 -07:00
Dillon Dumesnil
d96f756994 fix: AA-724: Updating the HiddenContentTransformer
We heard about a bug where learners granted extensions would still
lose access to content if it was marked as "hidden after due date".
This was caused by the HiddenContentTransformer using the due date
from collection time (publish time) rather than the user date returned
from the edx-when DateOverrideTransformer.

A small subtletly of these PRs is that Transformers with the
FilteringTransformerMixin are executed before those without it so
part of the fix was to make the HiddenContentTransformer not use the
FilteringTransformerMixin to ensure the DateOverrideTransformer had
run first.

Part 1/3
2021-03-26 10:59:55 -07:00
Carla Duarte
0d7140875f Merge pull request #27141 from edx/ciduarte/AA-722-2
fix: surface assignment type short_label in Progress Tab MFE API
2021-03-26 09:47:01 -04:00
Carla Duarte
4570d4e3d8 fix: surface assignment type short_label in Progress Tab MFE API 2021-03-25 17:52:15 -04:00
Saad Yousaf
229565a072 Merge pull request #27126 from edx/saad/TNL-7971-followup
[TNL-7971] - Correct filename for anonymized id report.
2021-03-26 00:40:03 +05:00
Feanil Patel
68bd33f310 Merge pull request #27138 from edx/feanil/add_request_user_change_logging
feat: Add more detailed request user change logging.
2021-03-25 14:01:52 -04:00
Feanil Patel
c2eabf6cca test: Update query counts.
The new WaffleFlag.is_enabled check in middleware increased query counts
for multiple tests.
2021-03-25 12:14:53 -04:00
Christie Rice
dabad9fdfd feat: Add cert_generation management command (#27131)
MICROBA-1078
2021-03-25 11:01:41 -04:00
Christie Rice
9a24e72643 fix: Require web certs (#27120)
MICROBA-1039
2021-03-25 09:29:51 -04:00
Régis Behmo
cfc45a1c19 docs: annotate REGISTRATION_EXTRA_FIELDS setting (#27136)
Close https://github.com/openedx/build-test-release-wg/issues/10
2021-03-25 08:02:24 -04:00
Zainab Amir
8cc5f13daf Add rate limit to registration endpoint (#27060)
Currently the registration endpoint has no rate limit. Added a new ratelimit
variable to support the change, it's value is set to 60/7d.

VAN-302
2021-03-25 16:28:30 +05:00
Carla Duarte
f88d049602 Merge pull request #27132 from edx/ciduarte/AA-722
AA-722: surface num_droppable assignments in MFE Progress Tab API
2021-03-24 16:10:36 -04:00
Carla Duarte
e8bfee28c5 AA-722: surface num_droppable assignments in MFE Progress Tab API 2021-03-24 13:55:56 -04:00
Sarina Canelake
e802614634 Merge pull request #27119 from edx/sarina/TNL-8138
fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
2021-03-24 08:12:01 -04:00
SaadYousaf
5876c783f7 correct filename for anonymized id report. 2021-03-24 14:46:44 +05:00
jawad khan
186cc9f16c LEARNER-7858 (#26967)
Removed tabindex="-1" from main element to fix accessibility issue
Description

Removed tabindex="-1"  from main
We had a strange issue where TalkBack wasn’t reading content in some xBlocks but was reading some others. I figured out that if you remove tabindex=-1 from <main>, TalkBack works as expected again. Tangentially, this breaks the old method of implementing SkipNav links. Further tangentially, the SkipNav links were already broken (or in this case redundant on mobile). @wittjeff  will file two separate issues after this one PR is merged — one  for a better way to implement SkipNav links for  Learning MFE, and one for a better / functional way to implement SkipNav links for Mobile.

How to reproduce
Go to [this unit](https://courses.edx.org/xblock/block-v1:W3Cx+WAI0.1x+3T2019+type@html+block@2eb3c86c479f44ba964f88ff0bfd9211) on mobile and turn on TalkBack. It will skip main content. For further information on testing go to [Jira Ticket](https://openedx.atlassian.net/browse/LEARNER-7858)
2021-03-24 11:15:16 +05:00
sarina
51ccf48f1c fix: Add ‘ENABLE_HELP_LINK’ to Studio settings
Fixes an issue where the button that linked to edX documentation for
course teams in Studio that displayed beside the logged-in user's username/
drop-down menu is gone. Regression from PR #26106

Ref: TNL-8138
2021-03-23 16:16:21 -04:00
Simon Chen
4c5d56ef06 MST-682 Add external_user_key to the student profile CSV (#27091)
* MST-682 Add external_user_key to the student profile CSV
This is a request from some Masters school partners. They would like to download the student enrolled list with the Masters external_user_key data referenced. This way, the schools can properly match the students enrolled in the course with the students enrolled through Masters enrollment system
2021-03-22 14:25:34 -04:00
Calen Pennington
91b74b7fd3 Merge pull request #23457 from open-craft/agrendalath/bb-2063-fix-marking-blocks-as-completed-on-course-outline-page-upstream
[BB-2063] Calculate completion for custom blocks on the Course Outline page
2021-03-22 13:33:18 -04:00
Agrendalath
e571693455 Support EXCLUDED blocks in Block Completion Transformer
For now only the discussion blocks were supported. If we had a custom XBlock that specified `completion_mode = XBlockCompletionMode.EXCLUDED`, then it could never be marked as completed on the course outline page, despite being marked as such inside the learning sequence.
2021-03-22 16:21:43 +01:00
Agrendalath
5a27b5df39 Calculate completion for custom blocks on the Course Outline page
This adds support for displaying completion on the course outline page, to remove the discrepancies between this view and the learning sequence. It also simplifies course outline page by reusing existing APIs for determining completion state and finding the "Resume block"'s target.
2021-03-22 16:21:32 +01:00
Bianca Severino
ed63ffbb50 Merge pull request #27086 from edx/bseverino/proctoring-escalation-email
Allow `get_proctoring_escalation_email` to use a course key object
2021-03-22 10:12:45 -04:00
Christie Rice
43f32a8f6b feat: Add initial certificate generation checks for updated (V2) course certificates (#27090)
MICROBA-923
2021-03-22 10:07:21 -04:00
Robert Raposa
f9c11f061f Merge pull request #27059 from open-craft/nizar/update_block_structure_toggles_annotations
docs: updates ticket links for block structure settings and toggles
2021-03-22 09:29:48 -04:00
M. Zulqarnain
40a987d9d0 refactor: pyupgrade on LMS (#26851) 2021-03-22 17:51:23 +05:00
Awais Qureshi
c43cdd0cee Merge pull request #27100 from edx/revert-27097-revert-27087-fixing-toggles
Revert "Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )""
2021-03-22 17:26:23 +05:00
Awais Qureshi
23bcd6f05d revert: Reverts #27097
#27097 reverted the pylint amnesty change. After reverting the ubuntu20 deployment, now this can be deployed again.
2021-03-22 15:17:22 +05:00
edX requirements bot
41c1d237eb Python Requirements Update (#27094)
* Updating Python Requirements

* fix proctoring test

Co-authored-by: Zulqarnain <muhammad.zulqarnain@arbisoft.com>
2021-03-22 15:15:46 +05:00
Awais Qureshi
20c39b267e Revert "temp: Apply pylint amnesy ( Type annotation-invalid-choice )" 2021-03-22 12:47:43 +05:00
Awais Qureshi
60cd0c1295 Merge pull request #27087 from edx/fixing-toggles
temp: Apply pylint amnesy ( Type annotation-invalid-choice )
2021-03-22 11:19:50 +05:00
Sofiane Bébert
5d7cd3d278 docs: annotate auto_certificate_generation (#26770) 2021-03-19 16:01:55 -04:00
Awais Qureshi
4611398429 temp: Apply pylint amnesy. 2021-03-19 23:01:31 +05:00