Commit Graph

20 Commits

Author SHA1 Message Date
Xavier Antoviaque
0c7620a544 Merge pull request #6637 from open-craft/mtyaka/validate-chars
Improve JS course key validation to not allow special chars.
2015-01-20 16:02:32 +01:00
Bertrand Marron
c4a7d770cc Remove all ellipses
It's a problem for accessibility
2015-01-15 09:03:12 -05:00
Matjaz Gregoric
d8e076566d Improve JS course key validation to not allow special chars.
Course and Library keys cannot contiain !'()* special characters,
but the JS validation on the new course/library failed to detect
these characters.

`encodeURIComponent` is used to check the string for special characters,
but `encodeURIComponent` does not encode these characters: -_!~*'().
(see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/encodeURIComponent)

The -_~ characters are allowed in course keys, but !'()* are not,
so add an explicit check for these characters to make sure a field
containing these characters does not pass the validation.
2015-01-15 08:32:19 +01:00
Jonathan Piacenti
91469f902f Refactored shared elements of create factories into base class. 2015-01-12 13:42:54 +03:00
E. Kolpakov
99caf602cb Refactoring create_course_utils and create_library_utils to reduce the amount of differences (mostly renames 2015-01-12 13:42:54 +03:00
Matjaz Gregoric
0b8471d6b3 Toggle aria-disabled attribute on New Course/New Library buttons. 2015-01-12 13:42:50 +03:00
Braden MacDonald
3e0f08ebc2 Studio support for creating and editing libraries (PR 6046)
SOL-1, SOL-2, SOL-3
2015-01-12 13:37:50 +03:00
Syed Hassan Raza
1e11baede4 Add aria-disabled attribute
TNL-997
2015-01-06 17:21:49 +05:00
Ben McMorran
d943204199 Fix i18n on course outline and show error message for long names 2014-08-21 12:11:28 -04:00
Ben McMorran
baee2da278 Improve javascript test coverage 2014-08-21 12:11:28 -04:00
Ben McMorran
1778c15703 Refactor dismissNotification uses into shared logic in view_utils 2014-08-21 12:11:27 -04:00
Ben McMorran
63603d70f4 Refactor shared course creation validation into create_course_utils 2014-08-21 12:11:27 -04:00
Ben McMorran
12a5781725 Add ability to set staff lock from course outline 2014-08-16 15:58:42 -04:00
Alexander Kryklia
a63cc0b30f Edit section/subsection release dates and grading types.
Fix bok_choy test by changing course separator.
Change format of the modal title to '[Subsection/Section Name] Settings'.
Improve bok_choy test stability.
Studio: correcting modal window size name for outline settings editor
Specify full date in bok_choy tests.
Refactor bok_choy tests.
Remove .modal-editor from basic-modal.underscore
Set classes in modal window dynamically.
Studio: revising outline edit modal tip content and overall size
Rename isEditable to isEditableOnCourseOutline.
Interpolate display name.
Use graded instead of format as flag.
Studio: revising outline settings edit modal size
Fix selectors in bok_choy tests.
2014-08-07 12:27:17 -04:00
Ben McMorran
ce06e7f7e7 Fix delete messages in course outline
STUD-2019
2014-08-07 12:27:16 -04:00
cahrens
6d82cf09a4 Correct publish titles, code review feedback. 2014-08-07 12:27:14 -04:00
Andy Armstrong
ef581e1146 Apply code review comments and fix tests 2014-08-07 12:27:14 -04:00
Andy Armstrong
a359065329 Integrate visual styling into the course outline 2014-08-07 12:27:13 -04:00
cahrens
d447c07540 Support staff locking on the unit page
STUD-1873
2014-08-07 12:16:22 -04:00
Andy Armstrong
f061bbc08b Backbone version of the course outline page
STUD-1726
2014-08-07 12:16:20 -04:00