Commit Graph

23036 Commits

Author SHA1 Message Date
Hamza Farooq
4a2549f49a fix: making LOGIN_REDIRECT_WHITELIST configurable through env files (#26760)
LOGIN_REDIRECT_WHITELIST has been used to filter redirect-url while processing logout requests but its configurations were not picked through environment files like lms.yml or studio.yml. This PR fixes that bug.
2021-08-03 08:29:23 -04:00
Olivia Ruiz-Knott
379a818a04 Merge pull request #28258 from edx/ork/MICROBA-1239_certificate-date-override
feat: Add CertificateDateOverride model
2021-08-02 13:23:46 -06:00
oliviaruizknott
8906adb072 feat: Add CertificateDateOverride model
Add a new model (and corresponding migration) to the certificates
app in the LMS: CertificateDateOverride. The model will eventually be
used to allow course teams / support to override the "Issued On" date
for a given course certificate.
2021-08-02 12:44:37 -06:00
Justin Hynes
8a7ad06304 Merge pull request #28332 from edx/jhynes/microba-1087_dashboard
refactor!: Remove `generate_example_certificates` and update Instructor Dashboard with updated messaging.
2021-08-02 14:02:34 -04:00
Justin Hynes
d4a7a44909 refactor!: Remove generate_example_certificates and update Instructor Dashboard with updated messaging.
[MICROBA-1087]
[DEPR-155]

* Remove `generate_example_certificates` functionality
* Adjust Instructor dashboard slightly to prevent people from clicking the `Generate Example Certificates` button, remove form/code that called the `generate_example_certificates` endpoint.
2021-08-02 13:26:28 -04:00
Matt Tuchfarber
622d56026c Certificate Display Settings revamp (round 2) (#28286)
feat: reimagine certificate display settings

The course settings `certificate_available_date` (CAD) and
`certificates_display_behavior` (CDB) were previously
acting indedependantly of one another. They now work in
tandem. This change:
- limits CDB to a dropdown
- removes "early_with_info" and adds "end_with_date"
- only takes CAD into account if "end_with_date" is selected
- Moves CDB to the main course schedule settings page
- updates CourseOverview model and CourseDetails objects to
validate these fields and choose sane defaults if they aren't
expected values

This work was previously done in bd9e7dd (complete with bugs), so this
version is toggleable via the ENABLE_V2_CERT_DISPLAY_SETTINGS setting
2021-08-02 11:30:15 -04:00
Nathan Sprenkle
121afd0c5f refactor: new logic for when to enable Gradebook bulk management (#28080)
Formerly, bulk management was enabled by sending feature feature
toggle to Gradebook which also checked for the presence of a 
master's track to enable the feature. This default enables for all
courses with a master's track and also allows selective enabling 
for courses with the feature flag.
2021-08-02 11:06:08 -04:00
Christie Rice
5fa4fcea5e fix: Handle missing user profile when setting a name in a course certificate (#28319)
MICROBA-1410
2021-08-02 10:58:13 -04:00
Awais Qureshi
eb0a66c2bd chore: Django3 has removed python_2_unicode_compatible.
Execute the codemodes.
2021-07-30 22:13:13 +05:00
Christie Rice
8971c99da6 feat!: Add migration to drop the CertificateWhitelist table (#28307)
This model has been replaced by the CertificateAllowlist.

MICROBA-1304
2021-07-30 10:27:35 -04:00
Maari
81a17b90aa feat: add an option to enable Badgr notifications (#28313)
With Badgr v2 API, notification emails for earning badges are
no longer sent to learners by default. However, the request to
create a badge assertion accepts an optional boolean property
"notify", that can be used to enable/disable email notifications.

Make it configurable by an optional setting `BADGR_ENABLE_NOTIFICATIONS`
(defaults to False).
2021-07-29 15:33:23 -04:00
Julia Eskew
aad7aa17db fix: Add production Django setting line for the origin-specific token to
disable subframe dialog suppression for sites which use ENV_TOKENS for config.
2021-07-29 12:28:55 -04:00
Christie Rice
5883d13092 feat!: Remove CertificateWhitelist model (#28308)
This model has been replaced by the CertificateAllowlist.

MICROBA-1304
2021-07-29 09:50:34 -04:00
Justin Hynes
1887f13fd2 Merge pull request #28281 from edx/jhynes/microba-1087
refactor!: Remove unused callback endpoints used for PDF cert generation/updates
2021-07-29 07:56:45 -04:00
Julia Eskew
a0d6095fb6 feat: Add token which disables different origin subframe dialog suppression
for Chrome version 92. This token is added to the courseware iFrame, which
enables the iFrame to retain the ability to summon modals & alerts - or open
new windows via JS. This token has a limited lifespan - it currently expires around
Dec 14, 2021.

TNL-8559
2021-07-28 14:32:39 -04:00
Justin Hynes
dbe8ae1fbb refactor!: Remove unused callback endpoints used for PDF cert generation/updates
[MICROBA-1087]
[DEPR-155]

* Removed callback functions that were originally used to update certificates (and example certificates) post xqueue processing
2021-07-28 14:21:31 -04:00
David Ormsbee
dae459bfb4 feat: Rollout override for Learning Sequences API (#28205)
We control rollout of the Learning Sequences REST API with the
USE_FOR_OUTLINES (learning_sequences.use_for_outlines) course waffle
flag. But sometimes we're going to want to be able to take a look at
production data output of this API before explicitly turning the API on
(and switching over to it) for the Courseware MFE. To do this, we're
going to make the availability base itself purely on the waffle flag and
course type (Old Mongo courses are not supported), and allow people to
"peek" at what the API would have given if it was rolled out by passing
an explicit "force_on=1" querystring param.

This is work to support the rollout of TNL-8330.
2021-07-28 11:53:17 -04:00
Awais Qureshi
718325a550 Merge pull request #28294 from edx/python2_unicode_rm_common
chore: Django3 has removed python_2_unicode_compatible.
2021-07-28 17:26:41 +05:00
Mehak Nasir
80b4dcceb6 Merge pull request #28291 from edx/TNL-8471
fix: description updates for pages and resources
2021-07-28 14:35:34 +05:00
Carla Duarte
bfd2d825f0 fix: progress tab serializer enforce float for num_total 2021-07-27 15:57:31 -04:00
Awais Qureshi
bdb1e61b82 chore: Django3 has removed python_2_unicode_compatible.
Execute the codemodes.
2021-07-27 23:35:00 +05:00
Mehak Nasir
7b29d1bdf2 fix: description updates for pages and resources 2021-07-27 20:32:31 +05:00
Michael Terry
789edbe555 Merge pull request #28256 from edx/mikix/course-home-access
feat: send course access error along to course home MFE
2021-07-26 13:34:54 -04:00
Justin Hynes
49bcdfe481 Merge pull request #28245 from edx/jhynes/microba-1227_cleanup
fix: remove disabled v1 course certificate queue code
2021-07-26 10:31:27 -04:00
Michael Terry
29159891c3 feat: send course access error along to course home MFE
We previously only sent it to the courseware MFE. Also unify the
naming of this access error to 'course_access' in courseware and
course home APIs.
2021-07-23 14:01:58 -04:00
Andrew Shultz
27ee8aee4a Merge pull request #28255 from edx/ashultz0/proc-bump-3206
chore: update edx-proctoring to 3.20.6
2021-07-23 09:58:32 -04:00
Andy Shultz
2e0393d098 fix: update platform test that directly creates proctor attempts
Student name field is gone. This test was providing a blank name so nothing
more than delete is needed.

MST-872
2021-07-22 16:44:11 -04:00
Thomas Tracy
abccf1ee26 [feat] Add enrollment mode to outline API (#28234) 2021-07-22 13:33:14 -04:00
Justin Hynes
0069bd724f fix: remove disabled v1 course certificate queue code
[MICROBA-1227]
[DEPR-155]

* remove queue.py (and associated unit tests)
* remove references to `queue.py` from functions in api.py (also update unit tests)
2021-07-22 11:03:49 -04:00
Matt Tuchfarber
325629dd25 Merge pull request #28237 from edx/tuchfarber/move_may_certify_2
Move cert display decisions to certificates app
2021-07-22 10:20:13 -04:00
Dillon Dumesnil
f886ced838 Merge pull request #28233 from edx/ddumesnil/hide-content-after-due-progress-aa-912
fix: AA-912: Hide URL after due date if subsection is marked as hide …
2021-07-22 07:17:35 -07:00
Piotr Surowiec
a5d9dd4fb9 fix: hide unavailable sequence title in course breadcrumbs (#28028)
When a sequence title was unavailable for a user (e.g. before starting a timed
exam), the `None` value was displayed in course breadcrumbs. This hides it in
such cases and ensures that a trailing breadcrumb separator is not displayed.
2021-07-22 09:52:25 -04:00
Farhaan Bukhsh
fa5736285e fix: Passwored reset page throwing page not found error (#27982)
Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>
2021-07-22 09:51:02 -04:00
Dillon Dumesnil
7dd4f2db99 fix: AA-912: Hide URL after due date if subsection is marked as hide after due
A bug was reported of a learner accessing content that should have been hidden
due to the hide after due setting in Studio by the course team by clicking on
the Progress tab. This takes into account that value and will now hide the URL
on the Progress tab in that scenario.
2021-07-21 17:53:23 -04:00
Matt Tuchfarber
d16c9a804c refactor: Move cert code to cert app
The `may_certify` function is used to determine whether a learner should
be able to see that their certificate is ready. It is therefore entirely
in the certificates domain. This remove may_certifiy and
may_certify_for_course from the xmodule and course_overview
apps and into the certificates app. The xmodule may_certify was not called
outside of tests prior to this, and the other's were easily moved.

In order to avoid circular imports, this also moved
certificate_info_for_user out of the model code and into an API
2021-07-21 15:56:19 -04:00
connorhaugh
0d26738fce fix: Prevent Transcripts from Failing Export, Edit (#28242)
Instead of having json errors in transcript acquisition and conversion cause errors, have transcription conversion and acquisition simply return an error message in the transcription which can prompt a change from the user.

Although not uploading a transcript is handled, transcripts can often cause errors in edit, export, and other activities due to json errors. These errors block the entire use of these features, so to allow for reupload, etc, we add an error message instead of transcript and log the event.

In response to [TNL-8539](https://openedx.atlassian.net/secure/RapidBoard.jspa?rapidView=580&projectKey=TNL&modal=detail&selectedIssue=TNL-8539)

Testing: Unit tests coverage is included in the PR. Upload, import, and export of courses with transcriptions is also easily hand-testable. Just create a video in studio, add an irrelevant transcript. Then try to import, export, and edit the problem. Expected behavior is success.
2021-07-21 15:52:54 -04:00
Bianca Severino
14c85d9465 feat: pass verified name flag into user api 2021-07-20 16:58:39 -04:00
Zach Hancock
6ba12c71d3 test: test case for duplicate user in multiple providers 2021-07-20 12:03:26 -04:00
Zach Hancock
aa2bf9c063 feat: program_enrollments support for multiple SAML providers 2021-07-20 12:03:26 -04:00
Christie Rice
8b362f11b5 fix: Unify required parameter checks
MICROBA-1373
2021-07-19 14:48:08 -04:00
Justin Hynes
fd578b6636 Merge pull request #28196 from edx/crice/gen
fix: Retrieve grade and enrollment mode only once
2021-07-19 14:47:03 -04:00
Bianca Severino
430f1554b4 Revert "feat: pass verified name flag into account settings"
This reverts commit 85dc8c8d67.
2021-07-19 12:06:33 -04:00
Maari
3d98bff695 Fix retrieving BadgeAssertion data from Badgr (#28039)
* Fix retrieving BadgeAssertion data from Badgr

With edx#27181, the integration with Badgr was updated and fixed to
be working with the Badgr v2 API. However, retrieving the Badge Assertion
data from Badgr still needs to be updated for the new json response
structure so we can save it at our end as well.

* Add BadgeAssertion table to LMS admin
2021-07-19 11:55:00 -04:00
Bianca Severino
85dc8c8d67 feat: pass verified name flag into account settings 2021-07-19 11:03:24 -04:00
Justin Hynes
38b0261761 Merge pull request #28208 from edx/jhynes/microba-1351
feat!: Remove `AUDIT_CERT_CUTOFF_DATE` configuration setting
2021-07-19 09:32:32 -04:00
Zia Fazal
6f6a9e9c0b Merge pull request #27762 from edly-io/ERTE-5
[ERTE-5] feat: Added enterprise uuid in event context for enterprise enrolment events
2021-07-19 10:43:43 +05:00
Justin Hynes
0dd319a089 feat!: Remove AUDIT_CERT_CUTOFF_DATE configuration setting
[MICROBA-1351][DEPR-159]
* Remove `AUDIT_CERT_CUTOFF_DATE`
2021-07-16 15:38:14 -04:00
Thomas Tracy
3ecd233c11 [feat] MB-1192: Add user_has_passing_grade to outline API (#28198)
* [feat] add user_has_passing_grade to outline API

* default to false

* add tests

* linting
2021-07-16 15:03:35 -04:00
Christie Rice
c7d06c6bfa fix: Retrieve grade and enrollment mode only once and pass their values to the generation task, so those values can be saved in the cert. Also protect against missing course grades.
MICROBA-1373
2021-07-16 13:43:07 -04:00
João Cabrita
7261bc42bd feat: Add legacy_link field to TextBook app
This implements the `legacy_link` method to the TextbooksCourseApp
and makes the `legacy_link` URL absolute in the API response.

Related tickets:
* [TNL-8438](https://openedx.atlassian.net/browse/TNL-8438)
* [BB-4416 (OpenCraft Internal)](https://tasks.opencraft.com/browse/BB-4416)
2021-07-16 19:34:13 +05:00